D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

victorr added a comment. Now there are a lot of errors with localization. There is a message about them. https://bugs.kde.org/show_bug.cgi?id=415541 Temporarily fixed this problem with attached patches when building packages. This error was originally described here https://phabricator

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added a comment. In D26544#595312 , @meven wrote: > In D26544#595269 , @leinir wrote: > > > In D26544#595246 , @bcooksley wrote: > > > > > Cancel

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

meven added a comment. In D26544#595269 , @leinir wrote: > In D26544#595246 , @bcooksley wrote: > > > Cancel that, it fails to build on Linux as well - i'm guessing that the KNetstuff changes have n

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added a comment. In D26544#595246 , @bcooksley wrote: > Cancel that, it fails to build on Linux as well - i'm guessing that the KNetstuff changes have not been landed? The KNS changes have indeed not been landed yet REPOSITORY

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

bcooksley added a comment. Cancel that, it fails to build on Linux as well - i'm guessing that the KNetstuff changes have not been landed? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26544 To: leinir, mart, ngraham Cc: bcooksley, davidedmundson, ngraham,

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

bcooksley added a comment. This change fails to build from source on FreeBSD due to missing headers in Frameworks. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26544 To: leinir, mart, ngraham Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n,

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

This revision was automatically updated to reflect the committed changes. Closed by commit R119:442c43b3ca98: Switch the Plasma Desktop KCMs to using KNewStuffQuick (authored by leinir). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26544?vs=73598&id=7

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir updated this revision to Diff 73598. leinir added a comment. - Unbreak the merge REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26544?vs=73597&id=73598 BRANCH switch-kcms-to-knsquick (branched from master) REVISION DETAIL https://phabric

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir updated this revision to Diff 73597. leinir added a comment. - Unbreak the merge REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26544?vs=73595&id=73597 BRANCH switch-kcms-to-knsquick (branched from master) REVISION DETAIL https://phabric

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir updated this revision to Diff 73595. leinir added a comment. Let's try and unbreak this diff, shall we... - Only try and work on newly installed themes - Port the cursortheme kcm to KNSQuick - Port the plasma theme kcm's ghns support to KNSQuick - Port the Icons kcm to KNSQuic

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

ngraham added a comment. Phab strikes again... I would revert to a previous version of this patch using the history tab in the web UI, download the raw diff from the web UI, and then manually apply it on top of HEAD. REPOSITORY R119 Plasma Desktop BRANCH switch-kcms-to-knsquick (br

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added a comment. Right, everything blew up i guess. Nice. REPOSITORY R119 Plasma Desktop BRANCH switch-kcms-to-knsquick (branched from master) REVISION DETAIL https://phabricator.kde.org/D26544 To: leinir, mart, ngraham Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGa

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir updated this revision to Diff 73544. leinir added a comment. - Merge remote-tracking branch 'origin/master' into switch-kcms-to-knsquick - Fix build (by removing stuff that was removed in master it seems) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricato

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added a comment. In D26544#594194 , @ngraham wrote: > Thanks for the explanation! Not a problem, it's not necessarily easy to spot at a glance - and thanks! :D REPOSITORY R119 Plasma Desktop BRANCH switch-kcms-to-knsquick (bra

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks for the explanation! REPOSITORY R119 Plasma Desktop BRANCH switch-kcms-to-knsquick (branched from master) REVISION DETAIL https://phabricator.kde.org/D26544 To: leinir, mar

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added inline comments. INLINE COMMENTS > ngraham wrote in colors.cpp:128 > This wraps a lot of existing functionality into that conditional as well. Was > all of that stuff broken and useless without D26543 > ? > > Everything seems to work anyway, but

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

ngraham added inline comments. INLINE COMMENTS > colors.cpp:128 > > -const auto newEntries = m_newStuffDialog->installedEntries(); > -// If one new theme was installed, select the first color file > in it > -if (newEntries.count() == 1) { > -

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir updated this revision to Diff 73409. leinir added a comment. As discussed above, we need to be able to build against an older version of Frameworks than 5.67. As such, wrap up the bits that aren't available before then in some compile-time checks. - Wrap the new requirements up

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added inline comments. INLINE COMMENTS > davidedmundson wrote in main.cpp:254 > FWIW, there is an alternative approach that we do in plasma-workspace > (shell/containmentconfigview.cpp) for reloading wallpapers types. > > kpackage emits a DBus signal when it performs an action, models ca

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added a comment. In D26544#592286 , @ngraham wrote: > I notice that this also has the effect of changing the button texts to not have ellipses on the end. I guess `NewStuff.Button` needs to do that itself? There's a bug report for

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir planned changes to this revision. leinir added a comment. In D26544#592285 , @ngraham wrote: > This patch makes plasma-desktop fail to build without the dependent KNS framework change. That means that the KNS change is in fact a hard depen

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added a comment. In D26544#591591 , @bcooksley wrote: > In the case of three Frameworks (namely plasma-framework, kwayland and kwindowsystem) I have on file requests from the Plasma and KWin developers informing me that their software do

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

ngraham added a comment. I notice that this also has the effect of changing the button texts to not have ellipses on the end. I guess `NewStuff.Button` needs to do that itself? Works great BTW. A big improvement! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

ngraham added a comment. This patch makes plasma-desktop fail to build without the dependent KNS framework change. That means that the KNS change is in fact a hard dependency and therefore this functionality can't make it into 5.18 with the patch's current state. If you want it for 5.18 (as

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

ngraham added a comment. In D26544#591418 , @leinir wrote: > Right, the functionality would all still exist (that is, install/uninstall/update/whatnot would function just fine), what would happen without the dependent patch is that the views wil

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

bcooksley added a comment. In the case of three Frameworks (namely plasma-framework, kwayland and kwindowsystem) I have on file requests from the Plasma and KWin developers informing me that their software does indeed require latest HEAD (with no delay) of those particular frameworks, hence

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

davidedmundson added inline comments. INLINE COMMENTS > main.cpp:254 > > -void IconModule::getNewStuff(QQuickItem *ctx) > +void IconModule::ghnsEntriesChanged(const QQmlListReference &changedEntries) > { FWIW, there is an alternative approach that we do in plasma-workspace (shell/containment

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added a comment. In D26544#591398 , @ngraham wrote: > Since D26543 is listed as a dependent, but it's in Frameworks, and Plasma 5.18 is going to depend on Frameworks 5.66, but 5.66 has already been tag

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

ngraham added a comment. Since D26543 is listed as a dependent, but it's in Frameworks, and Plasma 5.18 is going to depend on Frameworks 5.66, but 5.66 has already been tagged, that means that this can't land in 5.18, so we'll ship 5.18 with only the Glob

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir requested review of this revision. leinir added a comment. Right, that's the lot of the qtquick kcms in plasma-desktop! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26544 To: leinir, mart Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachu