D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham added a comment. UI refinement is here: D28280 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns, #baloo, #vdg, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7498b41a1979: [Baloo KCM] Complete overhaul of the include/exclude folder list (authored by bruns). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns updated this revision to Diff 78333. bruns marked 2 inline comments as done. bruns added a comment. update2 REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28025?vs=78332=78333 BRANCH baloo_config_rework REVISION DETAIL

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns updated this revision to Diff 78332. bruns marked 2 inline comments as done. bruns added a comment. update REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28025?vs=78064=78332 BRANCH baloo_config_rework REVISION DETAIL

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns marked 2 inline comments as done. bruns added inline comments. INLINE COMMENTS > ngraham wrote in filteredfoldermodel.cpp:36 > this handy little function feels like it wants to be in KCoreAddons or > something Now its likely inlined by the compiler ... > ngraham wrote in main.qml:112 >

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham added a comment. Ok, will do. I just have a few comments about the backend bits, just minor stuff. Overall this is really good! I plan to polish the UI after this lands, but left comments on the front-end component anyway so you can sharpen your QML skills (which are quite good

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. In D28025#631358 , @ngraham wrote: > If you're okay with me modifying the UI in a follow-up patch, I'll accept the UI in its current form. Is that acceptable? Thats the intention of all this - get it in a usable

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. TODO: T12840 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns, #baloo, #vdg, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham added a comment. Yes, it's true that our UIs are frequently inconsistent; that's why the #consistency goal exists. A big part of this goal is to improve the usability of common components like the Kirigami SwipeListItem so that

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. F8185503: Screenshot_20200320_022339.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns, #baloo, #vdg, ngraham, mart Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns updated this revision to Diff 78064. bruns added a comment. Use Kirigami.Action for Trash REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28025?vs=77574=78064 BRANCH baloo_config_rework REVISION DETAIL https://phabricator.kde.org/D28025

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. In D28025#630882 , @ngraham wrote: > In D28025#630849 , @bruns wrote: > > > Having only inclusion/exclusion is a temporary state. I plan to add more settings for each path, so

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham added a comment. In D28025#630849 , @bruns wrote: > Having only inclusion/exclusion is a temporary state. I plan to add more settings for each path, so having an "add" button for each possible state will no longer be feasible. > >

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. In D28025#630729 , @ngraham wrote: > I have some UI suggestions: > > - Have a button to add an exclusion path as well as a button to add an inclusion path, rather than a single Add Setting button, which is a rather

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham requested changes to this revision. ngraham added a reviewer: mart. ngraham added a comment. This revision now requires changes to proceed. I have some UI suggestions: - Have a button to add an exclusion path as well as a button to add an inclusion path, rather than a single Add

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

ngraham added a comment. Looks interesting, will take a look soon. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns, #baloo, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns updated this revision to Diff 77574. bruns added a comment. tabs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28025?vs=77560=77574 BRANCH baloo_config_rework REVISION DETAIL https://phabricator.kde.org/D28025 AFFECTED FILES

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added inline comments. INLINE COMMENTS > main.qml:169 > +id: removeFolder > + visible: model.deletable > +icon.name: "user-trash" Spurious tab REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns added a comment. F8174362: Screenshot_20200313_145738.png F8174361: Screenshot_20200313_145811.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28025 To: bruns,

D28025: [Baloo KCM] Complete overhaul of the include/exclude folder list

bruns created this revision. bruns added reviewers: Baloo, VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY The current "Excluded folders" list in the KCM is quite awkward: 1. It tries to mimic