D7849: Fix the tray icon scaling on HiDPI screens

2018-10-21 Thread Nathaniel Graham
ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. This does not actually compile for me against current git master: /home/dev/repos/plasma-framew

D7849: Fix the tray icon scaling on HiDPI screens

2018-02-13 Thread Nathaniel Graham
ngraham added a comment. Does this actually fully fix https://bugs.kde.org/show_bug.cgi?id=360333? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: aspotashev, ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson

D7849: Fix the tray icon scaling on HiDPI screens

2018-02-13 Thread Alexander Potashev
aspotashev added a comment. related bug report: https://bugs.kde.org/show_bug.cgi?id=360333 REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: aspotashev, ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson, plas

D7849: Fix the tray icon scaling on HiDPI screens

2018-02-10 Thread Piotr Kosinski
pgkos added a comment. In my opinion, roundToIconSize should operate on scaled units - it is used multiple times in a few plasmoids - all calls from them to roundToIconSize assume it will operate on scaled units. The method, as it is now, is useless, because QML code has no access to KI

D7849: Fix the tray icon scaling on HiDPI screens

2018-02-10 Thread Piotr Kosinski
pgkos updated this revision to Diff 26878. pgkos added a comment. This is a simpler implementation - the diff changes roundToIconSize so it uses scaled units. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7849?vs=19612&id=26878 REVISIO

D7849: Fix the tray icon scaling on HiDPI screens

2017-10-22 Thread Nathaniel Graham
ngraham added a comment. Any chance we can reach some kind of consensus here? REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: ngraham, anthonyfieroni, broulik, #frameworks, davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D7849: Fix the tray icon scaling on HiDPI screens

2017-09-17 Thread Piotr Kosinski
pgkos added a comment. @anthonyfieroni my first version of the diff changed only the tray icon QML file, but I think that it is better to fix it in the plasma framework, as that function is used in multiple other places and there is the same problem with wrongly sized icons on hidpi screens.

D7849: Fix the tray icon scaling on HiDPI screens

2017-09-17 Thread Anthony Fieroni
anthonyfieroni added a comment. So, Kai is right, it roundToIconSize only round size independent from dpi. Then when it used, it should be multiplyed by dpi. REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: anthonyfieroni, broulik, #frameworks, davidedmundson, plasm

D7849: Fix the tray icon scaling on HiDPI screens

2017-09-17 Thread Piotr Kosinski
pgkos added a comment. @broulik consider this case: The tray icons' size is defined by default in `org.kde.plasma.private.systemtray/contents/config/main.xml` to `smallMedium`, which means 22 pixels on a 96-dpi screen. On a 192-dpi screen, the icons' real size is 44 pixels. Now, in `o

D7849: Fix the tray icon scaling on HiDPI screens

2017-09-17 Thread Kai Uwe Broulik
broulik added a comment. I don't understand this. RoundToIconSize is supposed to round down and that's it. If I pass it 100 px because I'm on a high dpi screen, it will still return 100. Only if I pass it e.g. 34 it will change it to 32. REVISION DETAIL https://phabricator.kde.org/D7849 T

D7849: Fix the tray icon scaling on HiDPI screens

2017-09-17 Thread Piotr Kosinski
pgkos updated this revision to Diff 19612. pgkos added a comment. Fixed the previous diff. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7849?vs=19592&id=19612 REVISION DETAIL https://phabricator.kde.org/D7849 AFFECTED FILES src/declarativeimports/core/units.cpp src/declarat

D7849: Fix the tray icon scaling on HiDPI screens

2017-09-16 Thread Piotr Kosinski
pgkos updated this revision to Diff 19592. pgkos changed the repository for this revision from R120 Plasma Workspace to R242 Plasma Framework (Library). pgkos added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. Edited the

D7849: Fix the tray icon scaling on HiDPI screens

2017-09-16 Thread David Edmundson
davidedmundson added a comment. So isn't it round to icon size which is wrong? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, seb

D7849: Fix the tray icon scaling on HiDPI screens

2017-09-16 Thread Piotr Kosinski
pgkos added a reviewer: Plasma. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7849 To: pgkos, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7849: Fix the tray icon scaling on HiDPI screens

2017-09-16 Thread Piotr Kosinski
pgkos created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This patch fixes the problem with tray icon scaling on HiDPI screens - the icons are too small. The function `Units::roundToIconSize` retur