D8050: Expose wl_display_set_global_filter as a virtual method

This revision was automatically updated to reflect the committed changes. Closed by commit R127:7cb71d002b72: Expose wl_display_set_global_filter as a virtual method (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D8050?vs=20560=22503#toc REPOSITORY R127

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. @davidedmundson The CI image is updated, you can push this now. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson, #plasma, graesslin, bcooksley Cc: bcooksley, graesslin, plasma-devel, #frameworks, ZrenBot,

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. In https://phabricator.kde.org/D8050#154356, @davidedmundson wrote: > I'm not resubmitting something just for the purpose of you two winding each other up. Eh, it was not meant like that. I just wanted to point out that this does not need any changes

D8050: Expose wl_display_set_global_filter as a virtual method

davidedmundson added a comment. I'm not resubmitting something just for the purpose of you two winding each other up. We're in no rush for this. I'll check what suse has and go from there. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To:

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin accepted this revision. graesslin added a comment. I'm accepting this revision again. The CI system needs to have the PPA activated again as the old CI system had. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson, #plasma,

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. In https://phabricator.kde.org/D8050#154207, @bcooksley wrote: > Please remedy the Wayland dependency incompatibility. > > In the event the relevant package is not available in the distribution in question, you'll need to contact it's packagers and make the

D8050: Expose wl_display_set_global_filter as a virtual method

davidedmundson added a comment. This was reverted since yesterday when we noticed CI failed. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson, #plasma, graesslin, bcooksley Cc: bcooksley, graesslin, plasma-devel, #frameworks, ZrenBot,

D8050: Expose wl_display_set_global_filter as a virtual method

bcooksley requested changes to this revision. bcooksley added a comment. This revision now requires changes to proceed. Please remedy the Wayland dependency incompatibility. In the event the relevant package is not available in the distribution in question, you'll need to contact it's

D8050: Expose wl_display_set_global_filter as a virtual method

bcooksley reopened this revision. This revision is now accepted and ready to land. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D8050 To: davidedmundson, #plasma, graesslin Cc: graesslin, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. One of our CI jobs is no longer happy: 13:02:41 -- The following REQUIRED packages have not been found: 13:02:41 13:02:41 * Wayland (required version >= 1.13) , C library implementation of the Wayland protocol: a protocol for a compositor to talk to

D8050: Expose wl_display_set_global_filter as a virtual method

This revision was automatically updated to reflect the committed changes. Closed by commit R127:a1aad4e86cba: Expose wl_display_set_global_filter as a virtual method (authored by davidedmundson). REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE

D8050: Expose wl_display_set_global_filter as a virtual method

davidedmundson added a comment. It doesn't explicitly say anything, but I don't see how we can. I do have an approach where we would be able to show a polkit dialog described in https://phabricator.kde.org/T4437. REPOSITORY R127 KWayland BRANCH filter2 REVISION DETAIL

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Due you know whether we are allowed to block? E.g. to show a polkit dialog? My assumption would be we are not allowed to block here. REPOSITORY R127 KWayland BRANCH filter2

D8050: Expose wl_display_set_global_filter as a virtual method

davidedmundson updated this revision to Diff 20101. davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed Plasma on Wayland. updates REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D8050?vs=20069=20101 BRANCH

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in filtered_display.cpp:41 > I tried. > > modding getConnection means modding modding ClientConnection constructor, > modding that means modding the Private ctor > > that gets into > > wl_client_add_destroy_listener(c,

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added a comment. Btw. today is a great day: I finally can clean up my whiteboard. I had drafted an idea how to do what this change does more than a year ago and it's still waiting for the future me to implement it. But with this change I can finally clean it without having a bad

D8050: Expose wl_display_set_global_filter as a virtual method

davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in filtered_display.cpp:41 > Why a const cast? Or other said: could we overload the getConnection to > accept a const wl_client*? I tried. modding getConnection means modding modding ClientConnection constructor, modding

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added inline comments. INLINE COMMENTS > davidedmundson wrote in filtered_display.cpp:62 > Somewhat. > This is new in 1.13, we depend on 1.7. > > Debian is currently on 1.12. > (my general rule is: "is Debian has it, everyone else must do") > > Should we #ifdefs and then no-op (with

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added inline comments. INLINE COMMENTS > filtered_display.cpp:41 > +auto t = static_cast(data); > +auto clientConnection = > t->q->getConnection(const_cast(client)); > +auto interface = wl_global_get_interface(global);

D8050: Expose wl_display_set_global_filter as a virtual method

davidedmundson added inline comments. INLINE COMMENTS > graesslin wrote in filtered_display.cpp:62 > I didn't know such API exists! This is great ;-) > > But I think you need to increase the minimum Wayland version. Somewhat. This is new in 1.13, we depend on 1.7. Debian is currently on

D8050: Expose wl_display_set_global_filter as a virtual method

graesslin added inline comments. INLINE COMMENTS > filtered_display.cpp:62 > +} > +wl_display_set_global_filter(*this, Private::globalFilterCallback, > d.data()); > +}); I didn't know such API exists! This is great ;-) But I think you need to increase the minimum Wayland

D8050: Expose wl_display_set_global_filter as a virtual method

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY This allows a server to filter which globals are visible and