Device notifier restyle

2008-10-17 Thread Alessandro Diaferia
Hey ML, what about a quick and easy restyle of Device Notifier before feature freeze? I have 2 main changes in mind: 1 - Move the code to PopupApplet so that we can have a more homogeneus behavior with other iconified applets in the panel (e.g. dialog resizable); 2 - When no devices are plugged

Re: Device notifier restyle

2008-10-17 Thread Aaron J. Seigo
On Friday 17 October 2008, Alessandro Diaferia wrote: > 1 - Move the code to PopupApplet so that we can have a more homogeneus > behavior with other iconified applets in the panel (e.g. dialog resizable); > > 2 - When no devices are plugged in the list might be prettier (e.g. list > not visible, on

Re: Device notifier restyle

2008-10-17 Thread Alexis Ménard
Me of course. 2008/10/17 Aaron J. Seigo <[EMAIL PROTECTED]> > On Friday 17 October 2008, Alessandro Diaferia wrote: > > 1 - Move the code to PopupApplet so that we can have a more homogeneus > > behavior with other iconified applets in the panel (e.g. dialog > resizable); > > > > 2 - When no devi

Re: Device notifier restyle

2008-10-17 Thread Artur Souza (MoRpHeUz)
2008/10/17 Alessandro Diaferia <[EMAIL PROTECTED]>: > 1 - Move the code to PopupApplet so that we can have a more homogeneus > behavior with other iconified applets in the panel (e.g. dialog resizable); > > 2 - When no devices are plugged in the list might be prettier (e.g. list not > visible, only

Re: Device notifier restyle

2008-10-17 Thread Janz
A small suggestion about item 2: thinking about keep only visual elements the user needs at the moment (and place others in just when they become needed), what if the icon is hidden while there's no media to list and shows up (and pops the dialog) when the first device gets in (the same event that

Re: Device notifier restyle

2008-10-17 Thread Aaron J. Seigo
On Friday 17 October 2008, Janz wrote: > What do you think? i wonder if this would cause people to wonder 'where it went' and try and add it back? it's not quite the same as notifications ... or maybe it is .. *wobbles on the fence* -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8

Re: Device notifier restyle

2008-10-17 Thread Janz
I agree it depends. I believe a good measure is the purpose user expects from each widget. There are cases when he waits for just some information and cases when he always wants any information. Taskbar is one example of first case (and works exactly like I suggested for Device Notifier): if there

Review Request: Device Notifier restyle: part 1

2008-10-18 Thread Alessandro Diaferia
Device Notifier restyle. Just ported to PopupApplet + a bonus: good use of tooltips as you can see in the screenshots. Diffs - trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.h trunk/KDE/kdebase/workspace/plasma/applets/devicenotifier/devicenotifier.cpp trunk/KDE

Re: Review Request: Device Notifier restyle: part 1

2008-10-18 Thread Aaron Seigo
o reply, visit: > http://reviewboard.vidsolbach.de/r/226/ > --- > > (Updated 2008-10-18 09:52:05) > > > Review request for Plasma. > > > Summary > --- > > This is the first part of Device Notifi

Re: Review Request: Device Notifier restyle: part 1

2008-10-20 Thread Alessandro Diaferia
Seigo. Summary --- This is the first part of Device Notifier restyle. Just ported to PopupApplet + a bonus: good use of tooltips as you can see in the screenshots. UPDATE: diff updated according to Aaron's suggestions Diffs - trunk/KDE/kdebase/workspace/plasma/applets/devicenot