New lockscreen

Hi! The new lock screen has some more or less serious regressions, and doesn't seem to be maintained by anyone in particular (one of the regression bugs filed against it is from november, and I don't really see anyone in particular commenting or fixing anything, it only got a handful of commits in

Re: New lockscreen

On Thursday 10 January 2013, Martin Sandsmark wrote: > Hi! > > The new lock screen has some more or less serious regressions, and doesn't > seem to be maintained by anyone in particular (one of the regression bugs > filed against it is from november, and I don't really see anyone in > particular c

Re: New lockscreen

On Thursday, January 10, 2013 19:37:57 Martin Sandsmark wrote: > So, who is supposed maintain this new screenlocker? In its current state it .. > Another alternative is to revert the replacement for KDE 4.10, and instead disclaimer: i am not the maintainer of this component. i have contributed som

Re: New lockscreen

On Friday, January 11, 2013 10:28:22 Martin Gräßlin wrote: > On Friday 11 January 2013 10:12:13 Martin Sandsmark wrote: > > On Fri, Jan 11, 2013 at 09:49:06AM +0100, Martin Gräßlin wrote: > > > no, removing features is not a regression. It is the decision to remove > > > the > > > feature. The use

Re: New lockscreen

On Thu, Jan 10, 2013 at 09:46:11PM +0100, Marco Martin wrote: > 311571 and 312427 should be fixed now Thanks! > some bugs seems easy, some i can'r reproduce them at all. Which ones can't you reproduce? I can look at them this evening. > however not all of those are valid i think (the concept

Re: New lockscreen

On Thu, Jan 10, 2013 at 09:57:30PM +0100, Aaron J. Seigo wrote: > reverting is not going to happen at this point. Fair point, as it now seems to both have maintainers aware of its bugzilla component and is getting its bugs fixed. I really like the new screenlocker, both the architecture (one less

Re: New lockscreen

On Fri, Jan 11, 2013 at 10:50:53AM +0100, Aaron J. Seigo wrote: > "an animated screen saver" is not the only answer. "blank the screen" works > just as well, probably even better from a power consumption point of view. > blanking the screen is still supported :) Some people care more about aeste

Re: New lockscreen

On Friday, January 11, 2013 10:01:58 Martin Sandsmark wrote: > On Thu, Jan 10, 2013 at 09:57:30PM +0100, Aaron J. Seigo wrote: > > reverting is not going to happen at this point. > > Fair point, as it now seems to both have maintainers aware of its bugzilla > component and is getting its bugs fixe

Re: New lockscreen

On Friday 11 of January 2013 10:28:22 Martin Gräßlin wrote: > the implementation has been kept there AFAIK because people complain that we > wanted to remove it. It would be nice if the people who want to have the > old screen savers would step up to support the maintenance. Yes it would > have bee

Re: New lockscreen

Il 10/01/2013 21:57, Aaron J. Seigo ha scritto: [...] disclaimer: i am not the maintainer of this component. i have contributed some minor things to its development. however, i'm obviously vested in the workspace in general. reverting is not going to happen at this point. but what i will do is s

Re: Re: New lockscreen

On Friday 11 January 2013 09:28:19 Martin Sandsmark wrote: > Well, the old one managed to be both, so IMHO if we remove features it is a > regression (though which ones are you talking about?). no, removing features is not a regression. It is the decision to remove the feature. The use case for sc

Re: Re: New lockscreen

On Fri, Jan 11, 2013 at 09:49:06AM +0100, Martin Gräßlin wrote: > no, removing features is not a regression. It is the decision to remove the > feature. The use case for screen savers does no longer exist or when did you > last have a screen which needs to be saved? For background reading I > re

Re: Re: Re: New lockscreen

On Friday 11 January 2013 10:12:13 Martin Sandsmark wrote: > On Fri, Jan 11, 2013 at 09:49:06AM +0100, Martin Gräßlin wrote: > > no, removing features is not a regression. It is the decision to remove > > the > > feature. The use case for screen savers does no longer exist or when did > > you last

[Differential] [Accepted] D2523: New lockscreen

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH login_refactor2 REVISION DETAIL https://phabricator.kde.org/D2523 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/e

[Differential] [Closed] D2523: New lockscreen

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEcf87b9a1bf97: Summary: New lockscreen (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2523?vs=6177&am

[Differential] [Updated] D2523: New lockscreen

colomar added a project: VDG. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2523 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed, je

[Differential] [Commented On] D2523: New lockscreen

mart added a comment. code looks nice. you maybe want to add a screenshot, for the final go from vdg INLINE COMMENTS > KeyboardLayoutButton.qml:37 > + > +menu: QQC.Menu { > +id: keyboardMenu does a qmenu work on top the special lockscreen window? > Login.qml:25 > +//bu

[Differential] [Commented On] D2523: New lockscreen

davidedmundson added a comment. preview. F266450: Spectacle.kn3949.png INLINE COMMENTS > mart wrote in KeyboardLayoutButton.qml:37 > does a qmenu work on top the special lockscreen window? Turns out it does not. Which means my options are: - come

[Differential] [Commented On] D2523: New lockscreen

mart added a comment. feedback just of the screenshot: what about adding colorGroup: PlasmaCore.ColorScope.colorGroup in the userdelegate default avatar as well? (i can do a rr about that as is just partly related if you want) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DET

[Differential] [Commented On] D2523: New lockscreen

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in KeyboardLayoutButton.qml:37 > Turns out it does not. > > Which means my options are: > > - come up with an in-window pop-up (IIRC there used to be one back in KDE4 > days?) > > - use click to change (so it behaves different

[Differential] [Commented On] D2523: New lockscreen

davidedmundson added a comment. > colorGroup: PlasmaCore.ColorScope.colorGroup > in the userdelegate default avatar as well? (i can do a rr about that as is just partly related if you want) Pushed. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.k

[Differential] [Commented On] D2523: New lockscreen

colomar added a comment. Please tag all diffs with UI changes with VDG to make sure we learn about them. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2523 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: d

[Differential] [Request, 838 lines] D2523: New lockscreen

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY New lockscreen TEST PLAN Locked screen and unlocked Checked caps lock warning Checked

[Differential] [Updated, 818 lines] D2523: New lockscreen

davidedmundson updated this revision to Diff 6177. davidedmundson added a comment. Fixed comment about linking to Qt bug report Changed keyboard layout button back into click to change I can make it a custom menu afterwards. - Change comment for bug report - Restore click to chang

[Breeze] [Bug 370484] New: Lockscreen Breeze theme doesn't have keyboard layout indicator

https://bugs.kde.org/show_bug.cgi?id=370484 Bug ID: 370484 Summary: Lockscreen Breeze theme doesn't have keyboard layout indicator Product: Breeze Version: 5.8.0 Platform: Neon Packages OS: Linux