Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-02-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103618/#review10268 --- This review has been submitted with commit d6293cad6468a24c5e3

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Peter Penz
> On Jan. 3, 2012, 5:24 p.m., Ignat Semenov wrote: > > Sorry, was a misunderstanding among me and some plasma devs. Peter, we'd > > like to know the rationale for exposing such an option in the configuration > > UI. When I implemented the selection-toggle in Dolphin for KDE 4.1 I was not sure

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103618/#review9511 --- Sorry, was a misunderstanding among me and some plasma devs. Pet

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103618/ --- (Updated Jan. 3, 2012, 5:21 p.m.) Review request for Plasma, Aaron J. Seig

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103618/ --- (Updated Jan. 3, 2012, 5:16 p.m.) Review request for Plasma and Aaron J. S

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Ignat Semenov
> On Jan. 3, 2012, 3:03 p.m., Marco Martin wrote: > > hiding the selection + icon should happen automatically when doubleclick is > > disabled, i don't see a valid use case to be able to configure it > > idependently > > Shaun Reich wrote: > I think/hope you meant that the selection icon s

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Ignat Semenov
> On Jan. 3, 2012, 3:03 p.m., Marco Martin wrote: > > hiding the selection + icon should happen automatically when doubleclick is > > disabled, i don't see a valid use case to be able to configure it > > idependently > > Shaun Reich wrote: > I think/hope you meant that the selection icon s

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103618/ --- (Updated Jan. 3, 2012, 1:03 p.m.) Review request for Plasma and Aaron J. S

Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-07 Thread Ignat Semenov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103618/ --- Review request for Plasma and Aaron J. Seigo. Description --- This pa

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-03 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103618/#review9513 --- This review has been submitted with commit f5eb9ffa53fc96bb1d7b

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103618/#review9512 --- Ship it! last version looks good ;) - Marco Martin On Jan. 3

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-03 Thread Shaun Reich
> On Jan. 3, 2012, 3:03 p.m., Marco Martin wrote: > > hiding the selection + icon should happen automatically when doubleclick is > > disabled, i don't see a valid use case to be able to configure it > > idependently > > Shaun Reich wrote: > I think/hope you meant that the selection icon s

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-03 Thread Marco Martin
> On Jan. 3, 2012, 3:03 p.m., Marco Martin wrote: > > hiding the selection + icon should happen automatically when doubleclick is > > disabled, i don't see a valid use case to be able to configure it > > idependently > > Shaun Reich wrote: > I think/hope you meant that the selection icon s

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-03 Thread Shaun Reich
> On Jan. 3, 2012, 3:03 p.m., Marco Martin wrote: > > hiding the selection + icon should happen automatically when doubleclick is > > disabled, i don't see a valid use case to be able to configure it > > idependently I think/hope you meant that the selection icon should be hidden when double i

Re: Review Request: Add an option for disabling / enabling the selection marker in the FolderView applet

2012-01-03 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103618/#review9500 --- hiding the selection + icon should happen automatically when dou