Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review102460 --- if this patch is still relevant, please repost it to phabric

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Feb. 8, 2017, 12:49 p.m.) Status -- This change has been di

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Dec. 2, 2014, 12:18 p.m.) Review request for Plasma. Repositor

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

> On Nov. 28, 2014, 11:26 a.m., Vishesh Handa wrote: > > components/timelinemodel/timelinemodel.cpp, line 136 > > > > > > Has this been tested? > > > > This assert would be true when m_level is Month or

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review71055 --- components/timelinemodel/timelinemodel.h

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review71054 --- Ship it! It's not ideal, but ship it. I'll improve the Baloo

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review70975 --- Ship it! looks better to me - Marco Martin On Nov. 26, 201

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Nov. 26, 2014, 6:11 p.m.) Review request for Plasma. Changes -

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

> On Nov. 25, 2014, 3:39 p.m., Vishesh Handa wrote: > > components/timelinemodel/timelinemodel.cpp, line 144 > > > > > > Just my opinion - > > > > An assert would be better since m_level is an enum and s

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review70926 --- components/timelinemodel/qmldir

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- (Updated Nov. 25, 2014, 3:11 p.m.) Review request for Plasma. Changes -

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review69091 --- I would prefer CloudModel (with a better name) and timelinemod

Re: Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/#review69092 --- I'm very confused about this whole patch. Can you explain what

Review Request 120777: Plasma Active: Initial commit for Baloo Cloud Component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120777/ --- Review request for Plasma. Repository: plasma-mobile Description --