Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2015-01-06 Thread Bhushan Shah
> On Jan. 6, 2015, 3:07 p.m., Kai Uwe Broulik wrote: > > CMakeLists.txt, line 13 > > > > > > My CMake complains about this: > > Unknown CMake command "set_package_properties". Fixed in http://commits.kde.o

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2015-01-06 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/#review73246 --- CMakeLists.txt

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2015-01-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/ --- (Updated Jan. 6, 2015, 7:57 a.m.) Status -- This change has been mar

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2015-01-05 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/#review73174 --- Ship it! Ship It! - Aleix Pol Gonzalez On Jan. 5, 2015, 8:

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2015-01-05 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/ --- (Updated Jan. 5, 2015, 8:24 a.m.) Review request for Plasma. Changes --

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2014-12-29 Thread Aleix Pol Gonzalez
> On Dec. 29, 2014, 4:40 a.m., Aleix Pol Gonzalez wrote: > > Then Qt5Webkit should be marked as optional through the > > set_package_properties(). > > > > To be honest, I'm not thrilled about having many ways to configure these > > things, because sooner or later somebody will end up compiling

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2014-12-29 Thread David Faure
> On Dec. 29, 2014, 4:40 a.m., Aleix Pol Gonzalez wrote: > > Then Qt5Webkit should be marked as optional through the > > set_package_properties(). > > > > To be honest, I'm not thrilled about having many ways to configure these > > things, because sooner or later somebody will end up compiling

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2014-12-29 Thread Aleix Pol Gonzalez
> On Dec. 29, 2014, 4:40 a.m., Aleix Pol Gonzalez wrote: > > Then Qt5Webkit should be marked as optional through the > > set_package_properties(). > > > > To be honest, I'm not thrilled about having many ways to configure these > > things, because sooner or later somebody will end up compiling

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2014-12-29 Thread Marco Martin
> On Dic. 29, 2014, 4:40 a.m., Aleix Pol Gonzalez wrote: > > Then Qt5Webkit should be marked as optional through the > > set_package_properties(). > > > > To be honest, I'm not thrilled about having many ways to configure these > > things, because sooner or later somebody will end up compiling

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2014-12-29 Thread Marco Martin
> On Dic. 29, 2014, 4:40 a.m., Aleix Pol Gonzalez wrote: > > Then Qt5Webkit should be marked as optional through the > > set_package_properties(). > > > > To be honest, I'm not thrilled about having many ways to configure these > > things, because sooner or later somebody will end up compiling

Re: Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2014-12-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/#review72659 --- Then Qt5Webkit should be marked as optional through the set_p

Review Request 121718: Allow to compile plasma-workspace without Qt5WebKit installed.

2014-12-28 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121718/ --- Review request for Plasma. Repository: plasma-workspace Description ---