[plasmashell] [Bug 447389] Notifications widget in the system tray shows items that are not clickable

https://bugs.kde.org/show_bug.cgi?id=447389 Nicolas Fella changed: What|Removed |Added Component|general |Notifications Product|kwrited

[kwrited] [Bug 447389] New: Notifications widget in the system tray shows items that are not clickable

https://bugs.kde.org/show_bug.cgi?id=447389 Bug ID: 447389 Summary: Notifications widget in the system tray shows items that are not clickable Product: kwrited Version: 5.23.4 Platform: Other OS: Linux

Re: Port system tray away from SNI dataengine

On domenica 2 maggio 2021 13:48:06 CEST Konrad Materka wrote: > Hi, > > I think I'm finally ready to take https://phabricator.kde.org/T13319 :) > What is the best approach to DataEngine migration? It was/is a singleton, > but System Tray can be instanced several times. In additio

Port system tray away from SNI dataengine

Hi, I think I'm finally ready to take https://phabricator.kde.org/T13319 :) What is the best approach to DataEngine migration? It was/is a singleton, but System Tray can be instanced several times. In addition the SNI model can be quite heavy, it will use DBus a lot and will cache values

D29824: Avoid system tray resizing

niccolove created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. niccolove requested review of this revision. REVISION SUMMARY Currently, there was some code to avoid system tray resizing. However, being the properties not set to the root element

D29824: Avoid system tray resizing

niccolove added a comment. whops, this created a diff, not a MR REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29824 To: niccolove Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D29651: Notifications applet closes itself after removing all notifications while the system tray popup is pinned open

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks please phrase the commit message the opposite way. State what the commit changes, not what the state was before the commit. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D29651: Notifications applet closes itself after removing all notifications while the system tray popup is pinned open

epopov created this revision. epopov added reviewers: ngraham, plasma-devel. Herald added a project: Plasma. epopov requested review of this revision. REVISION SUMMARY When I pin a Notifications applet and then remove all notifications, the Notifications applet closes itself. BUG: 421344

D29469: Icon in system tray missing when WireGuard connection active on startup

This revision was automatically updated to reflect the committed changes. Closed by commit R116:040a5c8ce9b0: Icon in system tray missing when WireGuard connection active on startup (authored by andersonbruce, committed by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES

D29380: [System Tray] Always draw the highlight behind the icon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3f06349549c1: [System Tray] Always draw the highlight behind the icon (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29380?vs=81796

D29380: [System Tray] Always draw the highlight behind the icon

kmaterka accepted this revision. kmaterka added a comment. This revision is now accepted and ready to land. OK, accepted REPOSITORY R120 Plasma Workspace BRANCH draw-behind-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D29380 To: filipf, kmaterka, #plasma

D29380: [System Tray] Always draw the highlight behind the icon

filipf updated this revision to Diff 81796. filipf added a comment. move the code change to CurrentItemHighlight.qml REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29380?vs=81785=81796 BRANCH draw-behind-icons (branched from master) REVISION

D29380: [System Tray] Always draw the highlight behind the icon

kmaterka requested changes to this revision. kmaterka added a comment. This revision now requires changes to proceed. The same treatment is needed in `HiddenItemsView` to. Just move `z: -1` to `CurrentItemHighLight` component so that your fix will cover both cases. REPOSITORY R120 Plasma

D29380: [System Tray] Always draw the highlight behind the icon

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY There was a slight issue introduced with D28109 : the systray highlight can now cover up the

D29130: [Applet] Show in system tray iff at least one vault is open

ksmanis added a comment. It seems to me that this revision does not have the required momentum to move forward. I'll keep it open for another week in case someone else wants to chime in, but unless something changes I'll abandon it and maintain it off tree for personal use. REPOSITORY

D29130: [Applet] Show in system tray iff at least one vault is open

ivan added a comment. And I'l just be using my keyboard shortcut ;) REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29130 To: ksmanis, #plasma, #vdg, ivan Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D29130: [Applet] Show in system tray iff at least one vault is open

ngraham added a comment. (If this patch lands, I'll set it to "Always visible" because I use my vault a lot) REPOSITORY R845 Plasma Vault REVISION DETAIL https://phabricator.kde.org/D29130 To: ksmanis, #plasma, #vdg, ivan Cc: kmaterka, broulik, ngraham, plasma-devel, Orage, LeGast00n,

D29130: [Applet] Show in system tray iff at least one vault is open

ivan added a comment. I'm not fond of this change, but I agree with Nate's comment about the possibility of setting 'always visible' for users that wish to keep the current behaviour, so I'm not going to give this a -1. I'd still like the current behaviour kept, maybe with a different

D29130: [Applet] Show in system tray iff at least one vault is open

kmaterka added a comment. IMO it is the best **not** to add new status in System Tray - it is already quite confusing with "Disabled" state, the 3 other (Always hidden, Shown when relevant and Always shown) are OK and self-explanatory. "Shown when relevant" mi

D29130: [Applet] Show in system tray iff at least one vault is open

broulik added inline comments. INLINE COMMENTS > vaultsmodel.h:36 > Q_PROPERTY(bool hasError READ hasError NOTIFY hasErrorChanged) > +Q_PROPERTY(bool hasOpen READ hasOpen NOTIFY hasOpenChanged) > Q_PROPERTY(int count READ rowCount NOTIFY rowCountChanged) I think this should be

D29130: [Applet] Show in system tray iff at least one vault is open

ksmanis added a comment. I gave it some thought and I would be reluctant to introduce one more fuzzy (as in ambiguous) state. More specifically, right now, we have four states: "Shown when relevant", "Always shown", "Always hidden", and "Disabled". Without having gone through the

D29130: [Applet] Show in system tray iff at least one vault is open

ngraham added a comment. Yeah. Thinking about it more, your proposal makes some sense because people like you can currently not get what you want at all, while if we integrate this change, people like me can just change the visibility setting to "Always visible". So I'm leaning in the

D29130: [Applet] Show in system tray iff at least one vault is open

ksmanis added a comment. Accurate analysis. If I might add, as an infrequent user of Plasma Vaults, I am stuck between an (almost) always visible applet (whether I select "Always shown" or "Shown when relevant") and an always hidden applet. A "currently active" relevance would cater for

D29130: [Applet] Show in system tray iff at least one vault is open

ngraham added a reviewer: ivan. ngraham added a comment. With this change, a person who creates a Vault they will be regularly using and wants the system tray icon to be always visible now has to go out of their way to use the "always visible" setting in the system tray settings;

D29130: [Applet] Show in system tray iff at least one vault is open

ksmanis created this revision. ksmanis added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ksmanis requested review of this revision. REVISION SUMMARY Currently, the "Shown when relevant" visibility option in the system tray shows a

D28631: Remove Icons from system tray item tooltips

This revision was automatically updated to reflect the committed changes. Closed by commit R120:96ad51cde0ea: Remove Icons from system tray item tooltips (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28631?vs=79545=79573

D28631: Remove Icons from system tray item tooltips

kmaterka accepted this revision. kmaterka added a comment. This revision is now accepted and ready to land. In D28631#643325 , @ngraham wrote: > Remove no-longer-relevant reference to icon in `AbstractItem.qml` Thanks, accepted.

D28631: Remove Icons from system tray item tooltips

ngraham updated this revision to Diff 79545. ngraham added a comment. Remove no-longer-relevant reference to icon in `AbstractItem.qml` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28631?vs=79511=79545 BRANCH remove-systemtray-tooltip-icons

D28631: Remove Icons from system tray item tooltips

kmaterka requested changes to this revision. kmaterka added a comment. This revision now requires changes to proceed. In D28631#643116 , @davidre wrote: > I would argue that the implementation is free to ignore it > `Data structure that

D28631: Remove Icons from system tray item tooltips

davidre added a comment. In D28631#643111 , @kmaterka wrote: > For SNI, maybe we should consider showing an icon, but only if it is explicitly set? It is part of the specification

D28631: Remove Icons from system tray item tooltips

kmaterka added a comment. For SNI, maybe we should consider showing an icon, but only if it is explicitly set? It is part of the specification after all. From the other side it will be inconsistent...

D28631: Remove Icons from system tray item tooltips

ngraham updated this revision to Diff 79511. ngraham marked an inline comment as done. ngraham added a comment. Revert change to remove code from the Data Engine REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28631?vs=79510=79511 BRANCH

D28631: Remove Icons from system tray item tooltips

davidre added a reviewer: kmaterka. davidre added inline comments. INLINE COMMENTS > statusnotifieritemsource.cpp:342 > setData(QStringLiteral("ToolTipSubTitle"), QString()); > -setData(QStringLiteral("ToolTipIcon"), QString()); > -} else { we

D28631: Remove Icons from system tray item tooltips

icons from tooltips for panel widgets and system tray items. This patch implements that for system tray items, and removes the supporting code from the backend. TEST PLAN Apply patch Hover the cursor over system tray items, either in the compat applet or the expanded representation N

D28435: [System Tray] Update effective status on model insertion

This revision was automatically updated to reflect the committed changes. Closed by commit R120:1d3b6e8f0a18: [System Tray] Update effective status on model insertion (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28435?vs

D28435: [System Tray] Update effective status on model insertion

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This fixes the same issue affecting Vaults too. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28435 To: broulik, #plasma, kmaterka, davidre,

D28435: [System Tray] Update effective status on model insertion

broulik created this revision. broulik added reviewers: Plasma, kmaterka, davidre, ahmadsamir. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN - Started Konversation, has proper effective status of passive again.

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

epopov updated this revision to Diff 78827. epopov added a comment. Use `hideOnWindowDeactivate` property instead of `configuration.pin` REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28408?vs=78805=78827 REVISION DETAIL

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

gt; target: applet > onExpandedChanged: { > We should be able to hide the pinned applet by clicking in the system tray (at least this can be done now). REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28408 To: epopov, ngraham Cc

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

davidedmundson added a comment. As a question, rather than a researched proposal, is it better to check for the pin in? systemtray / PlasmoidItem.qml Connections { target: applet onExpandedChanged: { INLINE COMMENTS > main.qml:158 > + > +

D28408: Bug 416510: Klipper applet closes itself when I click on a history item while the system tray popup is pinned open

epopov created this revision. epopov added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. epopov requested review of this revision. REVISION SUMMARY When I pin a Klipper widget and then click on a history item, the Klipper widget closes. To

D28211: Make Pin buttons consistently sized in System Tray and Clock pop-ups

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3a44e360e01e: Make Pin buttons consistently sized in System Tray and Clock pop-ups (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org

Re: Drag and drop to system tray

"Also, since most System Tray icons are applets which hardly ever handle any files." You forgot about applications like Telegram, Skype, etc. These applications indeed accept files for sending. Currently if I want to send a file via drag and drop I have to open the window (e.g. Teleg

Re: Drag and drop to system tray

Hi, I think Martin means a behavior similar to the task manager where dragging a file over a window and waiting a little will raise that window so you can drag that file into the corresponding window. There's no plans to implement this and I personally think apps don't belong in System Tray

Re: Drag and drop to system tray

When you say system tray, what specifically are you referring to? There are definitely no plans to support dropping files onto the org.kde.plasma.systemtray containment.

Drag and drop to system tray

Hi, are there any plans to implement drap and drop support to system tray? So that it is possible to drag any file to an icon in the system tray, then the window of the corresponding app opens and then the file can be dropped in the right destination. Best regards, Martin

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

kmaterka added a comment. Fix for narrow panel in D27958 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg, niccolove, ngraham Cc: broulik, kmaterka, gvgeo, ngraham, plasma-devel, Orage,

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

ngraham added a comment. In D27466#624639 , @kmaterka wrote: > I guess it needs to be reworked... I can do that, just need few days for investigation. Thanks, much appreciated! REPOSITORY R120 Plasma Workspace REVISION DETAIL

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

kmaterka added a comment. In D27466#624574 , @broulik wrote: > > I believe that D26992 , moves the icons down. > > It looks like with that patch the icon sizes differ between plasmoids and SNIs

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

broulik added a comment. > I believe that D26992 , moves the icons down. It looks like with that patch the icon sizes differ between plasmoids and SNIs REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27466 To:

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

gvgeo added a comment. I believe that D26992 , moves the icons down. And this patch, by adding an extra smallSpacing/2 makes it more noticeable. Baking magic numbers is always questionable. Either the 1 smallspacing before, or the current 3/2, or 2

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

kmaterka added a comment. In D27466#624447 , @broulik wrote: > This causes layouting issues in narrow panels: > F8167100: Screenshot_20200309_085328.PNG > The icons are also too far apart For

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

broulik added a comment. This causes layouting issues in narrow panels: F8167100: Screenshot_20200309_085328.PNG REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg, niccolove, ngraham

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d1d769841d53: Increase the size of system tray icon hitboxes on the System Tray Plasmoid (authored by The-Feren-OS-Dev, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 77210. The-Feren-OS-Dev added a comment. Redone, again. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=77209=77210 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27466

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 77209. The-Feren-OS-Dev added a comment. One more diff tweak to make it normal-er. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=77208=77209 REVISION DETAIL https://phabricator.kde.org/D27466 AFFECTED FILES

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 77208. The-Feren-OS-Dev added a comment. Rebased on master CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75913=77208 REVISION DETAIL https://phabricator.kde.org/D27466 AFFECTED FILES

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

kmaterka added a comment. In D27466#620470 , @gvgeo wrote: > IMO this is the wrong way to do these changes. > > 1. I don't see "itemSize" to be used anywhere else(didn't check) than "tasksRow" where we already add a smallSpacing. It would be

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

gvgeo added a comment. IMO this is the wrong way to do these changes. 1. I don't see "itemSize" to be used anywhere else(didn't check) than "tasksRow" where we already add a smallSpacing. It would be best to increase the size in one place. 2. For tablets already allow to use bigger

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

IlyaBizyaev added a comment. Well, if dedoimedo likes it this way, then it's probably the right thing to do ;) Since no one else complains about this change, I'll assume I just was lucky to have proper scaling on my machine without "magic number" spacings. BRANCH D27466 (branched

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

niccolove added a comment. E.g.: dedoimedo complained about this in both the .18 and .17 review. BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg, niccolove, ngraham Cc: IlyaBizyaev, ngraham, plasma-devel, Orage,

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev added a comment. The main point of this patch is the spacing increase between tray icons that this hitbox size increase gives, which makes the tray look less cramped as a result. BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

IlyaBizyaev added a comment. It's hard to measure this in pixels, but on the screenshot, it's a 10% increase in size. I use default font settings btw, with a global scaling factor of 1.25. I'm not strongly against this, but I don't really see a point in this either. In, like, 4 years

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

ngraham added a comment. I mean, it's only one more pixel. :) But yes, for some people with certain fonts maybe it will be too much. But then again, could a single pixel really be enough to make it too much? BRANCH D27466 (branched from master) REVISION DETAIL

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

IlyaBizyaev added a comment. In D27466#620191 , @ngraham wrote: > It is (already) font-dependent, yes. A higher font size will result in larger spacing. > > IMO this is not super sensible, but, there is it. :p Ok, so I guess for the

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

ngraham added a comment. It is (already) font-dependent, yes. A higher font size will result in larger spacing. IMO this is not super sensible, but, there is it. :p BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg,

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev added a comment. Went to check on different DPIs again to be sure it's fine and it definitely looks fine to me, scaling up the hitbox padding additions (and therefore the icon spacing) in sync with the DPI scaling very nicely, so that shouldn't be an issue. BRANCH D27466

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev added a comment. In D27466#620052 <https://phabricator.kde.org/D27466#620052>, @IlyaBizyaev wrote: > In D27466#620050 <https://phabricator.kde.org/D27466#620050>, @The-Feren-OS-Dev wrote: > > > This patch only affects the System Tray widget i

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

IlyaBizyaev added a comment. In D27466#620050 <https://phabricator.kde.org/D27466#620050>, @The-Feren-OS-Dev wrote: > This patch only affects the System Tray widget itself, not anything else on the panel. Only the spacing around the icons that are part of the System Tray appl

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

r" screenshot. With normal usage, my systray area (icons + clock + a note widget) takes up 1/4 of the panel. Does it mean that after this change, it's going to be even larger? This patch only affects the System Tray widget itself, not anything else on the panel. Only the spacing around the

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

IlyaBizyaev added a comment. Repeating my comment on the previous diff for this change: on my machine, the current spacing for systray elements already looks like your "after" screenshot. With normal usage, my systray takes up 1/4 of the panel. Does it mean that after this change, it's

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev added a comment. In D27466#619931 , @ngraham wrote: > So at this point it's just one pixel, and I don't see the huge harm. :) However the last patch to adjust this (D27438 ) proved quite

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

ngraham accepted this revision. ngraham added a comment. So at this point it's just one pixel, and I don't see the huge harm. :) However the last patch to adjust this (D27438 ) proved quite controversial, so we should wait for more opinions to avoid

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9e0711ac408d: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet… (authored by The-Feren-OS-Dev, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

niccolove added a comment. +1 BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 To: The-Feren-OS-Dev, #vdg, niccolove Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

ngraham accepted this revision. ngraham added a reviewer: Plasma. ngraham added a comment. This revision is now accepted and ready to land. LGTM. #plasma folks, is this all technically correct? REPOSITORY R120 Plasma Workspace BRANCH D27465

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 75913. The-Feren-OS-Dev added a comment. Updated diff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75912=75913 BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 AFFECTED FILES

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 75912. The-Feren-OS-Dev added a comment. Updated diff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75873=75912 BRANCH D27466 (branched from master) REVISION DETAIL https://phabricator.kde.org/D27466 AFFECTED FILES

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

The-Feren-OS-Dev updated this revision to Diff 75911. The-Feren-OS-Dev marked an inline comment as done. The-Feren-OS-Dev added a comment. Moved baseSize declaration and changed it to a standard variable REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

ngraham added inline comments. INLINE COMMENTS > main.qml:44 > property bool vertical: plasmoid.formFactor === PlasmaCore.Types.Vertical > -readonly property int itemSize: > units.roundToIconSize(Math.min(Math.min(width, height), >

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 75873. The-Feren-OS-Dev added a comment. You gotta love arc/git sometimes... CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75872=75873 BRANCH D27466 (branched from master) REVISION DETAIL

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 75872. The-Feren-OS-Dev added a comment. Arcanist please REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75871=75872 BRANCH D27466 (branched from master) REVISION DETAIL

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 75871. The-Feren-OS-Dev added a comment. Hopefully fixed the diff again REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75870=75871 BRANCH D27466 (branched from master) REVISION DETAIL

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

The-Feren-OS-Dev updated this revision to Diff 75870. The-Feren-OS-Dev added a comment. Updated diff to be in line with parent patch REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27466?vs=75864=75870 BRANCH arcpatch-D27465_1 REVISION DETAIL

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

The-Feren-OS-Dev updated this revision to Diff 75869. The-Feren-OS-Dev added a comment. Tidied up code a bit and introduced new baseSize variable - Slightly increase system tray icon hitboxes in Non Tablet Mode Plasma REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

ngraham added inline comments. INLINE COMMENTS > main.qml:47 > +// Set the tray items' clickable areas on the panel to be bigger > than normal to allow for easier touchability > +return units.roundToIconSize(Math.min(Math.min(width, height), >

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. ...and now the split is complete. https://phabricator.kde.org/D27466 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham, davidre Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis,

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

The-Feren-OS-Dev updated this revision to Diff 75863. The-Feren-OS-Dev added a comment. Got rid of unnecessary rounding of smallSpacing at the end of the Tablet Mode padding addition REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. The initial patch of the three, now I've thought up a suitable way of doing this, has been made: https://phabricator.kde.org/D27465 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg,

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. Actually, on second thought, @ngraham I'm not even sure if step 2 would even be worth it on its own, if possible. On your suggestion you have it adjusted to have step 3's tablet mode checker in step 2. If I don't have that check in place, for step 2,

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. In D27438#613097 , @ngraham wrote: > ...one to increase the spacing when in tablet mode, and another one to increase the spacing when in desktop mode. At this point each patch will be changing a different line

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev abandoned this revision. The-Feren-OS-Dev added a comment. Alright, I'll start splitting the patches up now. Marking this one as Abandoned. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham, davidre

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. In D27438#613104 , @IlyaBizyaev wrote: > I agree with @broulik in that the spacing already feels quite excessive, or at least doesn't need to be increased (: > > Does this depend on DPI/panel size maybe?

D27438: Increase System Tray Plasmoid spacing value slightly

IlyaBizyaev added a comment. I agree with @broulik in that the spacing already feels quite excessive, or at least doesn't need to be increased (: Does this depend on DPI/panel size maybe? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To:

D27438: Increase System Tray Plasmoid spacing value slightly

ngraham added a comment. https://community.kde.org/Infrastructure/Phabricator#Marking_patches_as_dependent_on_other_patches It would probably be simplest do just do this though: 1. Abandon this patch 2. Submit a patch to refactor that logic to use a nested multi-line function for

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. How would I split it into two patches? Both patches would edit the exact same line. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27438 To: The-Feren-OS-Dev, #vdg, ngraham, davidre Cc: broulik, kmaterka, filipf, ndavis,

D27438: Increase System Tray Plasmoid spacing value slightly

ngraham added a comment. This should probably be two patches at this point: one to increase the spacing when using tablet mode (which IMO is an uncontroversial no-brainer) and another to increase the spacing when in desktop mode. INLINE COMMENTS > main.qml:45 > +// If

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev updated this revision to Diff 75851. The-Feren-OS-Dev added a comment. Tweaked an added comment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27438?vs=75850=75851 BRANCH master REVISION DETAIL

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev added a comment. In D27438#613051 , @davidre wrote: > In D27438#613050 , @The-Feren-OS-Dev wrote: > > > In D27438#612719 , @davidre

D27438: Increase System Tray Plasmoid spacing value slightly

The-Feren-OS-Dev updated this revision to Diff 75850. The-Feren-OS-Dev added a comment. Changed method used for increasing spacing between tray icons to something that increases hitbox sizes as well REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

  1   2   3   4   5   6   7   8   9   10   >