D29883: German translations for plasmanetworkmanagement-kded

2020-12-12 Thread Alois Spitzbart
loisspitz created this revision. loisspitz added a reviewer: kde-i18n-de. loisspitz added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. loisspitz requested review of this revision. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D25984: Load translations

2020-05-18 Thread Kai Uwe Broulik
broulik abandoned this revision. broulik added a comment. Looks like D27595 fixes the issue REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid Cc: vkrause, mart, davidedmund

D29706: support translations in faces

2020-05-13 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R111:ee2ff95bcbab: support translations in faces (authored by mart). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29706?vs=82743&id=82747 REVISION DE

D29706: support translations in faces

2020-05-13 Thread Marco Martin
mart updated this revision to Diff 82743. mart added a comment. - i18nd REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29706?vs=82741&id=82743 BRANCH phab/i18n REVISION DETAIL https://phabricator.kde.org/D29706 AFFECTED FILES faces/Config

D29706: support translations in faces

2020-05-13 Thread Marco Martin
mart updated this revision to Diff 82741. mart added a comment. - add own context for the internal qml files REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29706?vs=82726&id=82741 BRANCH phab/i18n REVISION DETAIL https://phabricator.kde.org/

D29706: support translations in faces

2020-05-13 Thread Marco Martin
mart added a comment. In D29706#669968 <https://phabricator.kde.org/D29706#669968>, @davidedmundson wrote: > Who extracts and loads the translations for: > > ./ConfigAppearance.qml > ./ConfigSensors.qml > ./FaceDetailsConfig.qml > ./UsedSensorsVie

D29706: support translations in faces

2020-05-13 Thread David Edmundson
davidedmundson added a comment. Who extracts and loads the translations for: ./ConfigAppearance.qml ./ConfigSensors.qml ./FaceDetailsConfig.qml ./UsedSensorsView.qml in the top level of faces but not in an individual package. code for the other stuff looks

D29706: support translations in faces

2020-05-13 Thread Marco Martin
mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY give each face its own catalog REPOSITORY R111 KSysguard Library BRANCH phab/i18n REVISION DETAIL

D25984: Load translations

2020-03-19 Thread Volker Krause
vkrause added a comment. In D25984#589426 , @mart wrote: > ping, what's the current status of this? There's also https://phabricator.kde.org/D27595, which might address the same/a similar issue. REPOSITORY R169 Kirigami REVISION DETAI

D26242: Port the translations module to ManagedConfigModule

2020-01-08 Thread Kevin Ottens
This revision was automatically updated to reflect the committed changes. Closed by commit R120:34216709c060: Port the translations module to ManagedConfigModule (authored by ervin). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26242?vs=72243&am

Re: New Emojier translations

2020-01-07 Thread Aleix Pol
On Mon, Dec 30, 2019 at 8:26 PM Luigi Toscano wrote: > > Yuri Chornoivan ha scritto: > > Hi, > > > > There is a report in Russian mailing list that the translations for the new > > emoji KCM [1] do not work. It is reported that the catalog name > > (plasma_appl

D25984: Load translations

2020-01-07 Thread Marco Martin
mart added a comment. ping, what's the current status of this? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter Cc: mart, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraha

Re: New Emojier translations

2019-12-30 Thread Luigi Toscano
Yuri Chornoivan ha scritto: > Hi, > > There is a report in Russian mailing list that the translations for the new > emoji KCM [1] do not work. It is reported that the catalog name > (plasma_applet_org.kde.kimpanel.po [2]) does not work for KCM (aka Emojier). > > It was s

D26242: Port the translations module to ManagedConfigModule

2019-12-27 Thread Kevin Ottens
ervin updated this revision to Diff 72243. ervin added a comment. Add missing files REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26242?vs=72242&id=72243 REVISION DETAIL https://phabricator.kde.org/D26242 AFFECTED FILES kcms/translat

D26242: Port the translations module to ManagedConfigModule

2019-12-27 Thread Kevin Ottens
/D26242 AFFECTED FILES kcms/translations/CMakeLists.txt kcms/translations/package/contents/ui/main.qml kcms/translations/translations.cpp kcms/translations/translations.h To: ervin, #plasma, mart, davidedmundson, crossi, bport Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578306 , @kossebau wrote: > Hm, though now I am confused why calling this from `KirigamiPlugin::initializeEngine` fixes things for you, the static struct constructor of that startup hook technology in the lib

D25984: Load translations

2019-12-15 Thread Kai Uwe Broulik
broulik added a comment. I guess it builds the QML tree and evaluates the `qsTr` calls and then finds it needs an item from a plugin and loads the import and only then translates it. Subsequent controls are translated, only the ones on the initial item are not. Perhaps if we shoehorn a `QQml

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. Hm, though now I am confused why calling this from `KirigamiPlugin::initializeEngine` fixes things for you, the static struct constructor of that startup hook technology in the lib should be invoked before during loading, no? Time to go playing with the actual

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578299 <https://phabricator.kde.org/D25984#578299>, @broulik wrote: > Ok, so turns out, it does call it when the plugin is loaded, but the translations are only installed *after* the QML has loaded and processed. Uh, okay, that s

D25984: Load translations

2019-12-15 Thread David Edmundson
davidedmundson added a comment. > Okay. Which app did you test with? Does it link kcoreaddons? Would poke then as well a bit, as I happen to have a related rant blog post lying around ;) ). systemsettings5 exhibits this situation REPOSITORY R169 Kirigami REVISION DETAIL https://pha

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578298 <https://phabricator.kde.org/D25984#578298>, @broulik wrote: > Well, whatever it is, it doesn't work. My search field isn't translated and I put breakpoints and I only get it load translations for kcoreaddons and kjobwi

D25984: Load translations

2019-12-15 Thread Kai Uwe Broulik
broulik added a comment. Ok, so turns out, it does call it when the plugin is loaded, but the translations are only installed *after* the QML has loaded and processed. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks

D25984: Load translations

2019-12-15 Thread Kai Uwe Broulik
broulik added a comment. Well, whatever it is, it doesn't work. My search field isn't translated and I put breakpoints and I only get it load translations for kcoreaddons and kjobwidgets. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 T

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578296 , @broulik wrote: > We don't link against Kirigami, so the startup routine stuff doesn't apply? `Q_COREAPP_STARTUP_FUNCTION` generates a static struct in the compiled code, whose constructor will

D25984: Load translations

2019-12-15 Thread Kai Uwe Broulik
broulik added a comment. We don't link against Kirigami, so the startup routine stuff doesn't apply? And we're way after the QCoreApp constructor at this point. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aac

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D25984#578291 , @broulik wrote: > Qt docs say "Adds a global function that will be called from the QCoreApplication constructor. " but when we at runtime somewhere load a QML plugin we're too late with that.

D25984: Load translations

2019-12-15 Thread Kai Uwe Broulik
broulik added a comment. Qt docs say "Adds a global function that will be called from the QCoreApplication constructor. " but when we at runtime somewhere load a QML plugin we're too late with that. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik

D25984: Load translations

2019-12-15 Thread Friedrich W. H. Kossebau
kossebau added a comment. > The ECM QM Loader uses Q_COREAPP_STARTUP_FUNCTION which doesn't work for things loaded as plugins like QML modules. Curious, where it exactly does it fail to work? Q_COREAPP_STARTUP_FUNCTION being nvoked during lib loading after the QApp instance exists still

D25984: Load translations

2019-12-14 Thread Kai Uwe Broulik
broulik added a comment. Sounds good to me lol REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D25984 To: broulik, #kirigami, #frameworks, kossebau, aacid, sitter Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, ma

D25984: Load translations

2019-12-14 Thread Harald Sitter
sitter added a comment. Seems a bit meh to have a verbatim copy of the auto generated functions. Perhaps it'd be better to add an option to the ECM generator to export a loader function for use in plugins? Then we could just call that from the plugin init instead of having to copy it. REP

D25984: Load translations

2019-12-14 Thread Kai Uwe Broulik
x27;t work for things loaded as plugins like QML modules. This copies the logic over to the plugin so the translations are loaded when the QML plugin is loaded. Not really like it, so I'm open to suggestions how to do that better in ECM or I don't know? TEST PLAN - The Search fi

D25306: Add translations for new memory sensors

2019-11-27 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes. Closed by commit R111:eedf1ca73d1b: Add translations for new memory sensors (authored by ahiemstra). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25306?vs=69749&id=7

Software translations

2019-11-18 Thread David Rebolo Magariños
Hello there, I was wondering if Plasma Mobile has an official site for translators to translate their ROM to our respective languages? If so, what is it call? Thank you for answering my question, David Rebolo Magariños

D25306: Add translations for new memory sensors

2019-11-14 Thread Arjen Hiemstra
ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY This adds the translated strings for the new Total, Available and Allocated sensors.

D18860: Add comment / description to the translations kcm

2019-07-26 Thread Eike Hein
hein added a comment. Good stuff 👍 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma, ngraham, bshah Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliez

D18860: Add comment / description to the translations kcm

2019-07-26 Thread Jonah Brüchert
This revision was automatically updated to reflect the committed changes. Closed by commit R120:59b1f923be29: Add comment / description to the translations kcm (authored by jbbgameich). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18860?vs=61958&am

D18860: Add comment / description to the translations kcm

2019-07-25 Thread Bhushan Shah
bshah accepted this revision as: bshah. bshah added a comment. This revision is now accepted and ready to land. I'd say if no-one else objects, feel free to submit this revision now. :-) We can always revise it since this is not going in stable branch. REPOSITORY R120 Plasma Workspace

D22517: kcms: translations: Make list separator translatable

2019-07-18 Thread Alexander Potashev
This revision was automatically updated to reflect the committed changes. Closed by commit R120:87da6e5d75cc: kcms: translations: Make list separator translatable (authored by aspotashev). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22517?vs=61934

D18860: Add comment / description to the translations kcm

2019-07-18 Thread Jonah Brüchert
8860 AFFECTED FILES kcms/translations/kcm_translations.desktop To: jbbgameich, hein, #plasma, ngraham Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D18860: Add comment / description to the translations kcm

2019-07-17 Thread Eike Hein
hein added a comment. How about - and sorry if you're tired of the patch by now - "Change workspace and application languages"? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma, ngraham Cc: bshah, sitter, apol, plasma-deve

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

2019-07-17 Thread Eike Hein
hein added a comment. Sorry, the cryptic comment can be safely ignored. I had a concern at first, then looked into it, decided I'm OK with the patch and forgot the started sentence. :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22503 To: jbbgameich,

D22517: kcms: translations: Make list separator translatable

2019-07-17 Thread Alexander Potashev
kcms/translations/package/contents/ui/main.qml To: aspotashev Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

2019-07-17 Thread Jonah Brüchert
This revision was automatically updated to reflect the committed changes. Closed by commit R120:08a802656df5: kcms: translations: use availableDomainTranslations from plasmashell instead of… (authored by jbbgameich). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https

D18860: Add comment / description to the translations kcm

2019-07-17 Thread Jonah Brüchert
ttps://phabricator.kde.org/D18860 AFFECTED FILES kcms/translations/kcm_translations.desktop To: jbbgameich, hein, #plasma, ngraham Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

2019-07-17 Thread Bhushan Shah
bshah added a comment. (me confused by cryptic comment) :P REPOSITORY R120 Plasma Workspace BRANCH translations-no-systemsettings (branched from master) REVISION DETAIL https://phabricator.kde.org/D22503 To: jbbgameich, hein Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

2019-07-17 Thread Eike Hein
hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. This creayes REPOSITORY R120 Plasma Workspace BRANCH translations-no-systemsettings (branched from master) REVISION DETAIL https://phabricator.kde.org/D22503 To: jbbgameich, hein Cc

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

2019-07-17 Thread Bhushan Shah
bshah added subscribers: hein, bshah. bshah added a comment. Personally speaking, +1, would love opinion of @hein REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22503 To: jbbgameich Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ra

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

2019-07-17 Thread Jonah Brüchert
. REPOSITORY R120 Plasma Workspace BRANCH translations-no-systemsettings (branched from master) REVISION DETAIL https://phabricator.kde.org/D22503 AFFECTED FILES kcms/translations/translations.cpp kcms/translations/translationsmodel.cpp To: jbbgameich Cc: plasma-devel, LeGast00n, jraleigh

D18860: Add comment / description to the translations kcm

2019-07-16 Thread Eike Hein
hein added a comment. Agreed with Harald, the wording's misleading sorry :) REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma, ngraham Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezha

D18860: Add comment / description to the translations kcm

2019-07-16 Thread Bhushan Shah
bshah added a comment. bump REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma, ngraham Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D18860: Add comment / description to the translations kcm

2019-06-27 Thread Harald Sitter
sitter added a comment. Mh, technically it's not setting system language, is it? It changes the user's language but has no facilities to apply that at system scope (i.e. across all users) Looking at the other KCMs the comment is more of the form "Configure/Change/Customize foobar" or "F

D18860: Add comment / description to the translations kcm

2019-06-24 Thread Jonah Brüchert
jbbgameich added a comment. ping REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma, ngraham Cc: apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D21422: [Notifications] Fix translations in popup

2019-05-27 Thread Victor Ryzhykh
victorr added a comment. In D21422#470541 , @victorr wrote: > > We also need this patch.F6854024: plasma-workspace-fix.patch > > It is possible that I am mistaken. > Need to check again. > Today, a

D21422: [Notifications] Fix translations in popup

2019-05-27 Thread Victor Ryzhykh
victorr added a comment. In D21422#470534 , @victorr wrote: > In D21422#470522 , @broulik wrote: > > > Which files are you missing? `main.qml` and `FullRepresentation.qml` aren't changed on purpose

D21422: [Notifications] Fix translations in popup

2019-05-27 Thread Victor Ryzhykh
victorr added a comment. In D21422#470522 , @broulik wrote: > Which files are you missing? `main.qml` and `FullRepresentation.qml` aren't changed on purpose as it's not neccessary there. We also need this patch.F6854024: plasma-workspace-

D21422: [Notifications] Fix translations in popup

2019-05-27 Thread Kai Uwe Broulik
broulik added a comment. Which files are you missing? `main.qml` and `FullRepresentation.qml` aren't changed on purpose as it's not neccessary there. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21422 To: broulik, #plasma, aacid, yurchor Cc: victorr, pla

D21422: [Notifications] Fix translations in popup

2019-05-27 Thread Victor Ryzhykh
victorr added a comment. This does not fix all files. I made such a patch two days ago.F6854006: plasma-workspace-5.15.90-fix_locales.patch REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21422 To: broulik, #plasma,

D21422: [Notifications] Fix translations in popup

2019-05-27 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R120:41e41b194c1f: [Notifications] Fix translations in popup (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21422?vs=58703&id=5

D21422: [Notifications] Fix translations in popup

2019-05-27 Thread Yuri Chornoivan
yurchor accepted this revision. yurchor added a comment. This revision is now accepted and ready to land. Thanks. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21422 To: broulik, #plasma, aacid, yurchor Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, Zre

D21422: [Notifications] Fix translations in popup

2019-05-27 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, aacid, yurchor. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The popup is a pure QML singleton and as such doesn't inherit the i18n context fro

D18860: Add comment / description to the translations kcm

2019-02-10 Thread Jonah Brüchert
jbbgameich updated this revision to Diff 51321. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18860?vs=51210&id=51321 REVISION DETAIL https://phabricator.kde.org/D18860 AFFECTED FILES kcms/translations/kcm_translations.desktop To: jbbgameich, hein, #plasma Cc: apol, plasma-d

D18860: Add comment / description to the translations kcm

2019-02-10 Thread Aleix Pol Gonzalez
apol added a comment. How about `System and applications language`? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D18860: Add comment / description to the translations kcm

2019-02-08 Thread Jonah Brüchert
-settings REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18860 AFFECTED FILES kcms/translations/kcm_translations.desktop To: jbbgameich, hein, #plasma Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts

[plasma-workspace] kcms/translations: Add copy of writeexports.h

2019-01-05 Thread Bhushan Shah
Git commit 46148f70835acd9a6037929266e3e1283d730f48 by Bhushan Shah. Committed on 05/01/2019 at 16:25. Pushed by bshah into branch 'master'. Add copy of writeexports.h todo: we should probably move this to some framework? so that both formats kcm or translations kcm can use this. Alt

D15115: fix translations kcm to be usable on new users/installations

2018-09-13 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:991bcf7d0d90: fix translations kcm to be usable on new users/installations (authored by sitter, committed by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https

D15115: fix translations kcm to be usable on new users/installations

2018-09-13 Thread Eike Hein
r.kde.org/D15115 AFFECTED FILES kcms/translations/translations.cpp To: hein, sitter Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15115: fix translations kcm to be usable on new users/installations

2018-09-13 Thread Eike Hein
hein commandeered this revision. hein edited reviewers, added: sitter; removed: hein. hein added a comment. I'll commandeer this rev to fix up the patch. Sorry @sitter, but then we can get this into beta still. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1

D15115: fix translations kcm to be usable on new users/installations

2018-09-13 Thread Eike Hein
However `SelectedTranslationsModel` only emits the signal when the list has changed, and an initial call to `setSelectedLanguages` with both the member and the parameter being empty doesn't cause an emit. This means your patch can be simplified though. Only the `Translations::load()`

D15115: fix translations kcm to be usable on new users/installations

2018-08-28 Thread Harald Sitter
.kde.org/D15115 AFFECTED FILES kcms/translations/translations.cpp To: sitter, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12118: Only install translations if they are available

2018-05-15 Thread Heiko Becker
heikobecker added a comment. In D12118#262926 , @ltoscano wrote: > I'd argue that ki18n_install should be fixed instead. It does not make sense to duplicate the if check for every call to ki18n_install. Seems every other ki18n_install cal

D12118: Only install translations if they are available

2018-05-15 Thread Luigi Toscano
ltoscano added a comment. I'd argue that ki18n_install should be fixed instead. It does not make sense to duplicate the if check for every call to ki18n_install. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D12118 To: heikobecker, #plasma, graess

D12118: Only install translations if they are available

2018-05-15 Thread Heiko Becker
heikobecker added a comment. In D12118#262921 , @ltoscano wrote: > This change should not be needed; ki18n_install is a noop operation if the directory does not exist - did you see any issue? Yeah, it tries to install an empty dir: '/usr/

D12118: Only install translations if they are available

2018-05-15 Thread Luigi Toscano
ltoscano requested changes to this revision. ltoscano added a comment. This revision now requires changes to proceed. This change should not be needed; ki18n_install is a noop operation if the directory does not exist - did you see any issue? REPOSITORY R129 Window Decoration Library REVIS

D12118: Only install translations if they are available

2018-05-15 Thread Heiko Becker
heikobecker added a comment. Ping? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D12118 To: heikobecker, #plasma, graesslin Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12118: Only install translations if they are available

2018-04-11 Thread Heiko Becker
heikobecker created this revision. heikobecker added reviewers: Plasma, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. heikobecker requested review of this revision. REVISION SUMMARY Otherwise an empty directory might get insta

D11812: Update translations docbook to 5.12

2018-04-04 Thread Burkhard Lück
This revision was automatically updated to reflect the committed changes. Closed by commit R119:5f8541f791b0: Update translations docbook to 5.12 (authored by lueck). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11812?vs=30954&id=31317 REVI

D11812: Update translations docbook to 5.12

2018-03-30 Thread Burkhard Lück
-> plasma TEST PLAN checkXML5 index.docbook REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D11812 AFFECTED FILES doc/kcontrol/translations/index.docbook To: lueck, #plasma, #documentation Cc: plasma-devel, kde-doc-english, ragreen, ZrenBot, lesliezhai,

D11482: Export Translations to right filename

2018-03-20 Thread Leszek Lesner
The issue actually was with the localization not been completed for some languages. So basically my mistake not looking there first after kbroulik told me it is a bug :P I initially thought maybe the pot files weren't updated correctly and that caused the translations not being complet

D11482: Export Translations to right filename

2018-03-20 Thread David Edmundson
davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > I doubt changing the name of the translation catalog is correct, because You're right. Change could still make sense if done with changing those other things

D11482: Export Translations to right filename

2018-03-20 Thread Burkhard Lück
lueck added a comment. I doubt changing the name of the translation catalog is correct, because 1. CMakeLists.txt has add_definitions (-DTRANSLATION_DOMAIN=\"plasmavault-kde\") therefore the vault library uses the translation domain "plasmavault-kde", not "plasma_applet_org.kde.plasma.va

D11482: Export Translations to right filename

2018-03-19 Thread Leszek Lesner
leszeklesner created this revision. leszeklesner added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. leszeklesner requested review of this revision. REVISION SUMMARY It exports its qml translations to plasmavault

D5209: Load translations from KPackage files if bundled

2018-02-02 Thread Luigi Toscano
ltoscano removed a dependency: D10215: Make KReport use marble component, KEXI & KEXI frameworks stable is 3.1. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: ltoscano, Zren, plasma-devel, #frameworks, micha

D5209: Load translations from KPackage files if bundled

2018-02-01 Thread Aleksandar Varagic
avaragic added a dependency: D10215: Make KReport use marble component, KEXI & KEXI frameworks stable is 3.1. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: ltoscano, Zren, plasma-devel, #frameworks, michael

D10219: Load translations from KPackage files if bundled

2018-01-31 Thread Chris Holland
This revision was automatically updated to reflect the committed changes. Closed by commit R118:37792755e48a: [plasmoidviewer] Load translations from KPackage files if bundled (authored by Zren). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10219?vs

D10219: Load translations from KPackage files if bundled

2018-01-31 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. thanks REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D10219 To: Zren, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwo

D10219: Load translations from KPackage files if bundled

2018-01-31 Thread Chris Holland
etup a test env that doesn't have translations elsewhere. cp -r /usr/share/plasma/plasmoids/org.kde.plasma.volume . cd org.kde.plasma.volume mkdir -p contents/locale/fr/LC_MESSAGES rm metadata.json kwriteconfig5 --file "$(realpath metadata.desktop)" --group

Re: Translations and appstream summaries

2017-12-15 Thread Shinjo Park
2017년 12월 14일 목요일 오후 11시 40분 14초 CET에 David Edmundson 님이 쓴 글: > org.kde.plasmashell.metainfo.xml in the repo plasma-desktop > we have errors on: > uk, sr-ijekavianlatin, sr-Latn, fr, el, nn, sr-ijekavian, es, gl, ko, sr Fixed for ko. Sorry about the inconvenience. signature.asc Description: This

Re: Translations and appstream summaries

2017-12-14 Thread Matthias Klumpp
2017-12-14 23:40 GMT+01:00 David Edmundson : > Translators, > > We're getting a bunch of tests failing [1] because of a translation issue. I wonder if that's true - appstreamcli will only return a non-zero exist status if you have warnings or errors, the added dot is just an info-type validation m

Translations and appstream summaries

2017-12-14 Thread David Edmundson
Translators, We're getting a bunch of tests failing [1] because of a translation issue. Appstream considers it to be a test failure if any description summary ends in a full stop . In particular for this file: org.kde.plasmashell.metainfo.xml in the repo plasma-desktop we have errors on: uk, s

D5209: Load translations from KPackage files if bundled

2017-10-25 Thread Chris Holland
Zren added a comment. Another note: `plasmoidviewer` is unaffected by this patch. Meaning - `devpath/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo` will not show translations in plasmoidviewer, but if you install to - `/.local/share/plasma

D5209: Load translations from KPackage files if bundled

2017-10-25 Thread Chris Holland
Zren added a comment. This worked - `~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/fr_CA/LC_MESSAGES/plasma_applet_org.kde.plasma.eventcalendar.mo` These didn't work - `~/.local/share/plasma/plasmoids/org.kde.plasma.eventcalendar/contents/locale/f

D5209: Load translations from KPackage files if bundled

2017-07-11 Thread Luigi Toscano
ltoscano added a comment. In https://phabricator.kde.org/D5209#124129, @davidedmundson wrote: > contents/locale/fr/org.kde.blahblah.po > > which is the same as KDE4. I guess you mean contents/locale/fr/org.kde.blahblah.**mo** ? REPOSITORY R242 Plasma Framework (Library)

D5209: Load translations from KPackage files if bundled

2017-07-11 Thread David Edmundson
davidedmundson added a comment. contents/locale/fr/org.kde.blahblah.po which is the same as KDE4. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: Zren, plasma-devel, #frameworks, ZrenBot, progwolff, l

D5209: Load translations from KPackage files if bundled

2017-07-11 Thread Chris Holland
Zren added a comment. Oh awesome. Just found out about this. So this would be added in Frameworks 5.37 then? Does this mean: 1. `digitalclock.plasmoid/translations/plasma_applet_org.kde.plasma.digitalclock.po` 2. `digitalclock.plasmoid/contents/translations

D5209: Load translations from KPackage files if bundled

2017-07-11 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:3a0f61b5591d: Load translations from KPackage files if bundled (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D5209

D5209: Load translations from KPackage files if bundled

2017-03-28 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, je

D5209: Load translations from KPackage files if bundled

2017-03-27 Thread David Edmundson
davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN Installed battery monitor locally with kpackagetool5 -i moved x-test .po file from being installed systemwide to only b

[Differential] [Closed] D3542: Remove outdated script for handling translations

2016-11-29 Thread ltoscano (Luigi Toscano)
This revision was automatically updated to reflect the committed changes. Closed by commit R119:3cf44a9101e0: Remove outdated script for handling translations (authored by ltoscano). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3542?vs=8614&id=

[Differential] [Accepted] D3542: Remove outdated script for handling translations

2016-11-29 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3542 EMAIL PREFERENCES https://phabricator.kde.org/settings/

[Differential] [Request, 91 lines] D3542: Remove outdated script for handling translations

2016-11-29 Thread ltoscano (Luigi Toscano)
ltoscano created this revision. ltoscano added a reviewer: Plasma. ltoscano added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY The files were relevant when the modules lived in its own repository. Translations are now included in the plasma

  1   2   3   >