Review Request 123276: Plasma-framework: Fix coding style, width should be renamed to height.

2015-04-06 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123276/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 123276: Plasma-framework: Fix coding style, width should be renamed to height.

2015-04-06 Thread David Edmundson
.) Review request for Plasma. Repository: plasma-framework Description --- Fix coding style width - height. Diffs - src/plasmaquick/appletquickitem.cpp 1abedf0 Diff: https://git.reviewboard.kde.org/r/123276/diff/ Testing --- Thanks

Change in plasma-framework[master]: Consider visualParent rotation in popupPosition

2015-04-02 Thread Marco Martin (Code Review)
/dialog.cpp A tests/dialog_positioning_parentrotated.qml 2 files changed, 102 insertions(+), 5 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/38/438/1 diff --git a/src/plasmaquick/dialog.cpp b/src/plasmaquick/dialog.cpp index cdf78eb..2166880 100644

Change in plasma-framework[master]: Simplify code flow

2015-03-13 Thread David Edmundson (Code Review)
an if Change-Id: Ic5046875ad39795248496a0d71f77b1e476058c4 --- M src/plasmaquick/dialog.cpp 1 file changed, 59 insertions(+), 57 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/19/419/1 diff --git a/src/plasmaquick/dialog.cpp b/src/plasmaquick/dialog.cpp

Change in plasma-framework[master]: Disconnect connections to d-mainItem when it has changed

2015-03-13 Thread David Edmundson (Code Review)
insertions(+), 0 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/18/418/1 diff --git a/src/plasmaquick/dialog.cpp b/src/plasmaquick/dialog.cpp index 0d820a6..097cc31 100644 --- a/src/plasmaquick/dialog.cpp +++ b/src/plasmaquick/dialog.cpp @@ -693,6

Change in plasma-framework[master]: Fix segfault in KWin when all screens disappear

2015-03-11 Thread Code Review
::isEffectActive (this=this@entry=0x7f3d1f1be290) at /var/tmp/portage/kde-frameworks/plasma-5.7.0/work/plasma-framework-5.7.0/src/plasma/private/effectwatcher.cpp:91 #3 0x7f3d1a1829a9 in isEffectActive (this=0x7f3d1f1be290) at /var/tmp/portage/kde-frameworks/plasma-5.7.0/work/plasma

[plasma-framework] src/declarativeimports/core: Shorter animations

2015-02-21 Thread Sebastian Kügler
Marco CCMAIL:plasma-devel@kde.org CCMAIL:k...@kde.org M +1-1src/declarativeimports/core/units.cpp http://commits.kde.org/plasma-framework/2cf49abb3e2c4e8ea8d5cb55e523dc1c3f57bddd diff --git a/src/declarativeimports/core/units.cpp b/src/declarativeimports/core/units.cpp index a740145

Change in plasma-framework[master]: support for C++ applets

2015-02-12 Thread Marco Martin (Code Review)
/appletinterface.cpp M src/scriptengines/qml/plasmoid/appletinterface.h 3 files changed, 26 insertions(+), 3 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/74/374/1 diff --git a/src/plasma/pluginloader.cpp b/src/plasma/pluginloader.cpp index 48cd46c..7ecdd15 100644

Change in plasma-framework[master]: Port to kpackage::package

2015-02-11 Thread David Edmundson (Code Review)
src/plasma/svg.cpp 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/67/367/1 diff --git a/src/plasma/svg.cpp b/src/plasma/svg.cpp index 28393e5..0a0db5e 100644 --- a/src/plasma/svg.cpp +++ b/src/plasma/svg.cpp

Change in plasma-framework[master]: Put all non tiled frame textures in the atlas

2015-02-11 Thread David Edmundson (Code Review)
: I2525998ab3c1c76870fe8e395051127a673979af --- M src/declarativeimports/core/framesvgitem.cpp 1 file changed, 17 insertions(+), 3 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/70/370/1 diff --git a/src/declarativeimports/core/framesvgitem.cpp b/src

Change in plasma-framework[master]: Fix leak in ContainmentActions

2015-02-11 Thread David Edmundson (Code Review)
: I41c9b9c224b36b045034755b07a92f2bdfe9f40e --- M src/plasma/containmentactions.cpp 1 file changed, 2 insertions(+), 0 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/66/366/1 diff --git a/src/plasma/containmentactions.cpp b/src/plasma/containmentactions.cpp index 3abb7fe..f24bdac 100644

Change in plasma-framework[master]: Unify when tooltips are shown and kept alive.

2015-02-10 Thread David Edmundson (Code Review)
); } } -- To view, visit https://gerrit.vesnicky.cesnet.cz/r/365 To unsubscribe, visit https://gerrit.vesnicky.cesnet.cz/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7d9ded9edb70672c572e008c8d6f1ffe2d76b773 Gerrit-PatchSet: 1 Gerrit-Project: plasma-framework Gerrit-Branch: master Gerrit

Re: Moving plasmaengineexplorer to plasma-framework?

2015-01-28 Thread Giorgos Tsiapaliokas
Hello, On 1/23/15 7:18 AM, Bhushan Shah wrote: So at moment plasmaengineexplorer is provided by plasmate which is not released at moment. yes unfortunately I haven't done a good job in that. I haven't abandoned plasmate, its just that I don't have the free time that I used to have. AFAIK

Change in plasma-framework[master]: export textFormat for the tooltip

2015-01-27 Thread Marco Martin (Code Review)
/plasmoid/appletinterface.cpp M src/scriptengines/qml/plasmoid/appletinterface.h 5 files changed, 62 insertions(+), 1 deletion(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/45/345/1 diff --git a/src/declarativeimports/core/private/DefaultToolTip.qml b/src

Re: Moving plasmaengineexplorer to plasma-framework?

2015-01-26 Thread Marco Martin
On Monday 26 January 2015, Bhushan Shah wrote: So I think in general moving plasmaengineexplorer to plasma-framework is no go? i would prefer not and we should think of releasing plasmate? yep.. -- Marco Martin ___ Plasma-devel mailing list

Re: Moving plasmaengineexplorer to plasma-framework?

2015-01-26 Thread Bhushan Shah
On Mon, Jan 26, 2015 at 9:35 PM, Bhushan Shah bhus...@gmail.com wrote: Indeed that kdevplatform dep is already optional and there is cmake switch for that too So I think in general moving plasmaengineexplorer to plasma-framework is no go? and we should think of releasing plasmate

Re: Moving plasmaengineexplorer to plasma-framework?

2015-01-26 Thread Sebastian Kügler
On Friday, January 23, 2015 13:32:09 Luca Beltrame wrote: In data venerdì 23 gennaio 2015 13:25:51, David Edmundson ha scritto: The rationale seems to be there's no release of plasmate, which is something very easily fixable by releasing plasmate. Plasmate(5) depends on the KF5 version of

Re: Moving plasmaengineexplorer to plasma-framework?

2015-01-26 Thread Bhushan Shah
On Mon, Jan 26, 2015 at 9:33 PM, Sebastian Kügler se...@kde.org wrote: We can and should make that kdevplatform dependency optional, especially since it's in non-released code. I think, as David already suggested, that we should do a release of the plasmate repo, for now without plasmate (which

Change in plasma-framework[master]: Make keyboard shortcuts work

2015-01-23 Thread Marco Martin (Code Review)
/appletinterface.h 2 files changed, 47 insertions(+), 0 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/42/342/1 diff --git a/src/scriptengines/qml/plasmoid/appletinterface.cpp b/src/scriptengines/qml/plasmoid/appletinterface.cpp index a27258b..0080b0d

Re: Moving plasmaengineexplorer to plasma-framework?

2015-01-23 Thread David Edmundson
I have doubts, I don't want to increase our install size for a developer aide. The rationale seems to be there's no release of plasmate, which is something very easily fixable by releasing plasmate. Equally importantly we have a licensing problem. All frameworks are currently LGPL. This is GPL.

Re: Moving plasmaengineexplorer to plasma-framework?

2015-01-23 Thread Andrea Scarpino
On Fri, Jan 23, 2015 at 6:18 AM, Bhushan Shah bhus...@gmail.com wrote: So at moment plasmaengineexplorer is provided by plasmate which is not released at moment. Also IMHO it makes sense to move plasmaengineexplorer to plasma-frameowork repo due to the fact that is important tool to debug

Re: Moving plasmaengineexplorer to plasma-framework?

2015-01-23 Thread Luca Beltrame
In data venerdì 23 gennaio 2015 13:25:51, David Edmundson ha scritto: The rationale seems to be there's no release of plasmate, which is something very easily fixable by releasing plasmate. Plasmate(5) depends on the KF5 version of kdevplatform, which hasn't seen a release yet. -- Luca

Moving plasmaengineexplorer to plasma-framework?

2015-01-22 Thread Bhushan Shah
the repo to plasma-framework clone [1], it includes total 66 commits from plasmate repo Everything seems to work fine.. compiles builds installs and works :) Thanks! PS: This is first time I have made any move between git repo, so if I am wrong somewhere sorry.. [1] http://quickgit.kde.org/?p

Change in plasma-framework[master]: never resize a dialog bigger than the screen

2015-01-16 Thread Marco Martin (Code Review)
-Id: I840868dbd7db665a3953687977d30dd6c3b4a386 Gerrit-PatchSet: 1 Gerrit-Project: plasma-framework Gerrit-Branch: master Gerrit-Owner: Marco Martin notm...@gmail.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo

Change in plasma-framework[master]: don't animate icons when they get resized

2015-01-16 Thread Marco Martin (Code Review)
sure if m_sizeChanged is true, never to animate the change Change-Id: I552f79b13f7714749137fa90df1f9f30120e6a37 --- M src/declarativeimports/core/iconitem.cpp 1 file changed, 10 insertions(+), 16 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/36/336/1

Change in plasma-framework[master]: Hack: silence failing test on Qt 5.2

2015-01-14 Thread Code Review
deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/24/324/1 diff --git a/autotests/dialognativetest.cpp b/autotests/dialognativetest.cpp index 6811202..7ddc228 100644 --- a/autotests/dialognativetest.cpp +++ b/autotests/dialognativetest.cpp @@ -81,9 +81,11

Change in plasma-framework[master]: Change string from non-existing %2 to %1.

2015-01-12 Thread Xuetian Weng (Code Review)
: I52b69a7bd65118c5d0a8dc5bc1649ca0157769d4 CCMAIL:notm...@gmail.com --- M src/plasma/private/applet_p.cpp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/18/318/1 diff --git a/src/plasma/private/applet_p.cpp b/src/plasma/private

Change in plasma-framework[master]: Add HiddenAction in Plasma::Types::ActionType

2015-01-02 Thread Bhushan Shah (Code Review)
/plasma.h 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/01/301/1 diff --git a/src/plasma/plasma.h b/src/plasma/plasma.h index 15c346b..3ad6327 100644 --- a/src/plasma/plasma.h +++ b/src/plasma/plasma.h @@ -113,7 +113,8

Change in plasma-framework[master]: Set visibility on mainItem to match Dialog

2014-12-28 Thread David Edmundson (Code Review)
-PatchSet: 1 Gerrit-Project: plasma-framework Gerrit-Branch: master Gerrit-Owner: David Edmundson da...@davidedmundson.co.uk Gerrit-Reviewer: Marco Martin notm...@gmail.com ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman

Change in plasma-framework[master]: migrate to KPackage

2014-12-23 Thread Marco Martin (Code Review)
/packageurlinterceptor.cpp 23 files changed, 345 insertions(+), 1,455 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/60/260/1 diff --git a/CMakeLists.txt b/CMakeLists.txt index ccec0ed..891183c 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -59,6

Change in plasma-framework[master]: Add a plotter component

2014-12-16 Thread Marco Martin (Code Review)
changed, 993 insertions(+), 3 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/44/244/1 diff --git a/CMakeLists.txt b/CMakeLists.txt index b19ab53..2a971a0 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -4,7 +4,7 @@ # ECM setup find_package(ECM

Change in plasma-framework[master]: save some CPU cycle when busy indicator is not visible.

2014-12-14 Thread Xuetian Weng (Code Review)
. Change-Id: Ia5c296cdbc6c0ccd2ca45444d4f3171723b50d23 --- M src/declarativeimports/plasmastyle/BusyIndicatorStyle.qml 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/40/240/1 diff --git a/src/declarativeimports

Change in plasma-framework[master]: Different themes between desktop and dialogs

2014-12-11 Thread Marco Martin (Code Review)
insertions(+), 0 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/18/218/1 diff --git a/src/plasmaquick/appletquickitem.cpp b/src/plasmaquick/appletquickitem.cpp index 6ec12b9..06406a4 100644 --- a/src/plasmaquick/appletquickitem.cpp +++ b/src/plasmaquick

Change in plasma-framework[master]: Use the same text colour for comboboxes as buttons

2014-12-11 Thread David Edmundson (Code Review)
/declarativeimports/plasmastyle/ComboBoxStyle.qml A tests/components/combobox.qml 2 files changed, 42 insertions(+), 0 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/19/219/1 diff --git a/src/declarativeimports/plasmastyle/ComboBoxStyle.qml b/src

Change in plasma-framework[master]: roundToIconSize(0) should return 0

2014-12-10 Thread David Edmundson (Code Review)
://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/13/213/1 diff --git a/src/declarativeimports/core/units.cpp b/src/declarativeimports/core/units.cpp index dfc817a..ba06553 100644 --- a/src/declarativeimports/core/units.cpp +++ b/src/declarativeimports/core/units.cpp @@ -107,9 +107,10 @@ int

Change in plasma-framework[master]: Do not keep reparsing plasmarc configuration

2014-12-10 Thread David Edmundson (Code Review)
files changed, 20 insertions(+), 12 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/14/214/1 diff --git a/src/declarativeimports/core/units.cpp b/src/declarativeimports/core/units.cpp index ba06553..43533df 100644 --- a/src/declarativeimports/core

Change in plasma-framework[master]: Save SVGs only when a theme is unloaded, not on each theme p...

2014-12-10 Thread David Edmundson (Code Review)
of parsing and IO. This makes everything a lot faster at no cost. Change-Id: Ica6ba0273bc99fb8ad8733a1c90db8f1e87c49ea --- M src/plasma/private/theme_p.cpp M src/plasma/theme.cpp 2 files changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs

Change in plasma-framework[master]: Use a shared config in tooltip

2014-12-10 Thread David Edmundson (Code Review)
: I68521f9066114a265c3f3444332e5e67016207f7 --- M src/declarativeimports/core/tooltip.cpp 1 file changed, 2 insertions(+), 4 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/16/216/1 diff --git a/src/declarativeimports/core/tooltip.cpp b/src/declarativeimports/core/tooltip.cpp index 839b8b7

Change in plasma-framework[master]: Reparse settings when they change

2014-12-10 Thread David Edmundson (Code Review)
: Ibb13077943330417fa08d23ce1ea60f2aff5defc --- M src/declarativeimports/core/tooltip.cpp M src/declarativeimports/core/tooltip.h 2 files changed, 7 insertions(+), 1 deletion(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/17/217/1 diff --git a/src/declarativeimports/core/tooltip.cpp b/src

Change in plasma-framework[master]: plasma_containmentactions_test: Link to KI18n

2014-12-09 Thread Heiko Becker (Code Review)
/testcontainmentactionsplugin/CMakeLists.txt 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/10/210/1 diff --git a/examples/testcontainmentactionsplugin/CMakeLists.txt b/examples/testcontainmentactionsplugin/CMakeLists.txt

Change in plasma-framework[master]: Make tooltipEnabledGlobally public property

2014-12-08 Thread Bhushan Shah (Code Review)
://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/07/207/1 diff --git a/src/declarativeimports/core/tooltip.cpp b/src/declarativeimports/core/tooltip.cpp index 839b8b7..dec3adc 100644 --- a/src/declarativeimports/core/tooltip.cpp +++ b/src/declarativeimports/core/tooltip.cpp @@ -75,7 +75,12

Change in plasma-framework[master]: export a plasma version number in themes

2014-12-02 Thread Marco Martin (Code Review)
changed, 30 insertions(+), 1 deletion(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/95/195/1 diff --git a/src/desktoptheme/air/metadata.desktop b/src/desktoptheme/air/metadata.desktop index a297bb9..c12fde3 100644 --- a/src/desktoptheme/air/metadata.desktop

Change in plasma-framework[master]: fix typo height - width

2014-12-02 Thread Xuetian Weng (Code Review)
value to height instead of width. Change-Id: Ie24ef194d9bf02e53b92aa6802b0fbded68b896d --- M src/plasmaquick/dialog.cpp 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/96/196/1 diff --git a/src/plasmaquick/dialog.cpp

Change in plasma-framework[master]: Fix the platformstatus kded module

2014-12-02 Thread Martin Klapetek (Code Review)
: I5006672ca041d9820b4388ba4e99b7899f36be18 --- M src/platformstatus/CMakeLists.txt R src/platformstatus/platformstatus.desktop 2 files changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/97/197/1 diff --git a/src/platformstatus/CMakeLists.txt

Change in plasma-framework[master]: use PlasmaCore.ColorScope when suitable

2014-11-25 Thread Marco Martin (Code Review)
/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml M src/declarativeimports/plasmacomponents/qml/styles/ToolButtonStyle.qml 3 files changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/77/177/1 diff --git a/src

Change in plasma-framework[master]: workaround on textarea input breaking

2014-11-04 Thread Marco Martin (Code Review)
appropriate Change-Id: I72c8f01d4557003604c4261ca5a9ab49dd136b02 --- M src/scriptengines/qml/plasmoid/appletinterface.cpp M src/scriptengines/qml/plasmoid/appletinterface.h 2 files changed, 35 insertions(+), 6 deletions(-) git pull ssh://gerrit.vesnicky.cesnet.cz:29418/plasma-framework refs/changes/45

Re: Fwd: Plasma Framework problems

2014-10-23 Thread David Faure
On Monday 20 October 2014 02:52:58 David Edmundson wrote: Give me the sha1 to cherry-pick and I'll make a 5.3.1 with it. a3932843386a29faa3c62bf2934a173a3781d56c ​ That doesn't make sense, that commit is from September 15 and is already in 5.3.0. PS: please CC me for urgent requests... --

Re: Fwd: Plasma Framework problems

2014-10-23 Thread David Edmundson
On Thu, Oct 23, 2014 at 9:33 AM, David Faure fa...@kde.org wrote: On Monday 20 October 2014 02:52:58 David Edmundson wrote: Give me the sha1 to cherry-pick and I'll make a 5.3.1 with it. a3932843386a29faa3c62bf2934a173a3781d56c ​ That doesn't make sense, that commit is from September 15

Re: Fwd: Plasma Framework problems

2014-10-23 Thread David Faure
with it. a3932843386a29faa3c62bf2934a173a3781d56c ​That doesn't make sense, that commit is from September 15 and is already in 5.3.0. Sorry, that was a hash to revert. Oh, I see, I thought the revert had happened in git... OK, done and packaged. Packagers: it's up. plasma-framework v5.3.1

Re: Fwd: Plasma Framework problems

2014-10-19 Thread David Faure
On Tuesday 14 October 2014 22:17:38 Marco Martin wrote: On Monday 13 October 2014, Marco Martin wrote: I need approval from Marco and other David. after a quick chat with David E this morning, I would revert that patch (and then remove the plugin in plasma-workspace master) *but* this

Re: Fwd: Plasma Framework problems

2014-10-19 Thread David Edmundson
Give me the sha1 to cherry-pick and I'll make a 5.3.1 with it. a3932843386a29faa3c62bf2934a173a3781d56c ​ ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 120596: Adopt QuickAddons in plasma-framework

2014-10-15 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120596/ --- Review request for KDE Frameworks and Plasma. Repository: plasma

Re: Review Request 120596: Adopt QuickAddons in plasma-framework

2014-10-15 Thread Marco Martin
.) Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Removes the code that was moved to QuickAddons Diffs - src/declarativeimports/core/framesvgitem.cpp bb4dc69 src/declarativeimports/core/iconitem.cpp 4f3d5d6 src

Re: Review Request 120596: Adopt QuickAddons in plasma-framework

2014-10-15 Thread Aleix Pol Gonzalez
marked as submitted. Review request for KDE Frameworks and Plasma. Repository: plasma-framework Description --- Removes the code that was moved to QuickAddons Diffs - src/declarativeimports/core/framesvgitem.cpp bb4dc69 src/declarativeimports/core/iconitem.cpp 4f3d5d6 src

Re: Fwd: Plasma Framework problems

2014-10-14 Thread Marco Martin
On Monday 13 October 2014, Marco Martin wrote: I need approval from Marco and other David. after a quick chat with David E this morning, I would revert that patch (and then remove the plugin in plasma-workspace master) *but* this only if there will be a 5.3.1 (there should be a fix in

Re: Fwd: Plasma Framework problems

2014-10-13 Thread Marco Martin
On Sunday 12 October 2014, David Edmundson wrote: Assuming we don't have a time machine our options are: - revert this commit and release plasma-framework 5.3.1 really quickly Please go with this option... I need approval from Marco and other David. David eh no, that commit

Re: Fwd: Plasma Framework problems

2014-10-13 Thread šumski
work out how we proceed. Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make everything work. Assuming we don't have a time machine our options are: - revert this commit and release plasma-framework 5.3.1 really quickly

Re: Fwd: Plasma Framework problems

2014-10-12 Thread David Edmundson
I'll report back when I've confirmed this and then we can work out how we proceed. Reverting a3932843386a29faa3c62bf2934a173a3781d56c does indeed make everything work. Assuming we don't have a time machine our options are: - revert this commit and release plasma-framework 5.3.1 really

Re: Fwd: Plasma Framework problems

2014-10-12 Thread David Edmundson
everything work. Assuming we don't have a time machine our options are: - revert this commit and release plasma-framework 5.3.1 really quickly Please go with this option... I need approval from Marco and other David. David ___ Plasma-devel mailing list

Re: Re: Fwd: Plasma Framework problems

2014-10-12 Thread Martin Gräßlin
a3932843386a29faa3c62bf2934a173a3781d56c does indeed make everything work. Assuming we don't have a time machine our options are: - revert this commit and release plasma-framework 5.3.1 really quickly Please go with this option... How will this affect Plasma 5.1? Given

Re: Fwd: Plasma Framework problems

2014-10-11 Thread David Edmundson
On Sat, Oct 11, 2014 at 8:10 PM, David Faure fa...@kde.org wrote: On Friday 10 October 2014 16:24:52 David Edmundson wrote: Packagers, It seems Plasma 5.0 does NOT run smoothly against Plasma Framework 5.3. It would be easiest if distros hold off shipping frameworks 5.3 until Plasma

Plasma Framework problems

2014-10-10 Thread David Edmundson
Packagers, It seems Plasma 5.0 does NOT run smoothly against Plasma Framework 5.3. It would be easiest if distros hold off shipping frameworks 5.3 until Plasma 5.1 when Plasma5.1 is released. Clearly this is a screw-up and we need to come up with some better policies when we plan Plasma 5.2

Re: Plasma Framework problems

2014-10-10 Thread šumski
On Friday 10 of October 2014 16:23:41 David Edmundson wrote: Packagers, It seems Plasma 5.0 does NOT run smoothly against Plasma Framework 5.3. It would be easiest if distros hold off shipping frameworks 5.3 until Plasma 5.1 when Plasma5.1 is released. Clearly this is a screw-up and we

trying test-driven bugfixes in plasma-framework

2014-09-15 Thread Marco Martin
Hi all, Since we are trying gerrit, let's try to push it even further: Right now, we are freezed, so that means in plasma-framework, plasma-workspace et al will happen only bugfixes for a month or so. Having Gerrit on plasma-framework, I hope that makes easier for me keeping track of changes

Re: trying test-driven bugfixes in plasma-framework

2014-09-15 Thread Marco Martin
On Monday 15 September 2014, Marco Martin wrote: It's a good moment now, since being mostly bugfixes, it should be mostly atomic commits without big changes (I still have to decide if the Dialog refactor can fully be considered bugfix or if is better to wait next frameworks release, usual

Re: trying test-driven bugfixes in plasma-framework

2014-09-15 Thread David Edmundson
​Right now, we are freezed, so that means in plasma-framework, plasma-workspace et al will happen only bugfixes for a month or so. Only frameworks is frozen. For workspace, desktop etc. we have till Thursday for feature freeze. https://techbase.kde.org/Schedules/Plasma_5 as it's released a week

[plasma-framework] src/desktoptheme/breeze: Optimize breeze theme

2014-07-22 Thread Aleix Pol
/widgets/tooltip.svgz M +---src/desktoptheme/breeze/widgets/translucentbackground.svgz M +---src/desktoptheme/breeze/widgets/viewitem.svgz http://commits.kde.org/plasma-framework/0b1bb7edd84b77c4cf5baae8f9e59473c9265f26 diff --git a/src/desktoptheme/breeze/dialogs/background.svgz b

Re: Review Request 118254: Plasma-Framework: Add new a shell intrerceptor

2014-05-27 Thread Antonis Tsiapaliokas
discarded. Review request for Plasma. Repository: plasma-framework Description --- hello, This patch adds a new interceptor for our shell packages. Right now we cannot load an svg if the image is inside the /contents/images of the shell package. So this patch solves that issue. Diffs

Re: Review Request 118254: Plasma-Framework: Add new a shell intrerceptor

2014-05-25 Thread Aleix Pol Gonzalez
/ --- (Updated May 22, 2014, 10:11 a.m.) Review request for Plasma. Repository: plasma-framework Description --- hello, This patch adds a new interceptor for our shell packages. Right now we cannot load an svg if the image

[plasma-framework] src/plasma: Make QtGui a public dependency of KF5::Plasma

2014-05-25 Thread Aleix Pol
dependency. (QGuiApplication, QFont, QPixmap are some examples). This also pulls QtCore (e.g. QString, QRect, QUrl), which also is, of course. CCMAIL: plasma-devel@kde.org M +1-1src/plasma/CMakeLists.txt http://commits.kde.org/plasma-framework/efdf1ca9176528cd1a16773e887df7740f42ee54 diff

Re: [plasma-framework] examples/dataengines: Fix build with examples

2014-05-25 Thread Aleix Pol
On Fri, May 23, 2014 at 12:22 PM, Sebastian Kügler se...@kde.org wrote: On Friday, May 23, 2014 12:18:55 Marco Martin wrote: I think it's a counter-effect of when i removed KConfigWidgets from libplasma. there is definitely a problem in the cmake there, qt5::gui should be in public in

Re: [plasma-framework] examples/dataengines: Fix build with examples

2014-05-23 Thread Sebastian Kügler
-0examples/dataengines/simpleEngine/CMakeLists.txt M +1-0examples/dataengines/sourcesOnRequest/CMakeLists.txt http://commits.kde.org/plasma-framework/1f80c23bd514247d60b831de7671eff1e6 64d95d diff --git a/examples/dataengines/simpleEngine/CMakeLists.txt b/examples

Re: [plasma-framework] examples/dataengines: Fix build with examples

2014-05-23 Thread Marco Martin
M +1-0examples/dataengines/sourcesOnRequest/CMakeLists.txt http://commits.kde.org/plasma-framework/1f80c23bd514247d60b831de7671eff 1e6 64d95d diff --git a/examples/dataengines/simpleEngine/CMakeLists.txt b/examples/dataengines/simpleEngine/CMakeLists.txt index

Re: [plasma-framework] examples/dataengines: Fix build with examples

2014-05-23 Thread Sebastian Kügler
On Friday, May 23, 2014 12:18:55 Marco Martin wrote: I think it's a counter-effect of when i removed KConfigWidgets from libplasma. there is definitely a problem in the cmake there, qt5::gui should be in public in libplasma, right? That's how I understand Aleix. -- sebas http://www.kde.org |

Review Request 118254: Plasma-Framework: Add new a shell intrerceptor

2014-05-22 Thread Antonis Tsiapaliokas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118254/ --- Review request for Plasma. Repository: plasma-framework Description

plasma-framework bugs

2014-04-29 Thread Marco Martin
Hi all, now that plasma-framework is in frameworks, it has its own product in bugzilla, the search is this: https://bugs.kde.org/buglist.cgi?cmdtype=runnamednamedcmd=framework-plasmalist_id=1007509 (unsurprisingly enough are all Dialog bugs :p) there should go bugs that are oviously from one

Re: plasma-framework bugs

2014-04-29 Thread Sebastian Kügler
On Tuesday, April 29, 2014 13:37:24 Marco Martin wrote: now that plasma-framework is in frameworks, it has its own product in bugzilla, the search is this: https://bugs.kde.org/buglist.cgi?cmdtype=runnamednamedcmd=framework-plasma; list_id=1007509 The search doesn't exist, you'll need

Re: plasma-framework bugs

2014-04-29 Thread Marco Martin
On Tuesday 29 April 2014 13:39:58 Sebastian Kügler wrote: On Tuesday, April 29, 2014 13:37:24 Marco Martin wrote: now that plasma-framework is in frameworks, it has its own product in bugzilla, the search is this: https://bugs.kde.org/buglist.cgi?cmdtype=runnamednamedcmd=framework-plasm

Re: plasma-framework bugs

2014-04-29 Thread Bhushan Shah
On Tue, Apr 29, 2014 at 5:15 PM, Marco Martin notm...@gmail.com wrote: try it again? here is correct link https://bugs.kde.org/buglist.cgi?cmdtype=doremremaction=runnamedcmd=framework-plasmasharer_id=69245list_id=1007520 -- Bhushan Shah http://bhush9.github.io IRC Nick : bshah on Freenode

Re: plasma-framework bugs

2014-04-29 Thread David Edmundson
I have just removed components component from the plasma-shell product and reassigned all the (closed) bugs to plasma-framework. You may have received some email spam from this, if so I apologise. David ___ Plasma-devel mailing list Plasma-devel

Re: plasma-framework in kdereview

2014-04-28 Thread Luigi Toscano
On Friday 25 of April 2014 15:43:39 Marco Martin wrote: On Friday 25 April 2014 15:24:50 Luigi Toscano wrote: On Friday 25 of April 2014 15:14:46 Àlex Fiestas wrote: Moving plasma-framework to frameworks means that we will loose flexibility since we won't be able to break api/abi

[plasma-framework] /: Install all plasma files in a prefix/share/plasma directory

2014-04-27 Thread Aleix Pol
+4-3src/plasmaquick/private/packages.cpp M +2-1src/platformstatus/platformstatus.cpp M +2-2src/scriptengines/python/CMakeLists.txt M +1-1src/scriptengines/ruby/CMakeLists.txt http://commits.kde.org/plasma-framework/e6f1fec0c77ef2bf692fbc382001a9d90971a4d6 diff

Re: plasma-framework in kdereview

2014-04-26 Thread Kevin Ottens
Hello, On Saturday 26 April 2014 02:33:07 Kevin Ottens wrote: On Saturday 26 April 2014 01:57:09 Albert Astals Cid wrote: El Divendres, 25 d'abril de 2014, a les 12:34:32, Marco Martin va escriure: since it was done earlier this week, better announce it formally, so everybody can

Re: plasma-framework in kdereview

2014-04-26 Thread Marco Martin
On 4/26/14, David Edmundson da...@davidedmundson.co.uk wrote: foreach (KConfigSkeletonItem *item, loader.items()) { d-operationsMap[item-group()][item-key()] = item-property(); } I ran plasmaengineexplorer and the UI for the activities service appeared properly. ok, if it

Re: plasma-framework in kdereview

2014-04-26 Thread Marco Martin
On Saturday, April 26, 2014, David Faure fa...@kde.org wrote: David is acting on the move as I'm typing that email. Stay tuned! :-) plasma-framework is now under frameworks/. kdesrc-build users, remember to do rm -rf kdereview/plasma-framework playground/libs/plasma-framework to avoid

Re: plasma-framework in kdereview

2014-04-25 Thread Àlex Fiestas
On Friday 25 April 2014 12:34:32 Marco Martin wrote: Hi all, since it was done earlier this week, better announce it formally, so everybody can actually do the -review part ;) the plasma-framework repository has been moved in kdereview, headed hopefully in frameworks. what it contains

Re: plasma-framework in kdereview

2014-04-25 Thread Marco Martin
On Friday 25 April 2014 15:14:46 you wrote: * there was the plasma shell: has been removed and moved to plasma-workspace, decreasing dependencies Moving plasma-framework to frameworks means that we will loose flexibility since we won't be able to break api/abi. that's exactly why i want

Re: plasma-framework in kdereview

2014-04-25 Thread Luigi Toscano
On Friday 25 of April 2014 15:14:46 Àlex Fiestas wrote: Moving plasma-framework to frameworks means that we will loose flexibility since we won't be able to break api/abi. So, do we really have to move it there? Imho would be prudent to keep it somewhere else where api/abi stability

Re: plasma-framework in kdereview

2014-04-25 Thread Marco Martin
On Friday 25 April 2014 15:24:50 Luigi Toscano wrote: On Friday 25 of April 2014 15:14:46 Àlex Fiestas wrote: Moving plasma-framework to frameworks means that we will loose flexibility since we won't be able to break api/abi. So, do we really have to move it there? Imho would be prudent

Re: plasma-framework in kdereview

2014-04-25 Thread Kevin Ottens
On Friday 25 April 2014 15:14:46 Àlex Fiestas wrote: On Friday 25 April 2014 12:34:32 Marco Martin wrote: Hi all, since it was done earlier this week, better announce it formally, so everybody can actually do the -review part ;) the plasma-framework repository has been moved

Re: plasma-framework in kdereview

2014-04-25 Thread David Edmundson
Well... it's been planned this way for three years if not more. Before that it was in kdelibs. Also, right now there is only one user of this framework (plasma-desktop), That's because the other users weren't ported to KF5 yet. But there's definitely more plasma users (amarok comes to mind,

Re: plasma-framework in kdereview

2014-04-25 Thread Kevin Ottens
On Friday 25 April 2014 17:46:23 David Edmundson wrote: Well... it's been planned this way for three years if not more. Before that it was in kdelibs. Also, right now there is only one user of this framework (plasma-desktop), That's because the other users weren't ported to KF5

Re: plasma-framework in kdereview

2014-04-25 Thread Marco Martin
On Friday 25 April 2014 17:46:23 David Edmundson wrote: Well... it's been planned this way for three years if not more. Before that it was in kdelibs. Also, right now there is only one user of this framework (plasma-desktop), That's because the other users weren't ported to KF5

Re: plasma-framework in kdereview

2014-04-25 Thread David Edmundson
On Fri, Apr 25, 2014 at 6:56 PM, Marco Martin notm...@gmail.com wrote: On Friday 25 April 2014 17:46:23 David Edmundson wrote: Well... it's been planned this way for three years if not more. Before that it was in kdelibs. Also, right now there is only one user of this framework

Re: plasma-framework in kdereview

2014-04-25 Thread Marco Martin
On Friday 25 April 2014 19:28:59 David Edmundson wrote: parse kconfigskeletons at runtime for what i'm concerned), that's the call of the application developer, as any workspace. That KConfigLoader already moved to KConfigGui. (and I agree that class is really really useful) argh :/, I

Re: plasma-framework in kdereview

2014-04-25 Thread Marco Martin
On Friday 25 April 2014 19:16:43 Kevin Ottens wrote: I think these statements show you totally ignore the history behind libplasma or how applications can use it... They (at least Amarok, not 100% sure for Skrooge) benefit from the component model used in libplasma: packages, dataengines,

Re: Re: plasma-framework in kdereview

2014-04-25 Thread Martin Gräßlin
into KConfig. No idea how it could happen that you weren't aware of it. And I also don't remember why I didn't adjust plasma-framework, but I assume that it was too much in flux at that time to do such a change. Cheers Martin signature.asc Description: This is a digitally signed message part

Re: Re: plasma-framework in kdereview

2014-04-25 Thread David Edmundson
weren't aware of it. And I also don't remember why I didn't adjust plasma-framework, but I assume that it was too much in flux at that time to do such a change. FYI I'm on it now. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org

Re: plasma-framework in kdereview

2014-04-25 Thread Marco Martin
the integration into KConfig. No idea how it could happen that you weren't aware of it. And I also don't remember why I didn't adjust plasma-framework, but I assume that it was too much in flux at that time to do such a change. Seems the problem is that Service is using a subclass to support multiple

Re: plasma-framework in kdereview

2014-04-25 Thread Guillaume DE BURE
Hi Everyone, Indeed, there was an intention to use some plasma components in Skrooge, but it never materialized in any official release. Today, this is mostly abandoned code, to my disappointment, but I never committed myself enough on finishing this part... As far as Skrooge is concerned,

<    1   2   3   4   5   6   7   >