amantia added reviewers: franckarrecot, renatoo, olivierjg.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8447
To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot,
renatoo, olivierjg
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-m
amantia updated this revision to Diff 21281.
amantia added a comment.
Implement changes requested by Laurent.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8447?vs=21235&id=21281
REVISION DETAIL
https://phabricator.kde.org/D8447
AFFECTED FILES
containments/desktop/plugins/fold
amantia updated this revision to Diff 21284.
amantia added a comment.
Added copyright notice
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8447?vs=21281&id=21284
REVISION DETAIL
https://phabricator.kde.org/D8447
AFFECTED FILES
containments/desktop/plugins/folder/CMakeLists.txt
amantia updated this revision to Diff 21287.
amantia added a comment.
Use QStringLiteral and nullptr
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8447?vs=21284&id=21287
REVISION DETAIL
https://phabricator.kde.org/D8447
AFFECTED FILES
containments/desktop/plugins/folder/CMakeL
amantia created this revision.
amantia added reviewers: Plasma, ervin, mlaurent, dvratil, hein, aacid.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
When using multiple screen with a Folder View as a desktop containment,
amantia added a comment.
Just to make clear, this is the first step and would not commit before the
problems with display removing/additions are solved. The ideas for doing that
are:
- keep per screen configuration and per desktop setting: e.g a different set
of position for icons if on
amantia updated this revision to Diff 21375.
amantia added a comment.
Add back unintentionally removed generate_export_header
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8447?vs=21287&id=21375
REVISION DETAIL
https://phabricator.kde.org/D8447
AFFECTED FILES
containments/desk
amantia updated this revision to Diff 21376.
amantia added a comment.
Now add back the generate_export_header for real
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8447?vs=21375&id=21376
REVISION DETAIL
https://phabricator.kde.org/D8447
AFFECTED FILES
containments/desktop/plu
amantia added a comment.
I've added some comments, I will address the ones I did not comment in a
follow-up patch.
INLINE COMMENTS
> broulik wrote in main.xml:40
> What's the purpose of `hidden=true`?
AFAIK it is not used in the GUI config. See also the others in the same file.
> broulik w
amantia added a comment.
I approved and actually suggested Laurent to update the diff. Sorry for the
confusion.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8447
To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot,
renatoo, olivierj
amantia updated this revision to Diff 21447.
amantia added a comment.
Make ScreenMapper a QML singleton, address the other issues mentioned by
Kai-Uwe.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=21365&id=21447
REVISION DETAIL
https://phabricator.kde.org/D8493
AFFECTE
amantia added a comment.
Sorry about that, I will fix asap (probably in the evening).
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8447
To: amantia, #plasma, ervin, hein, mlaurent, aacid, dvratil, franckarrecot,
renatoo, olivierjg
Cc: lbeltrame, plasma-dev
amantia created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8567
AFFECTED FILES
shell/shellcorona.cpp
shell/shellcoro
amantia updated this revision to Diff 21619.
amantia added a comment.
Basic handling of screen removal/addition.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=21447&id=21619
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D84
amantia edited the summary of this revision.
amantia added reviewers: Plasma, ervin, dvratil, mlaurent, hein.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8567
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezh
amantia edited the summary of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid
Cc: broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, seb
amantia edited the summary of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid
Cc: broulik, mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, seb
amantia added a comment.
Actually I don't really wantd to track anything aside of the screen ids
provided by plasma itself. Maybe a better solution would be to listen to
signals from Corona (by adding the missing signals) that are emited by
ShellCorona when screen setup changes.
REPOSITORY
amantia updated this revision to Diff 21679.
amantia added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Fix API docs text
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org
amantia added a comment.
@broulik Very good point, luckily I reworked it.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8566
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: broulik, plasma-devel, dhaumann, apol, #frameworks, ZrenBot, pro
amantia updated this revision to Diff 21682.
amantia added a comment.
Add signals instead of a new virtual method (that is not BIC). This also
makes us not rely on screen name, but only on plasma-internal screen id.
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
htt
amantia updated this revision to Diff 21683.
amantia edited the summary of this revision.
amantia added a comment.
Emit the screenRemoved/screenAdded signals. This needs a small rename of an
internal method.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.k
amantia created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
- store a map of url/screen ids in the configuration file
- have a central mapping object shared by all folder views
- if the model is used
amantia added a comment.
I have changed the code to not rely on screen removal/addition signals inside
the FolderView plugin, but use the existing code from shellcorona. This also
ensures that we get the signals for the right id, and works correctly as long
as the screen layout detection in
amantia added a reviewer: apol.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson,
apol
Cc: davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, j
amantia updated this revision to Diff 21685.
amantia added a comment.
Use the plasma signals with screen id instead of QGuiApplication signals with
the QScreen objects.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=21619&id=21685
BRANCH
amantia abandoned this revision.
amantia added a comment.
Created by mistake, right one is https://phabricator.kde.org/D8493
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8589
To: amantia
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreu
amantia marked an inline comment as done.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8567
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: mwolff, apol, mart, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg
amantia updated this revision to Diff 21686.
amantia added a comment.
Emit the screenRemoved from within removeDesktop
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8567?vs=21683&id=21686
BRANCH
master
REVISION DETAIL
https://phabricator.kde
amantia updated this revision to Diff 21687.
amantia added a comment.
Remove unneeded changed
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8567?vs=21686&id=21687
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8567
AFFECTED FILE
amantia retitled this revision from "Return the screen id for a screen name."
to "Emit signals when a screen is added or removed".
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8567
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: mwolff, apol, mart,
amantia updated this revision to Diff 21696.
amantia marked 8 inline comments as done.
amantia added a comment.
Handle screen associated in C++ part (no need to go through QML now), fix
issues mentioned by Milian.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricat
amantia edited the summary of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson,
apol
Cc: mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff,
lesli
amantia added inline comments.
INLINE COMMENTS
> mwolff wrote in foldermodel.cpp:1316
> adding some comment here would help people reading the code in the future.
> I.e. something like "exclude items that are shown on a different screen"
>
> also, I personally think this code is not pretty at a
amantia added inline comments.
INLINE COMMENTS
> mwolff wrote in foldermodel.cpp:1671
> missing disconnect on the old mapper for the invalidate filter
Done, although the screenmapper will never change.
> mwolff wrote in foldermodel.cpp:1704
> when the interface changes, don't you need to discon
amantia edited the summary of this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson,
apol
Cc: mwolff, davidedmundson, broulik, mart, plasma-devel, ZrenBot, progwolff,
lesli
amantia updated this revision to Diff 21703.
amantia added a comment.
Fix Milian's comments, simplify/merge ScreenMapper add/remove screen methods.
Treat folderview destruction as screen removal, as it has the same effects.
Makes the code work correctly
when the containment changes from Fo
amantia added a dependent revision: D8493: Make Folder View screen aware.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D8566
To: amantia, #plasma, ervin, dvratil, mlaurent, hein, davidedmundson
Cc: broulik, plasma-devel, dhaumann, apol, #frameworks,
amantia added a dependent revision: D8493: Make Folder View screen aware.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8567
To: amantia, #plasma, ervin, dvratil, mlaurent, hein
Cc: mwolff, apol, mart, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliez
amantia edited the summary of this revision.
amantia added dependencies: D8567: Emit signals when a screen is added or
removed, D8566: Add API to retrieve the screen id for a screen name.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma,
amantia updated this revision to Diff 21711.
amantia added a comment.
Added unit test for ScreenMapper and improve the code to cover all the cases
tested.
Added asserts instead of disconnects.
Change the ScreenMapper API completely to QString (from QUrl) as that is what
is more natural (w
amantia added a comment.
Sound hacky and dangerous for me due to the point you mentioned. I'm not sure
I have a better idea now .
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8598
To: mwolff, hein, amantia
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai,
amantia updated this revision to Diff 21837.
amantia added a comment.
- add unit tests for different scenarios of foldermodel and screenmapper
usage on multiple screens
- connect screenMappingChanged to invalidateFilter
- as addMapping is called from withing filterAcceptRows, make it possi
amantia updated this revision to Diff 21838.
amantia added a comment.
remove unimplemented method
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=21837&id=21838
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8493
AFFECTED FI
amantia added a comment.
I didn't tested the code yet, but in general looks good for me.
INLINE COMMENTS
> foldermodel.cpp:181
> +if (!m_dropTargetPositions.isEmpty()) {
> +qDebug() << "clearing drop target positions after timeout:" <<
> m_dropTargetPositions;
> +
amantia added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in foldermodel.cpp:163-164
> When QObject dies it's disconnected to all signal/slots. In this case if you
> want to not notify FolderModel you can use
>
> m_screenMapper->disconnect(this);
Yes, I know, indeed this might be
amantia updated this revision to Diff 22312.
amantia added a comment.
Handle the case when the folder view's path changes on one of the desktops
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=21838&id=22312
BRANCH
master
REVISION DETAIL
amantia updated this revision to Diff 22313.
amantia marked 2 inline comments as done.
amantia added a comment.
Implement changes requested by anthonyfieroni
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=22312&id=22313
BRANCH
master
REVI
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:eab03787350a: Add signals indicating if a screen was
added or removed (authored by amantia).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8566?
amantia closed this revision.
amantia added a comment.
https://commits.kde.org/plasma-framework/eab03787350a6c8cf56b1bf95f89b360c6633de3
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D8567
To: amantia, #plasma, ervin, dvratil, mlaurent, hein, davidedmundso
amantia requested changes to this revision.
amantia added a comment.
This revision now requires changes to proceed.
Unfortunately the current approach fails when the folderview points to
desktop:/ . In that case the targetUrl in the copyJobStarted is different
("desktop:/foo") from the url we
amantia updated this revision to Diff 22342.
amantia added a comment.
- WIP: Multiscreen drag and drop support in folder view
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=22313&id=22342
BRANCH
arcpatch-D8598_1
REVISION DETAIL
https://
amantia updated this revision to Diff 22344.
amantia added a comment.
Restoring previous version overwritten by mistake.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=22342&id=22344
BRANCH
master
REVISION DETAIL
https://phabricator.kde
amantia updated this revision to Diff 22387.
amantia marked 2 inline comments as done.
amantia added a comment.
Fix for some of Milian's comments (rest later, need to move to different
computer)
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs
amantia added inline comments.
INLINE COMMENTS
> mwolff wrote in screenmapper.cpp:41
> this is a pretty arbitrary timer, can you add a comment on why 100ms is
> better than going through the eventloop once via QMetaObject::invokeMethod
> with the delayed flag set?
Done. InvokeMethod would not
amantia updated this revision to Diff 22428.
amantia marked 2 inline comments as done.
amantia added a comment.
Add a code comment
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=22387&id=22428
BRANCH
master
REVISION DETAIL
https://phabr
amantia added inline comments.
INLINE COMMENTS
> mwolff wrote in screenmapper.cpp:108
> `m_itemsOnDisabledScreensMap` stores "names" from the `m_screenItemMap`, so I
> think this line here is wrong and should also use the proposed
> `screenUrlForPath` above, or `QUrl::fromUserInput`, no? Otherw
amantia updated this revision to Diff 22434.
amantia added a comment.
Remove unused var
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=22428&id=22434
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8493
AFFECTED FILES
cont
amantia updated this revision to Diff 22438.
amantia added a comment.
Handle screen removal correctly:
- adjust the first screen per path in a more efficient way
- adjust the number of screens per path properly
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabri
amantia added inline comments.
INLINE COMMENTS
> mwolff wrote in screenmapper.cpp:85
> this should imo be a for loop to make it clear that it is iterating over all
> items (more ideomatic). Also, couldn't you use range-based for here even?
range based loop: I need access to both key and value
amantia updated this revision to Diff 22444.
amantia added a comment.
Some code reogranization per Milian's request
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=22438&id=22444
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/
amantia added a comment.
Ok, let's wait for Eike and for the DND patches to be ready.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson,
apol, mwolff
Cc: anthonyfieroni, ngraham, m
amantia accepted this revision.
amantia added a comment.
This revision is now accepted and ready to land.
Looks good for me.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8598
To: mwolff, hein, amantia
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mo
amantia requested changes to this revision.
amantia added a comment.
This revision now requires changes to proceed.
Sorry, found two small issues :)
INLINE COMMENTS
> foldermodel.cpp:1076
> +// remember drop target position for target URL and forget about the
> source URL
> +
amantia updated this revision to Diff 22630.
amantia added a comment.
Fix problem of having ghost items,
fix problem of losing items when an item is moved to a screen and back.
Add unit test for the positioner when items are moved between screens.
Problem: moving multiple items works,
amantia commandeered this revision.
amantia edited reviewers, added: mwolff; removed: amantia.
amantia added a comment.
Commandeered and trying to fix the mess now.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8850
To: amantia, mwolff
Cc: broulik, plasma-de
amantia updated this revision to Diff 22631.
amantia added a comment.
Fix uploaded diff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8850?vs=22630&id=22631
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8850
AFFECTED FILES
containments/desktop/plugins/folder/au
amantia updated this revision to Diff 22632.
amantia added a comment.
Clean unit test and code: move out the unique testing part (will be moved to
a new patch)
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8850?vs=22631&id=22632
BRANCH
master
REVISION DETAIL
https://phabricat
amantia added inline comments.
INLINE COMMENTS
> mwolff wrote in positionertest.cpp:219
> second? this is the first and only one in this test, no?
There is one coming from init() (m_folderModel)
> mwolff wrote in positionertest.cpp:229
> `QVERIFY` the wait, also below
Changed, the rest is actu
amantia updated this revision to Diff 22657.
amantia added a comment.
Move out fix for proxy to source and remove the change from updateMap
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8850?vs=22632&id=22657
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8850
AFF
amantia retitled this revision from "WIP: support drag and drop between shared
folder view containments" to "Support drag and drop between shared folder view
containments".
amantia edited the summary of this revision.
amantia added reviewers: Plasma, hein.
REVISION DETAIL
https://phabricator.k
amantia updated this revision to Diff 22665.
amantia added a comment.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
Add uniqueness testing for the maps
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8915?vs=22659&id=22665
BR
amantia updated this revision to Diff 22677.
amantia added a comment.
- More stricter detection for moving between screens to fix issue
when a file is moved/copied out from within a folder of the desktop.
- Enable the code only when the folder view is used in a containment
Bugs t
amantia updated this revision to Diff 22679.
amantia added a comment.
Drop the items to the right screen when dragging from outside of the folder
view.
I admit it is not the nicest code for finding the final URL (that will be
returned by
KDirModel), ideas are welcome to improve it.
CH
amantia updated this revision to Diff 22682.
amantia added a comment.
- Improve path detection as suggested by Milian
- fix d&d for multiple items. There is only one issue, but I think it is
acceptable this way:
when moving two or more items that are not near each other to a new screen,
amantia updated this revision to Diff 22795.
amantia marked 2 inline comments as done.
amantia added a comment.
Handle Eike's comments
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=22444&id=22795
BRANCH
master
REVISION DETAIL
https://p
amantia added inline comments.
INLINE COMMENTS
> hein wrote in foldermodel.cpp:1688
> I know it's a very theoretical case, but you're not disconnecting from an old
> non-null ScreenMapper here.
>
> You're also not calling invalidateFilter even though filterAcceptsRow uses
> the mapper. It's al
amantia requested changes to this revision.
amantia added a comment.
This revision now requires changes to proceed.
Milian, please also update the commit description (the last paragraph needs
to go away).
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8598
T
amantia updated this revision to Diff 22797.
amantia added a comment.
Guard m_screenMapper usage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8850?vs=22682&id=22797
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8850
AFFECTED FILES
containments/desktop/plugins/
amantia added inline comments.
INLINE COMMENTS
> mwolff wrote in foldermodel.cpp:1123
> unguarded
It is guarded (line 1117)
REVISION DETAIL
https://phabricator.kde.org/D8850
To: amantia, mwolff, #plasma, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuter
amantia added inline comments.
INLINE COMMENTS
> mwolff wrote in foldermodel.cpp:1131
> unguarded
same here
REVISION DETAIL
https://phabricator.kde.org/D8850
To: amantia, mwolff, #plasma, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, se
amantia marked an inline comment as done.
REVISION DETAIL
https://phabricator.kde.org/D8850
To: amantia, mwolff, #plasma, hein
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
amantia updated this revision to Diff 22868.
amantia added a comment.
Guard screenmapper usage
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8850?vs=22797&id=22868
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8850
AFFECTED FILES
containments/desktop/plugins/fo
amantia accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
wip/lim-2
REVISION DETAIL
https://phabricator.kde.org/D8598
To: mwolff, hein, amantia
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abet
amantia added a comment.
@davidedmundson Any comments? If not, I will push this tomorrow.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, davidedmundson,
apol, mwolff
Cc: anthonyfieroni, ngrah
amantia removed a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8493
To: amantia, #plasma, ervin, mlaurent, dvratil, hein, aacid, apol, mwolff
Cc: anthonyfieroni, ngraham
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:88718b162ada: Make Folder View screen aware (authored by
amantia).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8493?vs=22795&id=23063
REVISION DETAIL
h
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:e94888701c32: FolderView: position files at drop event
target position (authored by mwolff, committed by amantia).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
amantia updated this revision to Diff 23065.
amantia added a comment.
Rebased
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8850?vs=22868&id=23065
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8850
AFFECTED FILES
containments/d
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:cc9c3d32a381: Support drag and drop between shared folder
view containments (authored by mwolff, committed by amantia).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:98d56d9135b1: Update the proxy to source and source to
proxy mapping correctly (authored by amantia).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D8915?vs=
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c0f8856742a4: Avoid jumping of items toward right/botton
when dropping (authored by amantia).
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
RE
amantia created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Until now every FolderView applet stored exactly the same screenMapping info
in the config file. Store it only once
using the config object
amantia added reviewers: Plasma, mwolff, hein, broulik.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9300
To: amantia, #plasma, mwolff, hein, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
amantia updated this revision to Diff 23846.
amantia added a comment.
Add const
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9300?vs=23821&id=23846
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D9300
AFFECTED FILES
containments
amantia added reviewers: Plasma, hein, mwolff, broulik.
amantia set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabrica
amantia added a comment.
I think it is better to store once, than 2-3 times (per desktop) as the data
is the same. I'm not sure if the corona level is the best, although I don't see
big problems with it.
REPOSITORY
R119 Plasma Desktop
BRANCH
master
REVISION DETAIL
https://phabricator
amantia added reviewers: Plasma, broulik, hein, mwolff.
amantia set the repository for this revision to R119 Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabrica
amantia closed this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9307
To: amantia, #plasma, hein, mwolff, broulik
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
amantia closed this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D9311
To: amantia, #plasma, broulik, hein, mwolff
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
101 - 200 of 211 matches
Mail list logo
