Re: New Logo (+Ksplash minimal)

2014-05-09 Thread Sebastian Kügler
On Friday, May 09, 2014 16:46:56 Jens Reuterberg wrote: > First bit - how about changing the logo on Ksplash minimal (that Martin K > suggested would get the gradient removed which is a great idea) to the > Plasma Logo instead of KDE logo. > > Second we've come to a sort of agreement in the KDE

Review Request 118063: New Formats KCM

2014-05-09 Thread Sebastian Kügler
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/873980fe-04f2-4d75-9074-2aa676723061__formatskcm.png Formats KCM in systemsettings https://git.reviewboard.kde.org/media/uploaded/files/2014/05/09/86a830ed-2d5d-4bdd-ba82-71ec73e6ce2c__formatskc

Re: Locale settings in Plasma Next

2014-05-09 Thread Sebastian Kügler
On Friday, May 09, 2014 15:03:28 John Layt wrote: > On 6 May 2014 22:35, Sebastian Kügler wrote: > > Where can I find that KCM? I've looked into the old kde-runtime repo, and > > the new location in plasma-desktop, but no branches that look like the > > code is in there

Re: Review Request 118063: New Formats KCM

2014-05-11 Thread Sebastian Kügler
workaround the separator. I've made it a simple number. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118063/#review57648 --

Re: Review Request 118063: New Formats KCM

2014-05-11 Thread Sebastian Kügler
above about needing to show the locale names in teh combo is correct, then > > just showing the resultign system name shoudl be enough. Otherwise we need > > to find something that will format using LC_MEASUREMENT. Or maybe we just > > leave it out for now. It needs research. I've made the example just show the measurement syste

Re: Review Request 118063: New Formats KCM

2014-05-11 Thread Sebastian Kügler
org/media/uploaded/files/2014/05/09/86a830ed-2d5d-4bdd-ba82-71ec73e6ce2c__formatskcmss.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118063: New Formats KCM

2014-05-11 Thread Sebastian Kügler
aded/files/2014/05/09/86a830ed-2d5d-4bdd-ba82-71ec73e6ce2c__formatskcmss.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Minutes Monday Plasma hangout

2014-05-12 Thread Sebastian Kügler
Present: Antonis, David, Ivan, Jens, Jonathan, Marco, Martin G., Martin K., Vishesh, Sebastian Antonis - has started the work to port Plasma Active to Plasma Next, - started with a "forked" shell package David: - Has been doing SDDM fixes, merge pending - Some files in plasma-framework need r

Re: Review Request 118089: Fix build: add spaces in string concatenation

2014-05-12 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118089/#review57759 --- Ship it! Ship It! - Sebastian Kügler On May 12, 2014, 12

Re: Review Request 118063: New Formats KCM

2014-05-12 Thread Sebastian Kügler
gt; > the global then all we need to export is LANG, so only writing out lcGlobal > > should be enough. If there's no overrides we should always be deleting them. > > Sebastian Kügler wrote: > Hm, LANG will be set from the Translations KCM, and affects that, no? (I > mig

Re: Review Request 118063: New Formats KCM

2014-05-12 Thread Sebastian Kügler
files/2014/05/09/86a830ed-2d5d-4bdd-ba82-71ec73e6ce2c__formatskcmss.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Where we are now... (VDG)

2014-05-13 Thread Sebastian Kügler
On Tuesday, May 13, 2014 12:25:57 Thomas Pfeiffer wrote: > As far as I know, the idea was to apply the Breeze color scheme and remove > the gradient from the next release of Oxygen I tried that last week, and it looked really underwhelming. We *can* remove gradient and adjust color scheme, but a

Re: Bug: Battery widget only showing one battery out of two after resume from standby

2014-05-13 Thread Sebastian Kügler
Hi Joschi, On Tuesday, May 13, 2014 10:21:59 Joschi Brauchle wrote: > I am running KDE 4.11.x on an Lenovo Thinkpad T440s with two batteries. > > The KDE battery widget works fine after the initial boot and shows the > correct values for both batteries. > > But after a standby and resume cycle,

Re: old bugs

2014-05-14 Thread Sebastian Kügler
On Wednesday, May 14, 2014 12:42:37 Marco Martin wrote: > One thing we all agree is that we want to keep bugzilla in a manageable > situation to avoid the plasma1 thousand bug tsunami. > > So, how to do this.. so far so good, we have 42 bugs at the moment, closed > a ton, but now that beta is ou

Plasma Next release schedule changes

2014-05-14 Thread Sebastian Kügler
Hey all, We had to delay the Plasma Next release, because Frameworks will only be released July 1st. Jonathan has adjusted the online schedule, the short version of the relevant part is: * Beta 2: Thu June 5 tagging, Tue 8 June release * Release Candidate: Thu 3 July tagging, Tue 8 July release

Re: Plasma Next release schedule changes

2014-05-14 Thread Sebastian Kügler
On Wednesday, May 14, 2014 15:16:45 Thomas Pfeiffer wrote: > On 14.05.2014 12:58, Sebastian Kügler wrote: > > Hey all, > > > > We had to delay the Plasma Next release, because Frameworks will only be > > released July 1st. Jonathan has adjusted the online schedule, t

Re: RFC - Removing System Bell KCM

2014-05-14 Thread Sebastian Kügler
On Wednesday, May 14, 2014 09:28:08 Hans Chen wrote: > On Mon, May 12, 2014 at 4:11 AM, Marco Martin wrote: > > On Monday 12 May 2014, Martin Gräßlin wrote: > > > I don't think it's something relevant anymore, and I'm not entirely > > > convinced this code even works. > > > > I thought it's stil

Re: Ship with Aurorae and Qtcurve or not...

2014-05-15 Thread Sebastian Kügler
On Thursday, May 15, 2014 12:40:55 Ivan Čukić wrote: > > > Don't we have a plasmoid already for that? That "report a bug" thing? We > > > could have that (or a similar one with warning text) placed on the > > > desktop > > > by default? > > Can somebody with good writing skills whip up something f

Re: Ship with Aurorae and Qtcurve or not...

2014-05-15 Thread Sebastian Kügler
On Thursday, May 15, 2014 13:58:04 Marco Martin wrote: > On Thursday 15 May 2014 13:35:21 Thomas Pfeiffer wrote: > > On 15.05.2014 12:16, David Edmundson wrote: > > > On Thu, May 15, 2014 at 11:39 AM, Jens Reuterberg wrote: > > > > > > > > > People always react whatever you do. > > > Do not get

Re: Review Request 118063: New Formats KCM

2014-05-15 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118063/#review57987 --- *puppyeyes* shipit? - Sebastian Kügler On May 13, 2014, 2

Re: Review Request 118063: New Formats KCM

2014-05-15 Thread Sebastian Kügler
/2014/05/09/86a830ed-2d5d-4bdd-ba82-71ec73e6ce2c__formatskcmss.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118150: Read locale settings from config for Plasma sessions

2014-05-15 Thread Sebastian Kügler
settings (for example in Plasma's clock). Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118150: Read locale settings from config for Plasma sessions

2014-05-15 Thread Sebastian Kügler
locale settings in kcmshell5 formats, re-logged in, checked that we get the right QLocale settings (for example in Plasma's clock). Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/p

Re: Ship with Aurorae and Qtcurve or not...

2014-05-16 Thread Sebastian Kügler
On Friday, May 16, 2014 16:20:26 Marco Martin wrote: > On Friday 16 May 2014, David Edmundson wrote: > > We have an extra month. Lets do it. > > > > > > > > As for your application, I think we need a guard on > > if (QFile::exists( theQStyleRcFile ) { > > > > return; > > > > } > > so we don't tr

Re: Review Request 118126: Show applets from the system tray in Widget Explorer

2014-05-19 Thread Sebastian Kügler
/widgetexplorer.cpp <https://git.reviewboard.kde.org/r/118126/#comment40421> Maybe this should be compile-time checked, as the code is touched anyway? - Sebastian Kügler On May 14, 2014, 1:08 p.m., David Edmundson wrote: > > ---

Minutes Monday Plasma hangout

2014-05-19 Thread Sebastian Kügler
Present: Antonis, Ivan, Marco, Martin G, Sebastian, Jens, Jonathan Antonis: - Ported Plasma Active's activitymanager, almost done Ivan: - Finished resources model - Working on applications pinning to activities - Compabitibility improvements between 4 and 5 activitymanager Jens: - Ongoing discus

Re: Review Request 118205: Turn the free space notifier into StatusNotifierItem

2014-05-20 Thread Sebastian Kügler
reespacenotifier/freespacenotifier.cpp <https://git.reviewboard.kde.org/r/118205/#comment40457> For new code, let's use the compile-time checked connect syntax. Makes it easier to spot errors. - Sebastian Kügler On May 19, 2014, 4:15

Re: Review Request 118205: Turn the free space notifier into StatusNotifierItem

2014-05-20 Thread Sebastian Kügler
d be compile-time as well. - Sebastian Kügler On May 20, 2014, 2:17 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.revi

Re: Review Request 118204: [klipper] Show filter widget before sending key events to it

2014-05-22 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118204/#review58300 --- Ship it! Sounds logical and sensible. - Sebastian Kügler

Re: Review Request 118258: [klipper] Always show filter widget in klipperpopup

2014-05-22 Thread Sebastian Kügler
g/r/118258/#comment40560> Can't we use QLineEdit, in order to avoid deprecated KLineEdit? - Sebastian Kügler On May 22, 2014, 1:17 p.m., Martin Gräßlin wrote: > > --- > This is an automatically generated e-mail. To r

Re: Review Request 118258: [klipper] Always show filter widget in klipperpopup

2014-05-22 Thread Sebastian Kügler
> On May 22, 2014, 1:23 p.m., Sebastian Kügler wrote: > > klipper/klipperpopup.cpp, line 73 > > <https://git.reviewboard.kde.org/r/118258/diff/1/?file=274169#file274169line73> > > > > Can't we use QLineEdit, in order to avoid deprecated KLineEdit? >

Re: Review Request 117374: Add a kded module for ksysguard

2014-05-22 Thread Sebastian Kügler
filterText is always empty here ksysguard/kdedksysguard.cpp <https://git.reviewboard.kde.org/r/117374/#comment40566> filterText is empty here - Sebastian Kügler On May 22, 2014, 2:18 p.m., Vishesh Handa wrote: > >

Review Request 118272: batterymonitor visual cleanups

2014-05-22 Thread Sebastian Kügler
e91-93c2-ebd6b1dab38d__battery-after-expanded.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: [plasma-framework] examples/dataengines: Fix build with examples

2014-05-23 Thread Sebastian Kügler
lic dependency, this shouldn't be > needed. > > On Mon, May 19, 2014 at 11:53 PM, Sebastian Kügler wrote: > > Git commit 1f80c23bd514247d60b831de7671eff1e664d95d by Sebastian Kügler. > > Committed on 19/05/2014 at 21:53. > > Pushed by sebas into branch 'master'

Re: Icons for Paste Bin and Paste

2014-05-23 Thread Sebastian Kügler
On Thursday, May 22, 2014 19:33:40 Thomas Pfeiffer wrote: > On Thursday 22 May 2014 19:17:22 Jens wrote: > > Ah the issue that there are TWO pastebin, one good for images (of > > all kinds, including the link above btw) as well as text and one not > > so good that is just for text > > > > > > > >

Re: [plasma-framework] examples/dataengines: Fix build with examples

2014-05-23 Thread Sebastian Kügler
On Friday, May 23, 2014 12:18:55 Marco Martin wrote: > I think it's a counter-effect of when i removed KConfigWidgets from > libplasma. there is definitely a problem in the cmake there, qt5::gui > should be in public in libplasma, right? That's how I understand Aleix. -- sebas http://www.kde.org

Re: Icons for Paste Bin and Paste

2014-05-23 Thread Sebastian Kügler
On Friday, May 23, 2014 13:24:20 Jens wrote: > I know that the work with global login is appearently rather > frustrating (as I've heard from you guys) since Google and > Facebook and Twitter all enjoy to swap stuff around making one > method completely useless after a short while. > > Marco if

Re: Review Request 118272: batterymonitor visual cleanups

2014-05-23 Thread Sebastian Kügler
an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/#review58340 ------- On May 22, 2014, 10:36 p.m., Sebastian Kügler wrote: > > --- >

Re: Review Request 118272: batterymonitor visual cleanups

2014-05-23 Thread Sebastian Kügler
g/media/uploaded/files/2014/05/22/4439093c-345c-44af-afa1-a05cb0973990__battery-after-collapsed.png after (expanded) https://git.reviewboard.kde.org/media/uploaded/files/2014/05/22/b18cf61f-0ff1-4e91-93c2-ebd6b1dab38d__battery-after-expanded.p

Re: Review Request 118272: batterymonitor visual cleanups

2014-05-23 Thread Sebastian Kügler
- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118272/#review58335 ------- On May 22, 2014, 10:36 p.m., Sebastian Kügler wrote: > >

Re: Review Request 118274: [digital-clock] Replace sizing timer with fontSizeMode property

2014-05-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118274/#review58357 --- Ship it! Ship It! - Sebastian Kügler On May 23, 2014, 10

Re: Review Request 118278: [2/2] Make sure we update the calendar on date change

2014-05-23 Thread Sebastian Kügler
/contents/ui/CalendarView.qml <https://git.reviewboard.kde.org/r/118278/#comment40606> Could be done with a Connection, adding a property just for one usage seems a bit like overkill. - Sebastian Kügler On May 23, 2014, 3:25 p.m., Martin Klapetek

Re: Review Request 118277: [1/2] Make sure we update the calendar on date change

2014-05-23 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118277/#review58361 --- Ship it! Ship It! - Sebastian Kügler On May 23, 2014, 3

Re: Review Request 118272: batterymonitor visual cleanups

2014-05-23 Thread Sebastian Kügler
.png after (expanded) https://git.reviewboard.kde.org/media/uploaded/files/2014/05/22/b18cf61f-0ff1-4e91-93c2-ebd6b1dab38d__battery-after-expanded.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Review Request 118290: Streamline Comment fields of KCMs

2014-05-23 Thread Sebastian Kügler
882c848 kcms/style/style.desktop fd19bc4b204ca102081629fd6132b14857c4e4bc kcms/workspaceoptions/workspaceoptions.desktop 3e318660b0258c17bc7641efb1d7f1e84a1eed44 Diff: https://git.reviewboard.kde.org/r/118290/diff/ Testing --- Thanks, Sebastian Kügler ___ Pla

Re: Plasma Addons

2014-05-24 Thread Sebastian Kügler
On Saturday, May 24, 2014 08:22:24 Martin Gräßlin wrote: > On Saturday 24 May 2014 00:23:45 David Edmundson wrote: > > we've started to get bug reports on plasma-addons. It appears they're > > distributed as part of OpenSuse RPMs. > > > > Can I confirm our position on what we're doing here, based o

Re: Plasma Next visual polish feedback from VDG core folks

2014-05-24 Thread Sebastian Kügler
On Saturday, May 24, 2014 12:23:54 Marco Martin wrote: > On Friday 23 May 2014 17:21:16 Andrew Lake wrote: > > I just had a quick question. If I have some feedback on areas to visually > > polish up for the Plasma Next release, should I file a bug or just share > > them via the email list? > > > >

Re: Plasma Addons

2014-05-25 Thread Sebastian Kügler
On Saturday, May 24, 2014 15:13:19 Luca Beltrame wrote: > In data sabato 24 maggio 2014 14:54:02, Sebastian Kügler ha scritto: > > +1 on all of the above. kdeplasma-addons is outside of our scope. > > Should distros tell reporters not to report bugs against kdeplasma-addons > fo

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
551139a33c kcms/standard_actions/standard_actions.desktop 54a3ea84fe40dea252d1925d9f07cf6f2882c848 kcms/style/style.desktop fd19bc4b204ca102081629fd6132b14857c4e4bc kcms/workspaceoptions/workspaceoptions.desktop 3e318660b0258c17bc7641efb1d7f1e84a1eed44 Diff: https://git.reviewboard.kde.org/r/118290/diff/ T

Minutes Monday Plasma hangout

2014-05-26 Thread Sebastian Kügler
Minutes 26-06-2014 Present: Aleix, Antonis, David, Jens, Marco, Martin G., Martin K., Sebastian Aleix: - Investigated Plasma startup performance: What can we do better? Antonis: - Plasma Active shell porting: - shellpackage support in urlintercepter David Edmundson: - Merged some SDDM patch

Re: Review Request 118328: Add the current month name to the calendar component by default

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118328/#review58475 --- For graphical changes, please add screenshots. - Sebastian

Re: Review Request 118328: Add the current month name to the calendar component by default

2014-05-26 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118328/#review58480 --- Ship it! Ship It! - Sebastian Kügler On May 26, 2014, 12

Re: High DPI issues

2014-05-26 Thread Sebastian Kügler
On Monday, May 26, 2014 16:55:42 Teo Mrnjavac wrote: > > Now, the most important difference to the approach I've seen in Qt, is > > that > > this is a QML binding in our case instead of a scaling factor which you > > inject in the rendering engine. This means, we can change those not only > > on >

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
There's a guideline on no abbreviations. I think & counts as one. Ah, yes. Missed that one. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118290/#review58456 -

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
aunch.desktop fbb3ca6 kcms/phonon/kcm_phonon.desktop 46eecff kcms/spellchecking/spellchecking.desktop 92a76cf kcms/standard_actions/standard_actions.desktop 54a3ea8 kcms/style/style.desktop fd19bc4 kcms/workspaceoptions/workspaceoptions.desktop 3e31866 Diff: https://git.reviewboard.kde.or

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
kcms/style/style.desktop fd19bc4 kcms/workspaceoptions/workspaceoptions.desktop 3e31866 Diff: https://git.reviewboard.kde.org/r/118290/diff/ Testing --- Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-26 Thread Sebastian Kügler
------ On May 27, 2014, 12:03 a.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118290/ > ---

Re: Review Request 118343: [klipper] Port from KMenu to QMenu

2014-05-27 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118343/#review58552 --- Ship it! Ship It! - Sebastian Kügler On May 27, 2014, 7

Re: Review Request 109160: do not truncate list of help options in KRunner

2014-05-28 Thread Sebastian Kügler
a4844 krunner/interfaces/default/interface.cpp 505e0aa Diff: https://git.reviewboard.kde.org/r/109160/diff/ Testing --- Verified that all help options are shown. No visible side-effects. Thanks, Sebastian Kügler ___ Plasma-devel mailing list P

Review Request 118390: Powerdevil KCM Updates

2014-05-28 Thread Sebastian Kügler
org/r/118390/diff/ Testing --- Tested in kcmshell5 and systemsettings, still fully functional. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118390: Powerdevil KCM Updates

2014-05-28 Thread Sebastian Kügler
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian K

Re: Review Request 118390: Powerdevil KCM Updates

2014-05-28 Thread Sebastian Kügler
-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118290: Streamline Comment fields of KCMs

2014-05-29 Thread Sebastian Kügler
/kcm_phonon.desktop 46eecff kcms/spellchecking/spellchecking.desktop 92a76cf kcms/standard_actions/standard_actions.desktop 54a3ea8 kcms/style/style.desktop fd19bc4 kcms/workspaceoptions/workspaceoptions.desktop 3e31866 Diff: https://git.reviewboard.kde.org/r/118290/diff/ Testing

Re: Review Request 118357: Disable the agenda part of the calendar

2014-05-30 Thread Sebastian Kügler
x27;s comment the agenda item code, so we don't waste memory or CPU cycles. Once done, please ship. - Sebastian Kügler On May 27, 2014, 4 p.m., Martin Klapetek wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 118390: Powerdevil KCM Updates

2014-05-30 Thread Sebastian Kügler
Hey, First, thanks all for the reviews. On Thursday, May 29, 2014 16:10:19 Andrew Lake wrote: > > On May 29, 2014, 8:13 a.m., Thomas Pfeiffer wrote: > > > Good improvements in general! > > > There are two changes which are not HIG-compliant: > > > - Control labels which are written next to the co

Re: Ship with Aurorae and Qtcurve or not...

2014-05-30 Thread Sebastian Kügler
On Thursday, May 29, 2014 15:09:33 Marco Martin wrote: > On Thursday 15 May 2014 11:39:00 Jens Reuterberg wrote: > > Ok so after the feedback from the Beta Release an issue that we knew was > > coming have happened. Visuals being the most easily accessible bit of > > anything technical, people have

Re: Review Request 118357: Disable the agenda part of the calendar

2014-05-30 Thread Sebastian Kügler
> On May 30, 2014, 1:27 p.m., Sebastian Kügler wrote: > > Since the visible flag is now static false, let's comment the agenda item > > code, so we don't waste memory or CPU cycles. Once done, please ship. > > Martin Klapetek wrote: > I specifically opted

Re: Review Request 118357: Disable the agenda part of the calendar

2014-05-30 Thread Sebastian Kügler
> On May 30, 2014, 1:27 p.m., Sebastian Kügler wrote: > > Since the visible flag is now static false, let's comment the agenda item > > code, so we don't waste memory or CPU cycles. Once done, please ship. > > Martin Klapetek wrote: > I specifically opted

Re: Review Request 118390: Powerdevil KCM Updates

2014-05-30 Thread Sebastian Kügler
ent. In the future, the currently proposed solution will take care of this automatically. IOW, it's not an issue right now, likely won't be in the future, it's also not a regression. - Sebastian --- This is an automatically gen

Re: Review Request 118390: Powerdevil KCM Updates

2014-05-30 Thread Sebastian Kügler
-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118417: [klipper] Port from KDebug to QDebug

2014-06-02 Thread Sebastian Kügler
> On May 30, 2014, 3:39 p.m., Alexander Richardson wrote: > > Shouldn't this rather use qCDebug() so that the output can be disabled? I think it would be nice, but I'd also leave the choice between qDebug and qCDebug up to the maintainer -- Martin. :) We haven't enforced it everywhere yet. -

Re: Review Request 118428: Drop configuration options for taskbar and desktop fonts

2014-06-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118428/#review58939 --- Ship it! Ship It! - Sebastian Kügler On May 30, 2014, 3

Re: Review Request 118038: Bring back a KCM for the screen locker

2014-06-02 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118038/#review58942 --- Ship it! Ship It! - Sebastian Kügler On May 8, 2014, 5:17

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Sebastian Kügler
e.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Sebastian Kügler
media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian K

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Sebastian Kügler
do just fine with section titles and a bit of spacing (as can be seen here). - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118390/#review58996 --------

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-02 Thread Sebastian Kügler
up visual > > elements without the line-y, boxy noise of a visible frame. If you used > > group boxes here and followed this new guidance you should get the visual > > design you're aiming for with more consistent spacing. > > > > Hope this helps! > > Se

Re: Review Request 118038: Bring back a KCM for the screen locker

2014-06-03 Thread Sebastian Kügler
, otherwise, it's good to go in. ksmserver/screenlocker/kcm/screenlocker.desktop <https://git.reviewboard.kde.org/r/118038/#comment41126> Screen Locking Timeouts ... please. :) - Sebastian Kügler On June 3, 2014, 6:53 a.m., Martin Gr

Re: Review Request 118390: Powerdevil KCM Updates

2014-06-03 Thread Sebastian Kügler
e.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png Advanced page before https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png Thanks, Sebastian K

Re: Review Request 118516: Load the networkmanager applet on demand

2014-06-04 Thread Sebastian Kügler
> On June 4, 2014, 11:02 a.m., Lukáš Tinkl wrote: > > How would you connect to a VPN in that case? > > Marco Martin wrote: > Is networkmanager used to connect a VPN? > (and more generally, are there any features in the plasmoid that can be > used without networkmanager running?) > > Lu

Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-05 Thread Sebastian Kügler
t.cpp b6fcd207a1d18466f4a747e1a0b4b58107c82871 Diff: https://git.reviewboard.kde.org/r/118581/diff/ Testing --- Tried to assign meta + something in global shortcuts KCM, fails without patch (see screenshot in the linked bugreport), works correctly with patch. Thanks, Sebastian K

Re: Plasma 5 branding

2014-06-06 Thread Sebastian Kügler
On Friday, June 06, 2014 11:04:09 Jonathan Riddell wrote: > A decision needs to be made on Plasma branding because we are now a month > away from release. > > I plan to use Plasma 5 for the generation of Plasma using KDE Frameworks 5. > > For technical numbers I'm using 4.97.0 for this beta and p

Re: Review Request 118583: Fix Comic Strip Installation

2014-06-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118583/#review59404 --- Ship it! Ship It! - Sebastian Kügler On June 6, 2014, 6

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Sebastian Kügler
7Name() is the correct one to use here. (Which leaves questions indeed.) - Sebastian Kügler On June 6, 2014, 6:45 a.m., Luca Beltrame wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git

Re: Plasma 5 branding

2014-06-06 Thread Sebastian Kügler
On Friday, June 06, 2014 12:07:06 Jonathan Riddell wrote: > On Fri, Jun 06, 2014 at 12:33:43PM +0200, Sebastian Kügler wrote: > > > That leaves the marketing release names. My best idea is Summer 2014 > > > etc so this release will be the Plasma 5 Summer 2014 release. Thi

Re: Review Request 118584: Formats KCM: Use QLocale::name() instead of bcp47Name() when writing to the configuration file

2014-06-06 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118584/#review59477 --- Ship it! Ship It! - Sebastian Kügler On June 6, 2014, 6

Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-09 Thread Sebastian Kügler
esn't work without (displays garbage like in the linked bugreport). Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-09 Thread Sebastian Kügler
------ On June 6, 2014, 12:39 a.m., Sebastian Kügler wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/118581/ > ---

Re: Review Request 118581: Consider Super_L and Super_R as modifiers

2014-06-09 Thread Sebastian Kügler
(see screenshot in the linked bugreport), works correctly with patch. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Minutes Monday Plasma hangout

2014-06-10 Thread Sebastian Kügler
Minutes from Monday Plasma Hangout Today! Present: AleixAntonis, Jonathan, Marco, Martin G., Martin K., David, Sebastian, Vishesh Antonis - Worked on wallpapers in Plasma Active shell - Created new touch-based UI to replace desktop UI - Added support for creating and editing activities - Exam p

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-10 Thread Sebastian Kügler
ated. - Sebastian --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118630/#review59659 --- On June 9, 2014, 10:04 p.m., Sebastian Kügler wrote: > > -

Re: Review Request 118630: [KQuickControls] Consider Super_L and Super_R as modifiers

2014-06-10 Thread Sebastian Kügler
sting --- Tested assigning Meta + L to digital clock plasmoid, works with the patch, doesn't work without (displays garbage like in the linked bugreport). Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://ma

Re: Plasma 5 Beta 2 tars

2014-06-10 Thread Sebastian Kügler
On Tuesday, June 10, 2014 22:10:19 Jonathan Riddell wrote: > Last minute update to fix issues in the translation files. Alas I found no > fix for the reported problem compiling on i386 Could you send a log here of the build failure on i386? -- sebas http://www.kde.org | http://vizZzion.org | GP

Re: Plasma 5 Beta 2 tars

2014-06-11 Thread Sebastian Kügler
[CC:ing frameworks-devel, hoping for additional input] On Friday, June 06, 2014 23:24:50 šumski wrote: > On Friday 06 of June 2014 21:32:48 Eric Hameleers wrote: > > On Fri, 6 Jun 2014, ?umski wrote: > > > On Thursday 05 of June 2014 16:47:59 Jonathan Riddell wrote: > > >> Tars are up for Plasma 5

Re: Review Request 118388: rename systemsettings binary to systemsettings5

2014-06-11 Thread Sebastian Kügler
> On June 9, 2014, 1:21 p.m., Eike Hein wrote: > > If you rename the .desktop files, please remember to update the default > > favorites configurations in Kicker (it's in the main.xml of the package) > > and Kickoff (somewhere in C++ model code) since they both reference System > > Settings by

Review Request 118678: [ki18n] Allow querying for translations of a specific domain

2014-06-11 Thread Sebastian Kügler
5 Diff: https://git.reviewboard.kde.org/r/118678/diff/ Testing --- Tested new translations KCM, languages show up. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain

2014-06-11 Thread Sebastian Kügler
-- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/#review59840 --- On June 11, 2014, 10:09 p.m., Sebastian Kügler wrote: > > --

Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain

2014-06-11 Thread Sebastian Kügler
09dd403e src/klocalizedstring.cpp e12d6dfa9c147ffb127f462dc5db236be0d2ff75 Diff: https://git.reviewboard.kde.org/r/118678/diff/ Testing --- Tested new translations KCM, languages show up. Thanks, Sebastian Kügler ___ Plasma-devel mailing li

Review Request 118716: New Translations KCM

2014-06-12 Thread Sebastian Kügler
--- Set up languages (x-test, others), re-logged in, languages correctly set up for KF5 and console applications. Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118716: New Translations KCM

2014-06-12 Thread Sebastian Kügler
/uploaded/files/2014/06/13/28a00558-f671-4f39-bfe3-ca9dca8e98ce__tranlationskcm.png Thanks, Sebastian Kügler ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

<    6   7   8   9   10   11   12   13   14   15   >