[Differential] [Accepted] D3484: Center systemmonitor window properly on multi-screen setup

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3484 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: vale

[Differential] [Accepted] D3489: Take control on default properties on *ListItem

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH mart/Kirigami2 REVISION DETAIL https://phabricator.kde.org/D3489 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart C

[Differential] [Accepted] D3507: Properly implement maximize of ShellClient

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH shell-client-fix-maximize REVISION DETAIL https://phabricator.kde.org/D3507 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferenc

[Differential] [Request, 37 lines] D3528: Select correct index without timer

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY remove the timer that selects the index at startup that caused flickering and things moving around since

[Differential] [Commented On] D3528: Select correct index without timer

mart added a comment. In https://phabricator.kde.org/D3528#65626, @davidedmundson wrote: > Is this just a manifest of us populating the model in KCMLookandFeel::load which is after setSource? I tried to add a load() in kcmutils/KCModuleQml just before loading the qml file, but ev

[Differential] [Closed] D3528: Select correct index without timer

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ee2ec66a4155: Select correct index without timer (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3528?vs=8564&id=8568 REVISION DETAIL h

[Differential] [Request, 129 lines] D3532: Select correct index without timer

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY select the correct index upon loading when the count changes. this removes the flicker at startup and the view is at the correct wallpaper sin

[Differential] [Updated] D3532: Select correct index without timer

mart added a reviewer: Plasma. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3532 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 25 lines] D3533: Select correct index without timer

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY remove the timer that selects the index at startup that caused flickering and things moving around since index

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

mart added a comment. In https://phabricator.kde.org/D3530#65867, @dfaure wrote: > But desktop:/ and applications:/ make no sense in other workspaces (I'm surprised we even still have applications:/, it's kind of a toy, isn't it?). > > (ok applications:/ might make sense in gnome, but

[Differential] [Accepted] D3508: Implement borderlessMaximizedWindows for Wayland windows

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R108 KWin BRANCH shell-client-borderless-maximized-windows REVISION DETAIL https://phabricator.kde.org/D3508 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel

[Differential] [Accepted] D3425: If we get a notification with no body, treat the subject line as the body

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D3425 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Closed] D3532: Select correct index without timer

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5434e4bc0141: Select correct index without timer (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3532?vs=8574&id=8601 REVISION DETAIL

[Differential] [Closed] D3533: Select correct index without timer

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d9d52a37c6ba: Select correct index without timer (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3533?vs=8575&id=8602 REVISION DETAIL h

[Differential] [Commented On] D3530: Import plasma-workspace kioslaves

mart added a comment. In https://phabricator.kde.org/D3530#65734, @aacid wrote: > > Dolphin in other environments currently gives a big error until you install plasma-workspace, which defeats the point of the split. > > Maybe Dolphin needs to be patched not to assume remote:/ will alw

[Differential] [Commented On] D3538: Drop resize animation when adding pages

mart added inline comments. INLINE COMMENTS > PageRow.qml:429 > id: stateTimer > -interval: 150 > +interval: 0 > onTriggered: container.state = container.pendingState if the interval went to 0, then couldn't be possible to remove

[Differential] [Accepted] D3541: Introduce a first test for PageRow

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH mart/Kirigami2 REVISION DETAIL https://phabricator.kde.org/D3541 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: pl

[Differential] [Commented On] D3539: [Notifications] Show interactive thumbnails on notifications

mart added a comment. I like the idea, but i am a bit concerned about the added complexity, that may be worked around? INLINE COMMENTS > NotificationItem.qml:318 > + > +ListView { > +id: previewList the main concern i have, is the general weight of QML. this is going to

[Differential] [Accepted] D3539: [Notifications] Show interactive thumbnails on notifications

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3539 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Accepted] D3549: [Lock Screen] Add keyboard icon for keyboard layout switcher

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3549 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Accepted] D3553: Fix 2 RTL bugs

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3553 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ttv20, #plasma_wor

[Differential] [Accepted] D3538: Drop resize animation when adding pages

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH mart/Kirigami2 REVISION DETAIL https://phabricator.kde.org/D3538 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: je

[Differential] [Accepted] D3558: Make properties readonly when possible

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH mart/Kirigami2 REVISION DETAIL https://phabricator.kde.org/D3558 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: pl

[Differential] [Accepted] D3557: [Notifications] Default initialize notificationProperties as empty object

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3557 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Request, 294 lines] D3561: make the logic of PageRow a ListView

mart created this revision. mart added a reviewer: Kirigami. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY it implements internally things like snapping and layouting makes the qml code significantly simpler it nee

[Differential] [Updated, 502 lines] D3561: make the logic of PageRow a ListView

mart updated this revision to Diff 8679. mart added a comment. - refactor delegate of ApplicationHeader REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3561?vs=8678&id=8679 BRANCH phab/listviewrow REVISION DETAIL https://phabricator.kde.org/D3561 AFF

[Differential] [Updated, 506 lines] D3561: make the logic of PageRow a ListView

mart updated this revision to Diff 8680. mart added a comment. - remove some redundant properties REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3561?vs=8679&id=8680 BRANCH phab/listviewrow REVISION DETAIL https://phabricator.kde.org/D3561 AFFECTED

[Differential] [Closed] D3561: make the logic of PageRow a ListView

This revision was automatically updated to reflect the committed changes. Closed by commit R169:7a6c6b9bcff9: make the logic of PageRow a ListView (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3561?vs=8680&id=8695 REVISION DETAIL https

[Differential] [Accepted] D3569: Add a test that makes sure that pages are destroyed

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH mart/Kirigami2 REVISION DETAIL https://phabricator.kde.org/D3569 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: pl

[Differential] [Accepted] D3560: [Notifications] Tighten layout

mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > NotificationItem.qml:156 > > -spacing: units.smallSpacing > +spacing: units.smallSpacing / 2 > you should still make sure i

[Differential] [Commented On] D3578: [RFC] Implement drag from free space also for QtQuickControls

mart added a comment. big +1 on this. to make it build on kde4, even if it's not pretty, could the method declarations be ifdeffed? implementations are mostly the same REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D3578 EMAIL PREFERENCES https://phabricator.kde.o

[Differential] [Accepted] D3572: systemtray: Don't propagate unhandled wheel events

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. ok for this revision (in 5.8 as well) even tough it kinda masks the actual problem, that is the wheel containmentactions plugin sometimes loaded in still unknown ci

[Differential] [Updated] D3588: Remove inexistent file references from kirigami.qrc

mart added a comment. In https://phabricator.kde.org/D3588#67023, @bearsh wrote: > running `scripts/gen_qml_qrc.sh` produces a different diff. the question is now, are all qml files (the script simply includes all available files) required? yes, all the qml files are required. R

[Differential] [Accepted] D3591: [qrc] update ressource file

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH kirigami2 (branched from mart/Kirigami2) REVISION DETAIL https://phabricator.kde.org/D3591 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: be

[Differential] [Accepted] D3559: [Notification Popup] Clear notification data after popup closed

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3559 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Accepted] D3594: [Notifications] Never manually hide() the NotificationPopup

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3594 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Accepted] D3589: Add a notication service to inhibit certain notifications based on metadata

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3589 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson,

[Differential] [Accepted] D3596: Block Network manager notifications when the popup is visible

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D3596 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailp

[Differential] [Request, 181 lines] D3603: Option to show percentage charge in the icon

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY add an option to show a text label with the percentage value in the battery icon. text will be shown bottom-right

[Differential] [Commented On] D3603: Option to show percentage charge in the icon

mart added a comment. F644198: Spectacle.J10007.png (on higher dpi screens should look a bit better) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3603 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/em

[Differential] [Updated, 180 lines] D3603: Option to show percentage charge in the icon

mart updated this revision to Diff 8787. mart added a comment. - correct copyright REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3603?vs=8786&id=8787 BRANCH phab/batterypercent REVISION DETAIL https://phabricator.kde.org/D3603 AFFECTED FILE

[Differential] [Updated, 180 lines] D3603: Option to show percentage charge in the icon

mart updated this revision to Diff 8788. mart added a comment. - correct copyright REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3603?vs=8787&id=8788 BRANCH phab/batterypercent REVISION DETAIL https://phabricator.kde.org/D3603 AFFECTED FILE

[Differential] [Commented On] D3603: Option to show percentage charge in the icon

mart added a comment. eew, sorry, that canvas thing was from an old experiment i did for a possible alternative graphics, which i forgot to kill ;) INLINE COMMENTS > broulik wrote in main.xml:11 > I think this could even be the default? not sure it's pretty enough for default (yet?), in the

[Differential] [Updated, 130 lines] D3603: Option to show percentage charge in the icon

mart updated this revision to Diff 8802. mart added a comment. - light shadow on the label REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3603?vs=8788&id=8802 BRANCH phab/batterypercent REVISION DETAIL https://phabricator.kde.org/D3603 AFFEC

[Differential] [Commented On] D3606: RFC: Listen for broadcast notifications on system bus

mart added a comment. since is rfc this is my comment: I like the idea a lot REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3606 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: mart, plasma-devel, l

[Differential] [Commented On] D3603: Option to show percentage charge in the icon

mart added a comment. F672027: Spectacle.T21326.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3603 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: broulik, pl

[Differential] [Updated, 175 lines] D3603: Option to show percentage charge in the icon

mart updated this revision to Diff 8840. mart added a comment. - add missing file REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3603?vs=8802&id=8840 BRANCH phab/batterypercent REVISION DETAIL https://phabricator.kde.org/D3603 AFFECTED FILES

[Differential] [Updated, 177 lines] D3603: Option to show percentage charge in the icon

mart updated this revision to Diff 8843. mart added a comment. - use anchors REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3603?vs=8840&id=8843 BRANCH phab/batterypercent REVISION DETAIL https://phabricator.kde.org/D3603 AFFECTED FILES ap

[Differential] [Closed] D3603: Option to show percentage charge in the icon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:27ac0b760855: Option to show percentage charge in the icon (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3603?vs=8843&id=8844 REVISIO

[Differential] [Changed Subscribers] D3620: Add Plasmoid that shows multiple other plasmoids in a tabbed interface

mart added inline comments. INLINE COMMENTS > groupingplasmoid.kdev4:1 > +[Buildset] > +BuildItems=@Variant(\x00\x00\x00\t\x00\x00\x00\x00\x01\x00\x00\x00\x0b\x00\x00\x00\x00\x01\x00\x00\x00 > > \x00g\x00r\x00o\x00u\x00p\x00i\x00n\x00g\x00p\x00l\x00a\x00s\x00m\x00o\x00i\x00d) this foder should

[Differential] [Accepted] D3585: Fix building library with qmake

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3585 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca,

[Differential] [Accepted] D3620: Add Plasmoid that shows multiple other plasmoids in a tabbed interface

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D3620 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: da

[Differential] [Changed Subscribers] D3606: Listen for broadcast notifications on system bus

mart added a subscriber: davidedmundson. mart added a comment. In https://phabricator.kde.org/D3606#67751, @davidedmundson wrote: > Note that actions won't work, we'd always be replying on the session bus. (this is solvable) is that even possible to add an action at all from there

[Differential] [Requested Changes To] D3630: [Digital Clock] Bug fixes and ui code optimization

mart requested changes to this revision. mart added a reviewer: mart. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > DigitalClock.qml:57 > // if the date/timezone cannot be fit with the smallest font to its > designated space > -readonly pro

[Differential] [Accepted] D3615: [Kicker] Hide "Edit Applications..." context menu entry if system immutable

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3615 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Commented On] D3606: Listen for broadcast notifications on system bus

mart added a comment. In https://phabricator.kde.org/D3606#67898, @broulik wrote: > What would be the best place to put a little utility (similar to notify-send or kdialog --passivepopup) for this? kde-cli-tools REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabri

[Differential] [Commented On] D3598: rework kscreen's OSD logic

mart added a comment. In https://phabricator.kde.org/D3598#67455, @sebas wrote: > protocol), we'll move this code into its own daemon and kwin will authorize that daemon. THat's basically the same approach we'll have to take with powerdevil. so in the end the authorized process w

[Differential] [Accepted] D3581: [PlasmaShell] Introduce activateTaskManagerEntry(index) method

mart accepted this revision. mart added a reviewer: mart. mart added a comment. not pretty for sure, but unfortunately i don't see much ways to avoid this, so go for it REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3581 EMAIL PREFERENCES https://phabric

[Differential] [Commented On] D3630: [Digital Clock] Bug fixes and ui code optimization

mart added a comment. yes, if you are comparing with an item height, it should stay in pixelSize REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3630 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: subdiff, #plasma, mart

[Differential] [Commented On] D3660: Plasma 5.9 "Canopee" Wallpaper

mart added a comment. like it a lot! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3660 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: kvermette, #plasma Cc: mart, broulik, plasma-devel, lesliezhai, ali-mohamed, jensreu

[Differential] [Commented On] D3658: Set Automatic login flag to adjust SDDM config directly

mart added a comment. did the helper already supported the action or is a different rr? REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D3658 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, p

[Differential] [Commented On] D3655: Kicker backend changes for Simple Menu.

mart added inline comments. INLINE COMMENTS > appentry.h:79 > AppGroupEntry(AppsModel *parentModel, KServiceGroup::Ptr group, > -bool flat, bool sorted, bool separators, int appNameFormat); > +bool paginate, int pageSize, bool flat, bool sorted, bool > separators

[Differential] [Accepted] D3654: [TextField] Allow disabling reveal password button through KIOSK restriction

mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > TextField.qml:49 > +// this takes into account kiosk restriction > +readonly property bool __effectiveRevealPasswordButtonShown: > reve

[Differential] [Accepted] D3651: Add utility to send broadcast notifications

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D3651 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasm

[Differential] [Commented On] D2687: [Icon Widget] Bring back properties dialog

mart added a comment. for me +1 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2687 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, dfaure Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterber

[Differential] [Accepted] D3655: Kicker backend changes for Simple Menu.

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3655 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, mart Cc: brouli

[Differential] [Accepted] D3666: Test the variable type without warning

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3666 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-dev

[Differential] [Accepted] D3658: Set Automatic login flag to adjust SDDM config directly

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D3658 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: dav

[Differential] [Accepted] D3679: Introduce undefined fields

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks BRANCH master REVISION DETAIL https://phabricator.kde.org/D3679 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #plasma, mart Cc: pla

[Differential] [Commented On] D3674: RFC: Allow pausing media players when screen is locked

mart added a comment. I would rather have media controls in the greeter. I don't like yet another option that does something rather weird :/ REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D3674 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/em

[Differential] [Accepted] D3680: Don't list separately plasmoids from metadata.desktop and .json

mart accepted this revision. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > packageloader.cpp:251 > + > +if (dirs.contains(dir)) > +continue; use { } BRANCH master REVISION DETAIL https://phabricator.kde.or

[Differential] [Accepted] D3681: Fix KAuthActionReply usage

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R134 Discover Software Store BRANCH master REVISION DETAIL https://phabricator.kde.org/D3681 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreference

[Differential] [Accepted] D3684: WIP: Media Controls on lock screen

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3684 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Accepted] D2687: [Icon Widget] Bring back properties dialog

mart accepted this revision. mart added a reviewer: mart. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2687 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, dfaure, mart Cc: mart, plasma-devel, lesliezhai

[Differential] [Accepted] D3685: Add SDDM theme install/uninstall with GHNS to the SDDM KCM

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R123 SDDM Configuration Panel (KCM) BRANCH ghns REVISION DETAIL https://phabricator.kde.org/D3685 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailprefe

[Differential] [Commented On] D3638: Implement drag from free space also for QtQuickControls

mart added a comment. +1 any news on that? REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D3638 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, #plasma, hpereiradacosta Cc: mart, plasma-devel, lesliezhai, ali-moham

[Differential] [Closed] D3553: Fix 2 RTL bugs

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4fada5bdb032: Fix 2 RTL bugs (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3553?vs=8647&id=9037 REVISION DETAIL https://phabricator.kd

[Differential] [Accepted] D3688: [Runners] Register actions right away

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3688 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma

[Differential] [Accepted] D3710: Fix resetMenu

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3710 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-dev

[Differential] [Accepted] D3726: Make sure pages are destroying when popping

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3726 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-dev

[Differential] [Accepted] D3725: [AppletQuickItem] Support launch error message

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3725 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasm

[Differential] [Accepted] D3731: Just look up once the SwipeItemFilter

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3731 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-dev

[Differential] [Accepted] D3749: Make it possible to use the keyboard on Kirigami apps

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3749 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-dev

[Differential] [Commented On] D3769: expose immutable through dbus

mart added a comment. In https://phabricator.kde.org/D3769#70449, @mvourlakos wrote: > It's for Now Dock's next version, a discussion can be found here: > https://phabricator.kde.org/D3754 in next version Now Dock will be a Dock > outside plasmashell but I want the user to have a uni

[Differential] [Commented On] D3769: expose immutable through dbus

mart added a comment. no, this kind of stuff should not be ever exported trough dbus REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3769 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, #plasma, davidedmundso

[Differential] [Updated] D3754: expose toggleWidgetExplorer through dbus

mart added a comment. I disagree, this commit should be reverted REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, davidedmundson, #plasma, mart Cc: plasma-d

[Differential] [Reopened] D3754: expose toggleWidgetExplorer through dbus

mart reopened this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3754 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mvourlakos, davidedmundson, #plasma, mart Cc:

[Differential] [Accepted] D3775: [KPropertiesDialog] Kill "Place in system tray" option

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D3775 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, dfaure, #plasma, #pl

[Differential] [Commented On] D3754: expose toggleWidgetExplorer through dbus

mart added a comment. expanding of why it should be reverted Its only use case is for another process that wants to pretend it's part of the shell, which is not a supported use case neither should be, both for sake of maintainability and of course wayland. REPOSITORY R120 Plasma Workspac

[Differential] [Commented On] D3769: expose immutable through dbus

mart added a comment. In https://phabricator.kde.org/D3769#70547, @mvourlakos wrote: > > note that if it becomes an outside application there is no way it would ever work under wayland > > why? isnt kwayland independent of plasmashell? the plasma wayland protocol, that has t

[Differential] [Changed Subscribers] D3745: [Folder View] Prevent stealing drop events on Compact Representation

mart added inline comments. INLINE COMMENTS > CompactRepresentation.qml:30 > onDrop: folderView.model.dropCwd(event) > +preventStealing: true > did you test if this wouldn't also block some normal mouse events (that you wouldn't want blocked)? REPOSITORY R119 Plasma Desktop REVIS

[Differential] [Accepted] D3755: [Folder View] Offer "Empty Trash" whenever we're in "trash" scheme

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3755 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Accepted] D3756: [Folder View] Add "Restore" from trash option

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3756 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Accepted] D3743: [Folder View] Show proper trash icon when it points to trash:/

mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > foldermodel.cpp:235 > + > +const KFileItem rootItem(url); > I wonder if KFileItem itself should return proper trash icons? REPOSITORY

[Differential] [Accepted] D3745: [Folder View] Prevent stealing drop events on Compact Representation

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. checked at droparea sources, preventstealing is only used in drop events, no mouse events, so all is fine :) REPOSITORY R119 Plasma Desktop REVISION DETAIL htt

[Differential] [Request, 27 lines] D3777: notice when the only screen changes

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY in a corner case that is used a lot, the internal laptop screen gets automatically disabled when an external scre

[Differential] [Accepted] D3764: Make sure that triggering a menu action keeps respecting its action value

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3764 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-dev

[Differential] [Accepted] D3778: Add some indication that the element is highlighted

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3778 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-dev

[Differential] [Accepted] D3779: Fix pageStack.push("string.qml") while loading

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D3779 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-dev

[Differential] [Accepted] D3787: [Plasmoidviewer] Allow passing "externalData" to the applet

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R118 Plasma SDK REVISION DETAIL https://phabricator.kde.org/D3787 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart

<    5   6   7   8   9   10   11   12   >