Re: [Potlatch-dev] [OSM-talk] Way with only one single node

2012-03-21 Thread Steve Bennett
On Thu, Mar 22, 2012 at 3:27 AM, Andy Allan wrote: > Finally, in other projects I follow the convention of "don't code > defensively", as described at > http://www.erlang.se/doc/programming_rules.shtml#HDR11 and elsewhere. Quote: "The function will crash if Option neither normal nor all, and it s

Re: [Potlatch-dev] [OSM-talk] Way with only one single node

2012-03-21 Thread Andy Allan
On 21 March 2012 16:34, Richard Fairhurst wrote: > I've corresponded with Thomas B and found some, ahem, fairly easy steps to > reproduce: > > 1. Click on map (_once_) to start new way > 2. With elastic band still engaged, click 'Save' > 3. Whatever the opposite of PROFIT is > > Will look at it t

Re: [Potlatch-dev] [OSM-talk] Way with only one single node

2012-03-21 Thread Richard Fairhurst
Andy wrote: > Anyway, mumble grumble unit testing. When we find out what's the > trigger, for the love of god someone should help me write the unit > test so that when it's fixed, it stays fixed. I've corresponded with Thomas B and found some, ahem, fairly easy steps to reproduce: 1. Click on map

Re: [Potlatch-dev] [OSM-talk] Way with only one single node

2012-03-21 Thread Andy Allan
On 21 March 2012 12:56, Steve Bennett wrote: > 1) We can fix this, but it's hard to prevent it coming back when new > features are built. I've probably written such bugs. Mumble grumble unit testing. > 3) I still think we should do this. We have a responsibility to not > mess up the database. S

Re: [Potlatch-dev] Flash Player minimum version

2012-03-21 Thread Andy Allan
On 21 March 2012 16:00, Tom Hughes wrote: > By earlier on do you mean earlier today? > > Only we started requiring 10.2 about 9am today and that was only reverted > back to 10.1 just before 11am when Richard's fixed version of Potlatch was > deployed. Yeah, I just read the commits. We were havin

Re: [Potlatch-dev] Flash Player minimum version

2012-03-21 Thread Richard Fairhurst
Andy wrote: > Ah, I wish that I'd known this earlier on - both that we had > a mismatch between required versions (i.e. osm.org was > requiring 10.1 instead of 10.2, hence the lack of > warnings) Yeah, wish I'd realised it too! Ah well, fixed now. > If you can confirm that the old p2, with your c

Re: [Potlatch-dev] Flash Player minimum version

2012-03-21 Thread Tom Hughes
On 21/03/12 15:54, Andy Allan wrote: Ah, I wish that I'd known this earlier on - both that we had a mismatch between required versions (i.e. osm.org was requiring 10.1 instead of 10.2, hence the lack of warnings) and also that we were in the process of changing things around! The training course

Re: [Potlatch-dev] Flash Player minimum version

2012-03-21 Thread Andy Allan
On 21 March 2012 11:38, Richard Fairhurst wrote: > I've therefore added a version check to the custom cursor code. If the > user is still on 10.1, it just won't set the cursors. I've tested it with > both 10.1 and 10.3 players and it seems to work fine. Flex 4.5 nominally > requires 10.2 but, for

Re: [Potlatch-dev] [OSM-talk] Way with only one single node

2012-03-21 Thread Steve Bennett
On Wed, Mar 21, 2012 at 10:14 PM, Richard Fairhurst wrote: > 1. In the UI (i.e. don't let the user create them in the first place) > 2. In the entity model and actions (i.e. don't let them get into P2's > internal data) > 3. In the upload code (i.e. don't let them be transmitted to the server) > >

[Potlatch-dev] Flash Player minimum version

2012-03-21 Thread Richard Fairhurst
Hi all, (This is partly a follow-up to Andy's mail of a few weeks ago!) We had a few reports on help.osm.org of P2 not working (the drag-and-drop icons on the left weren't appearing) and narrowed it down to the users still having Flash Player 10.1 installed. We were only using one 10.2 feature -

Re: [Potlatch-dev] [OSM-talk] Way with only one single node

2012-03-21 Thread Richard Fairhurst
[copied to potlatch-dev, followups probably better there] Steve Bennett wrote: > One thing we could add (in addition to trying to fix bugs in the > various places 1-length ways could be created) would be a > general filter at save time that prevents any 1-length ways > being sent back to the datab