On 22.12.20 17:17, Julien Pivotto wrote:
> Approve and auto merge are different. Auto merge is another value of the merge
> button, next to squash etc.
OK, that's different then. I have no objections to an additional
button that essentially says "merge this once the tests have passed,
and, if appl
Actually on Prometheus it would not rely on it at all unless on release
branches.
Le mar. 22 déc. 2020 à 17:45, Stuart Clark a
écrit :
> But it does rely on approval meaning "good to merge", rather than "only
> when someone else approves".
>
> On 22 December 2020 16:28:18 GMT, Julien Pivotto <
>
But it does rely on approval meaning "good to merge", rather than "only when
someone else approves".
On 22 December 2020 16:28:18 GMT, Julien Pivotto
wrote:
>So, to clarify, this is the equivalent to merge, just it wait for green
>ci.
>
>Le mar. 22 déc. 2020 à 17:17, Julien Pivotto
> a
>écrit
So, to clarify, this is the equivalent to merge, just it wait for green ci.
Le mar. 22 déc. 2020 à 17:17, Julien Pivotto a
écrit :
> Approve and auto merge are different. Auto merge is another value of the
> merge button, next to squash etc.
>
> Le mar. 22 déc. 2020 à 16:59, Bjoern Rabenstein a
Approve and auto merge are different. Auto merge is another value of the
merge button, next to squash etc.
Le mar. 22 déc. 2020 à 16:59, Bjoern Rabenstein a
écrit :
> On 16.12.20 21:33, Julien Pivotto wrote:
> >
> > Can we enable the new github feature, auto-merge, in prometheus
> > repositories
On 22/12/2020 15:59, Bjoern Rabenstein wrote:
On 16.12.20 21:33, Julien Pivotto wrote:
Can we enable the new github feature, auto-merge, in prometheus
repositories?
It waits for everything to be green before merging.
Auto-merge assumes that all tests green and one valid approval means
"please
On 16.12.20 21:33, Julien Pivotto wrote:
>
> Can we enable the new github feature, auto-merge, in prometheus
> repositories?
>
> It waits for everything to be green before merging.
Auto-merge assumes that all tests green and one valid approval means
"please merge". But I don't think that's true.
7 matches
Mail list logo