Re: [prometheus-developers] Evolving remote APIs

2021-11-18 Thread Tom Wilkie
Sounds good! Should we start a regular working group to focus on this? I know many people have been interested. In the meantime I'll try and get that v1 spec published on the prometheus site so we can officially call it "done". One question I'm interested in discussing is to what extent the

Re: [prometheus-developers] Migrating away from github.com/gogo/protobuf

2021-04-29 Thread Tom Wilkie
ith the Cortex and >> Thanos projects is probably a good idea ... >> > > +1 sounds good! Are there specific people I should ping on this list? Or > open up issues in their repos? You mentioned there are others for Cortex @ > tom.wil...@gmail.com? > > On Wed, Apr 28

Re: [prometheus-developers] Exemplar Query API query parameter

2021-04-29 Thread Tom Wilkie
I'd note a label selector (eg {foo="bar"}) _is_ a valid PromQL query, and can be passed to this API... Cheers Tom On Thu, Apr 29, 2021 at 9:34 AM Bartłomiej Płotka wrote: > Thanks, Ben, this is a very valid point. Is there a way we can improve > this? One solution would be: > > Update

Re: [prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-14 Thread Tom Wilkie
ans / website code / etc. >> > >> > >> https://github.com/promlabs/promql-compliance-tester/blob/master/cmd/promql-compliance-tester/main.go >> > >> > On Tue, Apr 13, 2021 at 9:50 PM Tom Wilkie >> wrote: >> > >> > > Yeah I’m f

Re: [prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-13 Thread Tom Wilkie
y repo for remote_write / PromQL / etc., or one > for each tested interface. There's definitely pros + cons for each > approach, but I'd ultimately be fine with either I think. > > On Tue, Apr 13, 2021 at 6:11 PM Tom Wilkie wrote: > >> I only suggested the -community org so

Re: [prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-13 Thread Tom Wilkie
I only suggested the -community org so its not in my personal org, to encourage contributions from the wider community. I would be happy to move it to the main prometheus org. As a monorepo guy, I'm less keen on a proliferation of many orgs so less keen on a dedicated prometheus-compatibility

[prometheus-developers] Prometheus Remote Write "compliance suite"

2021-04-13 Thread Tom Wilkie
Hello Prometheans! In preparation for my PromCon talk, I build a little test suite the checks various Prometheus Remote Write compatible "agents": https://github.com/tomwilkie/remote-write-compliance There are ~13 pretty simple tests, and each one exports some metrics, forks off the "agent"

Re: [prometheus-developers] Standard path for mixins

2021-03-03 Thread Tom Wilkie
@Frederic Branczyk should weigh in on this, but I believe the module name == the directory name in jsonnet bundler, so if we call them all monitoring-mixin then it will make it tricky to import multiple ones into the same project. So with that in mind I like "-mixin". But we could be more

Re: [prometheus-developers] Adding a CODEOWNERS file to prometheus/prometheus?

2021-03-01 Thread Tom Wilkie
Yes! I was chatting to Beorn about this the other week... Big +1 from me. Mind adding a line for /storage/remote too? Thanks Tom On Mon, Mar 1, 2021 at 8:05 PM Julius Volz wrote: > Heya all, > > Julien often helpfully pings me on PRs that touch the React UI, but it > would be much nicer if I

[prometheus-developers] Re: Towards removing the experimental "flag" from the Remote Write protocol.

2021-02-27 Thread Tom Wilkie
ts to give it another read over or has any questions, please do let me know! Thanks Tom On Mon, Feb 15, 2021 at 6:53 PM Tom Wilkie wrote: > Hello! > > I would like to start the discussion about removing the experimental > "flag" from the remote write protocol. This pr

Re: [prometheus-developers] Remote-write drop samples | design doc

2021-02-27 Thread Tom Wilkie
Hi Harkishen! Thank you for the doc - I'm really excited to see more interest in Prometheus remote write. We can go back and forth on the doc with comments, but perhaps it would be easier to have a chat over VC with Chris + I? My main concerns are that we preserve the lossless nature of the

Re: [prometheus-developers] [RFC] Splitting Prometheus configuration in multiple files

2021-02-19 Thread Tom Wilkie
Why you no use jsonnet? Or Cue? ...but seriously, I think this is a good next step. LGTM On Thu, Feb 18, 2021 at 9:46 PM Julien Pivotto wrote: > Hello, > > I have put together a design doc to split the prometheus configuration, > as per dev summit 2020/4 > > >

[prometheus-developers] Towards removing the experimental "flag" from the Remote Write protocol.

2021-02-15 Thread Tom Wilkie
Hello! I would like to start the discussion about removing the experimental "flag" from the remote write protocol. This protocol has been widely adopted by many* systems, and any changes at this stage would break lots of people. I think before we remove the experimental flag we need to actually

Re: [prometheus-developers] [VOTE] Allow Kelvin as temperature unit in some cases

2020-05-29 Thread Tom Wilkie
YES On Fri, May 29, 2020 at 8:13 AM Ben Kochie wrote: > YES > > On Thu, May 28, 2020 at 8:52 PM Bjoern Rabenstein > wrote: > >> Dear Prometheans, >> >> So far, we have recommended Celsius as the base unit for temperatures, >> despite Kelvin being the SI unit. That was well justified by the >>

Re: [prometheus-developers] [VOTE] Allow listing non-SNMP exporters for devices that can already be monitored via the SNMP Exporter

2020-05-29 Thread Tom Wilkie
YES On Fri, May 29, 2020 at 8:12 AM Ben Kochie wrote: > YES > > On Thu, May 28, 2020 at 9:30 PM Julius Volz wrote: > >> Dear Prometheans, >> >> https://github.com/prometheus/docs/pull/1640 proposes to list an >> exporter for Fortigate devices that uses a REST API. Brian's stance so far >> has

Re: [prometheus-developers] [VOTE] New governance document

2020-02-24 Thread Tom Wilkie
YES On Mon, Feb 24, 2020 at 2:24 PM Krasimir Georgiev wrote: > yes > > *Krasi Georgiev* > Senior Software Engineer > Monitoring Team > On Feb 21 2020, at 7:33 pm, Callum Styan wrote: > > Yes > > On Fri, Feb 21, 2020 at 6:11 AM Chris Marchbanks > wrote: > > Yes > > On Wed, Feb 19, 2020 at 1:44