With some discussions in the design docs with brian, it stills feels like a
confusion that, do we want to split labels_matchers in vector_selector that
are immediate child nodes to any binary expression?
On Wednesday, June 24, 2020 at 9:43:00 PM UTC+5:30 Harkishen Singh wrote:
> After
After discussions, I have updated the document with most of the comments
addressed (except the ones that are in conflict). The whitespace issue is
covered and is consistent now. A *note* section has been added to give a
prior knowledge on the formatting on which the document is based.
Please
On Tue, 23 Jun 2020 at 22:19, Julius Volz wrote:
> On Tue, Jun 23, 2020 at 9:47 AM Ben Kochie wrote:
>
>> One subject that I don't see covered in the doc is spacing. There are
>> several places where whitespace is optional, and it would be good to have a
>> consistent opinion on it.
>>
>> *
On Tue, Jun 23, 2020 at 9:47 AM Ben Kochie wrote:
> One subject that I don't see covered in the doc is spacing. There are
> several places where whitespace is optional, and it would be good to have a
> consistent opinion on it.
>
> * Between label selectors {foo="foo",bar="bar"} vs {foo="foo",
One subject that I don't see covered in the doc is spacing. There are
several places where whitespace is optional, and it would be good to have a
consistent opinion on it.
* Between label selectors {foo="foo",bar="bar"} vs {foo="foo", bar="bar"}
* Between params: histogram_quantile(0.9,
Thanks a lot for your great work! Expression formatting will likely require
dozens of detailed rules in order to get things consistent, and style
discussions are the perfect case for bikeshedding. I really appreciate your
efforts and can't wait for a `promtool fmt` on-save editor integration. The
Hello everyone!
As part of the GSoC 2020, I am working on designing a Promql expression
formatting/prettifying tool whose support will be as an extension in the
current promtool. A design document related to the same has been made and
it would be great for some comments/views/suggestions, etc.
7 matches
Mail list logo
