Re: 2.0.2 release is up

2008-10-13 Thread Kenton Varda
On Mon, Oct 13, 2008 at 2:26 AM, edan <[EMAIL PROTECTED]> wrote: > I quick google didn't turn up much for me on what that actually means > - does it mean anything to y'all? Yes, this was an overzealous warning present in one version of GCC which was promptly toned down in subsequent versions. Y

Re: 2.0.2 release is up

2008-10-13 Thread Jeremy Leader
edan wrote: > In any case, using gcc 4.1.2, "make" and "make check" (any reason you > didn't use the more standard "make test"?) succeeded for me, so I > guess I will have to just wait to update to protobuf-2.0.2 until I can > move myself to the newer gcc. For what it's worth, "make check" is sta

Re: 2.0.2 release is up

2008-10-13 Thread edan
Nope - indeed it doesn't work :( Unfortunately I am not (yet) enough of a C++ superstar to tinker much with that code. What I did try was to borrow someone else's updated environment and try to compile there using gcc 4.1.2 So... descriptor.cc does seem to compile under gcc 4.1.2! That's the g

Re: 2.0.2 release is up

2008-10-08 Thread Kenton Varda
OK, based on sephacryl's message I created this patch, but I suspect edan's problem is actually different. Can you both try it out and tell me if it works? edan, if this doesn't solve the problem for you, can you try making some changes yourself and figure out what works? Index: src/google/protob

Re: 2.0.2 release is up

2008-10-07 Thread sephacryl
What works is adding to the definition of class DescriptorBuilder to line1696, void AllocateOptions( const typename FileDescriptor::OptionsType& orig_options, FileDescriptor* descriptor); And changing the implementation, removing the template specialization, at line 2213 to: void

Re: 2.0.2 release is up

2008-10-07 Thread edan
Nope - same error... :( Any other ideas? On Oct 7, 4:25 am, "Kenton Varda" <[EMAIL PROTECTED]> wrote: > Well, the code is correct C++, so it's hard to tell what might convince the > compiler to accept it. > Does it work if you change this: > >   typename DescriptorT::OptionsType* options = >  

Re: 2.0.2 release is up

2008-10-06 Thread Kenton Varda
Well, the code is correct C++, so it's hard to tell what might convince the compiler to accept it. Does it work if you change this: typename DescriptorT::OptionsType* options = tables_->AllocateMessage(); To this: typedef typename DescriptorT::OptionsType OptionsType; OptionsType* op

Re: 2.0.2 release is up

2008-10-06 Thread sephacryl
Some problem with VS .NET 2003. It seems that the compiler cannot handle specialized template methods. I don't see why proper function overloading cannot be used. Anyway, I removed the specialization and moved the code up into the class definition and it works for me. --~--~-~--~~

Re: 2.0.2 release is up

2008-10-05 Thread edan
2.0.2 build bombs for me: google/protobuf/descriptor.cc: In member function `void google::protobuf::DescriptorBuilder::AllocateOptionsImpl(const std::string&, const std::string&, DescriptorT::OptionsType&, DescriptorT*)': google/protobuf/descriptor.cc:2225: syntax error before `>' token mak

2.0.2 release is up

2008-10-03 Thread Kenton Varda
http://code.google.com/p/protobuf/downloads/list I forgot to strip the win32 binary in the first upload, making for a ginormous download. Hence the -a. :/ --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "Protocol B