lgtm
New version is much nicer. Suck about the crashing bug in pkg-config. =(
Jeff Bailey | Google, Inc. | +1 514 670-8754
On Thu, Jul 30, 2009 at 3:00 PM, Kenton Varda ken...@google.com wrote:
New patch: Use pkg-config instead. Much simpler.
On Thu, Jul 30, 2009 at 10:05 AM, Jeff
On Wed, Jul 29, 2009 at 6:34 PM, Jeff Bailey jeffbai...@google.com wrote:
*sigh* It looks like the version at appspot.com isn't GA+ enabled, so I
sign in and it thinks I'm not signed in.
Anyhow, a few comments:
Since it's generated by configure.ac, do you need it in bin_SCRIPTS? I
think
(New patch set uploaded.)
On Thu, Jul 30, 2009 at 8:59 AM, Kenton Varda ken...@google.com wrote:
On Wed, Jul 29, 2009 at 6:34 PM, Jeff Bailey jeffbai...@google.comwrote:
*sigh* It looks like the version at appspot.com isn't GA+ enabled, so I
sign in and it thinks I'm not signed in.
lgtm
42 Packages which depend on Protocol Buffers should call this script
automatically 43 as part of their own configure script.
Provide an example with PKG_CONFIG or something like that.
Otherwise, looks good. Thanks!
Jeff Bailey | Google, Inc. | +1 514 670-8754
On Thu, Jul 30, 2009 at
Yeargh, I'm behind the times. pkg-config? I guess I should be integrating
with that rather than writing my own script?
On Thu, Jul 30, 2009 at 9:05 AM, Jeff Bailey jeffbai...@google.com wrote:
lgtm
42 Packages which depend on Protocol Buffers should call this script
automatically 43 as
I haven't done pkg-config stuff yet. Maybe check in on #autotools in
freenode. I'm usually there, as are other people.
Jeff Bailey | Google, Inc. | +1 514 670-8754
On Thu, Jul 30, 2009 at 12:12 PM, Kenton Varda ken...@google.com wrote:
Yeargh, I'm behind the times. pkg-config? I guess I
New patch: Use pkg-config instead. Much simpler.
On Thu, Jul 30, 2009 at 10:05 AM, Jeff Bailey jeffbai...@google.com wrote:
I haven't done pkg-config stuff yet. Maybe check in on #autotools in
freenode. I'm usually there, as are other people.
Jeff Bailey | Google, Inc. | +1 514 670-8754
Reviewers: jeffbailey,
Description:
This seems needed due to confusion about dependencies, pthreads, etc.
I'm not entirely familiar with the conventions for these scripts,
though. Did I do it right?
Please review this at http://codereview.appspot.com/98071
Affected files:
M Makefile.am
*sigh* It looks like the version at appspot.com isn't GA+ enabled, so I
sign in and it thinks I'm not signed in.
Anyhow, a few comments:
Since it's generated by configure.ac, do you need it in bin_SCRIPTS? I
think that might cause it to get looked at twice.
You should pretty much always do a
