One of the file spec tests was attempting to use X: as a fully
qualified file path, and the file type was correctly rejecting it,
since it is a relative path. This commit changes the spec test to
expect the file type to raise an exception.
Reviewed-by: Jacob Helwig
Signed-off-by: Josh Cooper
---
When running as root, the default conf and var directories on Windows
are currently puppet/etc and puppet/var within the windows
directory. Updated the spec tests to match what the code does on
Windows.
Whether or not this is the correct behavior is something that will be
addressed in the future.
The cacher was causing spec tests to fail due to Time.now not having
millisecond resolution on Windows. Now that usage of the cacher has
been removed from many places, these tests now pass.
Reviewed-by: Jacob Helwig
Signed-off-by: Josh Cooper
---
Local-branch: ticket/master/8663-windows-spec-tes
We are not supporting the ssh_authorized_key type on Windows at this
time, since Windows does not ship with an ssh server (though there are
third-party versions available). As a result these spec tests have
been disabled.
Reviewed-by: Jacob Helwig
Signed-off-by: Josh Cooper
---
Local-branch: tic
Changed the type name from append_line to
whole_line.
After feedback that having a type with a verb in
the name was confusing.
Signed-off-by: Dan Bode
---
.../provider/{append_line => whole_line}/ruby.rb |2 +-
lib/puppet/type/{append_line.rb => whole_line.rb} |6 ++--
.../{append_li
Changed the type name from append_line to
whole_line.
After feedback that having a type with a verb in
the name was confusing.
---
lib/puppet/provider/append_line/ruby.rb| 15 ---
lib/puppet/provider/whole_line/ruby.rb | 15 +++
lib/puppet/type/append_line.rb
The master, and queue applications are not used for agent
functionality and since only agent functionality is supported on
Windows, these tests do not need to run.
Reviewed-by: Josh Cooper
Signed-off-by: Jacob Helwig
---
spec/unit/application/master_spec.rb |2 +-
spec/unit/application/queu
We completed a refactor of the places using Puppet::Util::Cacher,
which resulted in a net deletion of 360 lines of code, simplified the
interaction between several areas of the code base, and removed some
of the inconsistent cacher behavior we were seeing on Windows. This
is slated for Telly.
We
Good day all,
Just a quick heads-up that I'll be upgrading Redmine on
https://projects.puppetlabs.com on the 28th at 10:30PM PDT. (05:30
UTC)
It should be swift, and probably, no one will even notice.
Thanks.
--
Ben Hughes || Come to PuppetConf http://bit.ly/puppetconfsig
--
You received thi
>> * I'm going to need to validate schema against the real argument list
>> in the class to make sure they don't mismatch.
>
> not sure what you mean
Just want to make sure what is specified in the schema aligns with
what parameters are defined in the class definition. For example -
someone may ad
Dan Bode wrote:
> I would prefer to not get back any schema if one is not specified. Not
> all users will want to create schemas, so this could wind up displaying
> unnecessary information.
Whereas I think exactly the opposite. :) Not everyone is going to have
schemas and functionality that consum
On Wed, Jul 27, 2011 at 10:00 AM, Ken Barber wrote:
> So I managed to make some of this work in core. I've got a very basic
> patch ... its not what one would call complete but I want to make sure
> I'm going in the right direction:
>
>
> https://github.com/kbarber/puppet/commit/74d32f3d8c565567f
So I managed to make some of this work in core. I've got a very basic
patch ... its not what one would call complete but I want to make sure
I'm going in the right direction:
https://github.com/kbarber/puppet/commit/74d32f3d8c565567faf23f90bbd828f8528539bb
So there are three sides to this ... the
13 matches
Mail list logo
