Re: [Puppet-dev] Re: [Puppet Users] ANNOUNCE: Puppet Dashboard 1.2rc3 available

2011-07-28 Thread Nick Lewis
On Thu, Jul 28, 2011 at 11:34 PM, David Schmitt wrote: > I tried to login to redmine with openid, but just got an "internal error". > > Here's the report: > > When having unresolved parameter collisions in the dashboard, > lib/node_group_graph throws and error: > >> ActionView::TemplateError (unde

[Puppet-dev] Re: Redmine upgrade

2011-07-28 Thread Ben Hughes
On Wed, Jul 27, 2011 at 11:55:16AM -0700, Ben Hughes wrote: > It should be swift, and probably, no one will even notice. Let us all just pretend that was the case... If anyone is seeing anything out of sorts, please give me a shout (or, if you still can, raise a ticket). Thanks. -- Ben Hughes

Re: [Puppet-dev] Re: [Puppet Users] ANNOUNCE: Puppet Dashboard 1.2rc3 available

2011-07-28 Thread David Schmitt
I tried to login to redmine with openid, but just got an "internal error". Here's the report: When having unresolved parameter collisions in the dashboard, lib/node_group_graph throws and error: ActionView::TemplateError (undefined method `first' for #}>) on line #4 of app/views/shared/_para

Re: [Puppet-dev] Re: [Puppet Users] ANNOUNCE: Puppet Dashboard 1.2rc3 available

2011-07-28 Thread Matt Robinson
Good catch, I've gone ahead and swapped the column order and merged the change, so we should be ready for another RC tomorrow unless anyone finds more issues. On Thu, Jul 28, 2011 at 4:51 PM, Daniel Hogland wrote: > Another bug that might want to be fixed (quick fix i'm sure) before cutting > a n

[Puppet-dev] Re: [Puppet Users] ANNOUNCE: Puppet Dashboard 1.2rc3 available

2011-07-28 Thread Daniel Hogland
Another bug that might want to be fixed (quick fix i'm sure) before cutting a new rc is 8691. Dan On Thu, Jul 28, 2011 at 4:38 PM, Matt Robinson wrote: > A race condition issue has been found with DelayedJob report > processing. The fix has been committed to the rc branch, so another > RC will

[Puppet-dev] Re: [Puppet Users] ANNOUNCE: Puppet Dashboard 1.2rc3 available

2011-07-28 Thread Matt Robinson
A race condition issue has been found with DelayedJob report processing. The fix has been committed to the rc branch, so another RC will be necessary. Ticket #8686 commit:e86526f224058d8d049b2f8b93d5fdca57332ad8 On Fri, Jul 22, 2011 at 4:18 PM, Michael Stahnke wrote: > This a feature release ca

[Puppet-dev] [PATCH/puppet-dashboard 2/2] Provide clearer error message when report host, kind and time are not unique

2011-07-28 Thread Matt Robinson
The previous error was just: Host has already been taken The problem is that host by itself isn't unique, but the error message would lead you to believe it is. Instead, mention that the host, kind, time combo needs to be unique. Paired-with: Jacob Helwig Signed-off-by: Matt Robinson ---

[Puppet-dev] [PATCH/puppet-dashboard 1/2] (#8686) Handle concurrent DelayedJob workers importing for same node

2011-07-28 Thread Matt Robinson
If you didn't have any delayed job workers and submitted multiple reports for the same node, when you started multiple workers they would each try to create the same node. There was no database constraint to prevent this, and Rails validation was worthless since the workers were running their own

[Puppet-dev] [PATCH/puppet 1/1] (#8663) Disable spec tests for unsupported functionality on Windows

2011-07-28 Thread Josh Cooper
The mount, shell, and ssh_authorized_key types are not supported on Windows, so these spec tests have been disabled when running on Windows. One of the compiler spec tests fails on Windows because Puppet::Util.execute attempts to execute a program named "git rev-parse HEAD". This has different sem

[Puppet-dev] [PATCH/puppet 1/1] (Maint.) Disable cleaning of storeconfigs.

2011-07-28 Thread Pieter van de Bruggen
This feature (and the corresponding tests) were causing intermittent failures which we were unable to trace. We will reintroduce this behavior when we can do so without test fragility. Reviewed-By: Matt Robinson Signed-off-by: Pieter van de Bruggen --- Local-branch: tickets/2.7.x/1886 lib/pupp

Re: [Puppet-dev] Re: Debugging Puppet on Windows

2011-07-28 Thread Josh Cooper
On Thu, Jul 28, 2011 at 12:34 PM, Nan Liu wrote: > On Thu, Jul 28, 2011 at 2:24 PM, Josh Cooper wrote: > > On Mar 18, 12:20 pm, Markus Roberts wrote: > >> On Fri, Mar 18, 2011 at 12:07 PM, Jay Flowers > wrote: > >> > I finally got some more time to work on this. I ended up getting > RubyMine

[Puppet-dev] [PATCH/puppet 1/1] (Maint.) Fix spec failures related to leaking state.

2011-07-28 Thread Pieter van de Bruggen
The `node clean` code has introduced a systematic change in state which is not uniformly protected against by the tests. As these order dependent failures arise, we should refactor the tests to be more robust. Reviewed-By: Matt Robinson Signed-off-by: Pieter van de Bruggen --- Local-branch: tic

[Puppet-dev] [PATCH/puppet 1/2] Fix #1886 - Add node cleanup capability

2011-07-28 Thread Pieter van de Bruggen
From: Peter Meier Here is a changeset that adds a new action to the puppet node face. This application removes all traces of a node on the puppetmaster (including certs, cached facts and nodes, reports, and storedconfig entries). Furthermore it is capable of unexporting exported resources of a

[Puppet-dev] [PATCH/puppet 2/2] (#1886) Clean up `node clean` for merge.

2011-07-28 Thread Pieter van de Bruggen
This includes various style changes, and assorted fixes to testing. Paired-With: Matt Robinson Signed-off-by: Pieter van de Bruggen --- Local-branch: feature/2.7.x/1886 lib/puppet/face/ca.rb | 30 +++--- lib/puppet/face/node/clean.rb | 111 ++--

Re: [Puppet-dev] Re: Debugging Puppet on Windows

2011-07-28 Thread Nan Liu
On Thu, Jul 28, 2011 at 2:24 PM, Josh Cooper wrote: > On Mar 18, 12:20 pm, Markus Roberts wrote: >> On Fri, Mar 18, 2011 at 12:07 PM, Jay Flowers wrote: >> > I finally got some more time to work on this.  I ended up getting RubyMine >> > setup and configured for me to develop and debug with. >>

Re: [Puppet-dev] Re: Debugging Puppet on Windows

2011-07-28 Thread Pieter van de Bruggen
Sounds right to me. +1 On Thu, Jul 28, 2011 at 11:24 AM, Josh Cooper wrote: > On Mar 18, 12:20 pm, Markus Roberts wrote: > > On Fri, Mar 18, 2011 at 12:07 PM, Jay Flowers > wrote: > > > I finally got some more time to work on this. I ended up getting > RubyMine > > > setup and configured for

[Puppet-dev] Re: Debugging Puppet on Windows

2011-07-28 Thread Josh Cooper
On Mar 18, 12:20 pm, Markus Roberts wrote: > On Fri, Mar 18, 2011 at 12:07 PM, Jay Flowers wrote: > > I finally got some more time to work on this.  I ended up getting RubyMine > > setup and configured for me to develop and debug with. > > > I logged a bug on this: > >https://projects.puppetlabs.