[Puppet-dev] (puppetlabs/puppet) Maint: Escape command in regexp

2012-04-18 Thread wearetherobots
On Thu Apr 19 06:34:48 UTC 2012 pull request #686 was closed. Maint: Escape command in regexp requested by (joshcooper) The pull request was merged by: jeffweiss -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. T

[Puppet-dev] (puppetlabs/puppet) Maint: Escape command in regexp

2012-04-18 Thread wearetherobots
Please review pull request #686: Maint: Escape command in regexp opened by (joshcooper) Description: On 64-bit Windows, the directory for 32-bit applications contains parentheses: C:/Program Files (x86). The test was using this in a regexp comparison and failing because t

[Puppet-dev] (puppetlabs/puppet) (#13898) Fail Face on option clash

2012-04-18 Thread wearetherobots
On Thu Apr 19 05:44:49 UTC 2012 pull request #685 was closed. (#13898) Fail Face on option clash requested by (jeffweiss) -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send email to puppet-d

[Puppet-dev] (puppetlabs/puppet) Implement Array#drop for Ruby 1.8.5

2012-04-18 Thread wearetherobots
Please review pull request #684: Implement Array#drop for Ruby 1.8.5 opened by (daniel-pittman) Description: This is a great convenience method, and people keep wanting to use it, so we may as well have a cheap, portable implementation to keep it working. Signed-off-by:

[Puppet-dev] (puppetlabs/puppet) Add ability to log spec test order to a file

2012-04-18 Thread wearetherobots
On Thu Apr 19 05:29:31 UTC 2012 pull request #676 was closed. Add ability to log spec test order to a file requested by (cprice-puppet) -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To post to this group, send ema

[Puppet-dev] (puppetlabs/puppet) (#14036) Handle upstart better

2012-04-18 Thread wearetherobots
On Thu Apr 19 05:20:08 UTC 2012 pull request #681 was closed. (#14036) Handle upstart better requested by (jeffweiss) The pull request was merged by: daniel-pittman -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group

[Puppet-dev] (puppetlabs/puppet) master - Windows and Ruby

2012-04-18 Thread wearetherobots
On Thu Apr 19 05:00:40 UTC 2012 pull request #648 was closed. master - Windows and Ruby requested by (daniel-pittman) The pull request was merged by: joshcooper -- You received this message because you are subscribed to the Google Groups "Puppet Developers" group. To

[Puppet-dev] (puppetlabs/puppet) (#13898) Fail Face when option collides w/ setting

2012-04-18 Thread wearetherobots
On Thu Apr 19 05:08:07 UTC 2012 pull request #679 was closed. (#13898) Fail Face when option collides w/ setting requested by (jeffweiss) The pull request was merged by: daniel-pittman -- You received this message because you are subscribed to the Google Groups "Pupp

[Puppet-dev] (puppetlabs/puppet) Bug #13284 - missing env vars during provider command execution

2012-04-18 Thread wearetherobots
On Thu Apr 19 02:28:31 UTC 2012 pull request #606 was closed. Bug #13284 - missing env vars during provider command execution requested by (zaphod42) The pull request was merged by: daniel-pittman -- You received this message because you are subscribed to the Google

[Puppet-dev] (puppetlabs/puppet) (#13435) Change default signing digest algorithm

2012-04-18 Thread wearetherobots
On Thu Apr 19 00:31:47 UTC 2012 pull request #616 was closed. (#13435) Change default signing digest algorithm requested by (jeffweiss) The pull request was merged by: daniel-pittman -- You received this message because you are subscribed to the Google Groups "Puppet

[Puppet-dev] (puppetlabs/puppet) Fix Bug #14055 windows: normalize non-zero but successful MSI exit codes

2012-04-18 Thread wearetherobots
Please review pull request #683: Fix Bug #14055 windows: normalize non-zero but successful MSI exit codes opened by (shawnl) Description: see http://msdn.microsoft.com/en-us/library/windows/desktop/aa368542%28v=vs.85%29.aspx Opened: Thu Apr 19 00:24:59 UTC 201

Re: [Puppet-dev] Changes to variable scoping in Telly

2012-04-18 Thread Jo Rhett
On Apr 18, 2012, at 4:04 PM, Andrew Parker wrote: >> On Apr 17, 2012, at 9:00 AM, Andrew Parker wrote: >>> Has anyone seen something where a manifest used $::var in order to *not* >>> get the value of $var that is overridden in a node? >> >> Uh… I use it extensively. > > Ah, interesting. Could y

[Puppet-dev] (puppetlabs/puppet) Bug/master/enc variables not overridden by node

2012-04-18 Thread wearetherobots
Please review pull request #682: Bug/master/enc variables not overridden by node opened by (zaphod42) Description: After the merge of the 2.7.x code that included the new lookup code, the fix to that caused ENC variable lookups to start behaving incorrectly. The problem w

Re: [Puppet-dev] Changes to variable scoping in Telly

2012-04-18 Thread Andrew Parker
On Apr 18, 2012, at 3:20 PM, Jo Rhett wrote: > On Apr 17, 2012, at 9:00 AM, Andrew Parker wrote: >> Has anyone seen something where a manifest used $::var in order to *not* get >> the value of $var that is overridden in a node? > > Uh… I use it extensively. Ah, interesting. Could you provide s

Re: [Puppet-dev] Changes to variable scoping in Telly

2012-04-18 Thread Jo Rhett
On Apr 17, 2012, at 9:15 AM, R.I.Pienaar wrote: > I think having a node variable merge in with top scope variables might > be acceptable in most cases - its roughly how things used to be have - but > its magical and weird and just not clear whats going on. > > Having that magical behavior support

Re: [Puppet-dev] Changes to variable scoping in Telly

2012-04-18 Thread Jo Rhett
On Apr 17, 2012, at 9:00 AM, Andrew Parker wrote: > Has anyone seen something where a manifest used $::var in order to *not* get > the value of $var that is overridden in a node? Uh… I use it extensively. >> At the moment (and under the new regime) >> >> $var = "top scope" >> node default {

[Puppet-dev] (puppetlabs/puppet) (#14036) Handle upstart better

2012-04-18 Thread wearetherobots
Please review pull request #681: (#14036) Handle upstart better opened by (jeffweiss) Description: Change the upstart provider to better handle the mix of some services that are upstart controlled and some that are init script controlled. Make the upstart provider the def

[Puppet-dev] (puppetlabs/puppet-acceptance) (maint) full precise support in testing

2012-04-18 Thread wearetherobots
On Wed Apr 18 18:18:09 UTC 2012 pull request #195 was closed. (maint) full precise support in testing requested by (justinstoller) The pull request was merged by: haus -- You received this message because you are subscribed to the Google Groups "Puppet Developers" gr

Re: [Puppet-dev] Changes to variable scoping in Telly

2012-04-18 Thread Eric Sorenson
On Apr 18, 2012, at 10:49 AM, Andrew Parker wrote: > Is there something that you could point me to in order to understand what are > considered the pitfalls of the language, a promoted style that is considered > effective, and when leaving that style might be appropriate (I'm thinking > about s

Re: [Puppet-dev] Changes to variable scoping in Telly

2012-04-18 Thread R.I.Pienaar
- Original Message - > From: "Andrew Parker" > To: puppet-dev@googlegroups.com > Sent: Wednesday, April 18, 2012 6:49:02 PM > Subject: Re: [Puppet-dev] Changes to variable scoping in Telly > > > On Apr 18, 2012, at 8:47 AM, R.I.Pienaar wrote: > > > Puppet is pretty frustrating, withou

Re: [Puppet-dev] Changes to variable scoping in Telly

2012-04-18 Thread Andrew Parker
On Apr 18, 2012, at 8:47 AM, R.I.Pienaar wrote: > Puppet is pretty frustrating, without years of using it its just really > hard to grasp some of the problems people have with the language. A > suggestion or statement about what is "never needed" is often incorrect > coming from someone who stu

[Puppet-dev] (puppetlabs/puppet) Feature/master/3757 agent lockfiles

2012-04-18 Thread wearetherobots
Please review pull request #680: Feature/master/3757 agent lockfiles opened by (cprice-puppet) Description: These commits do the following: re-introduce agent lockfile changes that were reverted out of 2.7.12 create separate Puppet settings for each lockfile path, rathe

Re: [Puppet-dev] Changes to variable scoping in Telly

2012-04-18 Thread R.I.Pienaar
- Original Message - > From: "Randall Hansen" > To: puppet-dev@googlegroups.com > Sent: Wednesday, April 18, 2012 4:41:57 PM > Subject: Re: [Puppet-dev] Changes to variable scoping in Telly > > On Wed, Apr 18, 2012 at 12:18 AM, Ken Barber > wrote: > > > I would prefer to see a high-le

Re: [Puppet-dev] Changes to variable scoping in Telly

2012-04-18 Thread Randall Hansen
On Wed, Apr 18, 2012 at 12:18 AM, Ken Barber wrote: > I would prefer to see a high-level specification of where we want to > be in a year, two years ... let it be nutted out in > workshops/discussions ... and then develop against it. Maybe I'm > wrong, and others feel they do have a high enough p

Re: [Puppet-dev] Order dependent test failures

2012-04-18 Thread Jeff McCune
On Tue, Apr 17, 2012 at 6:47 PM, Daniel Pittman wrote: > I just bisect with `rspec spec/[a-m]* spec/my/failing_spec.rb`, and > then narrow it down that way. The script is a faster way to do that. > > I never found debugger inspection very useful compared to bisection > because the source is often

Re: [Puppet-dev] Changes to variable scoping in Telly

2012-04-18 Thread R.I.Pienaar
- Original Message - > From: "Andrew Parker" > To: puppet-dev@googlegroups.com > Sent: Wednesday, April 18, 2012 1:34:14 AM > Subject: Re: [Puppet-dev] Changes to variable scoping in Telly > > So the decision is that we are going to leave the $::var vs. $var > issue as it currently stan

Re: [Puppet-dev] Changes to variable scoping in Telly

2012-04-18 Thread Ken Barber
>From my perspective I always kind of feel like we lack a bigger goal to aim for when we discuss these items - and therefore these incremental changes are myopic in nature - they focus on fixing one issue but I fear without a bigger picture plan anything incremental could be dangerous. I've mention