Re: [Puppet-dev] ensure property is always retrieve, even if useless

2015-07-22 Thread DEGREMONT Aurelien
Hi, +1 I really like this approach of this problem. I think Felix's original patch is much better than what I did years ago. It fixes the problem without the regression I had introduced. Patch seems really clean and as all Puppet tests are passing without problem I'm really confident in this p

Re: [Puppet-dev] Non-breaking changes and puppet 3.7.x

2014-12-05 Thread DEGREMONT Aurelien
Le 04/12/2014 22:24, Kylo Ginsberg a écrit : So Charlie, Spencer, Eric0 and I just had a quick convo on #puppet-dev about where non-breaking changes to puppet should land, given that the transition to puppet 4 will take a while for many sites. The tldr was the proposal that: * non-breaking ch

Re: [Puppet-dev] ensure property is always retrieve, even if useless

2013-12-20 Thread DEGREMONT Aurelien
Le 20/12/2013 16:03, Felix Frank a écrit : On 12/20/2013 03:41 PM, DEGREMONT Aurelien wrote: Assuming this patch is clean/adapted, is this something Puppet could accept? or there is still other problems? I can't really give a well founded comment on this. I like Jeff's approach in s

Re: [Puppet-dev] ensure property is always retrieve, even if useless

2013-12-20 Thread DEGREMONT Aurelien
Le 19/12/2013 23:39, Jeff Bachtel a écrit : In the end, even just the behavior change to "puppet resource" makes the patch a non-starter because it is a widely used feature. I understand this feature should be kept, but that a pity this should impact other even more useful feature like "appl

Re: [Puppet-dev] ensure property is always retrieve, even if useless

2013-12-19 Thread DEGREMONT Aurelien
Le 19/12/2013 18:06, Andy Parker a écrit : I took a quick look and I think the resource type is fine. However, since this patch means that we never retrieve the ensure value of the instance the logic around checking how to manage parameters (https://github.com/puppetlabs/puppet/blob/master/li

Re: [Puppet-dev] Perf improvement

2013-12-19 Thread DEGREMONT Aurelien
ing to sort out those implications/complications/drawbacks in that thread. Are you able to view that conversation? I did view those e-mails and I'm reading them attentively. I'm eagerly waiting for the conclusion :) Aurélien On Thu, Dec 19, 2013 at 3:14 AM, DE

Re: [Puppet-dev] Perf improvement

2013-12-19 Thread DEGREMONT Aurelien
while to reach a consensus about accepting it upstream, because it changes behavior pretty deep inside the very core of puppet, and the possible implications must be weighed carefully. Cheers, Felix On 12/19/2013 12:02 PM, DEGREMONT Aurelien wrote: Nobody cares? This is a performance improvement

Re: [Puppet-dev] Perf improvement

2013-12-19 Thread DEGREMONT Aurelien
Nobody cares? This is a performance improvement which seems harmless. Aurélien Le 17/12/2013 16:42, DEGREMONT Aurelien a écrit : Hello Working on upgrading from 0.25 to 3.x, I faced a regression regarding Service ensure behavior. In 0.25, this code, on a RedHat system: service { '

[Puppet-dev] ensure property is always retrieve, even if useless

2013-12-17 Thread DEGREMONT Aurelien
Hello Working on upgrading from 0.25 to 3.x, I faced a regression regarding Service ensure behavior. In 0.25, this code, on a RedHat system: service { 'ntpd': enable => false, hasstatus => true; } would trigger: /sbin/chkconfig ntpd and NO: service ntpd status Starting from 2.6 a

Re: [Puppet-dev] #8433 Globbing imports are now considered undefined behavior

2013-10-30 Thread DEGREMONT Aurelien
Le 24/10/2013 21:05, John Bollinger a écrit : At present, if the autoloader looks for my_module::foo::bar in my_module/manifests/foo.pp then I don't think it matters whether class my_module::foo::bar is expressed in nested or unnested form. I could not reproduce this behaviour with 2.6 I mea

Re: [Puppet-dev] #8433 Globbing imports are now considered undefined behavior

2013-10-29 Thread DEGREMONT Aurelien
Le 24/10/2013 21:05, John Bollinger a écrit : On Thursday, October 24, 2013 10:39:22 AM UTC-5, Adrien Thebo wrote: On Thu, Oct 24, 2013 at 12:54 AM, DEGREMONT Aurelien > wrote: Le 23/10/2013 17:41, Peter Meier a écrit : -BEGIN PGP SIGNED MESS

Re: [Puppet-dev] #8433 Globbing imports are now considered undefined behavior

2013-10-24 Thread DEGREMONT Aurelien
Le 23/10/2013 17:41, Peter Meier a écrit : -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 It seems that now the recommendation is to have one file per class? Yes it is. :/ Module manifests will be much more complex with a lot of files in it. If no, where puppet will look for foo::a::b class,

Re: [Puppet-dev] #8433 Globbing imports are now considered undefined behavior

2013-10-23 Thread DEGREMONT Aurelien
Thanks a lot. This was exactly what I was looking for. It seems that now the recommendation is to have one file per class? If no, where puppet will look for foo::a::b class, (aside from module/foo/manifest/a/b.pp)? Aurélien Le 23/10/2013 16:29, Peter Meier a écrit : -BEGIN PGP SIGNED M

[Puppet-dev] #8433 Globbing imports are now considered undefined behavior

2013-10-23 Thread DEGREMONT Aurelien
Hi all I'm currently working on upgrading our old 0.25 puppet infrasctructure to something more up to date. I've just faced the issue detailled in: https://projects.puppetlabs.com/issues/8433 Regarding automatic import and import "*.pp" behavior change. I'm trying to find an official documen

Re: [Puppet-dev] Various compiler performance patches

2012-07-09 Thread DEGREMONT Aurelien
Le 06/07/2012 20:29, Brice Figureau a écrit : The counterpart is that your compilation will now take ages (ie you'll have to compute those checksums during compilation). Your clients might timeout. That's how static compiler works. I agree that more computation should be done at catalog compilat

Re: [Puppet-dev] Various compiler performance patches

2012-07-06 Thread DEGREMONT Aurelien
Le 06/07/2012 18:27, Luke Kanies a écrit : On Jul 6, 2012, at 9:24 AM, DEGREMONT Aurelien wrote: Le 06/07/2012 18:07, Luke Kanies a écrit : On Jul 6, 2012, at 1:40 AM, DEGREMONT Aurelien wrote: Le 05/07/2012 19:00, Daniel Pittman a écrit : That would ... probably not show a lot of short

Re: [Puppet-dev] Various compiler performance patches

2012-07-06 Thread DEGREMONT Aurelien
Le 06/07/2012 18:07, Luke Kanies a écrit : On Jul 6, 2012, at 1:40 AM, DEGREMONT Aurelien wrote: Le 05/07/2012 19:00, Daniel Pittman a écrit : That would ... probably not show a lot of short-term performance gain for you. The static compiler, We tested (and proposed some fixes (pull

Re: [Puppet-dev] Various compiler performance patches

2012-07-06 Thread DEGREMONT Aurelien
Le 05/07/2012 19:00, Daniel Pittman a écrit : That would ... probably not show a lot of short-term performance gain for you. The static compiler, We tested (and proposed some fixes (pull request #769)) and that looks interesting but static compiler as some bad side effect which are removing s

Re: [Puppet-dev] Various compiler performance patches

2012-07-05 Thread DEGREMONT Aurelien
Le 05/07/2012 18:56, Luke Kanies a écrit : I agree that parallelization might make a big difference, but it has the chance to be a world of hurt, too. Threading in general is hard, threading in ruby is ridiculous, and threading around operations on the system whose interactions you can't pred

Re: [Puppet-dev] Various compiler performance patches

2012-07-05 Thread DEGREMONT Aurelien
Le 04/07/2012 19:29, Brice Figureau a écrit : Fixing #2198 [1] would be a very good start, then parallelize non-dependent sub-trees. In a word, that's not easy. I know that's would the *true* way to speed up puppet agent. But, as you said, I think this is far from trivial. But I do not enough of

Re: [Puppet-dev] Various compiler performance patches

2012-07-04 Thread DEGREMONT Aurelien
Le 04/07/2012 13:06, Brice Figureau a écrit : Well, you could try those on your (test) cluster and report back what it gave (only the master needs to be actually updated) :) We did and it works fine, but, as you said, this is our test cluster and it is not so representative. And all your expla

Re: [Puppet-dev] Various compiler performance patches

2012-07-04 Thread DEGREMONT Aurelien
Le 03/07/2012 17:16, Ken Barber a écrit : +3 your my new personal hero Brice :-). On Tue, Jul 3, 2012 at 4:10 PM, James Turnbull wrote: Nigel Kersten wrote: You're awesome Brice. :) +2! James If everybody is so exited with those patches, could we expected to see them integrated in 2.7.x

Re: [Puppet-dev] Trying to isolate performance issues with config retrieval.

2012-05-10 Thread DEGREMONT Aurelien
Daniel Pittman a écrit : It would be great to improve that, from our point of view, but I wonder a bit: when is this a killer problem for everyone? We are using puppet only interactively, on command line. When writing your manifests, you can try to apply your freshly written module a coupl