Re: [Puppet-dev] [PATCH/puppet 1/1] (#4835) Fixes spurious changes when managing group membership on OS X

2011-04-13 Thread Stefan Schulte
On Wed, Apr 13, 2011 at 03:46:29PM -0700, Nigel Kersten wrote: > On Wed, Apr 13, 2011 at 3:41 PM, Stefan Schulte > wrote: > > On Wed, Apr 13, 2011 at 10:50:58AM -0700, Nigel Kersten wrote: > >> On Wed, Apr 13, 2011 at 2:41 AM, Stefan Schulte > >> wrote: > >> > On Tue, Apr 12, 2011 at 07:32:49PM -

Re: [Puppet-dev] [PATCH/puppet 1/1] (#4835) Fixes spurious changes when managing group membership on OS X

2011-04-13 Thread Nigel Kersten
On Wed, Apr 13, 2011 at 3:41 PM, Stefan Schulte wrote: > On Wed, Apr 13, 2011 at 10:50:58AM -0700, Nigel Kersten wrote: >> On Wed, Apr 13, 2011 at 2:41 AM, Stefan Schulte >> wrote: >> > On Tue, Apr 12, 2011 at 07:32:49PM -0700, Nigel Kersten wrote: >> >>   Unless you happened to have members adde

Re: [Puppet-dev] [PATCH/puppet 1/1] (#4835) Fixes spurious changes when managing group membership on OS X

2011-04-13 Thread Stefan Schulte
On Wed, Apr 13, 2011 at 10:50:58AM -0700, Nigel Kersten wrote: > On Wed, Apr 13, 2011 at 2:41 AM, Stefan Schulte > wrote: > > On Tue, Apr 12, 2011 at 07:32:49PM -0700, Nigel Kersten wrote: > >>   Unless you happened to have members added to a group in exactly the > >> same order as they appear in

Re: [Puppet-dev] [PATCH/puppet 1/1] (#4835) Fixes spurious changes when managing group membership on OS X

2011-04-13 Thread Nigel Kersten
On Wed, Apr 13, 2011 at 2:41 AM, Stefan Schulte wrote: > I havent looked at the code but wouln't it be possible to use > Puppet::Property::List for the member property? Like the group > property in the user type. This property class than should do the > sorting for us (and I think we can drop the

Re: [Puppet-dev] [PATCH/puppet 1/1] (#4835) Fixes spurious changes when managing group membership on OS X

2011-04-13 Thread Nigel Kersten
On Wed, Apr 13, 2011 at 2:41 AM, Stefan Schulte wrote: > On Tue, Apr 12, 2011 at 07:32:49PM -0700, Nigel Kersten wrote: >>   Unless you happened to have members added to a group in exactly the >> same order as they appear in your puppet manifests, Puppet considered >> the 'is' and 'should' values

Re: [Puppet-dev] [PATCH/puppet 1/1] (#4835) Fixes spurious changes when managing group membership on OS X

2011-04-13 Thread Stefan Schulte
On Tue, Apr 12, 2011 at 07:32:49PM -0700, Nigel Kersten wrote: > Unless you happened to have members added to a group in exactly the > same order as they appear in your puppet manifests, Puppet considered > the 'is' and 'should' values to be out of sync due to ordering differences > between the a

Re: [Puppet-dev] [PATCH/puppet 1/1] (#4835) Fixes spurious changes when managing group membership on OS X

2011-04-12 Thread Daniel Pittman
On Tue, Apr 12, 2011 at 19:34, Nigel Kersten wrote: > On Tue, Apr 12, 2011 at 7:32 PM, Nigel Kersten wrote: >>  Unless you happened to have members added to a group in exactly the >> same order as they appear in your puppet manifests, Puppet considered >> the 'is' and 'should' values to be out of

Re: [Puppet-dev] [PATCH/puppet 1/1] (#4835) Fixes spurious changes when managing group membership on OS X

2011-04-12 Thread Nigel Kersten
On Tue, Apr 12, 2011 at 7:32 PM, Nigel Kersten wrote: >  Unless you happened to have members added to a group in exactly the > same order as they appear in your puppet manifests, Puppet considered > the 'is' and 'should' values to be out of sync due to ordering differences > between the arrays. >

[Puppet-dev] [PATCH/puppet 1/1] (#4835) Fixes spurious changes when managing group membership on OS X

2011-04-12 Thread Nigel Kersten
Unless you happened to have members added to a group in exactly the same order as they appear in your puppet manifests, Puppet considered the 'is' and 'should' values to be out of sync due to ordering differences between the arrays. The fix came in two small parts. a) Make the DirectoryServ