Re: [Puppet-dev] NTP & puppetlabs_spec_helper & hiera oh my ...

2012-05-14 Thread Chris Price
I think it belongs in puppet/blah/TestHelper.rb. This way the individual version of puppet that has the dependency is specifying it and initializing it... puppetlabs_spec_helper doesn't need to know anything about it. It's only job is to say "Hey, puppet! Do whatever it is that you need to do to

Re: [Puppet-dev] NTP & puppetlabs_spec_helper & hiera oh my ...

2012-05-14 Thread Jeff McCune
On Mon, May 14, 2012 at 9:41 AM, Daniel Pittman wrote: > > My question here is - where should this be fixed now? > > This should be fixed in your code: Hiera is a mandatory component with > the release of Telly, and disabling it for your tests is absolutely > wrong. > It seems like the puppetlabs

Re: [Puppet-dev] NTP & puppetlabs_spec_helper & hiera oh my ...

2012-05-14 Thread Ken Barber
Can I get someone to merge the updated pull request to hopefully at least fix ntp for everything but Puppet master? I can work on the master fix separately then: https://github.com/puppetlabs/puppetlabs-ntp/pull/17 This way (hopefully) I at least get one problem out of the way, before diving into

Re: [Puppet-dev] NTP & puppetlabs_spec_helper & hiera oh my ...

2012-05-14 Thread Justin Stoller
Just at a high level, this is essentially an issue with confusion around our Test Setup helpers and dependency resolution across multiple versions of our product. If we have this issue, our community certainly does as well. When looking for solutions (from best to worst): 1. Curated TestHelpers an

Re: [Puppet-dev] NTP & puppetlabs_spec_helper & hiera oh my ...

2012-05-14 Thread Chris Price
On Mon, May 14, 2012 at 6:19 AM, Ken Barber wrote: > > So when I roll back to c9386b541e9ecf6c0daffde2825bad385ea4da2b I'm > all good again. I've put in a work-around: > > c.before :each do >Puppet[:data_binding_terminus] = 'none' > end > > Which works smashingly ... but its a workaround, a

Re: [Puppet-dev] NTP & puppetlabs_spec_helper & hiera oh my ...

2012-05-14 Thread Ken Barber
Hrm. You are right, with that in mind I'll work to that end and see what I come up with and talk some more on this thread: since its going to affect all rspec-puppet tested projects. On Mon, May 14, 2012 at 5:41 PM, Daniel Pittman wrote: > On Mon, May 14, 2012 at 6:19 AM, Ken Barber wrote: > >>

Re: [Puppet-dev] NTP & puppetlabs_spec_helper & hiera oh my ...

2012-05-14 Thread Daniel Pittman
On Mon, May 14, 2012 at 6:19 AM, Ken Barber wrote: > So I took on this bug this morning, which I'd been meaning to work on > for quite some time: > > http://projects.puppetlabs.com/issues/11156 > > But hit some snags when it came to testing on master. Here is my patch: > > https://github.com/kbar

[Puppet-dev] NTP & puppetlabs_spec_helper & hiera oh my ...

2012-05-14 Thread Ken Barber
So I took on this bug this morning, which I'd been meaning to work on for quite some time: http://projects.puppetlabs.com/issues/11156 But hit some snags when it came to testing on master. Here is my patch: https://github.com/kbarber/puppetlabs-ntp/commit/e96894fd8c3a308f1a68d4a5466a2795c0eba6ad