[pve-devel] applied: [PATCH v3 qemu-server] fix #4201: delete cloud-init disk on rollback

2022-11-11 Thread Thomas Lamprecht
Am 11/11/2022 um 16:46 schrieb Mira Limbeck: > If the config doesn't contain the cloud-init disk anymore after the > rollback, we have to clean it up since otherwise no further disk can be > attached unless the one still existing on the storage is deleted. > > Signed-off-by: Mira Limbeck >

[pve-devel] applied: [PATCH docs v2 1/2] pveum: add the "user_mgmt" reference to the documentation

2022-11-11 Thread Thomas Lamprecht
Am 11/11/2022 um 16:05 schrieb Stefan Sterz: > since this key was missing from the PVE documentation, the TFA ui's > help buttons didn't work as they relied on it. > > Signed-off-by: Stefan Sterz > --- > pveum.adoc | 3 +++ > 1 file changed, 3 insertions(+) > > applied, thanks! btw. for my

Re: [pve-devel] [PATCH docs v2 2/2] asciidoc-pve: ignore anchor names in curly braces

2022-11-11 Thread Thomas Lamprecht
Am 11/11/2022 um 16:05 schrieb Stefan Sterz: > previously the scanner would detect some `onlineHelp` keys that are > set via CBind as anchor names. this would cause it to fail, as they > cannot be present anywhere in the documentation. no valid anchor name > can be wrapped in curly braces, as they

[pve-devel] [PATCH v3 qemu-server] fix #4201: delete cloud-init disk on rollback

2022-11-11 Thread Mira Limbeck
If the config doesn't contain the cloud-init disk anymore after the rollback, we have to clean it up since otherwise no further disk can be attached unless the one still existing on the storage is deleted. Signed-off-by: Mira Limbeck Reviewed-by: Stefan Hanreich Tested-by: Stefan Hanreich ---

Re: [pve-devel] [PATCH v2 qemu-server] fix #4201: delete cloud-init disk on rollback

2022-11-11 Thread Mira Limbeck
On 11/11/22 16:18, Stefan Hanreich wrote: Test Setup: I created a new VM, without any Cloud-Init drive, and immediately created a snapshot. Then I setup a Cloud-Init drive according to the PVE documentation via CLI. I created another snapshot of this state with a Cloud-Init drive. What I

Re: [pve-devel] [PATCH v2 qemu-server] fix #4201: delete cloud-init disk on rollback

2022-11-11 Thread Stefan Hanreich
Test Setup: I created a new VM, without any Cloud-Init drive, and immediately created a snapshot. Then I setup a Cloud-Init drive according to the PVE documentation via CLI. I created another snapshot of this state with a Cloud-Init drive. What I tested: - Rolling back to the older snapshot

[pve-devel] [PATCH docs v2 0/2] pve fix help buttons by accounting for keys in widget toolkit

2022-11-11 Thread Stefan Sterz
this patch series fixes an issue where `onlineHelp` keys, that were only used by components in the widget toolkit, were not properly mapped to the corresponding anchors in the docs. this lead to affected help buttons only showing an error message. this series first fixes `pve-docs` by adding keys

[pve-devel] [PATCH docs v2 1/2] pveum: add the "user_mgmt" reference to the documentation

2022-11-11 Thread Stefan Sterz
since this key was missing from the PVE documentation, the TFA ui's help buttons didn't work as they relied on it. Signed-off-by: Stefan Sterz --- pveum.adoc | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pveum.adoc b/pveum.adoc index cbd553a..52de14d 100644 --- a/pveum.adoc +++

[pve-devel] [PATCH manager v2 1/1] fix #4328: ui: add widget toolkit to dependencies of OnlineHelpInfo.js

2022-11-11 Thread Stefan Sterz
previously the widget toolkit was not scanned when creating the mapping between `onlineHelp` keys and pve-doc anchors. this could lead to cases where help buttons didn't work because the necessary mapping wasn't present in `OnlineHelpInfo.js`. Signed-off-by: Stefan Sterz --- i took the liberty

[pve-devel] [PATCH docs v2 2/2] asciidoc-pve: ignore anchor names in curly braces

2022-11-11 Thread Stefan Sterz
previously the scanner would detect some `onlineHelp` keys that are set via CBind as anchor names. this would cause it to fail, as they cannot be present anywhere in the documentation. no valid anchor name can be wrapped in curly braces, as they need to be valid xml names. hence it should be safe

Re: [pve-devel] [PATCH docs v2 2/2] added Memory Encryption documentation

2022-11-11 Thread Matthias Heiserer
Inline, I have some suggestions regarding wording and spelling On 11.11.2022 15:27, Markus Frank wrote: added AMD SEV documentation for "[PATCH qemu-server] QEMU AMD SEV enable" Signed-off-by: Markus Frank --- qm.adoc | 113 1 file

[pve-devel] [PATCH qemu-server v2 1/2] QEMU AMD SEV enable

2022-11-11 Thread Markus Frank
This Patch is for enabling AMD SEV (Secure Encrypted Virtualization) support in QEMU and enabling future memory encryption technologies like INTEL MKTME (Multi-key Total Memory Encryption) and SEV-SNP. Config-Example: memory_encryption: type=sev,cbitpos=47,policy=0x0001,reduced-phys-bits=1

[pve-devel] [PATCH qemu-server/docs v2 0/2] AMD SEV

2022-11-11 Thread Markus Frank
qemu-server: v2: * spelling of minimum * !$conf->{bios} eq 'ovmf' changed to $conf->{bios} ne 'ovmf' Markus Frank (1): QEMU AMD SEV enable PVE/QemuServer.pm | 133 ++ 1 file changed, 133 insertions(+) docs: v2: * added more details for host &

[pve-devel] [PATCH docs v2 2/2] added Memory Encryption documentation

2022-11-11 Thread Markus Frank
added AMD SEV documentation for "[PATCH qemu-server] QEMU AMD SEV enable" Signed-off-by: Markus Frank --- qm.adoc | 113 1 file changed, 113 insertions(+) diff --git a/qm.adoc b/qm.adoc index e7d0c07..5ba43a2 100644 --- a/qm.adoc +++

Re: [pve-devel] [PATCH v2 pve-container/qemu-server/pve-docs] Add pre/post-restore hooks

2022-11-11 Thread Daniel Tschlatscher
On 11/11/22 15:02, Stefan Hanreich wrote: > > On 11/11/22 14:58, Daniel Tschlatscher wrote: >> The new hookscript example works nicely out of the box. >> >> I tested restore for both VMs and containers via the GUI, the restore >> and create commands in the respective CLI commands and with the

Re: [pve-devel] [PATCH v2 pve-container/qemu-server/pve-docs] Add pre/post-restore hooks

2022-11-11 Thread Stefan Hanreich
On 11/11/22 14:58, Daniel Tschlatscher wrote: The new hookscript example works nicely out of the box. I tested restore for both VMs and containers via the GUI, the restore and create commands in the respective CLI commands and with the API. One thing which might some more consideration: When

Re: [pve-devel] [PATCH v2 pve-container/qemu-server/pve-docs] Add pre/post-restore hooks

2022-11-11 Thread Daniel Tschlatscher
The new hookscript example works nicely out of the box. I tested restore for both VMs and containers via the GUI, the restore and create commands in the respective CLI commands and with the API. One thing which might some more consideration: When restoring a backup that does not configure a

Re: [pve-devel] [PATCH pve-docs 1/1] add pre/post-restore events to example hookscript

2022-11-11 Thread Daniel Tschlatscher
On 11/10/22 16:33, Stefan Hanreich wrote: > Signed-off-by: Stefan Hanreich > --- > examples/guest-example-hookscript.pl | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/examples/guest-example-hookscript.pl > b/examples/guest-example-hookscript.pl > index

Re: [pve-devel] [PATCH manager v2 1/2] fix #3719: gui: expose LXC MTU option in web UI

2022-11-11 Thread Stefan Hanreich
Tested on an Alpine Linux Container (3.16): - setting MTU > 65535 or < 576 via UI (doesn't work) - setting MTU to several values >= 576 and <= 65535 via UI (works) - setting MTU to >= 64 and < 576 via config then starting (works, but this is apparently intended otherwise it would be a backwards

Re: [pve-devel] [PATCH pve-guest-common/pve-docs 0/1]

2022-11-11 Thread Daniel Tschlatscher
The hookscripts for pre- and post- snapshot work as intended. I tested creating snapshots in the GUI and on the CLI without finding any problems. When the hookscript fails the behavior was as I would expect it: An error in 'pre-hookscript' fails the whole task. An error in the 'post-hookscript'

Re: [pve-devel] [PATCH ha-manager 09/11] manager: use static resource scheduler when configured

2022-11-11 Thread Fiona Ebner
Am 10.11.22 um 15:37 schrieb Fiona Ebner: > @@ -206,11 +207,30 @@ my $valid_service_states = { > sub recompute_online_node_usage { So I was a bit worried that recompute_online_node_usage() would become too inefficient with the new add_service_usage_to_node() overhead from needing to read the

Re: [pve-devel] [PATCH V3 qemu-server 1/3] tap_plug: add support for bridge disable learning

2022-11-11 Thread Mira Limbeck
On 11/11/22 09:36, DERUMIER, Alexandre wrote: Le mercredi 09 novembre 2022 à 15:19 +0100, Mira Limbeck a écrit : Why not add the bridge in the pve-bridge script as well? This way there would be no need for patch 2 for qemu-server since we always add the MAC address to the FDB whenever the tap

[pve-devel] applied: [PATCH V4 storage 1/3] fix #3967: enable ZFS dRAID creation via API

2022-11-11 Thread Thomas Lamprecht
Am 10/11/2022 um 14:24 schrieb Stefan Hrdlicka: > It is possible to set the number of spares and the size of > data stripes via draidspares & dreaddata parameters. > > Signed-off-by: Stefan Hrdlicka > --- > PVE/API2/Disks/ZFS.pm | 55 ++- > 1 file

Re: [pve-devel] [PATCH V3 qemu-server 1/3] tap_plug: add support for bridge disable learning

2022-11-11 Thread DERUMIER, Alexandre
Le mercredi 09 novembre 2022 à 15:19 +0100, Mira Limbeck a écrit : > > > Why not add the bridge in the pve-bridge script as well? This way > there > would be no need for patch 2 for qemu-server since we always add the > MAC > address to the FDB whenever the tap device is plugged. > > If we

[pve-devel] applied: [PATCH qemu-server] tests: add tests for various combinations of configs for usb

2022-11-11 Thread Thomas Lamprecht
Am 11/11/2022 um 07:59 schrieb Dominik Csapak: > q35 + usb passthrough > q35 + usb3 passthrough > q35 + usb3 passthrough with new xhci controller > old machine type + new usb config error > old machine type + q35 + new usb config error > old ostype (w2k) + new usb config error > > Signed-off-by: