Re: [pygame] Re: Movie module being merged

Nevermind, if you add a slight delay after the stop command in test_stop, then the tests work. I'll be committing an updated unit test later today. On Sat, Oct 3, 2009 at 9:48 AM, Tyler Laing wrote: > Yeah, I turned off the pygame.quit already. Hmm, then maybe more time is > needed to ensure th

Re: [pygame] Re: Movie module being merged

Yeah, I turned off the pygame.quit already. Hmm, then maybe more time is needed to ensure the deletion of the movie module... I fixed the issue by adding a movie.stop() and a time.sleep(1) before the del movie call. This actually fixes the mess of threads issue. Stop isn't behaving right, so I'll

Re: [pygame] Re: Movie module being merged

Hi Tyler, Tyler Laing wrote: Part of the issue is that the movie isn't cleaning up properly after itself. The threads do take a miniscule amount of time to end and clean up. After each call I've added a 1 second wait, as the movie object does not and cannot act instantaneously, but quite close

Re: [pygame] Re: Movie module being merged

Part of the issue is that the movie isn't cleaning up properly after itself. The threads do take a miniscule amount of time to end and clean up. After each call I've added a 1 second wait, as the movie object does not and cannot act instantaneously, but quite close to instantaneously. I'm also not

Re: [pygame] Re: Movie module being merged

Hmm, not seeing the same issue here Lenard, sorry. What kind of movie file are you using? (Sorry been busy with midterms and assignments. I have a free weekend now, aside from errands.) On Tue, Sep 1, 2009 at 11:25 AM, Lenard Lindstrom wrote: > Hi Tyler, > > Debian lenny, Python 2.5, > > I am ge

Re: [pygame] Re: Movie module being merged

Nevermind, now I am. On Sat, Oct 3, 2009 at 8:54 AM, Tyler Laing wrote: > Hmm, not seeing the same issue here Lenard, sorry. What kind of movie file > are you using? (Sorry been busy with midterms and assignments. I have a free > weekend now, aside from errands.) > > > On Tue, Sep 1, 2009 at 11:

Re: [pygame] Re: Movie module being merged

Hi Tyler, Debian lenny, Python 2.5, I am getting a segfault in _movie_test.py, test_resize(), movie.resize(movie.width/2, movie.height/2). The order of test method execution I get is test_height, test_init, test_play_pause, test_resize. I have modified _movie_test.py to execute as a stand-a

Re: [pygame] Re: Movie module being merged

Well, let me see... File: _gmovie.c in stream_component_start if (stream_index < 0 || stream_index >= ic->nb_streams) { if(threaded) GRABGIL Py_DECREF(movie); if(threaded) RELEASEGIL retur

Re: [pygame] Re: Movie module being merged

Thanks for the input. Could you tell me which lines you noticed this on? -Tyler On Tue, Aug 25, 2009 at 2:01 PM, Jussi Toivola wrote: > Hi, > not sure if this is related. GIL trouble anyway. Noticed this while I > was tinkering with ffmpeg for Symbian. It's probably too slow on the > phones, bu

Re: [pygame] Re: Movie module being merged

Hi, not sure if this is related. GIL trouble anyway. Noticed this while I was tinkering with ffmpeg for Symbian. It's probably too slow on the phones, but I just want to see if I get it working... Anyway, there are several lines like this one: ... if(threaded) GRABGIL ... if(threaded)

Re: [pygame] Re: Movie module being merged

"tstate mix-up". I've looked, and there are no Python calls done without having the GIL. Like I said, its an extremely weird bug. It also occurs if you do five play throughs(play(0)) sequentially. -Tyler On Fri, Aug 21, 2009 at 6:11 PM, Lenard Lindstrom wrote: > Hi, > > Is it always a "tstate m

Re: [pygame] Re: Movie module being merged

Hi, Is it always a "tstate mix-up". If so, then it is likely a threading problem. Absolutely no Python api calls should be made while the GIL is released. If not then probably a memory problem. Lenard Tyler Laing wrote: Yeah I know about that. Its because of everything that is done to the v

Re: [pygame] Re: Movie module being merged

Yeah I know about that. Its because of everything that is done to the video file in the example code. Its a very hard error to pindown. Sometimes it happens during debugging, sometimes not. It happens on various kinds of videos, so its not format dependent, and it only happens after stopping and re

Re: [pygame] Re: Movie module being merged

Hi, It builds and installs in Debian lenny now. The __movie_test.py even works for the most part, though fails at the end with this error: Unpausing... True True Stopping..., sleeping for 3 seconds Playing again... done restart play... Surface time... ValueError: surface does not have the same

Re: [pygame] Re: Movie module being merged

Fixed that, sorry. I should have done an else, but I did an endif >.> -Tyler On Thu, Aug 20, 2009 at 1:09 PM, Lenard Lindstrom wrote: > Hi Tyler, > > It is finding the headers, but now I am getting this compiler error: > > gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall > -Wstri

Re: [pygame] Re: Movie module being merged

Hi Tyler, It is finding the headers, but now I am getting this compiler error: gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -D_REENTRANT -I/usr/X11R6/include -I/usr/include/SDL -I/usr/include/ffmpeg -I/usr/include/ffmpeg -I/usr/include/SDL -I/usr/i

Re: [pygame] Re: Movie module being merged

And I've now committed a fix for throwing exceptions if the surface given has the wrong aspect ratio. -Tyler On Thu, Aug 20, 2009 at 9:46 AM, Tyler Laing wrote: > I have this fixed, with it committed in revision 2628. I have a custom > Dependency class that adds extra directories to the include

Re: [pygame] Re: Movie module being merged

I have this fixed, with it committed in revision 2628. I have a custom Dependency class that adds extra directories to the include search path(like libavformat or ffmpeg). This prevents any accidental conflict of namespaces. Let me know if this works or not. -Tyler On Tue, Aug 18, 2009 at 5:17 PM

Re: [pygame] Re: Movie module being merged

Okay, I'll do those in a couple of days. To enable multiple movie playback, I'd have to go a layer deeper and use SDL_Audio directly, as there is no way to store a void * reference to the movie object with SDL_mixer. Thanks. :) On Wed, Aug 19, 2009 at 12:49 AM, René Dudfield wrote: > On Tue, Aug

Re: [pygame] Re: Movie module being merged

On Tue, Aug 18, 2009 at 5:11 PM, Tyler Laing wrote: > It could be. That, however, increases the coupling between the sound > subsystem and the movie module. If you want me to, I will, but I would need > to consider how best to make sure the sound subsystem can be replaced on > demand. > ah, yeah.

Re: [pygame] Re: Movie module being merged

Hi, No, I don't see any Debian specific predefined compiler macros. ffmpeg library information is available through pkg-config. Lenard Tyler Laing wrote: Does debian have a unique compile time flag I can use? -Tyler On Tue, Aug 18, 2009 at 12:09 PM, Lenard Lindstrom

Re: [pygame] Re: Movie module being merged

Does debian have a unique compile time flag I can use? -Tyler On Tue, Aug 18, 2009 at 12:09 PM, Lenard Lindstrom wrote: > Hi Tyler, > > /usr/include is included in the default header search paths. What is > installed is /usr/include/ffmpeg/avformat.h, not > /usr/include/ffmpeg/libavformat/avfor

Re: [pygame] Re: Movie module being merged

Hi Tyler, /usr/include is included in the default header search paths. What is installed is /usr/include/ffmpeg/avformat.h, not /usr/include/ffmpeg/libavformat/avformat.h. This may be a quirk of the Debian dev package and not the general case. Lenard Tyler Laing wrote: You don't have -l/usr

Re: [pygame] Re: Movie module being merged

You don't have -l/usr/include actually. What I will do is add to the directories searched, for the specific libraries to search in /usr/include/ffmpeg && /usr/include/ for if people install from source. Does that sound like a good solution? -Tyler On Tue, Aug 18, 2009 at 9:03 AM, Lenard Lindstrom

Re: [pygame] Re: Movie module being merged

It could be. That, however, increases the coupling between the sound subsystem and the movie module. If you want me to, I will, but I would need to consider how best to make sure the sound subsystem can be replaced on demand. And then for separate movie screens, it would be entirely possible if yo

Re: [pygame] Re: Movie module being merged

Ok, when I add _movie src/_gsound.c src/_gmovie.c src/_gcommand.c src/gmovie.c $(SDL) $(AVFORMAT) $(SWSCALE) $(MIXER) $(DEBUG) to Setup I get these build errors: building 'pygame._movie' extension gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -D_RE

Re: [pygame] Re: Movie module being merged

Hi René, My mistake. I didn't pay attention to the error. _movie.so was not event built since the _movie entry is missing in Setup.in. I had to manually enter it to Setup the last time, and that was clobbered when I reran config.py. Lenard René Dudfield wrote: On Tue, Aug 18, 2009 at 4:47

Re: [pygame] Re: Movie module being merged

On Tue, Aug 18, 2009 at 4:22 PM, Tyler Laing wrote: > Running at the same time? No. Unless there is a way to have multiple > separate SDL screens. Even then, it will be an issue as there is a global > struct used to record info in the sound module. Otherwise, everything else > can be instantiated p

Re: [pygame] Re: Movie module being merged

On Tue, Aug 18, 2009 at 4:47 PM, Lenard Lindstrom wrote: > Hi Tyler, > > The module now builds, but the _movie_test.py unit tests fail: > > ERROR: MovieTypeTest.test_height > -- > Traceback (most recent call last): >  File > "/home

Re: [pygame] Re: Movie module being merged

Hi Tyler, The module now builds, but the _movie_test.py unit tests fail: ERROR: MovieTypeTest.test_height -- Traceback (most recent call last): File "/home/lenard/.local/lib/python2.5/site-packages/pygame/tests/_movie_test.py"

Re: [pygame] Re: Movie module being merged

Running at the same time? No. Unless there is a way to have multiple separate SDL screens. Even then, it will be an issue as there is a global struct used to record info in the sound module. Otherwise, everything else can be instantiated per movie. -Tyler On Tue, Aug 18, 2009 at 7:55 AM, René Dud

Re: [pygame] Re: Movie module being merged

On Tue, Aug 18, 2009 at 3:41 PM, Tyler Laing wrote: > Thanks Rene, Lenard. I've committed a fix for the compile issues you sent me > lenard, it should work now, but let me know if it doesn't. > > Rene, is the movie test set to interactive? > > -Tyler Hi, I moved __movie_test.py into examples/ sin

Re: [pygame] Re: Movie module being merged

Thanks Rene, Lenard. I've committed a fix for the compile issues you sent me lenard, it should work now, but let me know if it doesn't. Rene, is the movie test set to interactive? -Tyler On Tue, Aug 18, 2009 at 3:59 AM, René Dudfield wrote: > hi, > > I made the _movie test only run on linux so

Re: [pygame] Re: Movie module being merged

hi, I made the _movie test only run on linux so far, with the test/_movie_tags.py file. Just a note if you're testing on non-linux platforms and the tests don't appear to run anymore. cheers, On Mon, Aug 17, 2009 at 11:54 PM, Tyler Laing wrote: > strange, I put in if checks around those... I'

Re: [pygame] Re: Movie module being merged

strange, I put in if checks around those... I'll fix that tomorrow. Thanks for the report Lenard. -Tyler On Mon, Aug 17, 2009 at 12:57 PM, Lenard Lindstrom wrote: > Never mind. The stable ffmpeg libraries for Debian are too outdated anyway: > > gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwr

Re: [pygame] Re: Movie module being merged

Never mind. The stable ffmpeg libraries for Debian are too outdated anyway: gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -D_REENTRANT -I/usr/X11R6/include -I/usr/include/SDL -I/usr/include/ffmpeg -I/usr/include/ffmpeg -I/usr/include/SDL -I/usr/inclu

Re: [pygame] Re: Movie module being merged

Hi Tyler, Sorry for the bad news but _movie.so fails to build under Debian lenny:building 'pygame._movie' extension gcc -pthread -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -fPIC -D_REENTRANT -I/usr/X11R6/include -I/usr/include/SDL -I/usr/include/SDL -I/usr/include/p

Re: [pygame] Re: Movie module being merged

cool bananas :)

[pygame] Re: Movie module being merged

What I forgot to say is, let me know, I will be beginning a merge at 2 pm. -Tyler On Sun, Aug 16, 2009 at 12:53 PM, Tyler Laing wrote: > I will be beginning the process of merging the movie module branch into the > main branch. > > As it stands, the ffmpeg movie backend compiles. The vlc backen