[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

2019-06-20 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: > Perhaps it would be helpful for someone to recap the current options on the > table for moving forward and the most significant risk to Cython, Projects > using Cython, or CPython by selecting each option. There are three options: (1) Status-quo (keep

[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

2019-06-20 Thread aeros167
aeros167 added the comment: Decided to start working on this issue, seems like a solid starting point. After submitting a minor doc contribution, I wanted to also attempt to contribute to some of the easier enhancement requests. >From my current assessment, it appears that

[issue37345] Add formal support for UDPLITE protococl

2019-06-20 Thread Gabe Appleton
Gabe Appleton added the comment: I just want to be explicit so I don't mess up on protocol, since I am new to this project. Does that mean that you want me to remove the helper function and put documentation in about that sockopt, or that an exception could be made in this case? --

[issue37345] Add formal support for UDPLITE protococl

2019-06-20 Thread Andrew Svetlov
Andrew Svetlov added the comment: We have no setsockopt() shortcut helpers. socket.setblocking() uses fcntl() internally. -- ___ Python tracker ___

[issue36165] DOC: ssl.rst is missing formatting on two links

2019-06-20 Thread Mariatta
Mariatta added the comment: This just needed backport to 3.7. Miss-islington is already working on it. Thanks! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue36165] DOC: ssl.rst is missing formatting on two links

2019-06-20 Thread miss-islington
Change by miss-islington : -- pull_requests: +14104 pull_request: https://github.com/python/cpython/pull/14281 ___ Python tracker ___

[issue37347] Reference-counting problem in sqlite

2019-06-20 Thread Benjamin Peterson
Benjamin Peterson added the comment: Why not use sqlite3_create_function_v2 to register a destructor for the function that does Py_DECREF and dispense with the dictionaries entirely? -- nosy: +benjamin.peterson ___ Python tracker

[issue37352] Typo in documentation: "to making it easy"

2019-06-20 Thread Mariatta
Mariatta added the comment: FWIW I agree that "with an eye to ..." sounds too complex. It would be great to change it to "with the goal of...". -- nosy: +Mariatta ___ Python tracker

[issue37352] Typo in documentation: "to making it easy"

2019-06-20 Thread Raymond Hettinger
Raymond Hettinger added the comment: It reads fine to me as is. -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

2019-06-20 Thread Carol Willing
Carol Willing added the comment: > Is four months really an unreasonable timeline? I thought most of these > packages released more frequently than CPython. I can't really predict with any accuracy what the release cycle is for most scientific projects. Anywhere from 1 month to 9 months

[issue37352] Typo in documentation: "to making it easy"

2019-06-20 Thread YoSTEALTH
YoSTEALTH added the comment: programmers "plan" their code, they don't "design" it, as far as i know! -- ___ Python tracker ___

[issue36511] Add Windows ARM32 buildbot

2019-06-20 Thread Paul Monson
Change by Paul Monson : -- pull_requests: +14103 pull_request: https://github.com/python/cpython/pull/14280 ___ Python tracker ___

[issue24772] Smaller viewport shifts the "expand left menu" character into the text

2019-06-20 Thread karl
karl added the comment: I'm at Mozilla All Hands this week. I'll check if my solution still makes sense next week and will make a pull request and/or propose another solution. Thanks for the reminder. adding to my calendar. -- ___ Python tracker

[issue37356] Name of 64-bit OpenSSL v1.1.1 DLLs

2019-06-20 Thread Steve Dower
Steve Dower added the comment: Yes, I noticed that they changed with OpenSSL 1.1.1a, but as far as I can tell we didn't do anything to cause that - our build definition is still the same, and uses "perl Configure VC-WIN64A-masm && nmake". Is this causing issues? Or is it just something that

[issue37349] venv.EnvBuilder environmental variable hooks

2019-06-20 Thread Caleb Donovick
Caleb Donovick added the comment: I have another idea, instead of baking in the semantics of the environmental variables, we could simply add the hooks __VENV_ACTIVATE_EXTRAS__ and __VENV_DEACTIVATE_EXTRAS__ to activate. By default they would be replaced by '', but would allow subclasses to

[issue24214] UTF-8 incremental decoder doesn't support surrogatepass correctly

2019-06-20 Thread STINNER Victor
Change by STINNER Victor : -- resolution: fixed -> status: closed -> open ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue37356] Name of 64-bit OpenSSL v1.1.1 DLLs

2019-06-20 Thread Phil Thompson
New submission from Phil Thompson : In the 3.8b1 64-bit Windows installer the names of the OpenSSL DLLs do not have the -x64 suffix which seems to be the convention (and is the default when building OpenSSL from source). The convention is followed in the 3.7.0 to 3.7.3 installers. I haven't

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

2019-06-20 Thread Paul Moore
Paul Moore added the comment: How will this interact with EnvBuilder.install_scripts() (which explicitly states that it performs textual substitution)? Note that I'm not aware of anyone who actually uses the ability to subclass EnvBuilder, but I wouldn't be surprised to find that people

[issue37349] venv.EnvBuilder environmental variable hooks

2019-06-20 Thread Caleb Donovick
Caleb Donovick added the comment: >PowerShell has a full programming language and all details can be found in >pyvenv.cfg now as of Python 3.8. So Activate.ps1 can read that file to get >what it needs to set paths and the prompt which is what gets substituted into >the generate

[issue37349] venv.EnvBuilder environmental variable hooks

2019-06-20 Thread Vinay Sajip
Vinay Sajip added the comment: > Is there an architecture that would be less objectionable? One thing I would consider is the ability to configure a custom_script_path in the same way as other parameters are now. It would be used as follows: If not None, it should specify a directory, and

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

2019-06-20 Thread Brett Cannon
Brett Cannon added the comment: > How would you plan to replace the functionality where the venv's bin path is > substituted into the script? Purely through introspecting its own path? It's stored in pyvenv.cfg. > I presume the security requirements you refer to are purely a Windows >

[issue37349] venv.EnvBuilder environmental variable hooks

2019-06-20 Thread Brett Cannon
Brett Cannon added the comment: > I am curious how you plan to achieve this without reducing the functionality > of venv? PowerShell has a full programming language and all details can be found in pyvenv.cfg now as of Python 3.8. So Activate.ps1 can read that file to get what it needs to

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

2019-06-20 Thread Vinay Sajip
Vinay Sajip added the comment: How would you plan to replace the functionality where the venv's bin path is substituted into the script? Purely through introspecting its own path? I see that PowerShell is/will be portable to e.g. Linux environments, but I presume the security requirements

[issue36511] Add Windows ARM32 buildbot

2019-06-20 Thread Steve Dower
Steve Dower added the comment: New changeset 43615485f1222cd9a94421a96cb7110bb52e1b8b by Steve Dower in branch '3.8': bpo-36511: Improve ARM32 buildbot scripts (GH-14251) https://github.com/python/cpython/commit/43615485f1222cd9a94421a96cb7110bb52e1b8b --

[issue37289] regression in Cython when pickling objects

2019-06-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 1e61504b8b941494f3ac03e0449ddbbba8960175 by Pablo Galindo in branch 'master': bpo-37289: Add a test for if with ifexpr in the peephole optimiser to detect regressions (GH-14127)

[issue36511] Add Windows ARM32 buildbot

2019-06-20 Thread Steve Dower
Change by Steve Dower : -- pull_requests: +14102 pull_request: https://github.com/python/cpython/pull/14279 ___ Python tracker ___

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

2019-06-20 Thread Caleb Donovick
Change by Caleb Donovick : -- nosy: +donovick ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

2019-06-20 Thread Steve Dower
Steve Dower added the comment: > While Cython may be able to respond within the beta period, scientific > projects that depend on it may lag longer as rebuilds and releases will need > to happen on PyPI, conda, and conda-forge. Release versioning is critical in > the science world as we

[issue37353] Source code has not always been forward-compatible

2019-06-20 Thread Prateek Nayak
Change by Prateek Nayak : -- keywords: +patch pull_requests: +14101 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14277 ___ Python tracker ___

[issue37351] Drop libpython38.a from Windows release

2019-06-20 Thread Steve Dower
Change by Steve Dower : -- keywords: +patch pull_requests: +14100 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/14276 ___ Python tracker

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

2019-06-20 Thread Zackery Spytz
Zackery Spytz added the comment: PR 14275 converts Modules/overlapped.c. Many methods now use METH_FASTCALL. -- nosy: +ZackerySpytz ___ Python tracker ___

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

2019-06-20 Thread Carol Willing
Carol Willing added the comment: Petr, Thanks for the thoughtful summary. If I am understanding the many messages in this and the other related issue and by looking at this with a scientific Python hat on (not as the Steering Council), I'm inclined to favor Nick's approach if possible: >

[issue20179] Derby #10: Convert 50 sites to Argument Clinic across 4 files

2019-06-20 Thread Zackery Spytz
Change by Zackery Spytz : -- pull_requests: +14099 pull_request: https://github.com/python/cpython/pull/14275 ___ Python tracker ___

[issue37349] venv.EnvBuilder environmental variable hooks

2019-06-20 Thread Caleb Donovick
Caleb Donovick added the comment: > I didn't say environment variables weren't commonly used. I'm talking about > the specific functionality this issue is about. This is likely true, to most people venv is black magic. That doesn't mean that people wouldn't use it if the functionality

[issue37340] remove free_list for bound method objects

2019-06-20 Thread Josh Rosenberg
Change by Josh Rosenberg : -- nosy: +josh.r ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37353] Source code has not always been forward-compatible

2019-06-20 Thread Carol Willing
Carol Willing added the comment: "...though source code has usually been forward-compatible within a major release series." Agree with your thoughts Julien and Zach. Perhaps remove "whereas" as well. -- nosy: +willingc ___ Python tracker

[issue37352] Typo in documentation: "to making it easy"

2019-06-20 Thread Carol Willing
Carol Willing added the comment: I agree with Zach's suggestions. If I were to rewrite and pass through a grammar checker, I would get closer to this (removing the verbose "an eye to": Writing test suites is very helpful, and you might want to design your code to make it easily tested. In

[issue37355] SSLSocket.read does a GIL round-trip for every 16KB TLS record

2019-06-20 Thread Josh Snyder
New submission from Josh Snyder : Background: SSLSocket.read drops the GIL and performs exactly one successful call to OpenSSL's `SSL_read`, whose documentation states "At most the contents of one record will be returned". TLS records are at most 16KB, so high throughput (especially

[issue12782] Multiple context expressions do not support parentheses for continuation across lines

2019-06-20 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: What do you mean with re-raise? The issue is not closed. If you have some proposal to overcome the limitations, the best approach is to comment here in the issue. -- ___ Python tracker

[issue37349] venv.EnvBuilder environmental variable hooks

2019-06-20 Thread Brett Cannon
Brett Cannon added the comment: I mentioned on python-ideas and opened https://bugs.python.org/issue37354 to actually make the Activate.ps1 file static for security purposes. -- nosy: +brett.cannon ___ Python tracker

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

2019-06-20 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: If we're in doubt, we should just apply PR 14193. It's essentially a one-line patch that fixes actual problems experienced by users and which doesn't break anything. Why should we *not* apply it? I know that we're not obliged to fix anything, but that is

[issue37354] Write PowerShell Activate.ps1 to be static so it can be signed

2019-06-20 Thread Brett Cannon
New submission from Brett Cannon : If Activate.ps1 was made to not have substitutions upon generation and be an entirely static file, then the file could be signed and thus not require people to lower their security requirements in PowerShell in order to activate their virtual environments.

[issue24214] UTF-8 incremental decoder doesn't support surrogatepass correctly

2019-06-20 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: This change seems to have caused test failure reported in https://github.com/python-hyper/wsproto/issues/126 from codecs import getincrementaldecoder decoder = getincrementaldecoder("utf-8")() print(decoder.decode(b'f\xf1\xf6rd', False)) # With

[issue19982] Add a "target" parameter to runpy.run_path and runpy.run_module

2019-06-20 Thread Joannah Nanjekye
Change by Joannah Nanjekye : -- nosy: +nanjekyejoannah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37351] Drop libpython38.a from Windows release

2019-06-20 Thread Steve Dower
Steve Dower added the comment: Turns out that using distutils/setuptools with --compiler=mingw32 is just doomed to fail when it hits get_msvcr(), which has never been updated for Python 3.5 onwards. So I think it's probably safe to assume that this scenario isn't a real thing and people

[issue37251] Mocking a MagicMock with a function spec results in an AsyncMock

2019-06-20 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: > BUT I think removing the `if getattr(obj, '__code__', None)` from > `_is_async_obj` actually makes this work correctly. It is possible for a > coroutine object to not have a __code__, but I don't think it is possible for > a coroutine function

[issue37349] venv.EnvBuilder environmental variable hooks

2019-06-20 Thread Vinay Sajip
Vinay Sajip added the comment: > Common python libraries that make use of environmental variables I didn't say environment variables weren't commonly used. I'm talking about the specific functionality this issue is about. > Overriding setup scripts is hardly a trivial task. One has to

[issue37352] Typo in documentation: "to making it easy"

2019-06-20 Thread YoSTEALTH
YoSTEALTH added the comment: "Writing test suites is very helpful, and you might want to plan your code based on expectation of making it easy for testing." -- nosy: +YoSTEALTH ___ Python tracker

[issue37349] venv.EnvBuilder environmental variable hooks

2019-06-20 Thread Caleb Donovick
Caleb Donovick added the comment: In regards to the added complexity by needing to be implemented across all shells, the functionality I am requesting already exists across all shells (e.g. setting PYTHONPATH) just not in a extensible way. -- ___

[issue37353] Source code has not always been forward-compatible

2019-06-20 Thread Zachary Ware
Zachary Ware added the comment: Perhaps just adding "within a major release series" after "forward-compatible" would be sufficient? -- nosy: +zach.ware ___ Python tracker

[issue37352] Typo in documentation: "to making it easy"

2019-06-20 Thread Zachary Ware
Zachary Ware added the comment: "making" looks fine to me as a native English speaker. I'm not sure it's properly correct English, but it's fine colloquially and I don't think "make" would improve it :) If anything, I'd change "to" to "toward", or possibly replace "an eye to" with "the

[issue37349] venv.EnvBuilder environmental variable hooks

2019-06-20 Thread Caleb Donovick
Caleb Donovick added the comment: Common python libraries that make use of environmental variables: - django - flask - jupyter - TensorFlow This is just off the top my head. While most developers are probably fine just setting the required variables at a system level that doesn't mean they

[issue35185] Logger race condition - loses lines if removeHandler called from another thread while logging

2019-06-20 Thread Vinay Sajip
Vinay Sajip added the comment: > I'd prefer correctness to be always there automatically, rather than > something the user must remember to enable by setting a flag such as > lockCallHandling Yes, I agree, I was just looking at different approaches while mulling all this over.

[issue37353] Source code has not always been forward-compatible

2019-06-20 Thread Julien Palard
New submission from Julien Palard : In Doc/library/parser.rst I can read: The parse trees are not typically compatible from one version to another, whereas source code has always been forward-compatible. But I don't think this is right, I think of print for example. Maybe just remove ",

[issue37347] Reference-counting problem in sqlite

2019-06-20 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37352] Typo in documentation: "to making it easy"

2019-06-20 Thread Julien Palard
New submission from Julien Palard : In Doc/faq/design.rst there's "with an eye to making it easily tested.". I'm not native english, but I think "making" is wrong here, maybe "make"? -- assignee: docs@python components: Documentation keywords: easy messages: 346141 nosy: docs@python,

[issue37349] venv.EnvBuilder environmental variable hooks

2019-06-20 Thread Vinay Sajip
Vinay Sajip added the comment: I'm not very keen on this approach, because it needs to be implemented across all shells and maintenance in this area can be a headache because not everyone has knowledge of multiple shells. There already are hooks for customising behaviour - you can subclass

[issue35185] Logger race condition - loses lines if removeHandler called from another thread while logging

2019-06-20 Thread Ben Spiller
Ben Spiller added the comment: Interesting conversation. :) Yes I agree correctness is definitely top priority. :) I'd go further and say I'd prefer correctness to be always there automatically, rather than something the user must remember to enable by setting a flag such as

[issue37351] Drop libpython38.a from Windows release

2019-06-20 Thread Steve Dower
Steve Dower added the comment: Realising that this may have an impact on distutils.cygwincompiler.Mingw32CCompiler, but I can't tell from the source code how/whether it would pick up the pre-packaged libpython38.a. Does anyone know? -- components: +Distutils nosy: +dstufft,

[issue12782] Multiple context expressions do not support parentheses for continuation across lines

2019-06-20 Thread Terry Davis
Terry Davis added the comment: I'd like to re-raise this issue. Should I cross-post to "discuss.python.org - Ideas"? -- nosy: +Terry Davis ___ Python tracker ___

[issue37351] Drop libpython38.a from Windows release

2019-06-20 Thread Steve Dower
New submission from Steve Dower : The step of generating a MinGW import library for Python releases is very rarely used, forces us to take extra build dependencies, and is better handled by the end-users who need it. We will drop the libpython38.a file from the main distribution, and update

[issue35185] Logger race condition - loses lines if removeHandler called from another thread while logging

2019-06-20 Thread Vinay Sajip
Vinay Sajip added the comment: > I'd definitely suggest we go for a solution that doesn't hit performance of > normal logging I agree, but correctness is important. I'm tending to the following: 1. Introduce a lockCallHandling module-level variable, defaulting to False to maximise logging

[issue20431] Should posix functions that accept fd also accept objects with .fileno()?

2019-06-20 Thread Joannah Nanjekye
Change by Joannah Nanjekye : -- nosy: +vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37348] Optimize PyUnicode_GetString for short ASCII strings

2019-06-20 Thread STINNER Victor
STINNER Victor added the comment: > _PyUnicode_FromASCII(s, len) is faster than PyUnicode_FromString(s) because > PyUnicode_FromString() uses temporary _PyUnicodeWriter to support UTF-8. I don't understand how _PyUnicodeWriter could be slow. It does not overallocate by default. It's just

[issue36511] Add Windows ARM32 buildbot

2019-06-20 Thread Steve Dower
Steve Dower added the comment: New changeset a1952122a3a20272e4db9e3c6205009a91c73ccf by Steve Dower (Paul Monson) in branch 'master': bpo-36511: Improve ARM32 buildbot scripts (GH-14251) https://github.com/python/cpython/commit/a1952122a3a20272e4db9e3c6205009a91c73ccf --

[issue37348] Optimize PyUnicode_GetString for short ASCII strings

2019-06-20 Thread Inada Naoki
Inada Naoki added the comment: Oh, wait. Why we used _PyUnicodeWriter here? Decoding UTF-8 must not require it. 2-pass is enough. -- ___ Python tracker ___

[issue37344] plistlib doesn't skip whitespace in XML format detection

2019-06-20 Thread Prateek Nayak
Change by Prateek Nayak : -- keywords: +patch pull_requests: +14098 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14266 ___ Python tracker ___

[issue24772] Smaller viewport shifts the "expand left menu" character into the text

2019-06-20 Thread Joannah Nanjekye
Joannah Nanjekye added the comment: @karl If you are still interested in solving this, open a pull request on https://github.com/python/cpython -- nosy: +nanjekyejoannah ___ Python tracker

[issue37350] print ResourceWarning object traceback when raised as error with -W error and -X tracemalloc

2019-06-20 Thread STINNER Victor
STINNER Victor added the comment: You can implement this behavior using the new sys.unraisablehook (Python 3.8): --- import sys import tracemalloc def foo(): open('foo', 'wb') def hook(unraisable): orig_unraisablehook(unraisable) if unraisable.object is not None: tb =

[issue37350] print ResourceWarning object traceback when raised as error with -W error and -X tracemalloc

2019-06-20 Thread Thomas Grainger
Change by Thomas Grainger : -- title: print ResourceWarning object traceback when raise as error with -W error -> print ResourceWarning object traceback when raised as error with -W error and -X tracemalloc ___ Python tracker

[issue37350] print ResourceWarning object traceback when raise as error with -W error

2019-06-20 Thread Thomas Grainger
New submission from Thomas Grainger : Current behaviour $ cat foo.py def foo(): open('foo', 'wb') foo() $ python3.8 -W all::ResourceWarning -X tracemalloc=5 foo.py foo.py:2: ResourceWarning: unclosed file <_io.BufferedWriter name='foo'> open('foo', 'wb') Object allocated at (most

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

2019-06-20 Thread Steve Dower
Steve Dower added the comment: > Note that the PR for the other similar issue #37221 has been accepted for > merging. I've already explained why that issue is different (it breaks a compatibility guarantee; this one changes something that was explicitly deprecated). Petr's question seems

[issue37347] Reference-counting problem in sqlite

2019-06-20 Thread Aleksandr Balezin
Change by Aleksandr Balezin : -- pull_requests: -14092 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37348] Optimize PyUnicode_GetString for short ASCII strings

2019-06-20 Thread Inada Naoki
Inada Naoki added the comment: > Most of changes are in not performance sensitive code. I do not think there > is a benefit of using new macro there. Because I used just sed. > If PyUnicode_FromString() is slow I prefer to optimize it instead of adding > yet one esoteric private function

[issue37348] add _PyUnicode_FROM_ASCII macro

2019-06-20 Thread Inada Naoki
Change by Inada Naoki : -- pull_requests: +14097 pull_request: https://github.com/python/cpython/pull/14273 ___ Python tracker ___

[issue37342] A type error in typeobj.rst

2019-06-20 Thread hai shi
Change by hai shi : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing

[issue37151] Calling code cleanup after PEP 590

2019-06-20 Thread Inada Naoki
Inada Naoki added the comment: New changeset 7e1a9aacff95c68d284f31666fe293fa2db5406d by Inada Naoki (Jeroen Demeyer) in branch 'master': bpo-37151: remove _PyCFunction_FastCallDict (GH-14269) https://github.com/python/cpython/commit/7e1a9aacff95c68d284f31666fe293fa2db5406d --

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

2019-06-20 Thread Jeroen Demeyer
Jeroen Demeyer added the comment: Can we then bring back the discussion to the core of this issue: should we restore tp_print or not in PyTypeObject? Note that the PR for the other similar issue #37221 has been accepted for merging. -- ___

[issue37349] venv.EnvBuilder environmental variable hooks

2019-06-20 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- components: +Library (Lib) -Interpreter Core nosy: +vinay.sajip versions: +Python 3.9 ___ Python tracker ___

[issue37221] PyCode_New API change breaks backwards compatibility policy

2019-06-20 Thread Jeroen Demeyer
Change by Jeroen Demeyer : -- pull_requests: -13873 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37349] venv.EnvBuilder environmental variable hooks

2019-06-20 Thread Caleb Donovick
Caleb Donovick added the comment: I have basic version working in POSIX. -- ___ Python tracker ___ ___ Python-bugs-list mailing

[issue37349] venv.EnvBuilder environmental variable hooks

2019-06-20 Thread Caleb Donovick
Change by Caleb Donovick : -- keywords: +patch pull_requests: +14096 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14272 ___ Python tracker ___

[issue37250] C files generated by Cython set tp_print to 0: PyTypeObject.tp_print removed

2019-06-20 Thread Steve Dower
Steve Dower added the comment: > I was trying to tell you that already in msg345969 but you insisted in > msg345988 that we should support that anyway. I made a general note that "extremely unlikely" isn't unlikely enough to be an argument. You'll notice I didn't quote any of the rest of

[issue37349] venv.EnvBuilder environmental variable hooks

2019-06-20 Thread Caleb Donovick
New submission from Caleb Donovick : Currently EnvBuilder allows for a number of customizations of virtual environments, however, it does not allow for any modifications of the activate script itself (unless one wants to rewrite it completely). Yet, it is fairly common requirement for

[issue37151] Calling code cleanup after PEP 590

2019-06-20 Thread Jeroen Demeyer
Change by Jeroen Demeyer : -- pull_requests: +14095 pull_request: https://github.com/python/cpython/pull/14269 ___ Python tracker ___

[issue37348] add _PyUnicode_FROM_ASCII macro

2019-06-20 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Most of changes are in not performance sensitive code. I do not think there is a benefit of using new macro there. If PyUnicode_FromString() is slow I prefer to optimize it instead of adding yet one esoteric private function for internal needs. In case

[issue37345] Add formal support for UDPLITE protococl

2019-06-20 Thread Gabe Appleton
Gabe Appleton added the comment: Its true that this doesnt exist at the C level, however I worry that having it purely through getsockopt() and setsockopt() would make things more confusing, so I added it as a helper function. I can remove it in lieu of documentation if that would block

[issue37347] Reference-counting problem in sqlite

2019-06-20 Thread Aleksandr Balezin
Change by Aleksandr Balezin : -- pull_requests: +14094 pull_request: https://github.com/python/cpython/pull/14268 ___ Python tracker ___

[issue37337] Add _PyObject_VectorcallMethod() function

2019-06-20 Thread Jeroen Demeyer
Change by Jeroen Demeyer : -- pull_requests: +14093 pull_request: https://github.com/python/cpython/pull/14267 ___ Python tracker ___

[issue35185] Logger race condition - loses lines if removeHandler called from another thread while logging

2019-06-20 Thread Ben Spiller
Ben Spiller added the comment: I'd definitely suggest we go for a solution that doesn't hit performance of normal logging when you're not adding/removing things, being as that's the more common case. I guess that's the reason why callHandlers was originally implemented without grabbing the

[issue37347] Reference-counting problem in sqlite

2019-06-20 Thread Aleksandr Balezin
Change by Aleksandr Balezin : -- keywords: +patch pull_requests: +14092 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14265 ___ Python tracker

[issue37348] add _PyUnicode_FROM_ASCII macro

2019-06-20 Thread Inada Naoki
Inada Naoki added the comment: Should we make these APIs public? * rename `_PyUnicode_FromASCII` to `PyUnicode_FromASCIIAndSize`. * add `PyUnicode_FromASCII` as static inline function (without ABI). * add `#define _PyUnicode_FromASCII PyUnicode_FromASCIIAndSize` for source code

[issue37348] add _PyUnicode_FROM_ASCII macro

2019-06-20 Thread Inada Naoki
Inada Naoki added the comment: I confirmed at least one measurable speedup: ./python -m pyperf timeit -s 'd={}' -- 'repr(d)' FromString: Mean +- std dev: 157 ns +- 3 ns FROM_ASCII: Mean +- std dev: 132 ns +- 3 ns >>> (157-132)/157 0.1592356687898089 --

[issue37348] add _PyUnicode_FROM_ASCII macro

2019-06-20 Thread STINNER Victor
STINNER Victor added the comment: > #define _PyUnicode_FROM_ASCII(s) _PyUnicode_FromASCII((s), strlen(s)) LGTM. -- nosy: +vstinner ___ Python tracker ___

[issue37348] add _PyUnicode_FROM_ASCII macro

2019-06-20 Thread Inada Naoki
Change by Inada Naoki : -- keywords: +patch pull_requests: +14091 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14264 ___ Python tracker ___

[issue37348] add _PyUnicode_FROM_ASCII macro

2019-06-20 Thread Inada Naoki
New submission from Inada Naoki : _PyUnicode_FromASCII(s, len) is faster than PyUnicode_FromString(s) because PyUnicode_FromString() uses temporary _PyUnicodeWriter to support UTF-8. But _PyUnicode_FromASCII("hello", strlen("hello"))` is not as easy as `PyUnicode_FromString("hello")`.

[issue37347] Reference-counting problem in sqlite

2019-06-20 Thread Aleksandr Balezin
Change by Aleksandr Balezin : Added file: https://bugs.python.org/file48430/bug.py ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue37347] Reference-counting problem in sqlite

2019-06-20 Thread Aleksandr Balezin
New submission from Aleksandr Balezin : There are a couple of bugs in sqlite bindings have been found related to reference-counting. Short info: sqlite connection class uses a dict to keep references to callbacks. This mechanism is not suitable for objects which equals but not the same. con

[issue37334] Add a cancel method to asyncio Queues

2019-06-20 Thread Martin Teichmann
Martin Teichmann added the comment: I also thought about `.close()` but then found `.cancel()` more intuitive. But intuition is not universal, so I am open to any wording. -- ___ Python tracker

[issue37345] Add formal support for UDPLITE protococl

2019-06-20 Thread Andrew Svetlov
Andrew Svetlov added the comment: Adding new constants like socket.IPPROTO_UDPLITE is fine. The question is: why we need a new function? There is no set_send_checksum_coverage() on C level IIRC -- nosy: +asvetlov ___ Python tracker

  1   2   >