Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
New changeset 799722cb0ddb90752cde7798cab543f30623ebf2 by Jason R. Coombs in
branch '3.9':
[3.9] bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all
but processor) (GH-23010) (#24232)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
New changeset 799722cb0ddb90752cde7798cab543f30623ebf2 by Jason R. Coombs in
branch '3.9':
[3.9] bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all
but processor) (GH-23010) (#24232)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
New changeset 799722cb0ddb90752cde7798cab543f30623ebf2 by Jason R. Coombs in
branch '3.9':
[3.9] bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all
but processor) (GH-23010) (#24232)
https://github.com/python/cpython/commit
Change by Jason R. Coombs :
--
pull_requests: +23056
pull_request: https://github.com/python/cpython/pull/24232
___
Python tracker
<https://bugs.python.org/issue42
Change by Jason R. Coombs :
--
pull_requests: +23057
pull_request: https://github.com/python/cpython/pull/24232
___
Python tracker
<https://bugs.python.org/issue42
Change by Jason R. Coombs :
--
pull_requests: +23055
pull_request: https://github.com/python/cpython/pull/24232
___
Python tracker
<https://bugs.python.org/issue42
Change by Jason R. Coombs :
--
versions: -Python 3.7
___
Python tracker
<https://bugs.python.org/issue42531>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
> Why do we keep setuptools?
I agree; would be good to remove it if possible.
There are many packages that fail to build without Setuptools being present or
--use-pep517 indicated. It would be nice if pip could make --use-pep517 the
default, upd
Jason R. Coombs added the comment:
Thanks!
No rush, but ideally soon enough to be merged before the beta release of Python
3.10 (2021-05-03).
--
___
Python tracker
<https://bugs.python.org/issue42
Jason R. Coombs added the comment:
In [this
commit](https://github.com/python/importlib_resources/commit/bd20d893f11f387d285c666bc99fd2d4a7c33ef8),
I've reconciled and merged the changes from importlib_resources 3.2-5.0,
mainly the namespace package support
(https://importlib
Jason R. Coombs added the comment:
Can you tell me more about the use-case that exhibited this undesirable
behavior? That is, what loader is it that supports `open_binary` but not
`is_resource` and doesn't have a `__origin__`?
--
___
Python
Jason R. Coombs added the comment:
> Regardless of whether PR 23611 is accepted, the test that it adds should be
> added to Python master to guard against regressions. I can submit that as a
> separate PR. Before I do that, do I need to create a new bpo ticket, or can I
> ju
Jason R. Coombs added the comment:
New changeset a6fd0f414c0cb4cd5cc20eb2df3340b31c6f7743 by Jason R. Coombs in
branch 'master':
bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all but
processor) (#23010)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
New changeset a6fd0f414c0cb4cd5cc20eb2df3340b31c6f7743 by Jason R. Coombs in
branch 'master':
bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all but
processor) (#23010)
https://github.com/python/cpython/commit
Jason R. Coombs added the comment:
New changeset a6fd0f414c0cb4cd5cc20eb2df3340b31c6f7743 by Jason R. Coombs in
branch 'master':
bpo-42163, bpo-42189, bpo-42659: Support uname_tuple._replace (for all but
processor) (#23010)
https://github.com/python/cpython/commit
Change by Jason R. Coombs :
--
stage: patch review -> needs patch
___
Python tracker
<https://bugs.python.org/issue38780>
___
___
Python-bugs-list mai
Change by Jason R. Coombs :
--
assignee: jaraco ->
___
Python tracker
<https://bugs.python.org/issue38780>
___
___
Python-bugs-list mailing list
Unsubscrib
Jason R. Coombs added the comment:
I started work on a test in
https://github.com/jaraco/cpython/tree/bugfix/bpo-38780-test, but (a) the test
was failing to exhibit the expected failures, and (b) I realized that the fix
isn't having the intended effect either, because for unix sockets
Jason R. Coombs added the comment:
New changeset dfdca85dfa64e72df385b3a486f85b773fc0f135 by Jason R. Coombs in
branch 'master':
bpo-42382: In importlib.metadata, `EntryPoint` objects now expose `dist`
(#23758)
https://github.com/python/cpython/commit
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +22672
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23010
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: commit review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
The PR for the related issue does address pickling. Do you expect pickles to
work across Python versions?
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Jason R. Coombs :
--
pull_requests: +22614
pull_request: https://github.com/python/cpython/pull/23758
___
Python tracker
<https://bugs.python.org/issue42
Jason R. Coombs added the comment:
This issue was implemented, just not as fully as I'd have hoped. Still lacking
is native support for .files on the built-in package providers and removing the
legacy APIs or at least configuring them to rely on the files API, but as far
as supplying
Jason R. Coombs added the comment:
In discussion, I realized that I don't yet understand what use-cases drive this
demand? What code is it that requires resolving a distribution from an entry
point?
--
___
Python tracker
<https://bugs.python.
Jason R. Coombs added the comment:
I've ported the initial patch over to the backport and am exploring options in
https://github.com/python/importlib_metadata/pull/266.
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue42382>
___
___
Python-bugs-list mailing list
Unsubscrib
Jason R. Coombs added the comment:
Erlend, inspired by your patches, I created
https://github.com/python/cpython/pull/23661/commits/e9723003d49c722d57a69e5016b442d4d752fc6d,
which uses a NullSocket instance instead of None, allowing the
behavior-suppression to be encapsulated in a single
Change by Jason R. Coombs :
--
pull_requests: +22527
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23661
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
versions: +Python 3.10 -Python 2.7, Python 3.7
___
Python tracker
<https://bugs.python.org/issue38780>
___
___
Python-bugs-list m
Jason R. Coombs added the comment:
I've applied the patches and pushed them to
https://github.com/jaraco/cpython/tree/bugfix/bpo-38780.
```
cpython master $ http
https://bugs.python.org/file48933/0001-bpo-38780-Harden-socket-use-in-logging.handlers.patch
| git apply
cpython master $ git
Jason R. Coombs added the comment:
I'll take a look at the patch and convert it to a PR.
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Thanks William for the detailed problem description.
If the issue has been fixed on Python 3.9 but not on 3.8, then it was likely a
redesign that enabled the improved behavior, a redesign that won't be ported
back to Python 3.8 and earlier
R. David Murray added the comment:
After thinking about it some more, I think given that when there is no
non-ascii mbox will happily treat *anything* as valid on the "From " line, that
we should consider blowing up on non-ascii t
R. David Murray added the comment:
Yep, you've found another in a category of bugs that have shown up in the
parser: places where there is a missing check for there being any value at all
before checking character [0].
In this case, the fix should be to add
if not obs_local_part
Jason R. Coombs added the comment:
Yes. If I trust my message from earlier, this issue is resolved. Closing now.
--
resolution: -> not a bug
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
R. David Murray added the comment:
The problem with that archive is that it is not in proper mbox format. It
contains the following line (5689):
From here I was hoping to run something like “dbus-send –system
–dest=Test.Me –print-reply /Japan Japan.Reset.Test string:”Hello””
You
Jason R. Coombs added the comment:
As I reviewed the PR, I do realize how tricky this change is going to be. In
addition to the three MSVC implementations in distutils, Setuptools has its own
(https://github.com/pypa/setuptools/blob/master/setuptools/msvc.py).
Interestingly, that file
Jason R. Coombs added the comment:
If you wish for the functionality to be available in setuptools (backported),
please contribute the change at https://github.com/pypa/distutils. At some
point, contributions to CPython will also be synced there as well, and any
changes there get synced
Jason R. Coombs added the comment:
Yes - I keep both in sync.
--
___
Python tracker
<https://bugs.python.org/issue42382>
___
___
Python-bugs-list mailin
Jason R. Coombs added the comment:
Pedro - thanks for the detailed report. Pull requests against
importlib_metadata are easier to accept because they can be tested more easily,
released more rapidly, and there's a straightforward way to port them to
CPython. Regardless, I see you've
New submission from Athul R :
rstrip removes the trailing `e`s.
i = "external_e_object"
i = i.rstrip('_object')
print(i)
"""
It should have printed `external_e` but it prints only `external_`.
"""
It happens only when I user
Jason R. Coombs added the comment:
I marked bpo-42263 as a duplicate of this issue.
This issue is implicated in preventing the desired fix for bpo-37193, where a
thread wishes to remove the handle to itself after performing its duty. By
removing its own handle, it can never be joined
Change by Jason R. Coombs :
--
versions: +Python 3.10
___
Python tracker
<https://bugs.python.org/issue37788>
___
___
Python-bugs-list mailing list
Unsubscribe:
Jason R. Coombs added the comment:
Yes, I agree it's a duplicate of issue37788.
And yes, it does still leak if the list is never created or if the target is a
no-op.
--
resolution: -> duplicate
stage: -> resolved
status: open -> closed
superseder: -> fix for bpo-3640
Jason R. Coombs added the comment:
I don't think it's a race condition for two reasons: adding a `time.sleep(1)`
after `.start` still raises errors, and in issue37193, there were 10 threads
created, with at least 9 of those reaching termination before the test ended,
yet it showed 10
Jason R. Coombs added the comment:
I filed issue42263 to capture the underlying cause of the memory leak that led
to the buildbot failures and the rollback.
--
___
Python tracker
<https://bugs.python.org/issue37
New submission from Jason R. Coombs :
In issue37193, I'd worked on an implementation in which a thread reference
would be removed as the thread was closing, but this led to a memory leak
caught by the buildbots (https://bugs.python.org/issue37193#msg380172).
As I tracked down the issue in GH
Change by Jason R. Coombs :
--
pull_requests: +22043
pull_request: https://github.com/python/cpython/pull/23127
___
Python tracker
<https://bugs.python.org/issue37
Change by Jason R. Coombs :
--
pull_requests: +22024
pull_request: https://github.com/python/cpython/pull/23107
___
Python tracker
<https://bugs.python.org/issue37
Jason R. Coombs added the comment:
I recommend a rollback. I’ll try to get to it later today.
--
___
Python tracker
<https://bugs.python.org/issue37193>
___
___
Jason R. Coombs added the comment:
New changeset c41559021213cfc9dc62a83fc63306b3bdc3e64b by MARUYAMA Norihiro in
branch 'master':
bpo-37193: remove thread objects which finished process its request (GH-13893)
https://github.com/python/cpython/commit/c41559021213cfc9dc62a83fc63306b3bdc3e64b
Jason R. Coombs added the comment:
Please take a look at the PR. Let me know what you think about the limited
compatibility it adds (still doesn't allow _replace on 'processor').
--
___
Python tracker
<https://bugs.python.org/issue42
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +21945
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23010
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Acknowledged. Thanks for the report. I'll likely address this issue alongside
the other (same PR).
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issu
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +21926
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/23010
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
Indeed, it was unexpected that consumers of the `uname_result` were using
`_replace`. In fact, the focus of the tests is on ensuring that users are able
to access the items by index, e.g. `uname()[0]`.
It should be possible to support `_replace
Change by Jason R. Coombs :
--
assignee: -> jaraco
___
Python tracker
<https://bugs.python.org/issue42163>
___
___
Python-bugs-list mailing list
Unsubscrib
Change by Jason R. Coombs :
--
stage: patch review -> commit review
___
Python tracker
<https://bugs.python.org/issue42090>
___
___
Python-bugs-list mai
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +21893
stage: backport needed -> patch review
pull_request: https://github.com/python/cpython/pull/22976
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
New changeset d1a0a960ee493262fb95a0f5b795b5b6d75cecb8 by Jason R. Coombs in
branch 'master':
bpo-42043: Add support for zipfile.Path subclasses (#22716)
https://github.com/python/cpython/commit/d1a0a960ee493262fb95a0f5b795b5b6d75cecb8
Jason R. Coombs added the comment:
This issue is fixed in zipp 3.4.0.
--
assignee: -> jaraco
stage: -> backport needed
___
Python tracker
<https://bugs.python.org/i
Jason R. Coombs added the comment:
New changeset df8d4c83a6e1727e766191896aeabde886979587 by Jason R. Coombs in
branch 'master':
bpo-41490: ``path`` and ``contents`` to aggressively close handles (#22915)
https://github.com/python/cpython/commit/df8d4c83a6e1727e766191896aeabde886979587
New submission from Jason R. Coombs :
In
[importlib_resources#68](https://github.com/python/importlib_resources/issues/68),
the project identified a deficiency with respect to pkg_resources for
resources in namespace packages.
The project has since merged support for these packages, slated
Change by Jason R. Coombs :
--
pull_requests: +21845
pull_request: https://github.com/python/cpython/pull/22915
___
Python tracker
<https://bugs.python.org/issue41
Change by Jason R. Coombs :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Jason R. Coombs added the comment:
This sounds like a worthy improvement. Are you interested in preparing a patch?
Would you consider contributing it to https://github.com/jaraco/zipp first?
--
___
Python tracker
<https://bugs.python.
New submission from Jason R. Coombs :
As reported in https://gitlab.com/python-devs/importlib_metadata/-/issues/124,
it would be nice if the PackageNotFoundError gave some guidance to the user
about the context of the error and how to investigate.
--
assignee: jaraco
components
Change by Jason R. Coombs :
--
pull_requests: +21684
pull_request: https://github.com/python/cpython/pull/22716
___
Python tracker
<https://bugs.python.org/issue42
Jason R. Coombs added the comment:
New changeset 967fddae2fe48f297563c358bdbdde1e2cfed4ee by Jason R. Coombs in
branch '3.8':
[3.8] bpo-41855: Fix duplicate results in FastPath.zip_children() (#22404)
https://github.com/python/cpython/commit/967fddae2fe48f297563c358bdbdde1e2cfed4ee
Jason R. Coombs added the comment:
This issue was addressed incidentally in
[jaraco/zipp#56](https://github.com/jaraco/zipp/issues/56) released as zipp
3.2.0.
I'd like to incorporate the tests submitted in PR 22711 and then port those
changes to Python
Jason R. Coombs added the comment:
Thanks Eryk for following up. Glad to hear the issue has been fixed upstream!
--
___
Python tracker
<https://bugs.python.org/issue21
New submission from Abhi R :
I tried to create a new virtual environment using virtualenv and the newly
released Python3.9 version and I got a runtime error saying " failed to find
interpreter for Builtin discover of python_spec='python3.9'".
--
components: Interpreter
Change by Jason R. Coombs :
--
resolution: -> fixed
___
Python tracker
<https://bugs.python.org/issue40564>
___
___
Python-bugs-list mailing list
Unsubscrib
Jason R. Coombs added the comment:
Fix merged into master. Please use zipp 3.2.0 on Python 3.9 and earlier for the
improved behavior or report back here if a backport is needed (and why).
--
stage: patch review -> resolved
status: open -> closed
versions: +Python 3.10 -Pyth
Jason R. Coombs added the comment:
New changeset ebbe8033b1c61854c4b623aaf9c3e170d179f875 by Jason R. Coombs in
branch 'master':
bpo-40564: Avoid copying state from extant ZipFile. (GH-22371)
https://github.com/python/cpython/commit/ebbe8033b1c61854c4b623aaf9c3e170d179f875
Change by Jason R. Coombs :
--
pull_requests: +21444
pull_request: https://github.com/python/cpython/pull/22404
___
Python tracker
<https://bugs.python.org/issue41
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +21443
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22403
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
The relevant commit is already present in importlib_metadata as
[079ca1cb701a5f4aab0a9cb00b0782c7ea8fb70b](https://gitlab.com/python-devs/importlib_metadata/-/commit/079ca1cb701a5f4aab0a9cb00b0782c7ea8fb70b).
--
components: +Library (Lib
New submission from Jason R. Coombs :
Scott J. reports in an e-mail:
When upgrading to Python 3.8.2, we noticed two issues in
importlib.metadata which are not present in importlib_metadata.
1. FastPath.zip_children() is very slow for large zips. Python 3.8.3
> already has a
Jason R. Coombs added the comment:
I've released zipp 3.2.0 that includes a fix for this issue (option 2). Please
test it out.
Because this change affects the user's expectation about the effect of what's
passed in, I'm hesitant to backport it to 3.8 and 3.9. It's too late to go into
3.9.0
Change by Jason R. Coombs :
--
keywords: +patch
pull_requests: +21408
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/22371
___
Python tracker
<https://bugs.python.org/issu
Jason R. Coombs added the comment:
I've also created this alternative to option 2:
- https://github.com/jaraco/zipp/tree/bugfix/bpo-40564-mixin
This alternative approach uses a mix-in rather than subclasses, creating a new
class on-demand. I was hoping this approach would enable just
Jason R. Coombs added the comment:
> I haven't yet figured out whether there's a convenient way for the reader to
> not keep the ZIP open for as long as it exists, but I think that's going to
> be the safest fix.
You may be right here. I don't fully understand the repro, but it se
Jason R. Coombs added the comment:
In jaraco/zipp, I've implemented three of the options above:
- https://github.com/jaraco/zipp/tree/bugfix/bpo-40564-option-1
- https://github.com/jaraco/zipp/tree/bugfix/bpo-40564-option-2
- https://github.com/jaraco/zipp/tree/bugfix/bpo-40564-option-5
Change by Jason R. Coombs :
--
resolution: -> wont fix
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
New submission from Prasanth R :
Got this error on Ubuntu-18 alone
```
_PYTHON_PROJECT_BASE=python3-3.8.3/Python-3.8.3
_PYTHON_HOST_PLATFORM=linux-x86_64
PYTHONPATH=python3-3.8.3/Python-3.8.3/build/lib.linux-x86_64-3.8/sysconfigdata:./Lib
_PYTHON_SYSCONFIGDATA_NAME
Jason R. Coombs added the comment:
One possible option to guarantee initialization could be for PyInitialize to
always call PySys_SetArgvEx(1, [""], 0), providing a default value for embedded
interpreters that fail to call it.
--
Jason R. Coombs added the comment:
Thanks Terry.
The correct URL is
[jaraco/keyring#445](https://github.com/jaraco/keyring/issues/445).
--
___
Python tracker
<https://bugs.python.org/issue41
Jason R. Coombs added the comment:
Implementing that last option:
```
diff --git a/zipp.py b/zipp.py
index 697d4a9..f244cba 100644
--- a/zipp.py
+++ b/zipp.py
@@ -111,6 +111,7 @@ class CompleteDirs(zipfile.ZipFile):
res = cls.__new__(cls)
vars(res).update(vars(source
Jason R. Coombs added the comment:
I see a few options here:
- Implement CompleteDirs/FastLookup as adapters instead of subclasses, allowing
the original ZipFile object to represent the state in a single place. This
approach would likely be slower due to the indirection on all operations
Jason R. Coombs added the comment:
I suspect the issue lies in how the CompleteDirs.make [replaces one instance
with
another](https://github.com/jaraco/zipp/blob/8ad959e61cd4be40baab93528775c2bf03c8f4e1/zipp.py#L112-L114)
in order to provide a complete list of implied directories
Jason R. Coombs added the comment:
I am able to replicate the failure using the ondisk fixture:
```diff
diff --git a/test_zipp.py b/test_zipp.py
index a6fbf39..539d0a9 100644
--- a/test_zipp.py
+++ b/test_zipp.py
@@ -259,3 +259,11 @@ class TestPath(unittest.TestCase):
def
Jason R. Coombs added the comment:
I've attempted to replicate the issue in the
[zipp](https://github.com/jaraco/zipp) test suite with this test:
```diff
diff --git a/test_zipp.py b/test_zipp.py
index a6fbf39..dc7c8aa 100644
--- a/test_zipp.py
+++ b/test_zipp.py
@@ -259,3 +259,10 @@ class
New submission from Jason R. Coombs :
In [pypa/keyring#445](https://github.com/pypa/keyring/445) and issue839151, we
learned that there are Python interpreters in which `sys.argv` is an empty
list, is not a list, or is not initialized at all. Through use of
`sys.argv[0]`, the documentation
R. David Murray added the comment:
Yes for the registry changes. I thought we had fixed the bug that was causing
message-id to get encoded, but maybe it still exists in 3.7? I don't remember
when we fixed it (and I may be remembering wrong!)
As for X- "unstructured headers&quo
R. David Murray added the comment:
It's not really an abuse. It is, however, buggy. It should be being applied
*only* when the header contains unstructured text. Unfortunately I made the
choice to treat any header that doesn't have a specific parser as unstructured,
and that was a wrong
New submission from Jason R. Coombs :
On Windows:
Python 3.8.3 (tags/v3.8.3:6f8c832, May 13 2020, 22:37:02) [MSC v.1924 64 bit
(AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import ntpath
>>
401 - 500 of 12043 matches
Mail list logo
