[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Zachary Ware added the comment: Excellent. Thanks, Terry! -- resolution: -> out of date stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Terry J. Reedy added the comment: I believe the following means 'No' and that you can close this. f:\dev\27>python -m test.regrtest test___all__ test_tcl Running Debug|Win32 interpreter... Run tests sequentially 0:00:00 [1/2] test___all__ 0:00:24 [2/2] test_tcl All 2 tests OK. --

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Zachary Ware added the comment: The root of this issue was fixed by #20035 for 3.5+. Terry, do you still have issues with this with 2.7, and is it still worth trying to fix? -- ___ Python tracker

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Zachary Ware added the comment: As for what's actually wrong here, Hirokazu Yamamoto's diagnosis in msg123615 (adjusted for 2.7) is correct. Either of the last two patches I posted should work to fix this issue, but they're both just band-aids rather than a real, once-and-for-all fix. #20035

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Terry J. Reedy added the comment: Zach, do you have any further thoughts in light of patches pushed since? What do you think is the exact remaining issue? -- assignee: terry.reedy - ___ Python tracker rep...@bugs.python.org

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Zachary Ware added the comment: Having another chance to look at this one, my previous message was incorrect; Terry's patch does not fix the issue for an installed Python 2.7. The only change it needs to work, though, is to replace 'Tkinter' with 'FixTk' in the import_fresh_module call.

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Zachary Ware added the comment: An alternative that works and also removes repeated Warning -- os.environ was modified by test_* is to import FixTk at the top of test_support, allowing the environment to be set up and to persist throughout all of the tests. I'm not sure if this is the right

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Changes by Ezio Melotti ezio.melo...@gmail.com: -- versions: +Python 2.7 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10652 ___ ___

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Zachary Ware added the comment: Terry, I just tested your 2.7 patch, and it does work, but the workaround that (I think) we have both been using on 3.x to find the Tcl/Tk .dlls (copying them into PCbuild) doesn't work on 2.7 for some reason. However, if you add ..\tcltk\bin to PATH, which

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Changes by Terry J. Reedy tjre...@udel.edu: -- versions: -Python 3.2 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10652 ___ ___ Python-bugs-list

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Terry J. Reedy added the comment: After editing 2.7 files to match Zach's patch, and also after adding the changes in my patch, and also deleting tcltk directory and rerunning external.bat to rebuild tcltk/ for 2.7 with tcl/tk 8.5.2, the tests still do not all work right. --

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Roundup Robot added the comment: New changeset b923234b60cb by Terry Jan Reedy in branch '3.2': Issue # 10652: make tcl/tk tests run after __all__ test, patch by Zachary Ware. http://hg.python.org/cpython/rev/b923234b60cb New changeset 596e8855895e by Terry Jan Reedy in branch '3.3': Issue #

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Zachary Ware added the comment: I was recently bitten by this issue. I've reviewed Terry's patch on Rietveld, and have tested it myself some. It seems to get the job done without getting in the way. -- nosy: +zach.ware ___ Python tracker

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Ezio Melotti added the comment: Would using import_fresh_module() in test_tcl (and others) work? -- versions: +Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10652 ___

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Zachary Ware added the comment: It does, in fact. Here's a patch. -- Added file: http://bugs.python.org/file29419/issue10652.v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10652 ___

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Terry J. Reedy added the comment: Once I worked around the example.bat problems so repository _tkinter will run for one python version (3.2), Zach's patch seems to solve the test problem as well as mine, and it is better self-contained. In other words, python -m test -ugui test___all__

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Ezio Melotti added the comment: LGTM. The changes on os.environ should be unrelated. I've seen a few other tests (e.g. test_distutils) that change it on Windows, and started writing a patch for it, but I never finished it. -- assignee: - terry.reedy stage: commit review - patch

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Terry J. Reedy tjre...@udel.edu added the comment: I tested this on Windows in my installed 3.3.0b1. Copying the inserted lines to my repository copy (where I cannot test it) gives the attached patch. On 3.2.3, the insertion line would be 1056 instead of 1158. -- Added file:

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Terry J. Reedy tjre...@udel.edu added the comment: Hirokazu's original patch was to restore sys.modules after *every* test, not just sys.modules. That *did* cause problems because (at minimum) of references in importlib. Restoring only after __all__ would only let test_tcl run but not

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Terry J. Reedy tjre...@udel.edu added the comment: I would like to see my patch (cut and paste from message above) or something like it in the next beta. It fixes the problem (since forever?) of tcl/tk/ttk tests not running properly (at least on windows) as part of the test suite. (I presume

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Georg Brandl ge...@python.org added the comment: It would be much better to have an actual patch to review. Then, we need someone who can test it on Windows. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10652

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

R. David Murray rdmur...@bitdance.com added the comment: I wonder if it would be sensible to have test___all__ restore the state of sys.modules after it runs. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10652

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Antoine Pitrou pit...@free.fr added the comment: I wonder if it would be sensible to have test___all__ restore the state of sys.modules after it runs. Probably not. I don't think we want to debug the consequences of having duplicate modules lying around by way of old references registered

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

R. David Murray rdmur...@bitdance.com added the comment: Yeah, we probably do not want to go there, even though technically I think those would be bugs. But bugs that it would only be nice to fix, not necessary to fix. -- ___ Python tracker

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Terry J. Reedy tjre...@udel.edu added the comment: I think this test disabling and failure issue should get some attention. Do the failures happen on non-Windows systems too? With installed 3.3.0b1 on Win7, test___all__, test_tcl, test_tk, test_ttk_textonly, and test_ttk_guionly all run if run

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Changes by Brian Curtin br...@python.org: -- nosy: +brian.curtin ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue10652 ___ ___ Python-bugs-list

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

New submission from Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp: On official Python3.2 beta1 windows binary, I noticed following command fails. (test_tcl alone won't fail) I couldn't reproduce this on binary built from source without installation.

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: test___all__ imports a lot of modules, but I found one of following modules can bring same error. # just import one of these in test_main(test___all__) #import idlelib.AutoComplete #import tkinter.scrolledtext #import

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: I think this happens because 1. test___all__.py imports tkinter module, and it imports tkinter/_fix.py 2. _fix.py sets TCL_LIBRARY etc as top level routine 3. regrtest.py resets os.environ after test___all__.py ends. so

[issue10652] test___all_ + test_tcl fails (Windows installed binary)

Hirokazu Yamamoto ocean-c...@m2.ccsnet.ne.jp added the comment: How about this patch? Is this kind of *fix* acceptable? # I hope this works. -- keywords: +patch Added file: http://bugs.python.org/file19977/py3k_restore_sys_modules_in_regrtest.patch