[issue11071] What's New review comments

2011-03-26 Thread Vinay Sajip
Changes by Vinay Sajip vinay_sa...@yahoo.co.uk: -- nosy: -vinay.sajip ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071 ___ ___

[issue11071] What's New review comments

2011-03-25 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: “unencoded” is still here. -- status: closed - open ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071 ___

[issue11071] What's New review comments

2011-03-25 Thread Roundup Robot
Roundup Robot devnull@devnull added the comment: New changeset a805d4415e34 by Raymond Hettinger in branch '3.2': Issue #11071: Fix whatsnew description of O/S access to raw bytes. http://hg.python.org/cpython/rev/a805d4415e34 New changeset df1a1774a544 by Raymond Hettinger in branch

[issue11071] What's New review comments

2011-03-25 Thread Raymond Hettinger
Changes by Raymond Hettinger raymond.hettin...@gmail.com: -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071 ___ ___

[issue11071] What's New review comments

2011-03-25 Thread Eli Bendersky
Changes by Eli Bendersky eli...@gmail.com: -- nosy: -eli.bendersky ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071 ___ ___ Python-bugs-list

[issue11071] What's New review comments

2011-03-18 Thread Raymond Hettinger
Raymond Hettinger raymond.hettin...@gmail.com added the comment: It seems no new issues have arisen. If something new comes-up, feel free to re-open. -- resolution: - fixed status: open - closed ___ Python tracker rep...@bugs.python.org

[issue11071] What's New review comments

2011-02-26 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: The section about os.environb talks about unencoded bytes and unencoded environment variables instead of undecoded. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071

[issue11071] What's New review comments

2011-02-19 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: Attached patch adds a missing attribution, a missing bug number, fixes one typo (“content manager”) and five grammar issues. I haven’t had time to make a full read-through during the last weeks, but here are a few comments about the overall

[issue11071] What's New review comments

2011-02-19 Thread Raymond Hettinger
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: Éric, go ahead an apply this patch except for the insertion of the in the codecs section. I'm not making regrouping, reordering, merging or other stylistic changes at this point. --

[issue11071] What's New review comments

2011-02-19 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: Applied in r88441. I checked again that the issue numbers were right, and discovered that the functions in site related to PEP 370 were actually new in 2.6, not 3.2, so you may want to remove that section. --

[issue11071] What's New review comments

2011-02-19 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: I checked again that the issue numbers were right, and discovered that the functions in site related to PEP 370 were actually new in 2.6, not 3.2, so you may want to remove that section. Sorry: The functions are indeed new in 2.7/3.2, it’s the

[issue11071] What's New review comments

2011-02-19 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: It appears that Misc/NEWS in 3.2 lists the new functions under the 3.1 section, among other strange differences. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071

[issue11071] What's New review comments

2011-02-19 Thread Nick Coghlan
Nick Coghlan ncogh...@gmail.com added the comment: On Sun, Feb 20, 2011 at 4:22 AM, Éric Araujo rep...@bugs.python.org wrote: It appears that Misc/NEWS in 3.2 lists the new functions under the 3.1 section, among other strange differences. new in 3.2 changes are relative to 3.1, while 2.7 is

[issue11071] What's New review comments

2011-02-19 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: Thanks for the message, but I already knew that. What I meant is that in the 3.2 version of Misc/NEWS, the addition of the functions is listed under the 3.1 section instead of 3.2. -- ___ Python

[issue11071] What's New review comments

2011-02-17 Thread Senthil Kumaran
Senthil Kumaran orsent...@gmail.com added the comment: Here are couple of Review Comments on What's new document. 1. The logging dictConfig example fails if you try directly out-of-text. The conf file is opened as a 'rb' and json module throws an error as TypeError: can't use a string pattern

[issue11071] What's New review comments

2011-02-17 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: 2.Issue number for functools.lru_cache is not mentioned. If no tracker id/ discussion is available, checkin link can be mentioned. There was no tracker issue for that; the checkin is r83327, but I don’t think it would be useful to mention it in

[issue11071] What's New review comments

2011-02-17 Thread Éric Araujo
Éric Araujo mer...@netwok.org added the comment: I meant Lib/subprocess.py, of course :) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071 ___

Re: [issue11071] What's New review comments

2011-02-17 Thread Senthil Kumaran
On Fri, Feb 18, 2011 at 2:18 AM, Éric Araujo rep...@bugs.python.org wrote: You must have missed line 752 and following of Lib/functools.py.  Brian did add context management support to Popen in response to my request in #10554. Yes, I did miss it because the What's new document referenced

[issue11071] What's New review comments

2011-02-10 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: Another remark. In the poplib section, there is a paragraph about asyncore: I don't see how both are related. -- ___ Python tracker rep...@bugs.python.org

[issue11071] What's New review comments

2011-02-10 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: In the What's new in 3.2: there is no mention of the PEP 3003 (Python Language Moratorium). May we add a section What is not new in 3.2? :-) This PEP is something specific to Python 3.2. --

[issue11071] What's New review comments

2011-02-10 Thread Raymond Hettinger
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: Victor, I don't think that would be useful in the Whatsnew document. That PEP was really about letting other implementations get caught-up. It has nearly zero relevance to users of CPython. --

[issue11071] What's New review comments

2011-02-06 Thread Daniel Urban
Daniel Urban urban.dani...@gmail.com added the comment: In the abc.abstractclassmethod example(http://docs.python.org/dev/py3k/whatsnew/3.2.html#abc), the methods probably should use cls as the name of the first parameter, not self, because they are classmethods. -- nosy: +durban

[issue11071] What's New review comments

2011-02-06 Thread Daniel Urban
Daniel Urban urban.dani...@gmail.com added the comment: In the shutil example (http://docs.python.org/dev/py3k/whatsnew/3.2.html#shutil) the function argument of shutil.register_archive_format is a string, but according to

[issue11071] What's New review comments

2011-02-06 Thread Ned Deily
Ned Deily n...@acm.org added the comment: In the paragraph on OS X builds, suggest changing OS X to Mac OS X. Also, instead of the direct recommendation to install ActiveState Tcl, a recommendation that could very well change over the lifetime of the 3.2 release and the released copies of

[issue11071] What's New review comments

2011-02-06 Thread Raymond Hettinger
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: Ned, thanks for the Mac correction. I prefer to leave the Tcl/Tk recommendation in place for several reasons: * for right now, it is needed to get tkinter to work and if we're too indirect about the fix, no one will find it

[issue11071] What's New review comments

2011-02-06 Thread Raymond Hettinger
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: Victor, I added more imports and fixed the ones that were mismatched with the sample code. I've left a few out in a couple places where I thought the imports got in the way of the narrative. --

[issue11071] What's New review comments

2011-02-06 Thread Ned Deily
Ned Deily n...@acm.org added the comment: I understand your point and it is not a huge issue but let me make an attempt to expand on the rationale. * for right now, it is needed to get tkinter to work and if we're too indirect about the fix, no one will find it and their install won't work.

[issue11071] What's New review comments

2011-02-02 Thread Éric Araujo
Changes by Éric Araujo mer...@netwok.org: -- nosy: +eric.araujo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071 ___ ___ Python-bugs-list

[issue11071] What's New review comments

2011-02-01 Thread Ezio Melotti
Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071 ___ ___

[issue11071] What's New review comments

2011-01-31 Thread Raymond Hettinger
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: Do yourself a favor and don't become a PEP 8 nut ;-) The primary purpose of the example in whatsnew is to teach, demonstrate, and explain. Any PEP 8 considerations take a back seat to that purpose (even PEP 8 itself

[issue11071] What's New review comments

2011-01-31 Thread Georg Brandl
Georg Brandl ge...@python.org added the comment: I agree with Raymond: whoever puts in 95% of work for a single document should have artistic license over the style. I also don't complain if people use a different indentation style in module docs they write (but I reserve the right to use

[issue11071] What's New review comments

2011-01-31 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: Python’s import mechanism can now load modules installed in directories with non-ASCII characters in the path name: import møøse.bites møøse is not a module *path*, but a module *name*... This example doesn't work on Windows: see

[issue11071] What's New review comments

2011-01-31 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: Should we add imports in all examples? Eg. add import math in: repr(math.pi) '3.141592653589793' str(math.pi) '3.141592653589793' At least, accumulate should be replaced by itertools.accumulate in the following example:

[issue11071] What's New review comments

2011-01-31 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: The import in the following example is wrong : import datetime datetime.now(timezone.utc) ... It should be replaced by: from datetime import datetime, timezone. -- ___ Python tracker

[issue11071] What's New review comments

2011-01-31 Thread Vinay Sajip
Vinay Sajip vinay_sa...@yahoo.co.uk added the comment: Nick, thanks for highlighting the logging changes. In addition to what you mentioned, there's still more, at least some of which deserves to get into what's new :-) 1. QueueHandler and QueueListener classes were added to help with logging

[issue11071] What's New review comments

2011-01-31 Thread STINNER Victor
STINNER Victor victor.stin...@haypocalc.com added the comment: ABCMeta should be replaced by abc.ABCMeta, or other abc. prefixes should be removed. class Temperature(metaclass=ABCMeta): @abc.abstractclassmethod def from_fahrenheit(self, t): ... @abc.abstractclassmethod

[issue11071] What's New review comments

2011-01-31 Thread Raymond Hettinger
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: Thanks Victor. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071 ___

[issue11071] What's New review comments

2011-01-31 Thread Alexander Belopolsky
Alexander Belopolsky belopol...@users.sourceforge.net added the comment: Please consider mentioning that several modules can now be called with -m: pickle, pickletools and tkinter. -- nosy: +belopolsky ___ Python tracker rep...@bugs.python.org

[issue11071] What's New review comments

2011-01-30 Thread Nick Coghlan
New submission from Nick Coghlan ncogh...@gmail.com: Reviewing the What's New docs, this seemed like the easiest way to give Raymond a list of things I noticed: - first sentence in the ast module section needs rewording (currently includes fragments from a couple of different phrasings) - in

[issue11071] What's New review comments

2011-01-30 Thread Nick Coghlan
Nick Coghlan ncogh...@gmail.com added the comment: A couple more in the Build and CAPI section: - The is a new function should be There is a new function - The PyUnicode_CompareWithASCIIString() now either needs to drop the The or add function before the now. It's fascinating to read all

[issue11071] What's New review comments

2011-01-30 Thread Nick Coghlan
Nick Coghlan ncogh...@gmail.com added the comment: Another significant logging change: the addition of the style parameter for Formatter objects (allowing the use of str.format and string.Template style substitution instead of percent formatting) --

[issue11071] What's New review comments

2011-01-30 Thread Nick Coghlan
Nick Coghlan ncogh...@gmail.com added the comment: The last two logging changes potentially worth mentioning that I noticed: - simple callables can now be supplied as logging filters (see the version 3.2 note in http://docs.python.org/dev/library/logging#filter-objects) - the logging API docs

[issue11071] What's New review comments

2011-01-30 Thread Nick Coghlan
Nick Coghlan ncogh...@gmail.com added the comment: I was wrong, I found one more potentially notable logging change: http://docs.python.org/dev/library/logging#logging.setLogRecordFactory -- ___ Python tracker rep...@bugs.python.org

[issue11071] What's New review comments

2011-01-30 Thread Nick Coghlan
Nick Coghlan ncogh...@gmail.com added the comment: Adding Vinay, given the number of logging changes in 3.2 that don't appear to be in the What's New yet (the only logging change noted there at the moment is the inclusion of PEP 391) -- nosy: +vinay.sajip

[issue11071] What's New review comments

2011-01-30 Thread Raymond Hettinger
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: Nick, thanks for the read-through and comments. Later this week, will get add a section of logging. Other people are also welcome to use this tracker item for other comments. --

[issue11071] What's New review comments

2011-01-30 Thread Nick Coghlan
Nick Coghlan ncogh...@gmail.com added the comment: Correct docs links for LogRecord attributes section: http://docs.python.org/dev/library/logging#logrecord-attributes -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071

[issue11071] What's New review comments

2011-01-30 Thread Raymond Hettinger
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: Eli, put your suggestions here. Do not edit the document directly. Right now, it's conflicting with my pending edits. Also, see the instruction at the top of the document. -- assignee: rhettinger - eli.bendersky

[issue11071] What's New review comments

2011-01-30 Thread Eli Bendersky
Eli Bendersky eli...@gmail.com added the comment: Raymond, as I said in the email sorry I wasn't aware of the issue, and Georg permitted me to commit directly to the file once the freeze is over. Maybe there was a misunderstanding. Also, can you refer me to the part of the file you mean? I

[issue11071] What's New review comments

2011-01-30 Thread Raymond Hettinger
Raymond Hettinger rhettin...@users.sourceforge.net added the comment: Can you join IRC #python for a bit? -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071 ___

[issue11071] What's New review comments

2011-01-30 Thread Raymond Hettinger
Changes by Raymond Hettinger rhettin...@users.sourceforge.net: -- Removed message: http://bugs.python.org/msg127573 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071 ___

[issue11071] What's New review comments

2011-01-30 Thread Georg Brandl
Georg Brandl ge...@python.org added the comment: I was just told about typo and grammar fixes though :) -- nosy: +georg.brandl ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071 ___

[issue11071] What's New review comments

2011-01-30 Thread Raymond Hettinger
Changes by Raymond Hettinger rhettin...@users.sourceforge.net: -- assignee: eli.bendersky - rhettinger ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11071 ___

[issue11071] What's New review comments

2011-01-30 Thread Eli Bendersky
Eli Bendersky eli...@gmail.com added the comment: r88274 - python/branches/py3k/Doc/whatsnew/3.2.rst Revert r88272 -- the examples are more readable with spacing. Raymond - then perhaps we should consider revising PEP 8 as well. When I first read it, the no spaces around = rule for kwargs was