[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the patch! I've reviewed it on Rietveld: http://bugs.python.org/review/9859/ -- nosy: +berker.peksag stage: needs patch -> patch review versions: +Python 3.5 -Python 3.2 ___ Python tracker

[issue23950] Odd behavior with "file" and "filename" attributes in cgi.FieldStorage

2015-04-14 Thread Rob King
New submission from Rob King: Hello, everyone. I've noticed an issue that could be just a documentation inaccuracy or a genuine, minor bug in cgi.FieldStorage. The documentation for the module states: "You can test for an uploaded file by testing either the filename attribute or the file att

[issue23951] Update devguide style to use a similar theme as Docs

2015-04-14 Thread Carol Willing
New submission from Carol Willing: It would be helpful to update the conf.py file and dependencies to use a modified 'pydoctheme' for the devguide style. The benefits would be improved readability, a consistent look with the stdlib docs, and collapsible sidebars. Attached is a screenshot of a

[issue5438] test_bigmem.test_from_2G_generator uses more memory than expected

2015-04-14 Thread Steve Dower
Steve Dower added the comment: It's passed. There was no memory usage increase from that point, but after about 20 minutes it completed successfully. All the tests passed on Ubuntu, but again, they didn't really fill up RAM - 50GB looks like the high point. -- ___

[issue17751] ctypes/test/test_macholib.py fails when run from the installed location

2015-04-14 Thread Marin Dantchev
Marin Dantchev added the comment: @Zachary - while that is doable, ctypes.macholib.dyld seems to be available in the dev version of 3.5. >>> import ctypes.macholib.dyld >>> ctypes.macholib.dyld.__file__ '/home/morkov/dev/cpython/Lib/ctypes/macholib/dyld.py' >>> from ctypes.macholib.dyld import

[issue18166] 'value' attribute for ValueError

2015-04-14 Thread Ofer Schwarz
Ofer Schwarz added the comment: There's actually no advantage for a weakref here, since the exception object already holds an indirect reference to all the raising frame's locals through __traceback__. -- nosy: +blackfawn ___ Python tracker

[issue21039] pathlib strips trailing slash

2015-04-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: I beg to disagree :) Pathlib tries to find a compromise between user-friendliness and power, but it's definitely more on the user-friendliness side than, say, the os module APIs. In other words, I don't think it's a problem if not all details of OS semantics c

[issue21039] pathlib strips trailing slash

2015-04-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: Therefore, I'm finally closing this as won't fix :) -- resolution: -> wont fix status: open -> closed ___ Python tracker ___ __

[issue21833] Fix unicodeless build of Python

2015-04-14 Thread A.M. Kuchling
A.M. Kuchling added the comment: The subsequent discussion didn't arrive at a consensus. Most commenters wanted to drop --disable-unicode support and thought these patches were too extensive for 2.7, but Serhiy noted that running the tests with --disable-unicode turns up problems in the Unicod

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-14 Thread Skip Montanaro
Skip Montanaro added the comment: I'm not sure I understand the problem is. You have a list containing four values, and try to unpack it into five individual objects. There is no element in the list "data" to assign the name "value". -- nosy: +skip.montanaro __

[issue23951] Update devguide style to use a similar theme as Docs

2015-04-14 Thread Zachary Ware
Zachary Ware added the comment: One benefit to having a different theme for the devguide is that it makes clear that "you're not in the standard library docs anymore". I agree that that screenshot looks quite a bit better, though. -- nosy: +zach.ware _

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-14 Thread Steven D'Aprano
Steven D'Aprano added the comment: The error message isn't wrong, just hard to understand. In your example, when it says "need more than 4 values to unpack" it means that it got four values on the right hand side, and needs five (which is more than four) to match what is on the left. When the

[issue17751] ctypes/test/test_macholib.py fails when run from the installed location

2015-04-14 Thread Zachary Ware
Zachary Ware added the comment: My bad, you're right. Thanks! -- resolution: -> out of date stage: needs patch -> resolved status: open -> closed ___ Python tracker ___ ___

[issue5438] test_bigmem.test_from_2G_generator uses more memory than expected

2015-04-14 Thread Steve Dower
Steve Dower added the comment: Just for fun, I attached the memory usage graph from the Windows run. You can see the long pauses in the middle for the two changed tests, and the graph only goes up to 57GB despite the limit being set at 440GB. -- Added file: http://bugs.python.org/file3

[issue22046] ZipFile.read() should mention that it might throw NotImplementedError

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3e8047ee9bbb by Gregory P. Smith in branch '3.4': issue22046: mention that zipfile can raise NotImplementedError on unsupported https://hg.python.org/cpython/rev/3e8047ee9bbb New changeset 4b9deb7e6f2b by Gregory P. Smith in branch 'default': issue2

[issue22046] ZipFile.read() should mention that it might throw NotImplementedError

2015-04-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: fyi - i didn't update the 2.7 docs. just 3.4 and 3.5. if some committer wants to, feel free. -- nosy: +gregory.p.smith ___ Python tracker ___

[issue22046] ZipFile.read() should mention that it might throw NotImplementedError

2015-04-14 Thread Gregory P. Smith
Changes by Gregory P. Smith : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue22631] Feature Request CAN_RAW_FD_FRAMES

2015-04-14 Thread Larry Hastings
Larry Hastings added the comment: Isn't this a "new feature"? 2.7 is maybe fair game, but 3.4 arguably is not. It should be odd to have a field marked in the documentation as "New in 3.4.4." -- ___ Python tracker

[issue22631] Feature Request CAN_RAW_FD_FRAMES

2015-04-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: It is a new feature. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https

[issue22631] Feature Request CAN_RAW_FD_FRAMES

2015-04-14 Thread Larry Hastings
Larry Hastings added the comment: Benjamin, would you like CAN_RAW_FD_FRAMES in the next 2.7? -- nosy: +benjamin.peterson ___ Python tracker ___ _

[issue5438] test_bigmem.test_from_2G_generator uses more memory than expected

2015-04-14 Thread Joe Jevnik
Joe Jevnik added the comment: I think that the idea is not to get as close to the limit as possible but just to hard cap the memory usage of the test suite so that it doesn't get oom-killed. twouters, does this sound correct? Also, I think that this means that the new decorator is reporting a

[issue20669] OpenBSD: socket.recvmsg tests fail with OSError: [Errno 40] Message too long

2015-04-14 Thread Michael Schurter
Changes by Michael Schurter : -- nosy: -schmichael ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mai

[issue23342] run() - unified high-level interface for subprocess

2015-04-14 Thread Thomas Kluyver
Thomas Kluyver added the comment: 6a following in-person review with Gregory: - Reapplied to the updated codebase. - Docs: mention the older functions near the top, because they'll still be important for some time. - Docs: Be explicit that combined stdout/stderr goes in stdout attribute. - Vari

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-14 Thread Ulaga Nathan Mahadevan
Ulaga Nathan Mahadevan added the comment: I agree. I posted it as an enhancement request. Steven explained the expected message clearly. Thanks. On Tue, Apr 14, 2015 at 12:58 PM, Steven D'Aprano wrote: > > Steven D'Aprano added the comment: > > The error message isn't wrong, just hard to under

[issue23193] Please support "numeric_owner" in tarfile

2015-04-14 Thread Eric V. Smith
Eric V. Smith added the comment: Thanks for your review, Berker. I've updated the code with most of your suggestions, although some of them were mooted by some restructuring I did. A couple of questions/issues: - I'm not sure where we stand on keyword-only arguments. I certainly agree that I'd

[issue16405] Explain how to set up the whitespace commit hook locally

2015-04-14 Thread Ned Deily
Ned Deily added the comment: The wording of the patch looks good to me other than one issue: which hook to use. I notice Nick's suggestion is to use the hg "commit" hook. But in the comments for the checkwhitespace hook itself, "pretxncommit" is the suggested hook. The difference between th

[issue22211] Remove VMS specific code in expat.h & xmlrole.h

2015-04-14 Thread A.M. Kuchling
Changes by A.M. Kuchling : -- nosy: +akuchling, fdrake ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://

[issue23952] Document the 'maxlen' member of the cgi module

2015-04-14 Thread Rob King
Changes by Rob King : -- versions: +Python 2.7, Python 3.2, Python 3.3 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubs

[issue23952] Document the 'maxlen' member of the cgi module

2015-04-14 Thread Rob King
New submission from Rob King: The cgi module has a global variable, 'maxlen', that specifies the maximum length of a POST request. By default, this limit is 0, meaning an unlimited POST request size. Having an unlimited default opens up CGI scripts to resource-exhaustion attacks. Setting the

[issue23944] Argument Clinic: wrap impl's declaration if it's too long

2015-04-14 Thread Zachary Ware
Zachary Ware added the comment: Larry: Here's your sample: /*[clinic input] _winapi.CreateProcess application_name: Py_UNICODE(nullable=True) command_line: Py_UNICODE(nullable=True) proc_attrs: object Ignored internally, can be None. thread_attrs: object Ignored

[issue3353] make built-in tokenizer available via Python C API

2015-04-14 Thread Dustin J. Mitchell
Dustin J. Mitchell added the comment: New: - rename token symbols in token.h with a PYTOK_ prefix - include an example of using the PyTokenizer functions - address minor review comments -- Added file: http://bugs.python.org/file38999/issue3353-2.patch

[issue5438] test_bigmem.test_from_2G_generator uses more memory than expected

2015-04-14 Thread Thomas Wouters
Thomas Wouters added the comment: Yes. The test doesn't run with more than the requested "units", but if you run it without -M it does run with a very small number, in order to make sure the tests don't bitrot. The mechanism could do with an overhaul though; I wrote it in 2006 or so, before we h

[issue22631] Feature Request CAN_RAW_FD_FRAMES

2015-04-14 Thread R. David Murray
R. David Murray added the comment: There is no CAN support in 2.7, so no. -- nosy: +r.david.murray ___ Python tracker ___ ___ Python-b

[issue9014] Incorrect documentation of the PyObject_HEAD macro

2015-04-14 Thread A.M. Kuchling
A.M. Kuchling added the comment: Did you intend to remove the discussion of Py_TRACE_REFS completely? (I've reworked your patch a little bit, adding some markup such as :c:macro:`Py_REFCNT`.) -- nosy: +akuchling Added file: http://bugs.python.org/file39000/issue.txt _

[issue9014] Incorrect documentation of the PyObject_HEAD macro

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 760c5cfacbaa by Gregory P. Smith in branch '3.4': issue9014: Properly document PyObject_HEAD and friends post-PEP-3123. https://hg.python.org/cpython/rev/760c5cfacbaa New changeset 7dc8f0075d60 by Gregory P. Smith in branch 'default': issue9014: Pro

[issue9014] Incorrect documentation of the PyObject_HEAD macro

2015-04-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: i used wiggin15's patch to start with. I'm now looking at akuchling's patch and will incorporate any additional things it adds (I missed that earlier). -- assignee: docs@python -> gregory.p.smith nosy: +gregory.p.smith __

[issue9014] Incorrect documentation of the PyObject_HEAD macro

2015-04-14 Thread A.M. Kuchling
A.M. Kuchling added the comment: The markup is not a huge deal, I think. I also did some bits of rewording that can probably be ignored. The TRACE_REFS question is the only important one, I think. -- ___ Python tracker

[issue23953] test_mmap uses cruel and unusual amounts of disk space

2015-04-14 Thread Larry Hastings
New submission from Larry Hastings: My laptop is running 64-bit Linux (14.10). It has 4.6GB of free disk space. Naturally that's not enough to run test_mmap. When I run the test suite, test_mmap consumes all available disk space, then fails. (Hopefully freeing all its temporary files!) If

[issue23935] Clean up Clinic's type expressions of buffers

2015-04-14 Thread Larry Hastings
Larry Hastings added the comment: New patch revision, including the new API change (the "types" argument to a constructor must now be a set of strings). -- Added file: http://bugs.python.org/file39001/larry.clinic.buffer.conceptual.cleanup.3.txt ___

[issue23944] Argument Clinic: wrap impl's declaration if it's too long

2015-04-14 Thread Zachary Ware
Zachary Ware added the comment: Alright, alright, I'll get you a file. On Tue, Apr 14, 2015 at 1:22 PM, Larry Hastings wrote: > > Larry Hastings added the comment: > > I wish the Python bug tracker had a way of attaching files to issues, so we > didn't have to just copy and paste into and out

[issue9014] Incorrect documentation of the PyObject_HEAD macro

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 752ea0acc37e by Gregory P. Smith in branch '3.4': issue9014: Include more formatting on :c:type:`PyObject` etc. https://hg.python.org/cpython/rev/752ea0acc37e New changeset 78a2d1169be1 by Gregory P. Smith in branch 'default': issue9014: Include mor

[issue23944] Argument Clinic: wrap impl's declaration if it's too long

2015-04-14 Thread Larry Hastings
Larry Hastings added the comment: I wish the Python bug tracker had a way of attaching files to issues, so we didn't have to just copy and paste into and out of the comments. Ah well, wishful thinking! -- ___ Python tracker

[issue9014] Incorrect documentation of the PyObject_HEAD macro

2015-04-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: We no longer describe the contents of PyObject in the docs so mentioning Py_TRACE_REFS does not seem worth it as that just changes Py_HEAD_EXTRA which adds the doubly linked list to PyObject (today). Py_TRACE_REFS isn't useful for anyone to know about IMNSHO

[issue23944] Argument Clinic: wrap impl's declaration if it's too long

2015-04-14 Thread Zachary Ware
Zachary Ware added the comment: You can even have the whole thing, with lots of samples :) -- Added file: http://bugs.python.org/file39002/_winapi.c ___ Python tracker ___ __

[issue23944] Argument Clinic: wrap impl's declaration if it's too long

2015-04-14 Thread Larry Hastings
Larry Hastings added the comment: That's AMAZING, you mean the web site knew how to do that THE WHOLE TIME? -- ___ Python tracker ___

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-14 Thread Michael McFadden
Michael McFadden added the comment: I have a patch for moving script_helper as R. David suggested. Here it is. -- nosy: +flipmcf Added file: http://bugs.python.org/file39003/iss9517_move_script_helpers_py.patch ___ Python tracker

[issue13472] devguide doesn’t list all build dependencies

2015-04-14 Thread Jeff Ramnani
Jeff Ramnani added the comment: So, the devguide has been updated since this issue was opened. The Quick Start section now has a link to build documentation, which includes information about build dependencies. Is this sufficient to call this bug closed? -- nosy: +jramnani _

[issue12923] test_urllib fails in refleak mode

2015-04-14 Thread Daniel Rocco
Daniel Rocco added the comment: Hi, Here is an alternate patch to the test suite that demonstrates the failure without needing refleak mode. The test works by issuing enough requests that, if retries are not independent per request, the test triggers the code path that results in the test faili

[issue23921] Standardize documentation whitespace, formatting

2015-04-14 Thread James Edwards
James Edwards added the comment: Thanks for the review Serhiy. I'll prepare a revised patchset, given the comments from you and Berker and have it uploaded today. Thanks again. -- ___ Python tracker

[issue23954] Pressing enter/return or clicking IDLE's autocomplete does not select the option

2015-04-14 Thread Al Sweigart
New submission from Al Sweigart: Currently, when you press Ctrl+Space or select Edit > Show Completions, a dropdown menu appears and lets you select an autocomplete option. If you press Tab, the highlighted option in the dropdown is selected and your typing autocompletes. However, pressing ent

[issue9246] os.getcwd() hardcodes max path len

2015-04-14 Thread William Orr
William Orr added the comment: Revisiting this, I've updated python3 to calculate this and use gradual dynamic allocation like the python2 implementation. -- nosy: +worr versions: +Python 3.5 -Python 2.7, Python 3.2, Python 3.3 Added file: http://bugs.python.org/file39005/max_getcwd.pat

[issue13866] {urllib, urllib.parse}.urlencode should not use quote_plus

2015-04-14 Thread Arnon Yaari
Arnon Yaari added the comment: Updated patch to the correct format, added a test and some more documentation. -- nosy: +wiggin15 versions: +Python 3.5 -Python 3.4 Added file: http://bugs.python.org/file39006/issue13866.patch ___ Python tracker

[issue23955] Add python.ini file for embedded/applocal installs

2015-04-14 Thread Steve Dower
New submission from Steve Dower: When Python starts running we (getpathp.c) looks in the registry for its library directory. To avoid this, you can set PYTHONPATH and PYTHONHOME environment variables, but this isn't always easy if you've copied Python into your app's directory. We should look

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-14 Thread Michael McFadden
Michael McFadden added the comment: bobcatfish: Sorry, I didn't refresh and see your comment before submitting my patch. It only moves script_helpers, but doesn't address the original OP. Hopefully I made your life easier, not harder. -- ___ Pyt

[issue1481347] parse_makefile doesn't handle $$ correctly

2015-04-14 Thread Kasia Jachim
Kasia Jachim added the comment: Tested on 2.7.6 (default from Ubuntu) and 3.5.0a3+ (built from sources), in both cases $$ seems to work correctly, returned {'FOO': '${bar} bla bla'} for the input from msg60909. -- nosy: +kjachim ___ Python tracker

[issue23951] Update devguide style to use a similar theme as Docs

2015-04-14 Thread Carol Willing
Carol Willing added the comment: Zach, Good point. Perhaps a different highlight color across the top would be enough to indicate that "you are in the dev guide". -- ___ Python tracker

[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Laura Rupprecht
Laura Rupprecht added the comment: Thanks Berker! I've added some updates to the patch taking your suggestions into account. There is also a change from using "detect_module_matches" to "detect_api_mismatch", as it is a more general (and accurate) description. Also, adding tests for the "dete

[issue13472] devguide doesn’t list all build dependencies

2015-04-14 Thread Ned Deily
Changes by Ned Deily : -- nosy: +willingc ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.o

[issue16405] Explain how to set up the whitespace commit hook locally

2015-04-14 Thread Carol Willing
Carol Willing added the comment: Ned, Thanks for the review and feedback. It seems reasonable to me to mention both the "pretxncommit" hook as well as the "commit" hook as well as your brief comments on the difference between the two. I'll make that change to the patch and resubmit. ---

[issue23944] Argument Clinic: wrap impl's declaration if it's too long

2015-04-14 Thread Larry Hastings
Larry Hastings added the comment: Attached is a patch. This causes a lot of churn, darn. Should I copy & paste the patch into this text box too? Maybe that would be more convenient! -- Added file: http://bugs.python.org/file39008/larry.clinic.wrap.long.impl.decls.1.txt

[issue21327] socket.type value changes after using settimeout()

2015-04-14 Thread Raúl Cumplido
Raúl Cumplido added the comment: Added patch that solves issue, but I am not sure this is what you expect. If you think this is the expected behavior I will add docs and tests: >>> sock = socket.socket(type=socket.SOCK_STREAM | socket.SOCK_NONBLOCK) >>> sock.type 2049 >>> socket.get_socket_type(

[issue21327] socket.type value changes after using settimeout()

2015-04-14 Thread Raúl Cumplido
Raúl Cumplido added the comment: Added docs and test in the patch. -- keywords: +patch Added file: http://bugs.python.org/file39009/issue21327.patch ___ Python tracker ___ __

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-14 Thread William Orr
William Orr added the comment: I've updated the error message to just include the expected number of arguments. I think this makes it way more readable. -- keywords: +patch nosy: +worr Added file: http://bugs.python.org/file39010/maxvalueerror.patch

[issue23949] Number of elements display in error message is wrong while unpacking in traceback

2015-04-14 Thread Arnon Yaari
Arnon Yaari added the comment: Adding alternative patch for suggestion. -- nosy: +wiggin15 versions: +Python 3.5 -Python 3.2 Added file: http://bugs.python.org/file39011/issue23949.diff ___ Python tracker _

[issue23944] Argument Clinic: wrap impl's declaration if it's too long

2015-04-14 Thread Larry Hastings
Larry Hastings added the comment: Okay, this patch is about half the size. I had a bug that was throwing away some important syntax. With this patch applied, Python builds and the test suite is as reasonable as usual. I swear, C compilers are so fussy sometimes! -- Added file: http

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-14 Thread Michael McFadden
Michael McFadden added the comment: re: test.test_tools.py - should this also move into test.support ? -- ___ Python tracker ___ ___ P

[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset b42d1f2aa7a2 by Gregory P. Smith in branch 'default': issue9859: Adds a test.support.detect_api_mismatch function useful to https://hg.python.org/cpython/rev/b42d1f2aa7a2 New changeset 0b6c894c3c96 by Gregory P. Smith in branch 'default': issue9859:

[issue23921] Standardize documentation whitespace, formatting

2015-04-14 Thread James Edwards
James Edwards added the comment: Attaching revised patch per reviews. Notable changes: * Reverted howto/curses.rst multiple inline statements -> multi-target assignment (curses.rst is now unchanged) * Reverted library/subprocess.rst "==>" to "# ==>" changes since there are other

[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Berker Peksag
Berker Peksag added the comment: I've added a couple of comments about the test: http://bugs.python.org/review/9859/ -- ___ Python tracker ___ ___

[issue23957] Additional misspelled in documentation

2015-04-14 Thread Andrew Pinkham
New submission from Andrew Pinkham: There is a minor typo under PyMem_SetupDebugHooks in the C-API section in 3.4 and 3.5 . "Additional" is misspelled as "Additionnal" on the page. https://docs.python.org/3.5/c-api/memory.html https://docs.python.org/3.4/c-api/memory.html The problem does not

[issue23956] Compatibility misspelled in Lib/imp.py

2015-04-14 Thread Jacinda Shelly
New submission from Jacinda Shelly: Minor misspelling in Lib/imp.py. Doing this as a training exercise for my first patch. -- assignee: docs@python components: Documentation files: misspelling.patch keywords: patch messages: 241005 nosy: docs@python, jacinda priority: normal severity: n

[issue20172] Derby #3: Convert 67 sites to Argument Clinic across 4 files (Windows)

2015-04-14 Thread Zachary Ware
Changes by Zachary Ware : Added file: http://bugs.python.org/file39016/9ec35c653970.diff ___ Python tracker ___ ___ Python-bugs-list mailing l

[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: Thanks! Patch applied. I reworded one doc string slightly and fixed up a few lines that were longer than 80 characters. Berker's most recent comments are good ones and can be addressed in another patch. Laura, can you jump through the https://www.python.

[issue9858] Python and C implementations of io are out of sync

2015-04-14 Thread Gregory P. Smith
Gregory P. Smith added the comment: A test has been added as part of issue9859, it is marked with @unittest.skip as the API surface does not yet match. -- nosy: +gregory.p.smith ___ Python tracker _

[issue20172] Derby #3: Convert 67 sites to Argument Clinic across 4 files (Windows)

2015-04-14 Thread Zachary Ware
Zachary Ware added the comment: Latest patch ought to be good, if anybody feels like rubber-stamping a 5000 line patch :) -- nosy: +steve.dower ___ Python tracker ___ __

[issue9517] Make test.script_helper more comprehensive, and use it in the test suite

2015-04-14 Thread R. David Murray
R. David Murray added the comment: test_tools is a test suite that tests the tools in the scripts directory, it is not tools for testing. So no, it doesn't belong in test.support. -- ___ Python tracker ___

[issue12807] Optimization/refactoring for {bytearray, bytes, unicode}.strip()

2015-04-14 Thread Matt Soucy
Changes by Matt Soucy : -- nosy: +msoucy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe: https://mail.python.or

[issue23958] compile warnings in libffi

2015-04-14 Thread Steve R. Hastings
New submission from Steve R. Hastings: The normal build should not have any warnings. The source for libffi included some comparisons between signed int and unsigned int, which caused warnings. The patch changes the signed int variables to unsigned int. -- components: Build files: lib

[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 9903368b9d7b by Gregory P. Smith in branch 'default': issue9859: rename CPyMatchTest to APIMismatchTest and add @support.cpython_only. https://hg.python.org/cpython/rev/9903368b9d7b New changeset cbdd56d07123 by Gregory P. Smith in branch 'default':

[issue23919] [Windows] test_os fails several C-level assertions

2015-04-14 Thread Steve Dower
Steve Dower added the comment: So just discussed with Zach the idea of hiding all assertion outputs by default and then using -n to display the output on stderr. That would help people get started running tests locally as well, since the dialogs that appear by default look like pretty bad fail

[issue21916] Create unit tests for turtle textonly

2015-04-14 Thread Gregory Loyse
Gregory Loyse added the comment: Thanks David for your review! I have added a new patch in response. Note the file has a new name -- Added file: http://bugs.python.org/file39018/test_turtle.patch ___ Python tracker

[issue23944] Argument Clinic: wrap impl's declaration if it's too long

2015-04-14 Thread Zachary Ware
Zachary Ware added the comment: After an English lesson, looks fine to me. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue20769] Reload() description is unclear

2015-04-14 Thread Dorian Pula
Changes by Dorian Pula : -- keywords: +patch versions: +Python 3.5 Added file: http://bugs.python.org/file39019/reload_importlib_doc_py_3_5_fix.patch ___ Python tracker ___

[issue22137] Test imaplib API on all methods specified in RFC 3501

2015-04-14 Thread Maciej Szulik
Maciej Szulik added the comment: Milan, thanks for your patch, I've added comments to it (look for review link next to submitted file), can you address them please? Other option is, if you don't mind, I'll take over this issue and finish on top of your work. -- nosy: +maciej.szulik _

[issue23957] Additional misspelled in documentation

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset ef58fc2e7b06 by R David Murray in branch '3.4': #23957: fix typo. https://hg.python.org/cpython/rev/ef58fc2e7b06 New changeset 4286afa7b63e by R David Murray in branch 'default': Merge: #23957: fix typo. https://hg.python.org/cpython/rev/4286afa7b63

[issue23957] Additional misspelled in documentation

2015-04-14 Thread R. David Murray
R. David Murray added the comment: Thanks, Andrew. -- nosy: +r.david.murray resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___ __

[issue23956] Compatibility misspelled in Lib/imp.py

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset 08400c64af93 by Zachary Ware in branch '3.4': Issue #23956: Fix typo in imp.py docstring. https://hg.python.org/cpython/rev/08400c64af93 New changeset 5586d4a4402e by Zachary Ware in branch 'default': Closes #23956: Merge with 3.4 https://hg.python.

[issue23956] Compatibility misspelled in Lib/imp.py

2015-04-14 Thread Zachary Ware
Zachary Ware added the comment: Thank you for the patch! -- nosy: +zach.ware versions: +Python 3.4 ___ Python tracker ___ ___ Python-b

[issue23959] Update imaplib to support RFC3501

2015-04-14 Thread Maciej Szulik
New submission from Maciej Szulik: Current imaplib implementation follows obsoleted RFC2060. It should be updated to follow RFC3501. -- components: email messages: 241022 nosy: barry, maciej.szulik, r.david.murray priority: normal severity: normal status: open title: Update imaplib to s

[issue9731] Add ABCMeta.has_methods and tests that use it

2015-04-14 Thread Laura Rupprecht
Laura Rupprecht added the comment: Related item: Added a helper function to verify API match of two modules, addressing issue9859. It checks for a closer match but mentioned this ticket from the thread. -- nosy: +laura ___ Python tracker

[issue23959] Update imaplib to support RFC3501

2015-04-14 Thread Maciej Szulik
Maciej Szulik added the comment: I'm volunteering myself to work on this as a follow-up work to http://bugs.python.org/issue22137. -- ___ Python tracker ___

[issue23958] compile warnings in libffi

2015-04-14 Thread Zachary Ware
Zachary Ware added the comment: Steve: libffi is an upstream project, so technically they should be the ones to patch it. However, we do sometimes patch our own copy anyway and just keep the diff around. Nosying doko as the guy who usually gets stuck handling libffi upgrades and will know be

[issue18128] pygettext: non-standard timestamp format in POT-Creation-Date

2015-04-14 Thread Michael McFadden
Michael McFadden added the comment: I'm going to be adding some tests around pygettext tool and then tackling this. -- nosy: +flipmcf ___ Python tracker ___ _

[issue9859] Add tests to verify API match of modules with 2 implementations

2015-04-14 Thread Roundup Robot
Roundup Robot added the comment: New changeset c6df85e1d42e by Gregory P. Smith in branch 'default': issue9859: Use an expected failure rather than a skip. https://hg.python.org/cpython/rev/c6df85e1d42e -- ___ Python tracker

[issue21116] Failure to create multiprocessing shared arrays larger than 50% of memory size under linux

2015-04-14 Thread Antoine Pitrou
Antoine Pitrou added the comment: Actually, recent POSIX states unconditionally that: « If the file previously was smaller than this size, ftruncate() shall increase the size of the file. If the file size is increased, the extended area shall appear as if it were zero-filled. » (from http://p

[issue21327] socket.type value changes after using settimeout()

2015-04-14 Thread Nina Zakharenko
Nina Zakharenko added the comment: Maybe it would be better if the type property on socket had this behavior, rather than creating a new method. -- nosy: +nnja ___ Python tracker __

[issue20769] Reload() description is unclear

2015-04-14 Thread Dorian Pula
Changes by Dorian Pula : Added file: http://bugs.python.org/file39020/reload_builtin_functions_doc_py_2_7_fix.patch ___ Python tracker ___ __

[issue20769] Reload() description is unclear

2015-04-14 Thread Dorian Pula
Dorian Pula added the comment: Attached patches with proposed change to the documentation to make the description clearer. Please review and comment. -- nosy: +dorianpula ___ Python tracker __

[issue23935] Clean up Clinic's type expressions of buffers

2015-04-14 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: The new API change looks doubtful for me. It is more verbose. And less readable. It makes harder to search in sources, because {'str', 'robuffer'} is the same as {'robuffer', 'str'}. If Argument Clinic would a tool with programmatic API, sets would make sens

[issue21327] socket.type value changes after using settimeout()

2015-04-14 Thread R. David Murray
R. David Murray added the comment: If we were designing from scratch, that would be true. But we are stuck with the behavior that we have, and cannot change it because we need to preserve backward compatibility. This is why we need to make it a new method. -- ___

<    1   2   3   >