Re: [python-committers] Please edit the commit message when merge a PR

2017-08-02 Thread Serhiy Storchaka
11.07.17 19:39, Brett Cannon пише: There's isn't a way to block a merge at that stage. But one thing I've been thinking about is adding a check to Bedevere post-merge that sees if the commit message was left unchanged (not quite sure if I can come up with a reliable heuristic, though). In inst

Re: [python-committers] mention-bot is dead, long live the (misnamed) CODEOWNERS file!

2017-08-02 Thread Terry Reedy
Rearranging things in order. I asked > Do people on a team have to be core-developers? The broader question is whether active people who want notifications have to be a committer to get automatic notifications of a PR and in particular a review request. It appears that anyone with a github

Re: [python-committers] mention-bot is dead, long live the (misnamed) CODEOWNERS file!

2017-08-02 Thread Senthil Kumaran
Only committers can merge stuff. So, that would make a requirement that reviewers (and @team-of-reviwers)should be core-dev / committers. On Wed, Aug 2, 2017 at 2:47 PM, Steve Dower wrote: > Should we seed the teams from the experts list? > > > > I have no strong opinion about core vs non-core

Re: [python-committers] mention-bot is dead, long live the (misnamed) CODEOWNERS file!

2017-08-02 Thread Steve Dower
Should we seed the teams from the experts list? I have no strong opinion about core vs non-core dev, but I think part of the point of the distinction is reflected here. Why would we notify someone about every PR in an area if we don’t want them to be committers? Top-posted from my Windows phone

Re: [python-committers] mention-bot is dead, long live the (misnamed) CODEOWNERS file!

2017-08-02 Thread Terry Reedy
On 8/2/2017 10:37 AM, Nick Coghlan wrote: On 2 August 2017 at 07:09, Christian Heimes wrote: I suggested teams to make the file a bit easier to maintain. The rule format works differently than the old mentionbot format. In the old format we had a relationship user -> files. The new CODEOWNERS f

Re: [python-committers] mention-bot is dead, long live the (misnamed) CODEOWNERS file!

2017-08-02 Thread Nick Coghlan
On 2 August 2017 at 07:09, Christian Heimes wrote: > I suggested teams to make the file a bit easier to maintain. The rule > format works differently than the old mentionbot format. In the old > format we had a relationship user -> files. The new CODEOWNERS format > has files -> users mapping with