Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)

2009-01-08 Thread M.-A. Lemburg
On 2009-01-08 01:01, Collin Winter wrote: On Wed, Jan 7, 2009 at 2:35 PM, Brett Cannon br...@python.org wrote: On Wed, Jan 7, 2009 at 10:57, M.-A. Lemburg m...@egenix.com wrote: [SNIP] BTW: The _codecsmodule.c file is a 4 spaces indent file as well (just like all Unicode support source

Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)

2009-01-08 Thread Raymond Hettinger
From: M.-A. Lemburg m...@egenix.com The question to put up against this is: How often do you get irritated by lines not being correctly indented ? Basically never. Raymond ___ Python-Dev mailing list Python-Dev@python.org

Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)

2009-01-08 Thread Victor Stinner
Le Thursday 08 January 2009 10:48:53 M.-A. Lemburg, vous avez écrit : svn blame -x -b will do the trick for SVN. Perhaps there's even some .subversion/config option to set this globally. The question really is: How often do Python developers use svn blame ? I use svn blame to find a revision

Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)

2009-01-08 Thread Kristján Valur Jónsson
Sent: 8. janúar 2009 09:49 To: Collin Winter Cc: Antoine Pitrou; python-dev@python.org Subject: Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k) Or better yet, really bite the bullet and just reindent everything to spaces. Not every one uses vim

Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)

2009-01-08 Thread M.-A. Lemburg
indentations in C files (Decoder functions accept str in py3k) Or better yet, really bite the bullet and just reindent everything to spaces. Not every one uses vim or emacs, nor do all tools understand their modelines. FYI, there are options to svn blame and git to skip whitespace-only changes

Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)

2009-01-08 Thread Brett Cannon
On Thu, Jan 8, 2009 at 01:52, Raymond Hettinger pyt...@rcn.com wrote: From: M.-A. Lemburg m...@egenix.com The question to put up against this is: How often do you get irritated by lines not being correctly indented ? Basically never. And of course I am the polar opposite: frequently enough

Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)

2009-01-08 Thread Guido van Rossum
On Thu, Jan 8, 2009 at 10:29 AM, Brett Cannon br...@python.org wrote: On Thu, Jan 8, 2009 at 01:52, Raymond Hettinger pyt...@rcn.com wrote: From: M.-A. Lemburg m...@egenix.com The question to put up against this is: How often do you get irritated by lines not being correctly indented ?

Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)

2009-01-08 Thread Brett Cannon
On Thu, Jan 8, 2009 at 10:41, Guido van Rossum gu...@python.org wrote: On Thu, Jan 8, 2009 at 10:29 AM, Brett Cannon br...@python.org wrote: On Thu, Jan 8, 2009 at 01:52, Raymond Hettinger pyt...@rcn.com wrote: From: M.-A. Lemburg m...@egenix.com The question to put up against this is: How

Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)

2009-01-08 Thread Nick Coghlan
Brett Cannon wrote: Can we then all agree that a policy of re-indenting per function as changes are made to the code is acceptable but not required? Such a rule would certainly make *my* life a lot easier - the reason I find the tabs annoying is because I have my editor set to switch everything

Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)

2009-01-08 Thread Brett Cannon
On Thu, Jan 8, 2009 at 12:43, Nick Coghlan ncogh...@gmail.com wrote: Brett Cannon wrote: Can we then all agree that a policy of re-indenting per function as changes are made to the code is acceptable but not required? Such a rule would certainly make *my* life a lot easier - the reason I

Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)

2009-01-08 Thread Benjamin Peterson
On Thu, Jan 8, 2009 at 2:52 PM, Brett Cannon br...@python.org wrote: On Thu, Jan 8, 2009 at 12:43, Nick Coghlan ncogh...@gmail.com wrote: Even if we do adopt such a rule, C patches posted to the tracker should still try to avoid including pure whitespace changes though - leaving the

Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)

2009-01-08 Thread Brett Cannon
On Thu, Jan 8, 2009 at 17:31, Benjamin Peterson benja...@python.org wrote: On Thu, Jan 8, 2009 at 2:52 PM, Brett Cannon br...@python.org wrote: On Thu, Jan 8, 2009 at 12:43, Nick Coghlan ncogh...@gmail.com wrote: Even if we do adopt such a rule, C patches posted to the tracker should still

Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)

2009-01-08 Thread Benjamin Peterson
On Thu, Jan 8, 2009 at 7:39 PM, Brett Cannon br...@python.org wrote: On Thu, Jan 8, 2009 at 17:31, Benjamin Peterson benja...@python.org wrote: On Thu, Jan 8, 2009 at 2:52 PM, Brett Cannon br...@python.org wrote: On Thu, Jan 8, 2009 at 12:43, Nick Coghlan ncogh...@gmail.com wrote: Even if we

Re: [Python-Dev] Fixing incorrect indentations in C files (Decoder functions accept str in py3k)

2009-01-08 Thread Brett Cannon
On Thu, Jan 8, 2009 at 17:42, Benjamin Peterson benja...@python.org wrote: On Thu, Jan 8, 2009 at 7:39 PM, Brett Cannon br...@python.org wrote: On Thu, Jan 8, 2009 at 17:31, Benjamin Peterson benja...@python.org wrote: On Thu, Jan 8, 2009 at 2:52 PM, Brett Cannon br...@python.org wrote: On