[Python-Dev] Reminder: Please elaborate commit messages

2018-05-22 Thread Victor Stinner
Hi, In https://bugs.python.org/issue33531, Andrew Svetlov wrote "Fixed failed sendfile tests on Windows (at least I hope so)." without giving any bpo number or a commit number. So I looked at latest commits and I found: --- commit e2537521916c5bf88fcf54d4654ff1bcd332be4a Author: Andrew Svetlov D

Re: [Python-Dev] Reminder: Please elaborate commit messages

2018-05-22 Thread Andrew Svetlov
Sorry for that. I thought that the bpo issue can be skipped because it is tests-only change, no asyncio code was affected. Will be more accurate next time. On Tue, May 22, 2018 at 3:26 PM Victor Stinner wrote: > Hi, > > In https://bugs.python.org/issue33531, Andrew Svetlov wrote "Fixed > failed

Re: [Python-Dev] Reminder: Please elaborate commit messages

2018-05-22 Thread Victor Stinner
Usually, I don't open a new bug to fix or enhance a test. So I wouldn't say that it's mandatory. It's really on a case by case basis. It seems like test_asyncio failures are a hot topic these days :-) It's one of the reasons why Python 3.7rc1 has been delayed by 2 days, no? :-) Victor 2018-05-22

Re: [Python-Dev] Reminder: Please elaborate commit messages

2018-05-22 Thread Terry Reedy
On 5/22/2018 8:37 AM, Andrew Svetlov wrote: Sorry for that. I thought that the bpo issue can be skipped because it is tests-only change, no asyncio code was affected. Will be more accurate next time. A new issue was not needed. Adding 'bpo-33531' would have been fine, automatically linking t

Re: [Python-Dev] Reminder: Please elaborate commit messages

2018-05-22 Thread Yury Selivanov
On Tue, May 22, 2018 at 8:52 AM Victor Stinner wrote: > Usually, I don't open a new bug to fix or enhance a test. So I > wouldn't say that it's mandatory. It's really on a case by case basis. > It seems like test_asyncio failures are a hot topic these days :-) > It's one of the reasons why Pytho

Re: [Python-Dev] Reminder: Please elaborate commit messages

2018-05-22 Thread Terry Reedy
On 5/22/2018 2:26 PM, Yury Selivanov wrote: On Tue, May 22, 2018 at 8:52 AM Victor Stinner wrote: Usually, I don't open a new bug to fix or enhance a test. So I wouldn't say that it's mandatory. It's really on a case by case basis. It seems like test_asyncio failures are a hot topic these d