On Thu, 2015-03-12 at 08:34 -0400, Josef Skladanka wrote:
> == openqa_trigger.py ==
>
> I really don't like the whole check_condition() thing. The name of the
> function does no correspond to what it does, which is quite unpleasant
> together with its side-effects (scheduling the jobs, and changin
On Thu, 2015-03-12 at 07:57 -0700, Adam Williamson wrote:
> On 2015-03-12 02:50, Josef Skladanka wrote:
> > Adam,
> >
> > please set these up for review in Phabricator. I strongly suspect
> > (given the time that I spent looking at the changes so far) that
> > some discussion will be required, a
On 2015-03-12 02:50, Josef Skladanka wrote:
Adam,
please set these up for review in Phabricator. I strongly suspect
(given the time that I spent looking at the changes so far) that some
discussion will be required, and Phab is _the_ place to do it.
Also, please make sure to rebase your repos to
Some preliminary feedback:
= openqa_fedora =
== _do_install_and_reboot.pm ==
Please delete the "anaconda_install_finish" needle, if it is unused.
anaconda_install_done needle:
* Why is only a part of the button selected?
* What is the logic behind "assert_and_click" for multiple areas in o
Adam,
please set these up for review in Phabricator. I strongly suspect (given the
time that I spent looking at the changes so far) that some discussion will be
required, and Phab is _the_ place to do it.
Also, please make sure to rebase your repos to their current state, before
creating the ph
Hey, folks. So I've been tweaking and testing my openQA live image
test stuff today, and I think it's probably about ready for merging.
I've got branches of both openqa_fedora and openqa_fedora_tools with
relevant changes:
https://www.happyassassin.net/cgit/openqa_fedora/log/?h=live
https://www
