Am 03.08.2017 um 17:02 hat Kevin Wolf geschrieben:
> This is the first part of some fixes to bdrv_reopen(), which seems
> reasonable enough to merge for 2.10.
>
> There is much more wrong with bdrv_reopen() currently, especially with
> respect to op blocker permissions (basically the required perm
Cleber Rosa writes:
> On 07/21/2017 08:33 AM, Stefan Hajnoczi wrote:
>> On Thu, Jul 20, 2017 at 11:47:27PM -0400, Cleber Rosa wrote:
>>> This is a follow up to a previous discussion about reported failures when
>>> running some qemu-iotests. Turns out the failures were due to missing
>>> librari
Stefan Hajnoczi writes:
> On Wed, Jul 26, 2017 at 02:24:02PM -0400, Cleber Rosa wrote:
>>
>>
>> On 07/26/2017 01:58 PM, Stefan Hajnoczi wrote:
>> > On Tue, Jul 25, 2017 at 12:16:13PM -0400, Cleber Rosa wrote:
>> >> On 07/25/2017 11:49 AM, Stefan Hajnoczi wrote:
>> >>> On Fri, Jul 21, 2017 at 10
Am 07.08.2017 um 22:30 hat Eric Blake geschrieben:
> This also requires changing the return type of get_cluster_offset()
> and adjusting all callers.
>
> Use osdep.h macros instead of open-coded rounding while in the
> area.
>
> Reported-by: Markus Armbruster
> Signed-off-by: Eric Blake
> ---
>
Am 07.08.2017 um 22:30 hat Eric Blake geschrieben:
> vpc_open() was checking for bdrv_getlength() failure in one, but
> not the other, location.
>
> Reported-by: Markus Armbruster
> Signed-off-by: Eric Blake
> ---
> block/vpc.c | 9 -
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
Am 07.08.2017 um 22:30 hat Eric Blake geschrieben:
> It's been #if 0'd since its introduction in 2006, commit 585f8587.
> We can revive dead code if we need it, but in the meantime, it has
> bit-rotted (for example, not checking for failure in bdrv_getlength()).
>
> Signed-off-by: Eric Blake
Rev
Am 07.08.2017 um 22:30 hat Eric Blake geschrieben:
> qcow2_co_pwritev_compressed() should not call bdrv_truncate()
> if determining the size failed.
>
> Reported-by: Markus Armbruster
> Signed-off-by: Eric Blake
Reviewed-by: Kevin Wolf
07.08.2017 18:57, Kevin Wolf wrote:
Am 07.08.2017 um 16:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
185 iotest is broken.
How to test:
i=0; while ./check -qcow2 -nocache 185; do ((i+=1)); echo N = $i; \
done; echo N = $i
finished for me like this:
185 2s ... - output mismatch (see 1
Am 08.08.2017 um 10:42 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 07.08.2017 18:57, Kevin Wolf wrote:
> > Am 07.08.2017 um 16:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > 185 iotest is broken.
> > >
> > > How to test:
> > > > i=0; while ./check -qcow2 -nocache 185; do ((i+=1)); echo
08.08.2017 12:04, Vladimir Sementsov-Ogievskiy wrote:
08.08.2017 11:53, Kevin Wolf wrote:
Am 08.08.2017 um 10:42 hat Vladimir Sementsov-Ogievskiy geschrieben:
07.08.2017 18:57, Kevin Wolf wrote:
Am 07.08.2017 um 16:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
185 iotest is broken.
How to
08.08.2017 11:53, Kevin Wolf wrote:
Am 08.08.2017 um 10:42 hat Vladimir Sementsov-Ogievskiy geschrieben:
07.08.2017 18:57, Kevin Wolf wrote:
Am 07.08.2017 um 16:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
185 iotest is broken.
How to test:
i=0; while ./check -qcow2 -nocache 185; do ((i+
On Tue, Aug 08, 2017 at 10:39:29AM +0800, Fam Zheng wrote:
> On Fri, 08/04 16:49, Daniel P. Berrange wrote:
> > This is odd. In the bdrv_aligned_readv() it looks very much like
> > we'll reference qiov->niov, if bytes != 0, so if qiov was NULL we
> > would crash.
>
> It doesn't make sense if read
On Mon, Aug 07, 2017 at 06:29:09PM -0400, Jeff Cody wrote:
> Commit c096358e747e88fc7364e40e3c354ee0bb683960 introduced assertion
> checks for when qemu_mutex() functions are called without the
> corresponding qemu_mutex_init() having initialized the mutex.
>
> This uncovered a latent bug in qemu'
On Mon, Aug 07, 2017 at 07:15:29PM +0300, Alberto Garcia wrote:
> Both the throttling limits set with the throttling.iops-* and
> throttling.bps-* options and their QMP equivalents defined in the
> BlockIOThrottle struct are integer values.
>
> Those limits are also reported in the BlockDeviceInfo
On Fri, Aug 04, 2017 at 04:43:54PM +0200, Kevin Wolf wrote:
> This option was only added to allow 'null-co://' and 'null-aio://' as
> filenames, its value never served any actual purpose and was ignored.
> Nevertheless it was accepted as '-drive driver=null,filename=foo'.
>
> The correct way to en
On Fri, Aug 04, 2017 at 10:36:58PM +0800, Fam Zheng wrote:
> It's not too surprising when a user specifies the backing file relative
> to the current working directory instead of the top layer image. This
> causes error when they differ. Though the error message has enough
> information to infer th
On Fri, Aug 04, 2017 at 03:08:26PM +0100, Daniel P. Berrange wrote:
> Signed-off-by: Daniel P. Berrange
> ---
>
> - Clarify that @bytes matches @qiov total size (Kevin)
>
> include/block/block_int.h | 31 +++
> 1 file changed, 31 insertions(+)
Reviewed-by: Stefan H
On Tue 08 Aug 2017 12:00:30 PM CEST, Stefan Hajnoczi wrote:
> On Mon, Aug 07, 2017 at 07:15:29PM +0300, Alberto Garcia wrote:
>> Both the throttling limits set with the throttling.iops-* and
>> throttling.bps-* options and their QMP equivalents defined in the
>> BlockIOThrottle struct are integer v
08.08.2017 12:04, Vladimir Sementsov-Ogievskiy wrote:
08.08.2017 12:04, Vladimir Sementsov-Ogievskiy wrote:
08.08.2017 11:53, Kevin Wolf wrote:
Am 08.08.2017 um 10:42 hat Vladimir Sementsov-Ogievskiy geschrieben:
07.08.2017 18:57, Kevin Wolf wrote:
Am 07.08.2017 um 16:16 hat Vladimir Sementso
On Tue 08 Aug 2017 12:17:12 PM CEST, Alberto Garcia wrote:
> I was under the impression that Markus wanted to change the QAPI types
> of the throttling fields in BlockDeviceInfo for 2.10 as well, so this
> patch is relevant.
I just saw that his series is still an RFC, so we can leave this patch
f
Am 08.08.2017 um 00:29 schrieb Jeff Cody:
Commit c096358e747e88fc7364e40e3c354ee0bb683960 introduced assertion
checks for when qemu_mutex() functions are called without the
corresponding qemu_mutex_init() having initialized the mutex.
This uncovered a latent bug in qemu's nfs driver - in
nfs_cli
Eric Blake writes:
> These days, many programs are including a bug-reporting address,
> or better yet, a link to the project web site, at the tail of
> their --help output. However, we were not very consistent at
> doing so: only qemu-nbd and qemu-qa mentioned anything, with the
> latter pointin
On 08/08/2017 13:06, Markus Armbruster wrote:
> Eric Blake writes:
>
>> These days, many programs are including a bug-reporting address,
>> or better yet, a link to the project web site, at the tail of
>> their --help output. However, we were not very consistent at
>> doing so: only qemu-nbd and
* Markus Armbruster (arm...@redhat.com) wrote:
> Signed-off-by: Markus Armbruster
> ---
> monitor.c | 75
> +++
> 1 file changed, 47 insertions(+), 28 deletions(-)
>
> diff --git a/monitor.c b/monitor.c
> index e0f8801..8b54ba1 100644
Am 08.08.2017 um 00:29 hat Jeff Cody geschrieben:
> Commit c096358e747e88fc7364e40e3c354ee0bb683960 introduced assertion
> checks for when qemu_mutex() functions are called without the
> corresponding qemu_mutex_init() having initialized the mutex.
>
> This uncovered a latent bug in qemu's nfs dri
On Fri, Aug 04, 2017 at 04:01:18PM +0200, Markus Armbruster wrote:
> blk_getlength() can fail. I figure the following need fixing:
>
> hw/arm/musicpal.c: musicpal_init()
Seems okay:
flash_size = blk_getlength(blk);
if (flash_size != 8*1024*1024 && flash_size != 16*1024*1024 &&
flash_size !=
On 8 August 2017 at 13:04, Stefan Hajnoczi wrote:
> On Fri, Aug 04, 2017 at 04:01:18PM +0200, Markus Armbruster wrote:
>> blk_getlength() can fail. I figure the following need fixing:
>>
>> hw/arm/musicpal.c: musicpal_init()
>
> Seems okay:
>
> flash_size = blk_getlength(blk);
> if (flash_size !=
If blk_getlength() fails in virtio_blk_update_config() consider the disk
image length to be 0 bytes.
Signed-off-by: Stefan Hajnoczi
---
hw/block/virtio-blk.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
index b750bd8b53..a16
On Tue, Aug 08, 2017 at 10:06:04AM +0200, Markus Armbruster wrote:
> Stefan Hajnoczi writes:
>
> > On Wed, Jul 26, 2017 at 02:24:02PM -0400, Cleber Rosa wrote:
> >>
> >>
> >> On 07/26/2017 01:58 PM, Stefan Hajnoczi wrote:
> >> > On Tue, Jul 25, 2017 at 12:16:13PM -0400, Cleber Rosa wrote:
> >>
On Wed 02 Aug 2017 12:57:04 PM CEST, Manos Pitsidianakis wrote:
>> At the moment I think throttle_groups_lock isn't strictly needed
>> because incref/decref callers hold the QEMU global mutex anyway.
>>
>> But code accessing throttle_groups still has to be disciplined.
>> Since throttle_groups_lock
On Mon 31 Jul 2017 11:54:41 AM CEST, Manos Pitsidianakis wrote:
> block/throttle.c uses existing I/O throttle infrastructure inside a
> block filter driver. I/O operations are intercepted in the filter's
> read/write coroutines, and referred to block/throttle-groups.c
>
> The driver can be used wit
Signed-off-by: Jeff Cody
---
block/curl.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/block/curl.c b/block/curl.c
index 00a9879..35cf417 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -857,6 +857,9 @@ out_noclean:
qemu_mutex_destroy(&s->mutex);
g_free(s->cookie);
g_f
If curl_global_init() fails, per the documentation no other curl
functions may be called, so make sure to check the return value.
Also, some minor changes to the initialization latch variable 'inited':
- Make it static in the file, for clarity
- Change the name for clarity
- Make it a bool
Signe
Some minor cleanup for a few network protocols, with a few bug fixes thrown in.
I don't think there is anything in here that needs to be for 2.10, however.
Jeff Cody (7):
block/ssh: don't call libssh2_init() in block_init()
block/ssh: make compliant with coding guidelines
block/sheepdog: rem
We don't need libssh2 failure to be fatal (we could just opt to not
register the driver on failure). But, it is probably a good idea to
avoid external library calls during the block_init(), and call the
libssh2 global init function on the first usage, returning any errors.
Signed-off-by: Jeff Cody
This addresses non-functional changes to help curl.c better comply
with the coding styles (comments, indentation, brackets, etc.).
One minor code change is the combination of two if statements into
a single if statement.
Signed-off-by: Jeff Cody
---
block/curl.c | 100 ++
'tag' is already checked in the lines immediately preceding this check,
and set to non-NULL if NULL. No need to check again, it hasn't changed.
Signed-off-by: Jeff Cody
---
block/sheepdog.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
i
No functional changes, just whitespace manipulation.
Signed-off-by: Jeff Cody
---
block/sheepdog.c | 162 +++
1 file changed, 81 insertions(+), 81 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index bbbfa72..ad461f1 100644
---
Signed-off-by: Jeff Cody
---
block/ssh.c | 32 ++--
1 file changed, 18 insertions(+), 14 deletions(-)
diff --git a/block/ssh.c b/block/ssh.c
index cbb0e34..97f7673 100644
--- a/block/ssh.c
+++ b/block/ssh.c
@@ -241,7 +241,7 @@ static int parse_uri(const char *filename
On Tue, Aug 08, 2017 at 03:13:36PM +0200, Alberto Garcia wrote:
On Mon 31 Jul 2017 11:54:41 AM CEST, Manos Pitsidianakis wrote:
block/throttle.c uses existing I/O throttle infrastructure inside a
block filter driver. I/O operations are intercepted in the filter's
read/write coroutines, and refer
On 08/07/2017 07:08 PM, John Snow wrote:
>
>
> On 08/03/2017 12:33 PM, Eric Blake wrote:
>> Not sure if this should go through Kevin's block tree, Paolo's
>> miscellaneous patches, or if I should just do a pull request
>> myself (since patch 4 includes a change to qemu-nbd)
>>
>
> Nothing to ke
Am 03.07.2017 um 20:09 hat Eric Blake geschrieben:
> POSIX says that backslashes in the arguments to 'echo', as well as
> any use of 'echo -n' and 'echo -e', are non-portable; it recommends
> people should favor 'printf' instead. This is definitely true where
> we do not control which shell is run
The following changes since commit b4174c4b08a719e7df7e4f35c29f44b7c2517237:
Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
(2017-08-08 10:01:49 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch chan
From: Alberto Garcia
The QUORUM_REPORT_BAD event has fields to report the sector in which
the error was detected and the number of affected sectors starting
from that one. This is important for read and write errors, but not
for flush errors.
For flush errors the current code reports the total s
From: Jeff Cody
Calls to bdrv_getlength() were not checking for error. In vhdx.c, this
can lead to truncating an image file, so it is a definite bug. In
vhdx-log.c, the path for improper behavior is less clear, but it is best
to check in any case.
Some minor code movement of the log_guid intia
From: Jeff Cody
VHDX uses uint64_t types for most offsets, following the VHDX spec.
However, bdrv_truncate() takes an int64_t value for the truncating
offset. Check for overflow before calling bdrv_truncate().
While we are here, replace the bit shifting with QEMU_ALIGN_UP as well.
N.B.: For a
From: Jeff Cody
Reported-by: Kevin Wolf
Signed-off-by: Jeff Cody
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block/vhdx-log.c | 17 ++---
1 file changed, 14 insertions(+), 3 deletions(-)
diff --git a/block/vhdx-log.c b/block/vhdx-log.c
index 95972230f0..a27dc059cd 1006
From: Cleber Rosa
A race condition is currently present between the clean up attempt of
the QEMU process and the execution of qemu-img. The actual (bad)
output is:
-Warning: Image size mismatch!
-Images are identical.
+qemu-img: Could not open '/tests/qemu-iotests/scratch/t.raw':
Failed to
From: "Denis V. Lunev"
If we can not get the file length, the state of BDS is broken completely.
Return error to the caller.
Signed-off-by: Denis V. Lunev
CC: Markus Armbruster
CC: Kevin Wolf
CC: Max Reitz
CC: Stefan Hajnoczi
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
block/pa
From: Paolo Bonzini
This is not used anymore since c01c214b69 ("block: remove all encryption
handling APIs", 2017-07-11).
Signed-off-by: Paolo Bonzini
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
include/block/block_int.h | 1 -
1 file changed, 1 deleti
From: Jeff Cody
Signed-off-by: Jeff Cody
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block/vhdx-log.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/block/vhdx-log.c b/block/vhdx-log.c
index a27dc059cd..14b724ef7b 100644
--- a/block/vhdx-log.c
+++ b/block/v
This option was only added to allow 'null-co://' and 'null-aio://' as
filenames, its value never served any actual purpose and was ignored.
Nevertheless it was accepted as '-drive driver=null,filename=foo'.
The correct way to enable the protocol prefixes (and that without adding
a useless -drive o
From: Fam Zheng
Errors from the callees must be captured and propagated to our caller,
ensure this for both find_extent() and bdrv_getlength().
Reported-by: Markus Armbruster
Signed-off-by: Fam Zheng
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block/vmdk.c | 26 ++-
From: "Denis V. Lunev"
Original idea beyond the code in question was the following: we have failed
to write zeroes with fallocate(FALLOC_FL_ZERO_RANGE) as the simplest
approach and via fallocate(FALLOC_FL_PUNCH_HOLE)/fallocate(0). We have the
only chance now: if the request comes beyond end of th
From: "Denis V. Lunev"
This would be actually strange and error prone. If truncate() nowadays
will fail, there is something fatally wrong. Let's check for that during
the actual work.
The only fallback case is when the file is not zero initialized. In this
case we should switch to preallocation
Reopening an image should be consistent with opening it, so we should
set BDRV_O_ALLOW_RDWR for any image that is reopened read-write like in
bdrv_open_inherit().
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Jeff Cody
Reviewed-by: John Snow
---
block.c | 5 -
1 file chan
Commit 8ee03995 refactored the code incorrectly and broke the release of
permissions on the old BDS. Instead of changing the permissions to the
new required values after removing the old BDS from the list of
children, it only re-obtains the permissions it already had.
Change the order of operation
This allows qemu-iotests to test the switch between read-only and
read-write mode for block devices.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Jeff Cody
Reviewed-by: John Snow
---
qemu-io-cmds.c | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
d
BDRV_O_ALLOW_RDWR is a flag that tells whether qemu can internally
reopen a node read-write temporarily because the user requested
read-write for the top-level image, but qemu decided that read-only is
enough for this node (a backing file).
bdrv_reopen() is different, it is also used for cases whe
From: Jeff Cody
Commit c096358e747e88fc7364e40e3c354ee0bb683960 introduced assertion
checks for when qemu_mutex() functions are called without the
corresponding qemu_mutex_init() having initialized the mutex.
This uncovered a latent bug in qemu's nfs driver - in
nfs_client_close(), the NFSClient
This serves as a regression test for the bugs that were just fixed for
bdrv_reopen() between read-only and read-write mode.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
Reviewed-by: Jeff Cody
Reviewed-by: John Snow
---
tests/qemu-iotests/187 | 69 +
On Tue, Aug 08, 2017 at 08:50:55AM -0500, Eric Blake wrote:
> On 08/07/2017 07:08 PM, John Snow wrote:
> >
> >
> > On 08/03/2017 12:33 PM, Eric Blake wrote:
> >> Not sure if this should go through Kevin's block tree, Paolo's
> >> miscellaneous patches, or if I should just do a pull request
> >> m
On 08/08/2017 03:28 AM, Kevin Wolf wrote:
> Am 07.08.2017 um 22:30 hat Eric Blake geschrieben:
>> This also requires changing the return type of get_cluster_offset()
>> and adjusting all callers.
>>
>> Use osdep.h macros instead of open-coded rounding while in the
>> area.
>>
>> Reported-by: Markus
On 08/08/2017 13:20, Dr. David Alan Gilbert wrote:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> Signed-off-by: Markus Armbruster
>> ---
>> monitor.c | 75
>> +++
>> 1 file changed, 47 insertions(+), 28 deletions(-)
>>
>> diff --g
Do not communicate after the first error to avoid communicating throught
broken channel. The only exclusion is try to send NBD_CMD_DISC anyway on
in nbd_client_close.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Hi all. Here is a patch, fixing a problem noted in
[PATCH 06/17] block/nbd-client
On 08/08/2017 08:54 AM, Kevin Wolf wrote:
> Am 03.07.2017 um 20:09 hat Eric Blake geschrieben:
>> POSIX says that backslashes in the arguments to 'echo', as well as
>> any use of 'echo -n' and 'echo -e', are non-portable; it recommends
>> people should favor 'printf' instead. This is definitely tr
On Tue, 08/08 13:22, Stefan Hajnoczi wrote:
> If blk_getlength() fails in virtio_blk_update_config() consider the disk
> image length to be 0 bytes.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> hw/block/virtio-blk.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/hw/bl
* Markus Armbruster (arm...@redhat.com) wrote:
> Sizes, virtual and physical addresses should use QAPI type 'size'
> (uint64_t). memsave, pmemsave parameters @val, @size are 'int'
> (int64_t). qmp_memsave() and qmp_pmemsave() implicitly convert to
> target_ulong or hwaddr.
>
> Change the paramet
Commit b43671f8 accidentally broke run_test.sh within tests/multiboot;
due to a subtle change in whitespace.
These two commands produce theh same output (at least, for sane $IFS
of space-tab-newline):
echo -e "...$@..."
echo -e "...$*..."
But that's only because echo inserts spaces between multi
08.08.2017 17:29, Vladimir Sementsov-Ogievskiy wrote:
Do not communicate after the first error to avoid communicating throught
broken channel. The only exclusion is try to send NBD_CMD_DISC anyway on
in nbd_client_close.
worth add: To simplify things, return -EIO in case of disconnect too.
(re
On 08/08/2017 09:29 AM, Vladimir Sementsov-Ogievskiy wrote:
> Do not communicate after the first error to avoid communicating throught
> broken channel. The only exclusion is try to send NBD_CMD_DISC anyway on
> in nbd_client_close.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
>
> Hi al
* Paolo Bonzini (pbonz...@redhat.com) wrote:
> On 08/08/2017 13:20, Dr. David Alan Gilbert wrote:
> > * Markus Armbruster (arm...@redhat.com) wrote:
> >> Signed-off-by: Markus Armbruster
> >> ---
> >> monitor.c | 75
> >> +++
> >> 1 fil
Am 08.08.2017 um 16:29 hat Eric Blake geschrieben:
> On 08/08/2017 08:54 AM, Kevin Wolf wrote:
> > Am 03.07.2017 um 20:09 hat Eric Blake geschrieben:
> >> POSIX says that backslashes in the arguments to 'echo', as well as
> >> any use of 'echo -n' and 'echo -e', are non-portable; it recommends
> >>
Stefan Hajnoczi writes:
> On Tue, Aug 08, 2017 at 10:06:04AM +0200, Markus Armbruster wrote:
>> Stefan Hajnoczi writes:
>>
>> > On Wed, Jul 26, 2017 at 02:24:02PM -0400, Cleber Rosa wrote:
>> >>
>> >>
>> >> On 07/26/2017 01:58 PM, Stefan Hajnoczi wrote:
>> >> > On Tue, Jul 25, 2017 at 12:16:1
On Tue 08 Aug 2017 03:45:44 PM CEST, Manos Pitsidianakis wrote:
> On Tue, Aug 08, 2017 at 03:13:36PM +0200, Alberto Garcia wrote:
>>On Mon 31 Jul 2017 11:54:41 AM CEST, Manos Pitsidianakis wrote:
>>> block/throttle.c uses existing I/O throttle infrastructure inside a
>>> block filter driver. I/O op
On 08/07/2017 08:55 PM, John Snow wrote:
>
>
> On 08/07/2017 10:45 AM, Markus Armbruster wrote:
>> Block dirty bitmaps represent granularity in bytes as uint32_t. It
>> must be a power of two and a multiple of BDRV_SECTOR_SIZE.
>>
>> The trouble with uint32_t is computations like this one in
>>
On 08/07/2017 09:45 AM, Markus Armbruster wrote:
> hbitmap_count() returns uint64_t.
>
> Clean up test-hbitmap.c to check its value with g_assert_cmpuint()
> instead of g_assert_cmpint().
>
> bdrv_get_dirty_count() and bdrv_get_meta_dirty_count() return its
> value converted to int64_t. Clean th
On Tue, Aug 08, 2017 at 04:53:08PM +0200, Alberto Garcia wrote:
On Tue 08 Aug 2017 03:45:44 PM CEST, Manos Pitsidianakis wrote:
On Tue, Aug 08, 2017 at 03:13:36PM +0200, Alberto Garcia wrote:
On Mon 31 Jul 2017 11:54:41 AM CEST, Manos Pitsidianakis wrote:
block/throttle.c uses existing I/O thr
* Markus Armbruster (arm...@redhat.com) wrote:
> Sizes should use QAPI type 'size' (uint64_t). balloon parameter
> @value is 'int' (int64_t). qmp_balloon() implicitly converts to
> ram_addr_t, i.e. uint64_t. BALLOON_CHANGE parameter @actual and
> BalloonInfo member @actual are also 'int'.
> virt
08.08.2017 17:44, Eric Blake wrote:
On 08/08/2017 09:29 AM, Vladimir Sementsov-Ogievskiy wrote:
Do not communicate after the first error to avoid communicating throught
broken channel. The only exclusion is try to send NBD_CMD_DISC anyway on
in nbd_client_close.
Signed-off-by: Vladimir Sementso
On 08/08/2017 04:13 AM, Daniel P. Berrange wrote:
> On Tue, Aug 08, 2017 at 10:39:29AM +0800, Fam Zheng wrote:
>> On Fri, 08/04 16:49, Daniel P. Berrange wrote:
>>> This is odd. In the bdrv_aligned_readv() it looks very much like
>>> we'll reference qiov->niov, if bytes != 0, so if qiov was NULL w
On Tue 08 Aug 2017 04:56:20 PM CEST, Manos Pitsidianakis wrote:
>>> So basically if we have anonymous groups, we accept limits in the
>>> driver options but only without a group-name.
>>
>>In the commit message you do however have limits and a group name, is
>>that a mistake?
>>
>>-drive driver
On 08/08/2017 04:04 AM, Vladimir Sementsov-Ogievskiy wrote:
Throttling "guaranties" that there will not be more than one
request. But
what prevent less than one, i.e. zero, like in my reproduction?
>>> Yes, I understand. Can we somehow make sure that at least one iteration
>>> is ma
* Markus Armbruster (arm...@redhat.com) wrote:
> The previous commit made it unsigned in QMP. Switch HMP's args_type
> from 'M' to 'o'. Loses support for expressions (QEMU pocket
> calculator), gains support for units other than mebibytes. Negative
> values are no longer accepted and interpreted
08.08.2017 18:07, Eric Blake wrote:
On 08/08/2017 04:04 AM, Vladimir Sementsov-Ogievskiy wrote:
Throttling "guaranties" that there will not be more than one
request. But
what prevent less than one, i.e. zero, like in my reproduction?
Yes, I understand. Can we somehow make sure that at least on
On 08/08/2017 05:00 AM, Stefan Hajnoczi wrote:
> On Mon, Aug 07, 2017 at 07:15:29PM +0300, Alberto Garcia wrote:
>> Both the throttling limits set with the throttling.iops-* and
>> throttling.bps-* options and their QMP equivalents defined in the
>> BlockIOThrottle struct are integer values.
>>
>>
Am 08.08.2017 um 17:10 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 08.08.2017 18:07, Eric Blake wrote:
> > On 08/08/2017 04:04 AM, Vladimir Sementsov-Ogievskiy wrote:
> >
> > > > > > Throttling "guaranties" that there will not be more than one
> > > > > > request. But
> > > > > > what prevent
* Markus Armbruster (arm...@redhat.com) wrote:
> The previous commit switched balloon from 'M' to 'o', rendering 'M'
> unused. It was never used for anything else. Drop it.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Dr. David Alan Gilbert
> ---
> monitor.c | 11 +--
> 1 file
On Tue 08 Aug 2017 05:11:27 PM CEST, Eric Blake wrote:
>> Why is this marked for-2.10? Does it fix a bug?
>
> Theoretically, converting between int64_t and double loses precision
> on any values larger than 2^53. In all practicality, though, if you
> expect throttling to be precise through 2^53 (
Do not communicate after the first error to avoid communicating throught
broken channel. The only exclusion is try to send NBD_CMD_DISC anyway on
in nbd_client_close.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Hi all. Here is a patch, fixing a problem noted in
[PATCH 06/17] block/nbd-client
* Markus Armbruster (arm...@redhat.com) wrote:
> The previous commit made them unsigned in QMP. Switch HMP's args_type
> from 'l' to 'o'. Loses support for expressions (QEMU pocket
> calculator), gains support for unit suffixes. Negative values are no
> longer accepted and interpreted modulo 2^6
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> Signed-off-by: Markus Armbruster
>> ---
>> monitor.c | 75
>> +++
>> 1 file changed, 47 insertions(+), 28 deletions(-)
>>
>> diff --git a/monitor.c
"Dr. David Alan Gilbert" writes:
> * Markus Armbruster (arm...@redhat.com) wrote:
>> Sizes, virtual and physical addresses should use QAPI type 'size'
>> (uint64_t). memsave, pmemsave parameters @val, @size are 'int'
>> (int64_t). qmp_memsave() and qmp_pmemsave() implicitly convert to
>> target
On 8 August 2017 at 14:58, Kevin Wolf wrote:
> The following changes since commit b4174c4b08a719e7df7e4f35c29f44b7c2517237:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
> (2017-08-08 10:01:49 +0100)
>
> are available in the git repository at:
>
> git://repo.or
Juan Quintela writes:
> Markus Armbruster wrote:
>> Sizes should use QAPI type 'size' (uint64_t). migrate-set-cache-size
>> parameter @value is 'int' (int64_t). qmp_migrate_set_cache_size()
>> ensures it fits into size_t. page_cache.c implicitly converts the
>> signed size to unsigned types (
John Snow writes:
> On 08/07/2017 10:45 AM, Markus Armbruster wrote:
>> Block dirty bitmaps represent granularity in bytes as uint32_t. It
>> must be a power of two and a multiple of BDRV_SECTOR_SIZE.
>>
>> The trouble with uint32_t is computations like this one in
>> mirror_do_read():
>>
>>
John Snow writes:
> On 08/07/2017 10:45 AM, Markus Armbruster wrote:
>> Byte counts should use QAPI type 'size' (uint64_t). BlockDirtyInfo
>> member @count is 'int' (int64_t). bdrv_query_dirty_bitmaps() computes
>> @count from bdrv_get_dirty_count() in uint64_t, then implicitly
>> converts to i
* Markus Armbruster (arm...@redhat.com) wrote:
> "Dr. David Alan Gilbert" writes:
>
> > * Markus Armbruster (arm...@redhat.com) wrote:
> >> Signed-off-by: Markus Armbruster
> >> ---
> >> monitor.c | 75
> >> +++
> >> 1 file changed, 4
On 08/08/2017 10:16 AM, Kevin Wolf wrote:
is sleep for ms portable?
>>> Sadly, sub-second sleep is a GNU coreutils feature; I suspect the BSD
>>> machines may fail to parse it. (Of course, we could do some sort of
>>> 'sleep $SMALL', where $SMALL is 0.5 if sleep supports it, and 1 otherwise)
The block backend changed in a way that flushing empty CDROM drives
is now an error. Amend IDE to avoid doing so until the root problem
can be addressed for 2.11.
Reported-by: Kieron Shorrock
Signed-off-by: John Snow
---
hw/ide/core.c | 11 +++
1 file changed, 7 insertions(+), 4 deletio
1 - 100 of 137 matches
Mail list logo
