Philippe Mathieu-Daudé writes:
> Remove unnecessary casts using coccinelle scripts.
>
> The CPU()/OBJECT() patches don't introduce logical change,
> The DEVICE() one removes various OBJECT_CHECK() calls.
Queued, thanks!
Managing expecations: I'm not a QOM maintainer, I don't want to become
14.05.2020 21:29, Eric Blake wrote:
reviving this thread...
On 4/3/20 6:23 AM, Peter Krempa wrote:
On Fri, Apr 03, 2020 at 14:02:47 +0300, Vladimir Sementsov-Ogievskiy wrote:
19.12.2019 13:36, Peter Krempa wrote:
On Thu, Dec 19, 2019 at 11:51:01 +0300, Vladimir Sementsov-Ogievskiy wrote:
Hi
14.05.2020 21:00, Eric Blake wrote:
Dirty bitmaps are important to incremental backups, including exposure
over NBD where I'm already maintainer. Also, I'm aware that lately I
have been doing as much code/review on bitmaps as John Snow who is
trying to scale back in order to focus elsewhere;
Philippe Mathieu-Daudé writes:
> The OBJECT() macro is defined as:
>
> #define OBJECT(obj) ((Object *)(obj))
>
> Remove the unnecessary OBJECT() casts when we already know the
> pointer is of Object type.
>
> Patch created mechanically using spatch with this script:
>
> @@
> typedef
On 5/13/20 8:36 AM, Eyal Moscovici wrote:
All calls to cvtnum check the return value and print the same error message more
or less. And so error reporting moved to cvtnum_full to reduce code
duplication and provide a single error message. Additionally, cvtnum now wraps
cvtnum_full with the
On 5/4/20 5:48 AM, Philippe Mathieu-Daudé wrote:
> One might find interesting to look at AHCI IRQs.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/ide/ahci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
> index 13d91e109a..fc82cbd5f1 100644
>
On 5/12/20 3:49 PM, Philippe Mathieu-Daudé wrote:
> Handlers don't need to modify the IDEDMA structure.
> Make it const.
>
> Signed-off-by: Philippe Mathieu-Daudé
I'll trust your judgment. As long as it still compiles and passes
qtests, I'm happy if you're happy.
Acked-by: John Snow
> ---
It's not really a warning; we don't want to see it if we're not running
in at least a verbose mode. We can see it on the test summary just fine.
Signed-off-by: John Snow
---
tests/qemu-iotests/iotests.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Separate the streams; stdout is for test diff output, stderr is for
control messages and things for the human to look at.
(Cough, unfortunately, I didn't realize that ./check actually just
always redirects both, so even on STDERR, you can't see warnings.
Oh well...)
Signed-off-by: John Snow
---
Hi, you can take just patch 1. patches 2-3 admittedly don't do a whole
heck of a lot, because I didn't realize that ./check discards *all*
output from either stdout or stderr.
The changes are tiny, though, and maybe still worth doing in the long
run? Hm. They are archived on the list now, anyway.
Shift the logging initialization up to occur prior to validation checks,
so that notrun() messages still get printed to console.
(Also, remove the "debugging messages active" message, because we don't
need to see that hundreds of times per iotest suite run.)
Signed-off-by: John Snow
---
On 5/14/20 6:06 AM, Kevin Wolf wrote:
> Am 14.05.2020 um 08:24 hat John Snow geschrieben:
>> On 3/31/20 9:44 AM, Kevin Wolf wrote:
>>> Am 31.03.2020 um 02:00 hat John Snow geschrieben:
We can turn logging on/off globally instead of per-function.
Remove use_log from run_job, and
On 5/14/20 11:59 AM, Kevin Wolf wrote:
> Am 14.05.2020 um 17:07 hat John Snow geschrieben:
>>
>>
>> On 5/14/20 10:47 AM, Kevin Wolf wrote:
>>> Am 14.05.2020 um 04:25 hat John Snow geschrieben:
It's easier to work with than a list of tuples, because we can check the
keys for
On 5/14/20 11:53 AM, Kevin Wolf wrote:
> Am 14.05.2020 um 04:25 hat John Snow geschrieben:
>> Instead of having somewhat reproduced it for itself.
>>
>> Signed-off-by: John Snow
>
> I think you should pass auto_dismiss=True to the JobRunner, or (probably
> preferable) change
On 5/14/20 11:40 AM, Kevin Wolf wrote:
> Am 14.05.2020 um 04:25 hat John Snow geschrieben:
>> The idea is that instead of increasing the arguments to job_run all the
>> time, create a more general-purpose job runner that can be subclassed to
>> do interesting things with.
>>
>> pylint note: the
On 5/14/20 2:00 PM, Eric Blake wrote:
> Dirty bitmaps are important to incremental backups, including exposure
> over NBD where I'm already maintainer. Also, I'm aware that lately I
> have been doing as much code/review on bitmaps as John Snow who is
> trying to scale back in order to focus
On 12/19/19 2:51 AM, Vladimir Sementsov-Ogievskiy wrote:
Important thing for bitmap migration is to select destination block
node to obtain the migrated bitmap.
Prepatch, on source we use bdrv_get_device_or_node_name() to identify
the node, and on target we do bdrv_lookup_bs.
On 1/31/20 1:23 PM, Eric Blake wrote:
On 12/19/19 2:51 AM, Vladimir Sementsov-Ogievskiy wrote:
From: Max Reitz
The commit and mirror block nodes are filters, so they should be marked
as such.
Signed-off-by: Max Reitz
Signed-off-by: Vladimir Sementsov-Ogievskiy
[squash comment fix from
On 12/19/19 2:51 AM, Vladimir Sementsov-Ogievskiy wrote:
To be used for bitmap migration in further commit.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
include/block/dirty-bitmap.h | 1 +
block/dirty-bitmap.c | 13 +
2 files changed, 14 insertions(+)
reviving this thread...
On 4/3/20 6:23 AM, Peter Krempa wrote:
On Fri, Apr 03, 2020 at 14:02:47 +0300, Vladimir Sementsov-Ogievskiy wrote:
19.12.2019 13:36, Peter Krempa wrote:
On Thu, Dec 19, 2019 at 11:51:01 +0300, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
It's a continuation for
Dirty bitmaps are important to incremental backups, including exposure
over NBD where I'm already maintainer. Also, I'm aware that lately I
have been doing as much code/review on bitmaps as John Snow who is
trying to scale back in order to focus elsewhere; and many of the
recent patches have come
14.05.2020 16:52, Eric Blake wrote:
On 5/14/20 12:08 AM, John Snow wrote:
On 5/14/20 12:49 AM, Vladimir Sementsov-Ogievskiy wrote:
13.05.2020 23:24, John Snow wrote:
On 5/13/20 10:14 AM, Eric Blake wrote:
Dirty bitmaps are important to incremental backups, including exposure
over NBD
Am 07.05.2020 um 14:11 hat Philippe Mathieu-Daudé geschrieben:
> block_copy_task_entry() might be written differently to avoid
> the initialization. This silents the warning and let me build.
Thanks, applied to the block branch.
Kevin
On 5/14/20 7:28 AM, Max Reitz wrote:
On 10.05.20 15:40, Maxim Levitsky wrote:
Some options are only useful for creation
(or hard to be amended, like cluster size for qcow2), while some other
options are only useful for amend, like upcoming keyslot management
options for luks
+#define
On 10.05.20 15:40, Maxim Levitsky wrote:
> Currently the implementation only supports amending the encryption
> options, unlike the qemu-img version
>
> Signed-off-by: Maxim Levitsky
> Reviewed-by: Daniel P. Berrangé
> ---
> block/qcow2.c| 39 +++
>
On 10.05.20 15:40, Maxim Levitsky wrote:
> Signed-off-by: Maxim Levitsky
> Reviewed-by: Daniel P. Berrangé
> ---
> block/crypto.c | 72
> qapi/block-core.json | 14 -
> 2 files changed, 66 insertions(+), 20 deletions(-)
Reviewed-by:
Am 14.05.2020 um 17:07 hat John Snow geschrieben:
>
>
> On 5/14/20 10:47 AM, Kevin Wolf wrote:
> > Am 14.05.2020 um 04:25 hat John Snow geschrieben:
> >> It's easier to work with than a list of tuples, because we can check the
> >> keys for membership.
> >>
> >> Signed-off-by: John Snow
> >>
Am 14.05.2020 um 04:25 hat John Snow geschrieben:
> Instead of having somewhat reproduced it for itself.
>
> Signed-off-by: John Snow
I think you should pass auto_dismiss=True to the JobRunner, or (probably
preferable) change prepare_and_start_job() to start the job with
auto_dismiss=False.
On 10.05.20 15:40, Maxim Levitsky wrote:
> blockdev-amend will be used similiar to blockdev-create
> to allow on the fly changes of the structure of the format based block
> devices.
>
> Current plan is to first support encryption keyslot management for luks
> based formats (raw and embedded in
Am 14.05.2020 um 04:25 hat John Snow geschrieben:
> The idea is that instead of increasing the arguments to job_run all the
> time, create a more general-purpose job runner that can be subclassed to
> do interesting things with.
>
> pylint note: the 'callbacks' option guards against unused
On 5/14/20 10:47 AM, Kevin Wolf wrote:
> Am 14.05.2020 um 04:25 hat John Snow geschrieben:
>> It's easier to work with than a list of tuples, because we can check the
>> keys for membership.
>>
>> Signed-off-by: John Snow
>> ---
>> python/qemu/machine.py| 10 +-
>>
On 5/7/20 2:11 PM, Philippe Mathieu-Daudé wrote:
block_copy_task_entry() might be written differently to avoid
the initialization. This silents the warning and let me build.
Philippe Mathieu-Daudé (2):
block/block-copy: Fix uninitialized variable in block_copy_task_entry
block/block-copy:
14.05.2020 17:20, Eric Blake wrote:
On 5/14/20 1:45 AM, Vladimir Sementsov-Ogievskiy wrote:
13.05.2020 04:16, Eric Blake wrote:
Include actions for --add, --remove, --clear, --enable, --disable, and
--merge (note that --clear is a bit of fluff, because the same can be
accomplished by removing
On 14.05.20 16:14, Daniel P. Berrangé wrote:
> On Thu, May 14, 2020 at 04:09:59PM +0200, Max Reitz wrote:
>> On 10.05.20 15:40, Maxim Levitsky wrote:
>>> This implements the encryption key management using the generic code in
>>> qcrypto layer and exposes it to the user via qemu-img
>>>
>>> This
On 10.05.20 15:40, Maxim Levitsky wrote:
> This allows more tests to be able to have same output on both qcow2 luks
> encrypted images
> and raw luks images
>
> Signed-off-by: Maxim Levitsky
> Reviewed-by: Daniel P. Berrangé
> ---
> tests/qemu-iotests/087.out | 6 ++---
>
On 5/14/20 9:29 AM, Eric Blake wrote:
WARNING: Block comments use a leading /* on a separate line
#20: FILE: qemu-nbd.c:919:
+ /* Remember parents stderr only if the fork option is set.
The comment could use some grammar help (s/parents/parent's/), and in
truth, I don't think it
Am 14.05.2020 um 04:25 hat John Snow geschrieben:
> It's easier to work with than a list of tuples, because we can check the
> keys for membership.
>
> Signed-off-by: John Snow
> ---
> python/qemu/machine.py| 10 +-
> tests/qemu-iotests/040| 12 ++--
>
Am 14.05.2020 um 15:21 hat Thomas Lamprecht geschrieben:
> On 5/12/20 4:43 PM, Kevin Wolf wrote:
> > Stefan (Reiter), after looking a bit closer at this, I think there is no
> > bug in QEMU, but the bug is in your coroutine code that calls block
> > layer functions without moving into the right
On 5/14/20 3:24 PM, Peter Maydell wrote:
On Tue, 12 May 2020 at 08:48, Philippe Mathieu-Daudé wrote:
Switch to using the qdev gpio API which is preferred over
qemu_allocate_irqs(). One step to eventually deprecate and
remove qemu_allocate_irqs() one day.
diff --git a/hw/mips/mips_int.c
On 10.05.20 15:40, Maxim Levitsky wrote:
> Now that we have all the infrastructure in place,
> wire it in the qcow2 driver and expose this to the user.
>
> Signed-off-by: Maxim Levitsky
> Reviewed-by: Daniel P. Berrangé
> ---
> block/qcow2.c | 72
Am 14.05.2020 um 15:52 hat Stefan Reiter geschrieben:
> On 5/12/20 4:43 PM, Kevin Wolf wrote:
> > tracked_request_begin() is called for most I/O operations, so it's a
> > good place to assert that we're indeed running in the home thread of the
> > node's AioContext.
> >
>
> Is this patch
On 5/14/20 9:55 AM, Eric Blake wrote:
> On 5/14/20 12:53 AM, John Snow wrote:
>> Catch only the timeout error; if there are other problems, allow the
>> stack trace to be visible.
>>
>
> A lot of patches in this series start with "python//" - is that
> intentional, or should it be a single
On 5/14/20 7:51 AM, no-re...@patchew.org wrote:
Patchew URL:
https://patchew.org/QEMU/20200514063112.1457125-1-raphael.p...@hetzner.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id:
On 5/14/20 9:52 AM, Eric Blake wrote:
> On 5/14/20 12:08 AM, John Snow wrote:
>>
>>
>> On 5/14/20 12:49 AM, Vladimir Sementsov-Ogievskiy wrote:
>>> 13.05.2020 23:24, John Snow wrote:
On 5/13/20 10:14 AM, Eric Blake wrote:
> Dirty bitmaps are important to incremental backups,
On Thu, May 14, 2020 at 04:09:59PM +0200, Max Reitz wrote:
> On 10.05.20 15:40, Maxim Levitsky wrote:
> > This implements the encryption key management using the generic code in
> > qcrypto layer and exposes it to the user via qemu-img
> >
> > This code adds another 'write_func' because the
On 5/14/20 1:45 AM, Vladimir Sementsov-Ogievskiy wrote:
13.05.2020 04:16, Eric Blake wrote:
Include actions for --add, --remove, --clear, --enable, --disable, and
--merge (note that --clear is a bit of fluff, because the same can be
accomplished by removing a bitmap and then adding a new one in
On 5/14/20 1:21 AM, Vladimir Sementsov-Ogievskiy wrote:
13.05.2020 04:16, Eric Blake wrote:
Upcoming patches want to add some basic bitmap manipulation abilities
to qemu-img. But blockdev.o is too heavyweight to link into qemu-img
(among other things, it would drag in block jobs and
On 5/14/20 6:45 AM, Vladimir Sementsov-Ogievskiy wrote:
13.05.2020 04:16, Eric Blake wrote:
- HBitmap **backup, Error **errp)
+BdrvDirtyBitmap *block_dirty_bitmap_merge(const char *node, const
char *target,
+
BlockDirtyBitmapMergeSourceList
On 5/14/20 12:19 AM, Vladimir Sementsov-Ogievskiy wrote:
In the future, when we improve the ability to look up bitmaps through
a filter, we will probably also want to teach the block layer to
automatically let filters pass this request on through.
Hm. I think that bitmap at filter bs is a
On 10.05.20 15:40, Maxim Levitsky wrote:
> This implements the encryption key management using the generic code in
> qcrypto layer and exposes it to the user via qemu-img
>
> This code adds another 'write_func' because the initialization
> write_func works directly on the underlying file, and
On 5/14/20 12:53 AM, John Snow wrote:
Catch only the timeout error; if there are other problems, allow the
stack trace to be visible.
A lot of patches in this series start with "python//" - is that
intentional, or should it be a single slash?
Signed-off-by: John Snow
---
On 5/14/20 12:08 AM, John Snow wrote:
On 5/14/20 12:49 AM, Vladimir Sementsov-Ogievskiy wrote:
13.05.2020 23:24, John Snow wrote:
On 5/13/20 10:14 AM, Eric Blake wrote:
Dirty bitmaps are important to incremental backups, including exposure
over NBD where I'm already maintainer. Also, I'm
On 5/12/20 4:43 PM, Kevin Wolf wrote:
tracked_request_begin() is called for most I/O operations, so it's a
good place to assert that we're indeed running in the home thread of the
node's AioContext.
Is this patch supposed to be always correct or only together with nr. 2?
I changed our code
On 5/13/20 5:13 PM, no-re...@patchew.org wrote:
Patchew URL:
https://patchew.org/QEMU/20200513133629.18508-1-eyal.moscov...@oracle.com/
Hi,
This series failed the docker-mingw@fedora build test. Please find the testing
commands and
their output below. If you have Docker installed, you can
Am 13.05.2020 um 13:05 hat Max Reitz geschrieben:
> Based-on: <20200429141126.85159-1-mre...@redhat.com>
> (“block: Do not call BlockDriver.bdrv_make_empty() directly”)
>
> Branch: https://github.com/XanClic/qemu.git child-role-v4
> Branch: https://git.xanclic.moe/XanClic/qemu.git child-role-v4
On 10.05.20 15:40, Maxim Levitsky wrote:
> Some qcow2 create options can't be used for amend.
> Remove them from the qcow2 create options and add generic logic to detect
> such options in qemu-img
>
> Signed-off-by: Maxim Levitsky
> Reviewed-by: Daniel P. Berrangé
> ---
> block/qcow2.c
On Tue, 12 May 2020 at 08:48, Philippe Mathieu-Daudé wrote:
>
> Switch to using the qdev gpio API which is preferred over
> qemu_allocate_irqs(). One step to eventually deprecate and
> remove qemu_allocate_irqs() one day.
> diff --git a/hw/mips/mips_int.c b/hw/mips/mips_int.c
> index
On 5/12/20 4:43 PM, Kevin Wolf wrote:
> Stefan (Reiter), after looking a bit closer at this, I think there is no
> bug in QEMU, but the bug is in your coroutine code that calls block
> layer functions without moving into the right AioContext first. I've
> written this series anyway as it
On Tue, 12 May 2020 at 08:48, Philippe Mathieu-Daudé wrote:
>
> Coverity points out (CID 1421934) that we are leaking the
> memory returned by qemu_allocate_irqs(). We can avoid this
> leak by switching to using qdev_init_gpio_in(); the base
> class finalize will free the irqs that this allocates
On Mon, May 11, 2020 at 07:36:30PM +0100, Stefan Hajnoczi wrote:
> The glib event loop does not call fdmon_io_uring_wait() so fd handlers
> waiting to be submitted build up in the list. There is no benefit is
> using io_uring when the glib GSource is being used, so disable it
> instead of
On Mon, May 11, 2020 at 07:36:29PM +0100, Stefan Hajnoczi wrote:
> The io_uring file descriptor monitoring implementation has an internal
> list of fd handlers that are pending submission to io_uring.
> fdmon_io_uring_destroy() deletes all fd handlers on the list.
>
> Don't delete fd handlers
Am 29.04.2020 um 16:11 hat Max Reitz geschrieben:
> v1: https://lists.nongnu.org/archive/html/qemu-block/2020-04/msg01245.html
>
> Branch: https://github.com/XanClic/qemu.git fix-bdrv_make_empty-v2
> Branch: https://git.xanclic.moe/XanClic/qemu.git fix-bdrv_make_empty-v2
>
> Based-on:
Patchew URL:
https://patchew.org/QEMU/20200514063112.1457125-1-raphael.p...@hetzner.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20200514063112.1457125-1-raphael.p...@hetzner.com
Subject: [PATCH v2 0/1] qemu-nbd: Close
On 10.05.20 15:40, Maxim Levitsky wrote:
> Some options are only useful for creation
> (or hard to be amended, like cluster size for qcow2), while some other
> options are only useful for amend, like upcoming keyslot management
> options for luks
>
> Since currently only qcow2 supports amend,
On 10.05.20 15:40, Maxim Levitsky wrote:
> 'force' option will be used for some unsafe amend operations.
>
> This includes things like erasing last keyslot in luks based formats
> (which destroys the data, unless the master key is backed up
> by external means), but that _might_ be desired
On 10.05.20 15:40, Maxim Levitsky wrote:
> Next few patches will expose that functionality to the user.
>
> Signed-off-by: Maxim Levitsky
> Reviewed-by: Daniel P. Berrangé
> ---
> crypto/block-luks.c | 395 +++-
> qapi/crypto.json| 61 ++-
> 2
13.05.2020 04:16, Eric Blake wrote:
-HBitmap **backup, Error **errp)
+BdrvDirtyBitmap *block_dirty_bitmap_merge(const char *node, const char *target,
+ BlockDirtyBitmapMergeSourceList
*bitmaps,
+ HBitmap
Am 14.05.2020 um 09:13 hat Max Reitz geschrieben:
> On 13.05.20 18:11, Eric Blake wrote:
> > On 5/13/20 9:56 AM, Max Reitz wrote:
> >> This command allows mapping block node names to aliases for the purpose
> >> of block dirty bitmap migration.
> >>
> >> This way, management tools can use
Am 14.05.2020 um 11:09 hat Max Reitz geschrieben:
> On 13.05.20 22:09, Vladimir Sementsov-Ogievskiy wrote:
> [...]
> > 1. So, you decided to make only node-mapping, not bitmap-mapping, so we
> > can't rename bitmaps in-flight and can't migrate bitmaps from one node
> > to several and visa-versa. I
* Lukas Straub (lukasstra...@web.de) wrote:
> Terminology:
> instance = one (nbd) blockdev/one chardev/the single migrationstate
> connection = one TCP connection
>
> Hello Everyone,
> Having read all the comments, here is proposal v2:
> Every instance registers itself with a unique name in the
14.05.2020 12:09, Max Reitz wrote:
On 13.05.20 22:09, Vladimir Sementsov-Ogievskiy wrote:
[...]
1. So, you decided to make only node-mapping, not bitmap-mapping, so we
can't rename bitmaps in-flight and can't migrate bitmaps from one node
to several and visa-versa. I think it's OK, nothing good
Am 13.05.2020 um 21:12 hat Lukas Straub geschrieben:
> Terminology:
> instance = one (nbd) blockdev/one chardev/the single migrationstate
> connection = one TCP connection
>
> Hello Everyone,
> Having read all the comments, here is proposal v2:
Looks quite good to me.
> Every instance registers
Am 14.05.2020 um 08:24 hat John Snow geschrieben:
> On 3/31/20 9:44 AM, Kevin Wolf wrote:
> > Am 31.03.2020 um 02:00 hat John Snow geschrieben:
> >> We can turn logging on/off globally instead of per-function.
> >>
> >> Remove use_log from run_job, and use python logging to turn on
> >> diffable
On Wed, 13 May 2020 at 15:15, Max Reitz wrote:
>
> The following changes since commit d5c75ec500d96f1d93447f990cd5a4ef5ba27fae:
>
> Merge remote-tracking branch
> 'remotes/stefanberger/tags/pull-tpm-2020-05-08-1' into staging (2020-05-12
> 17:00:10 +0100)
>
> are available in the Git
* Max Reitz (mre...@redhat.com) wrote:
> On 14.05.20 10:42, Dr. David Alan Gilbert wrote:
> > * Max Reitz (mre...@redhat.com) wrote:
> >
> >
> >
> >> +void qmp_migrate_set_bitmap_node_mapping(MigrationBlockNodeMappingList
> >> *mapping,
> >> + Error
On 13.05.20 22:09, Vladimir Sementsov-Ogievskiy wrote:
[...]
> 1. So, you decided to make only node-mapping, not bitmap-mapping, so we
> can't rename bitmaps in-flight and can't migrate bitmaps from one node
> to several and visa-versa. I think it's OK, nothing good in such
> possibilities, and
On 14.05.20 10:42, Dr. David Alan Gilbert wrote:
> * Max Reitz (mre...@redhat.com) wrote:
>
>
>
>> +void qmp_migrate_set_bitmap_node_mapping(MigrationBlockNodeMappingList
>> *mapping,
>> + Error **errp)
>> +{
>> +QDict *in_mapping = qdict_new();
>> +
* Max Reitz (mre...@redhat.com) wrote:
> +void qmp_migrate_set_bitmap_node_mapping(MigrationBlockNodeMappingList
> *mapping,
> + Error **errp)
> +{
> +QDict *in_mapping = qdict_new();
> +QDict *out_mapping = qdict_new();
> +
> +for (;
On 5/14/20 6:46 AM, Klaus Jensen wrote:
From: Klaus Jensen
Having the patch subject duplicated ease review (not all email client
display email subject close to email content):
"Do cmb/pmr init as part of pci init."
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Klaus Jensen
On 5/14/20 6:46 AM, Klaus Jensen wrote:
From: Klaus Jensen
Signed-off-by: Klaus Jensen
Reviewed-by: Maxim Levitsky
---
hw/block/nvme.c | 95 ++---
1 file changed, 51 insertions(+), 44 deletions(-)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
On 13.05.20 22:09, Vladimir Sementsov-Ogievskiy wrote:
> 13.05.2020 17:56, Max Reitz wrote:
>> This command allows mapping block node names to aliases for the purpose
>> of block dirty bitmap migration.
>>
>> This way, management tools can use different node names on the source
>> and destination
On 2020/5/13 下午5:47, Dima Stepanov wrote:
case CHR_EVENT_CLOSED:
/* a close event may happen during a read/write, but vhost
* code assumes the vhost_dev remains setup, so delay the
* stop & clear to idle.
* FIXME: better handle failure in vhost code,
On 2020/5/13 下午5:36, Dima Stepanov wrote:
On Wed, May 13, 2020 at 11:00:38AM +0800, Jason Wang wrote:
On 2020/5/12 下午5:08, Dima Stepanov wrote:
On Tue, May 12, 2020 at 11:26:11AM +0800, Jason Wang wrote:
On 2020/5/11 下午5:11, Dima Stepanov wrote:
On Mon, May 11, 2020 at 11:05:58AM +0800,
On 13.05.20 18:11, Eric Blake wrote:
> On 5/13/20 9:56 AM, Max Reitz wrote:
>> This command allows mapping block node names to aliases for the purpose
>> of block dirty bitmap migration.
>>
>> This way, management tools can use different node names on the source
>> and destination and pass the
13.05.2020 04:16, Eric Blake wrote:
Include actions for --add, --remove, --clear, --enable, --disable, and
--merge (note that --clear is a bit of fluff, because the same can be
accomplished by removing a bitmap and then adding a new one in its
place, but it matches what QMP commands exist).
[...] introduced with e6df58a5, stderr won't get closed if the fork
option is __not__ set.
On 5/14/20 8:31 AM, Raphael Pour wrote:
> introduced with e6df58a5, stderr won't get closed if the fork option is
> set.
--
Hetzner Online GmbH
Am Datacenter-Park 1
08223 Falkenstein/Vogtland
Close inherited stderr of the parent if fork_process is false.
Otherwise no one will close it. (introduced by e6df58a5)
---
qemu-nbd.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index 4aa005004e..a324d21c5e 100644
--- a/qemu-nbd.c
+++
Hello,
introduced with e6df58a5, stderr won't get closed if the fork option is
set. This causes other processes reading stderr to block infinietly or
crash while relying on EOF.
v2:
- Instead of closing the inherited stderr in the child, avoid the dup
in the parent if the fork option is
On 3/31/20 9:44 AM, Kevin Wolf wrote:
> Am 31.03.2020 um 02:00 hat John Snow geschrieben:
>> We can turn logging on/off globally instead of per-function.
>>
>> Remove use_log from run_job, and use python logging to turn on
>> diffable output when we run through a script entry point.
>>
>>
13.05.2020 04:16, Eric Blake wrote:
Upcoming patches want to add some basic bitmap manipulation abilities
to qemu-img. But blockdev.o is too heavyweight to link into qemu-img
(among other things, it would drag in block jobs and transaction
support - qemu-img does offline manipulation, where
On 4/21/20 9:35 AM, Vladimir Sementsov-Ogievskiy wrote:
All other test files are executable, except for this one. Fix that.
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
tests/qemu-iotests/283 | 0
1 file changed, 0 insertions(+), 0 deletions(-)
mode change 100644 => 100755
On 5/14/20 7:53 AM, John Snow wrote:
In the case that we receive a reply but are unable to understand it, use
this exception name to indicate that case.
Signed-off-by: John Snow
---
python/qemu/lib/qmp.py | 10 ++
1 file changed, 10 insertions(+)
diff --git a/python/qemu/lib/qmp.py
mypy considers it incorrect to use `bool` to statically return false,
because it will assume that it could conceivably return True, and gives
different analysis in that case. Use a None return to achieve the same
effect, but make mypy happy.
Note: Pylint considers function signatures as code that
These arguments don't need to be mutable and aren't really used as
such. Clarify their types as immutable and adjust code to match where
necessary.
In general, It's probably best not to accept a user-defined mutable
object and store it as internal object state unless there's a strong
On 5/14/20 7:54 AM, John Snow wrote:
It can be None; so add assertions or exceptions where appropriate to
guard the access accordingly.
Signed-off-by: John Snow
---
python/qemu/lib/qtest.py | 14 +++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git
In the case that we receive a reply but are unable to understand it, use
this exception name to indicate that case.
Signed-off-by: John Snow
---
python/qemu/lib/qmp.py | 10 ++
1 file changed, 10 insertions(+)
diff --git a/python/qemu/lib/qmp.py b/python/qemu/lib/qmp.py
index
On 5/14/20 7:53 AM, John Snow wrote:
Put the init arg handling all at the top, and mostly in order (deviating
when one is dependent on another), and put what is effectively runtime
state declaration at the bottom.
Signed-off-by: John Snow
---
python/qemu/lib/machine.py | 29
On 5/14/20 7:53 AM, John Snow wrote:
Python 3.5 and above do not print a warning when logging is not
configured. As a library, it's best practice to leave logging
configuration to the client executable.
Signed-off-by: John Snow
---
python/qemu/lib/machine.py | 3 ---
1 file changed, 3
On 5/14/20 7:53 AM, John Snow wrote:
The type system doesn't want integers.
Signed-off-by: John Snow
---
python/qemu/lib/qmp.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/python/qemu/lib/qmp.py b/python/qemu/lib/qmp.py
index b91c9d5c1c..a634c4e26c 100644
---
On 5/14/20 7:53 AM, John Snow wrote:
When I initially split this out, I considered this more of a machine
error than a QMP protocol error, but I think that's misguided.
Move this back to qmp.py and name it QMPResponseError. Convert
qmp.command() to use this exception type.
Signed-off-by: John
1 - 100 of 114 matches
Mail list logo
