Am 26. Februar 2024 11:14:09 UTC schrieb "Philippe Mathieu-Daudé"
:
>Instantiate TYPE_ICH_DMI_PCI_BRIDGE in TYPE_ICH9_SOUTHBRIDGE.
>
>Since the Q35 machine doesn't use it, add the 'd2p-enabled'
>property to disable it.
>
>Signed-off-by: Philippe Mathieu-Daudé
>---
> include/hw/southbridge/ich9
Am 26. Februar 2024 11:13:59 UTC schrieb "Philippe Mathieu-Daudé"
:
>Since v1 [1]:
>- Rebased on top of Bernhard patches
>- Rename files with 'ich9_' prefix (Bernhard)
>
>Hi,
>
>I have a long standing southbridge QOM rework branches. Since
>Bernhard is actively working on the PIIX, I'll try to
22.02.2024 00:16, Michael Tokarev wrote:
-static int64_t cvtnum_full(const char *name, const char *value, int64_t min,
- int64_t max)
+static int64_t cvtnum_full(const char *name, const char *value,
+ bool issize, int64_t min, int64_t max)
{
26.02.2024 17:14, Daniel P. Berrangé :
On Thu, Feb 22, 2024 at 12:15:42AM +0300, Michael Tokarev wrote:
Currently we have:
./qemu-img resize none +10
qemu-img: Could not open 'none': Could not open 'none': No such file or
directory
stop printing the message twice, - local_err already ha
In order to correctly print executable name in various
error messages, pass argv[0] to error_exit() function.
This way, error messages will refer to actual executable
name, which may be different from 'qemu-img'.
For subcommands, pass original command name from the
qemu-img argv[0], plus the subco
22.02.2024 00:15, Michael Tokarev :
Currently we have:
./qemu-img resize none +10
qemu-img: Could not open 'none': Could not open 'none': No such file or
directory
This one needs expected-output tweaks for tests.
/mjt
26.02.2024 18:43, Michael Tokarev wrote:
The reason is most likely the argv/argc handling (lack of optind reset).
In the later change it is fixed but at that stage it's broken.
Nope. GNU getopt_long really needs resetting the state.
Or else it keeps return_in_order/permute/etc setting from
the
26.02.2024 18:40, Daniel P. Berrangé :
..
I'm not sure how, but this change seems to have broken the iotests.
Just one example:
Heh. Thank you for trying that. I wanted to do that but forgot.
The reason is most likely the argv/argc handling (lack of optind reset).
In the later change it is f
On Thu, Feb 22, 2024 at 12:15:45AM +0300, Michael Tokarev wrote:
> In order to correctly print executable name in various
> error messages, pass argv[0] to error_exit() function.
> This way, error messages will refer to actual executable
> name, which may be different from 'qemu-img'.
>
> For subc
26.02.2024 17:52, Daniel P. Berrangé wrote:
On Thu, Feb 22, 2024 at 12:16:00AM +0300, Michael Tokarev wrote:
'qemu-img resize --help' does not work, since it wants more
arguments. Also it -size is only recognized as a very last
argument, but it is common for tools to handle other options
after
On Thu, Feb 22, 2024 at 12:16:09AM +0300, Michael Tokarev wrote:
> cvtnum() expects input string to specify some sort of size
> (optionally with KMG... suffix). However, there are a lot
> of other number conversions in there (using qemu_strtol &Co),
> also, not all conversions which use cvtnum, ac
On Thu, Feb 22, 2024 at 12:16:08AM +0300, Michael Tokarev wrote:
> also add short description to each command and use it in --help
>
> Signed-off-by: Michael Tokarev
> ---
> qemu-img.c | 41 ++---
> 1 file changed, 34 insertions(+), 7 deletions(-)
Reviewed-by
On Thu, Feb 22, 2024 at 12:16:00AM +0300, Michael Tokarev wrote:
> 'qemu-img resize --help' does not work, since it wants more
> arguments. Also it -size is only recognized as a very last
> argument, but it is common for tools to handle other options
> after positional arguments too.
>
> Tell get
On Thu, Feb 22, 2024 at 12:16:07AM +0300, Michael Tokarev wrote:
> now once all individual subcommands has --help support, remove
> the large unreadable help() thing and replace it with small
> global --help, which refers to individual command --help for
> more info.
>
> While at it, also line-wra
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
On 26/2/24 11:50, BALATON Zoltan wrote:
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
On 26/2/24 08:40, Markus Armbruster wrote:
BALATON Zoltan writes:
On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote:
Rename "internal.h" as "ide_int
On 26/2/24 14:23, BALATON Zoltan wrote:
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
On 26/2/24 14:01, BALATON Zoltan wrote:
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
Expose TYPE_ICH_DMI_PCI_BRIDGE to the new
"hw/pci-bridge/ich9_dmi.h" header.
Since this is effectively an empt
On 26/2/24 11:50, BALATON Zoltan wrote:
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
On 26/2/24 08:40, Markus Armbruster wrote:
BALATON Zoltan writes:
On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote:
Rename "internal.h" as "ide_internal.h", and include
Is there a convention about
26.02.2024 17:34, Daniel P. Berrangé wrote:
On Thu, Feb 22, 2024 at 12:15:47AM +0300, Michael Tokarev wrote:
For the global help there's an extra '\n' after 'Usage'. It would be
good go be consistent in this between global and per-command help.
$ ./build/qemu-img --help
qemu-img version 8.2.5
On Thu, Feb 22, 2024 at 12:15:57AM +0300, Michael Tokarev wrote:
> When no -l/-a/-c/-d specified, assume -l (list).
>
> Use the same values for SNAPSHOT_LIST/etc constants as the
> option chars (lacd), this makes it possible to simplify
> option handling a lot, combining cases for 4 options into
>
On Thu, Feb 22, 2024 at 12:15:47AM +0300, Michael Tokarev wrote:
> Create helper function cmd_help() to display command-specific
> help text, and use it to print --help for 'create' subcommand.
>
> Add missing long options (eg --format) in img_create().
>
> Remove usage of missing_argument()/unre
On Thu, Feb 22, 2024 at 12:15:46AM +0300, Michael Tokarev wrote:
> This info will be used to generate --help output.
>
> Signed-off-by: Michael Tokarev
> ---
> qemu-img.c | 34 +-
> 1 file changed, 17 insertions(+), 17 deletions(-)
Reviewed-by: Daniel P. Berrangé
On Thu, Feb 22, 2024 at 12:15:45AM +0300, Michael Tokarev wrote:
> In order to correctly print executable name in various
> error messages, pass argv[0] to error_exit() function.
> This way, error messages will refer to actual executable
> name, which may be different from 'qemu-img'.
>
> For subc
On Thu, Feb 22, 2024 at 12:15:43AM +0300, Michael Tokarev wrote:
> qemu_opt_set_number() expects signed int64_t.
>
> Use int64_t instead of uint64_t for img_size, use -1 as "unset"
> value instead of UINT64_MAX, and do not require temporary sval
> for conversion from string.
>
> Signed-off-by: Mi
On Thu, Feb 22, 2024 at 12:15:44AM +0300, Michael Tokarev wrote:
> Initializing an unsigned as -1, or using temporary
> sval for conversion is awkward. Since we don't allow
> other "negative" values anyway, use signed value and
> pass it to bdrv_img_create() (where it is properly
> converted to un
On Thu, Feb 22, 2024 at 12:15:42AM +0300, Michael Tokarev wrote:
> Currently we have:
>
> ./qemu-img resize none +10
> qemu-img: Could not open 'none': Could not open 'none': No such file or
> directory
>
> stop printing the message twice, - local_err already has
> all the info, no need to p
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
On 26/2/24 13:52, BALATON Zoltan wrote:
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
Most ICH9-related files use the 'ich9_' prefix.
Mention 'AHCI' in the file name.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ide/{ich.c => ich9_ahci.c
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
On 26/2/24 14:01, BALATON Zoltan wrote:
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
Expose TYPE_ICH_DMI_PCI_BRIDGE to the new
"hw/pci-bridge/ich9_dmi.h" header.
Since this is effectively an empty object (that's not even instantiated by
On 26/2/24 13:52, BALATON Zoltan wrote:
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
Most ICH9-related files use the 'ich9_' prefix.
Mention 'AHCI' in the file name.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ide/{ich.c => ich9_ahci.c} | 0
That would rather be ahci-ich9.h then analog
On 26/2/24 14:01, BALATON Zoltan wrote:
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
Expose TYPE_ICH_DMI_PCI_BRIDGE to the new
"hw/pci-bridge/ich9_dmi.h" header.
Since this is effectively an empty object (that's not even instantiated
by default) I still think that instead of adding even
On 26/2/24 12:13, Philippe Mathieu-Daudé wrote:
Here we introduce the ICH9 'southbridge' as a QOM container.
Since the chipset comes as a whole, we shouldn't instantiate
its components separately. However in order to maintain old
code we expose some properties to configure the container and
not
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
Expose TYPE_ICH_DMI_PCI_BRIDGE to the new
"hw/pci-bridge/ich9_dmi.h" header.
Since this is effectively an empty object (that's not even instantiated by
default) I still think that instead of adding even more files for it all
this could just b
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
Most ICH9-related files use the 'ich9_' prefix.
Mention 'AHCI' in the file name.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ide/{ich.c => ich9_ahci.c} | 0
That would rather be ahci-ich9.h then analogous to ahci-allwinnet.c
maybe?
Regsard
Start the TYPE_ICH9_SOUTHBRIDGE stub, a kind of QOM
container which will contain all the ICH9 parts.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
include/hw/southbridge/ich9.h | 3 ++
hw/i386/pc_q35.c | 7
hw/southbridge/ich9.c | 61
Expose TYPE_ICH9_SMB_DEVICE to the new "hw/i2c/ich9_smbus.h"
header.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
include/hw/i2c/ich9_smbus.h | 25 +
hw/i2c/{smbus_ich9.c => ich9_smbus.c} | 15 ++-
hw/i2c/me
Instantiate TYPE_ICH_DMI_PCI_BRIDGE in TYPE_ICH9_SOUTHBRIDGE.
Since the Q35 machine doesn't use it, add the 'd2p-enabled'
property to disable it.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/southbridge/ich9.h | 9 -
hw/i386/pc_q35.c | 1 +
hw/southbridge/ich9.c
Most ICH9-related files use the 'ich9_' prefix.
Mention 'AHCI' in the file name.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ide/{ich.c => ich9_ahci.c} | 0
hw/ide/meson.build| 2 +-
2 files changed, 1 insertion(+), 1 deletion(-)
rename hw/ide/{ich.c => ich9_ahci.c} (100%)
diff --
Most ICH9-related files use the 'ich9_' prefix,
rename lpc_ich9.c as ich9_lpc.c.
Restrict LPC/ISA definitions by moving them
to the "hw/isa/ich9_lpc.h" header.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
include/hw/isa/ich9_lpc.h | 166 ++
Instantiate TYPE_ICH9_SMB_DEVICE in TYPE_ICH9_SOUTHBRIDGE.
Since the PC machines can disable SMBus (see the
PC_MACHINE_SMBUS dynamic property), add the 'smbus-enabled'
property to disable it.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/southbridge/ich9.h | 32 --
Instantiate EHCI and UHCI in TYPE_ICH9_SOUTHBRIDGE.
Since machines can disable USB, add the 'ehci-count'
property. Machine can disable USB functions by setting
ehci-count=0.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/southbridge/ich9.h | 5 ---
hw/i386/pc_q35.c | 62 ++--
Instantiate TYPE_ICH9_LPC_DEVICE in TYPE_ICH9_SOUTHBRIDGE.
Expose the SMM property so the Q35 machine can disable it
(depending on the accelerator used).
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/southbridge/ich9.h | 4
hw/i386/pc_q35.c | 20 ++--
h
Instantiate TYPE_ICH9_AHCI in TYPE_ICH9_SOUTHBRIDGE.
Since the PC machines can disable SATA (see the
PC_MACHINE_SATA dynamic property), add the 'sata-enabled'
property to disable it.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 2 ++
include/hw/southbridge/ich9.h |
Only files including "hw/acpi/ich9_tco.h" require
the ich9_generate_smi() declaration.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/acpi/ich9_tco.h| 1 +
include/hw/southbridge/ich9.h | 2 --
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/include/hw/acpi/ich9_tco.h b/i
Extract 'ICH9 South Bridge' from the 'PC' section.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 992799171f..e3f14c28a8 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1816
Expose TYPE_ICH_DMI_PCI_BRIDGE to the new
"hw/pci-bridge/ich9_dmi.h" header.
Signed-off-by: Philippe Mathieu-Daudé
---
MAINTAINERS | 1 +
include/hw/pci-bridge/ich9_dmi.h | 20
include/hw/southbridge/ich9.h | 2 --
hw/pci-
Since v1 [1]:
- Rebased on top of Bernhard patches
- Rename files with 'ich9_' prefix (Bernhard)
Hi,
I have a long standing southbridge QOM rework branches. Since
Bernhard is actively working on the PIIX, I'll try to refresh
and post. This is also motivated by the Dynamic Machine work
where we ar
Make it explicit the following are ICH9 specific:
acpi_pm_tco_init() -> ich9_acpi_pm_tco_init()
vmstate_tco_io_sts -> vmstate_ich9_sm_tco.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/acpi/ich9_tco.h | 5 ++---
hw/acpi/ich9.c | 4 ++--
hw/acpi/ich9_tco.c | 4 ++-
Restrict ACPI definitions from "hw/southbridge/ich9.h"
to the ACPI files where they are used.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/acpi/ich9.h| 15 +++
include/hw/southbridge/ich9.h | 18 --
hw/acpi/ich9.c| 4
3 files chan
Instead of casting OBJECT(lpc) multiple times,
do it once in the new 'lpc_obj' variable.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/i386/pc_q35.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index 45a4102e75..dcad6000d9 10
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
On 26/2/24 09:00, Philippe Mathieu-Daudé wrote:
On 26/2/24 08:40, Markus Armbruster wrote:
BALATON Zoltan writes:
On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote:
Rename "internal.h" as "ide_internal.h", and include
Is there a conventio
On Mon, 26 Feb 2024, Philippe Mathieu-Daudé wrote:
On 26/2/24 08:40, Markus Armbruster wrote:
BALATON Zoltan writes:
On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote:
Rename "internal.h" as "ide_internal.h", and include
Is there a convention about using underscore or dash in file names? T
On Feb 26 09:18, Philippe Mathieu-Daudé wrote:
> On 22/2/24 10:29, Klaus Jensen wrote:
> > From: Klaus Jensen
> >
> > numcntl is one byte and so is max_vfs. Using cpu_to_le16 on big endian
> > hosts results in numcntl being set to 0.
> >
> > Fix by dropping the endian conversion.
> >
> > Fixes:
Philippe Mathieu-Daudé writes:
> Rename "internal.h" as "ide_internal.h", and include
ide-internal.h
> it via its relative local path, instead of absolute
> to the project root path.
>
> Signed-off-by: Philippe Mathieu-Daudé
The series is a lovely little cleanup; thanks, guys!
On 22/2/24 10:29, Klaus Jensen wrote:
From: Klaus Jensen
numcntl is one byte and so is max_vfs. Using cpu_to_le16 on big endian
hosts results in numcntl being set to 0.
Fix by dropping the endian conversion.
Fixes: 746d42b13368 ("hw/nvme: Initialize capability structures for
primary/secondar
On 26/2/24 09:00, Philippe Mathieu-Daudé wrote:
On 26/2/24 08:40, Markus Armbruster wrote:
BALATON Zoltan writes:
On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote:
Rename "internal.h" as "ide_internal.h", and include
Is there a convention about using underscore or dash in file names?
The
Missing review: 3
Since v2:
- Remove local 'ahci' variable
- Rename "ide_internal.h" -> "ide-internal.h" (Zoltan)
Since v1:
- Remove use of "ahci_internal.h" in SBSA-Ref
- Rename "internal.h" -> "ide_internal.h"
Supersedes: <20240223142633.933694e6...@zero.eik.bme.hu>
BALATON Zoltan (1):
hw/i
Rename "internal.h" as "ide_internal.h", and include
it via its relative local path, instead of absolute
to the project root path.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/ide/ahci_internal.h| 2 +-
hw/ide/{internal.h => ide-internal.h} | 0
hw/ide/ahci.c
From: BALATON Zoltan
Remove last two includes of hw/ide/intarnal.h outside of hw/ide and
replace them with newly added public header to allow moving internal.h
into hw/ide to really stop exposing it.
Fixes: a11f439a0e (hw/ide: Stop exposing internal.h to non-IDE files)
Signed-off-by: BALATON Zol
Use ahci_ide_create_devs() instead of open-coding it.
Not accessing AHCIDevice internals anymore allows to
remove "hw/ide/ahci_internal.h" (which isn't really a
public header).
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Thomas Huth
---
hw/arm/sbsa-ref.c | 11 +--
1 file changed,
On 26/2/24 08:40, Markus Armbruster wrote:
BALATON Zoltan writes:
On Sun, 25 Feb 2024, Philippe Mathieu-Daudé wrote:
Rename "internal.h" as "ide_internal.h", and include
Is there a convention about using underscore or dash in file names? The headers
Thomas added are using - as well as ahci
59 matches
Mail list logo
