ded
zeroes. Then, the second pass is performed, to mirror the actual data
as before.
If the above two conditions are not met, then the first pass is skipped,
and only the second pass (the one with the actual data) is performed.
Signed-off-by: Jeff Cody <jc...@redhat.com>
---
block/mirror.c
share
is unresponsive.
Signed-off-by: Peter Lieven <p...@kamp.de>
Reviewed-by: Jeff Cody <jc...@redhat.com>
Reviewed-by: Max Reitz <mre...@redhat.com>
Message-id: 1440671441-7978-1-git-send-email...@kamp.de
Signed-off-by: Jeff Cody <jc...@redhat.com>
---
block/nfs.c | 36 +
From: Liu Yuan <liuy...@cmss.chinamobile.com>
With reopen supported, block-commit (and offline commit) is now supported for
image files whose base image uses the Sheepdog protocol driver.
Cc: qemu-de...@nongnu.org
Cc: Jeff Cody <jc...@redhat.com>
Cc: Kevin Wolf <kw...@redhat.
erlapping
Cc: Teruaki Ishizaki <ishizaki.teru...@lab.ntt.co.jp>
Cc: Vasiliy Tolstov <v.tols...@selfip.ru>
Cc: Jeff Cody <jc...@redhat.com>
Signed-off-by: Hitoshi Mitake <mitake.hito...@lab.ntt.co.jp>
Tested-by: Vasiliy Tolstov <v.tols...@selfip.ru>
Message-id: 14410
From: Peter Lieven <p...@kamp.de>
st.st_blocks is always counted in 512 byte units. Do not
use st.st_blksize as multiplicator which may be larger.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Peter Lieven <p...@kamp.de>
Reviewed-by: Max Reitz <mre...@redhat.com>
Reviewed
The following changes since commit eb9d0ea063fc7bdfab76b84085602a9e48d13ec7:
Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150924'
into staging (2015-09-24 01:32:11 +0100)
are available in the git repository at:
g...@github.com:codyprime/qemu-kvm-jtc.git
ommand
Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
Tested-by: Jeff Cody <jc...@redhat.com>
Message-id: 1441682913-14320-3-git-send-email-we...@cn.fujitsu.com
Signed-off-by: Jeff Cody <jc...@redhat.com>
---
block/backup.c | 20 ++--
1 file changed, 14 in
ations of snapshots and clones and
discards objects unconditionally.
With this patch, the driver just updates an inode object for updating
reference. Removing the object is done in sheep process side.
Cc: Teruaki Ishizaki <ishizaki.teru...@lab.ntt.co.jp>
Cc: Vasiliy Tolstov <v.tols...@selfip.ru
On Tue, Sep 08, 2015 at 11:28:31AM +0800, Wen Congyang wrote:
> If we do copy-on-read in before_write_notifier, qemu will be crashed. The
> backtrace is:
> Program terminated with signal 6, Aborted.
> #0 0x7f5d69207b55 in raise () from /lib64/libc.so.6
> (gdb) bt
> #0 0x7f5d69207b55 in
On Wed, Sep 02, 2015 at 08:35:37AM +0200, Alberto Garcia wrote:
> On Wed 02 Sep 2015 12:30:15 AM CEST, Jeff Cody <jc...@redhat.com> wrote:
>
> > Multiple sub-systems in QEMU may find it useful to generate IDs
> > for objects that a user may reference via QMP or HMP.
On Wed, Sep 02, 2015 at 05:09:41PM +0200, Max Reitz wrote:
> On 01.09.2015 00:55, Jeff Cody wrote:
> > On Mon, Aug 31, 2015 at 09:05:12PM +0200, Max Reitz wrote:
> >> Currently, if a qemu/qemu-io/qemu-img/qemu-nbd invocation receives a
> >> segmentation fault, that m
t;bs %p
> > sector_num %"PRId64" nb_sectors %d"
> > bdrv_co_copy_on_readv(void *bs, int64_t sector_num, int nb_sector) "bs %p
> > sector_num %"PRId64" nb_sectors %d"
> > +bdrv_co_nested_readv(void *bs, int64_t sector_num, int nb_sect
On Wed, Sep 02, 2015 at 04:51:11PM +0800, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
> Signed-off-by: Gonglei <arei.gong...@huawei.com>
> Cc: Jeff Cody <jc...@re
ned-off-by: Gonglei <arei.gong...@huawei.com>
> Cc: Jeff Cody <jc...@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefa...@redhat.com>
> ---
> block/Makefile.objs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/Makefile.objs b/block/Make
On Tue, Sep 01, 2015 at 03:13:52PM -0400, John Snow wrote:
>
>
> On 09/01/2015 01:23 PM, Jeff Cody wrote:
> > Multiple sub-systems in QEMU may find it useful to generated IDs
>
> generate
>
> > for objects that a user may reference via QMP or HMP. This patch
&
If a node-name is not specified, automatically generate the node-name.
Generated node-names will use the "block" sub-system identifier.
Signed-off-by: Jeff Cody <jc...@redhat.com>
---
block.c | 25 -
1 file changed, 16 insertions(+), 9 deletions(-)
diff
this:
#block076
The caller of id_generate() is responsible for freeing the generated
node name string with g_free().
Signed-off-by: Jeff Cody <jc...@redhat.com>
---
include/qemu-common.h | 8
util/id.c | 35 +++
2 files changed, 43 insertions(+)
details.
Jeff Cody (2):
util - add automated ID generation utility
block: auto-generated node-names
block.c | 25 -
include/qemu-common.h | 8
util/id.c | 35 +++
3 files changed, 59 insertions(+), 9
On Tue, Sep 01, 2015 at 12:55:15PM -0600, Eric Blake wrote:
> On 09/01/2015 11:23 AM, Jeff Cody wrote:
> > Multiple sub-systems in QEMU may find it useful to generated IDs
> > for objects that a user may reference via QMP or HMP. This patch
> > presents a standard
On Tue, Sep 01, 2015 at 04:55:16PM -0600, Eric Blake wrote:
> On 09/01/2015 04:30 PM, Jeff Cody wrote:
> > Multiple sub-systems in QEMU may find it useful to generate IDs
> > for objects that a user may reference via QMP or HMP. This patch
> > presents a standard
the next ID based on prior behavior).
See patch 1 for the generation scheme details.
Jeff Cody (2):
util - add automated ID generation utility
block: auto-generated node-names
block.c | 25 -
include/qemu-common.h | 8
util/id.c
The caller of id_generate() is responsible for freeing the generated
node name string with g_free().
Signed-off-by: Jeff Cody <jc...@redhat.com>
---
include/qemu-common.h | 8
util/id.c | 36
2 files changed, 44 insertions(+)
diff
If a node-name is not specified, automatically generate the node-name.
Generated node-names will use the "block" sub-system identifier.
Reviewed-by: Eric Blake <ebl...@redhat.com>
Reviewed-by: John Snow <js...@redhat.com>
Signed-off-by: Jeff Cody <jc...@redh
On Thu, Aug 27, 2015 at 12:30:41PM +0200, Peter Lieven wrote:
> If the file is readonly its not expected to grow so
> save the blocking call to nfs_fstat_async and use
> the value saved at connection time. Also important
> the monitor (and thus the main loop) will not hang
> if block device info
On Mon, Aug 31, 2015 at 09:05:12PM +0200, Max Reitz wrote:
> Currently, if a qemu/qemu-io/qemu-img/qemu-nbd invocation receives a
> segmentation fault, that message is invisible in most cases since the
> output is generally filtered and bash suppresses the segmentation fault
> notice for any but
is queried and the NFS share
is unresponsive.
Signed-off-by: Peter Lieven p...@kamp.de
---
v1-v2: update cache on reopen_prepare [Max]
v2-v3: use cache only if cache.direct=off [Max]
Reviewed-by: Jeff Cody jc...@redhat.com
On Thu, Aug 20, 2015 at 12:46:47PM +0200, Peter Lieven wrote:
st.st_blocks is always counted in 512 byte units. Do not
use st.st_blksize as multiplicator which may be larger.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Peter Lieven p...@kamp.de
---
block/nfs.c | 2 +-
1 file changed, 1
On Wed, Aug 26, 2015 at 08:49:06PM +0200, Peter Lieven wrote:
Am 26.08.2015 um 17:31 schrieb Jeff Cody:
On Mon, Aug 24, 2015 at 10:13:16PM +0200, Max Reitz wrote:
On 24.08.2015 21:34, Peter Lieven wrote:
Am 24.08.2015 um 20:39 schrieb Max Reitz:
On 24.08.2015 10:06, Peter Lieven wrote
On Mon, Aug 24, 2015 at 10:13:16PM +0200, Max Reitz wrote:
On 24.08.2015 21:34, Peter Lieven wrote:
Am 24.08.2015 um 20:39 schrieb Max Reitz:
On 24.08.2015 10:06, Peter Lieven wrote:
If the file is readonly its not expected to grow so
save the blocking call to nfs_fstat_async and use
(task.ret 0 ? task.ret : st.st_blocks * st.st_blksize);
+return (task.ret 0 ? task.ret : st.st_blocks * 512);
}
static int nfs_file_truncate(BlockDriverState *bs, int64_t offset)
--
1.9.1
Reviewed-by: Jeff Cody jc...@redhat.com
On Wed, Aug 19, 2015 at 01:43:41PM +0800, Wen Congyang wrote:
On 08/19/2015 01:41 PM, Paolo Bonzini wrote:
On 18/08/2015 19:54, Wen Congyang wrote:
We will copy data in before_write_notifier to do backup.
It is a nested I/O request, so we cannot do copy-on-read.
Can you explain why?
...@redhat.com
Reviewed-by: Jeff Cody jc...@redhat.com
Message-id: 1439455310-11263-1-git-send-email-kw...@redhat.com
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/mirror.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 0841964
/zero of=/var/tmp/foo oflag=direct
bs=4k.
Cc: Jeff Cody jc...@redhat.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Message-id: 1435761950-26714-1-git-send-email-stefa...@redhat.com
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/mirror.c
The following changes since commit be1f13ac9d9fc21908975460652a72f5f0c018c5:
Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150813' into staging
(2015-08-13 17:47:44 +0100)
are available in the git repository at:
g...@github.com:codyprime/qemu-kvm-jtc.git tags/block-pull-request
On Thu, Aug 13, 2015 at 10:41:50AM +0200, Kevin Wolf wrote:
This fixes a regression introduced by commit dcfb3beb (mirror: Do zero
write on target if sectors not allocated), which was reported to cause
aborts with the message Co-routine re-entered recursively.
The cause for this bug is the
;
qemu_coroutine_yield();
+s-waiting_for_io = false;
continue;
} else if (cnt != 0) {
delay_ns = mirror_iteration(s);
--
1.8.3.1
Reviewed-by: Jeff Cody jc...@redhat.com
On Fri, Aug 14, 2015 at 03:51:03PM +0100, Peter Maydell wrote:
On 14 August 2015 at 14:57, Jeff Cody jc...@redhat.com wrote:
The following changes since commit be1f13ac9d9fc21908975460652a72f5f0c018c5:
Merge remote-tracking branch 'remotes/lalrae/tags/mips-20150813' into
staging (2015
On Mon, Aug 03, 2015 at 11:52:37AM +0200, Paolo Bonzini wrote:
Since sheepdog does not implement a rebind callback, this back pointer
is dangerous. Do not use it.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/sheepdog.c | 4 +---
1 file changed, 1 insertion(+), 3
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/sheepdog.c | 152 ++-
1 file changed, 71 insertions(+), 81 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index bd7cbed..9585beb 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
The following changes since commit f793d97e454a56d17e404004867985622ca1a63b:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging
(2015-07-24 13:07:10 +0100)
are available in the git repository at:
https://github.com/codyprime/qemu-kvm-jtc.git
On Mon, Jul 27, 2015 at 11:21:42AM -0400, Jeff Cody wrote:
The following changes since commit f793d97e454a56d17e404004867985622ca1a63b:
Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into
staging (2015-07-24 13:07:10 +0100)
are available in the git repository
The following changes since commit f8787f8723eaca1be99e3b1873e54de163fffa93:
Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20150727' into
staging (2015-07-27 19:37:09 +0100)
are available in the git repository at:
g...@github.com:codyprime/qemu-kvm-jtc.git
On Wed, Jul 22, 2015 at 02:27:46PM +0100, Richard W.M. Jones wrote:
v3:
Same as v2 but set the return value to -EIO.
Thanks, applied to my block tree:
https://github.com/codyprime/qemu-kvm-jtc/tree/block
Thanks,
Jeff
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/sheepdog.c | 152 ++-
1 file changed, 71 insertions(+), 81 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index bd7cbed..9585beb 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
in the code as
well, so store the correct value for use in all those cases.
We also check the Max Tables Entries value, to make sure that it is
SIZE_MAX / 4, so we know the pagetable size will fit in size_t.
Reported-by: Richard W.M. Jones rjo...@redhat.com
Signed-off-by: Jeff Cody jc...@redhat.com
significantly less memory than
expected.
Since qemu_try_blockalign() size argument is size_t, cast the
multiplication correctly to prevent overflow.
The value of max_table_entries * 4 is used elsewhere in the code as
well, so store the correct value for use in all those cases.
Jeff Cody (2):
block: vpc
On Fri, Jul 24, 2015 at 04:08:57PM +0100, Stefan Hajnoczi wrote:
On Wed, Jul 22, 2015 at 09:56:41AM -0400, Jeff Cody wrote:
On Wed, Jul 22, 2015 at 02:27:47PM +0100, Richard W.M. Jones wrote:
Reviewed-by: Jeff Cody jc...@redhat.com
Jeff: Are you taking this through your tree like gluster
On Wed, Jul 22, 2015 at 07:29:47PM +0200, Max Reitz wrote:
On 22.07.2015 19:26, Jeff Cody wrote:
On Wed, Jul 22, 2015 at 07:02:02PM +0200, Max Reitz wrote:
On 21.07.2015 18:13, Jeff Cody wrote:
When we allocate the pagetable based on max_table_entries, we multiply
the max table entry value
On Wed, Jul 22, 2015 at 07:02:02PM +0200, Max Reitz wrote:
On 21.07.2015 18:13, Jeff Cody wrote:
When we allocate the pagetable based on max_table_entries, we multiply
the max table entry value by 4 to accomodate a table of 32-bit integers.
However, max_table_entries is a uint32_t, and the VPC
On Wed, Jul 22, 2015 at 02:07:22PM +0100, Richard W.M. Jones wrote:
On some (but not all) systems:
$ qemu-img create -f qcow2 overlay -b ssh://xen/
Segmentation fault
It turns out this happens when inet_connect returns -1 in the
following code, but errno == 0.
s-sock =
On Wed, Jul 22, 2015 at 02:22:18PM +0100, Richard W.M. Jones wrote:
On Wed, Jul 22, 2015 at 09:17:49AM -0400, Jeff Cody wrote:
Both nbd and sheepdog handle it in a similar fashion (i.e. not relying
on errno being set on inet_connect failure). However, both nbd and
sheepdog use -EIO
in the code as
well, so store the correct value for use in all those cases.
We also check the Max Tables Entries value, to make sure that it is
SIZE_MAX / 4, so we know the pagetable size will fit in size_t.
Reported-by: Richard W.M. Jones rjo...@redhat.com
Signed-off-by: Jeff Cody jc...@redhat.com
Message-id: 1434380534-7680-1-git-send-email-stefa...@redhat.com
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/backup.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/backup.c b/block/backup.c
index d3c7d9f..965654d 100644
--- a/block/backup.c
+++ b/block/backup.c
we...@cn.fujitsu.com
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Message-id: 1431486673-19280-1-git-send-email-f...@redhat.com
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/mirror.c | 13 -
1 file changed, 12 insertions(+), 1
or bdrv_close; this particular
bdrv_drain_all does nothing for that.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Reviewed-by: Fam Zheng f...@redhat.com
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Message-id: 1432822903-25821-1-git-send-email-pbonz...@redhat.com
Signed-off-by: Jeff Cody jc
qemu-img: curl: transfer closed with 469989 bytes remaining to read
qemu-img: error while reading sector 16384: Protocol error
Signed-off-by: Richard W.M. Jones rjo...@redhat.com
Reviewed-by: Stefan Hajnoczi stefa...@redhat.com
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/curl.c | 15
...@redhat.com
Message-id: a588.3080...@cn.fujitsu.com
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/mirror.c | 11 ++-
blockdev.c | 4 +---
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index a2700ca..323f747 100644
--- a/block
On Thu, Jun 25, 2015 at 08:39:56PM +0100, Richard W.M. Jones wrote:
Currently if qemu is connected to a curl source (eg. web server), and
the web server fails / times out / dies, you always see a bogus EIO
Input/output error.
For example, choose a large file located on any local webserver
;
rcb-acb = acb;
rcb-buf = buf;
rcb-s = acb-s;
--
1.9.1
Reviewed-by: Jeff Cody jc...@redhat.com
, errp);
-if (r 0) {
-goto failed_shutdown;
-}
-}
-
r = rados_connect(s-cluster);
if (r 0) {
error_setg(errp, error connecting);
--
1.9.1
Reviewed-by: Jeff Cody jc...@redhat.com
into the parent, delete nothing. */
bm = bdrv_reclaim_dirty_bitmap(bs, job-sync_bitmap, NULL);
assert(bm);
Didn't Jeff Cody already stage this?
Yes
of max_table_entries * 4 is used elsewhere in the code as
well, so store the correct value for use in all those cases.
Jeff Cody (2):
block: vpc - prevent overflow if max_table_entries = 0x4000
block: qemu-iotests - add check for multiplication overflow in vpc
block/vpc.c
in the code as
well, so store the correct value for use in all those cases.
Reported-by: Richard W.M. Jones rjo...@redhat.com
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vpc.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index 37572ba
This checks that VPC is able to successfully fail (without segfault)
on an image file with a max_table_entries that exceeds 0x4000.
This table entry is within the valid range for VPC (although too large
for this sample image).
Signed-off-by: Jeff Cody jc...@redhat.com
---
tests/qemu-iotests
On Thu, May 28, 2015 at 04:21:43PM +0200, Paolo Bonzini wrote:
Draining is not necessary, I/O can happen as soon as the
commit coroutine yields. Draining can be necessary before
reopening the file for read/write, or while modifying the
backing file chain, but that is done separately in
On Wed, May 13, 2015 at 11:11:13AM +0800, Fam Zheng wrote:
Before, we only yield after initializing dirty bitmap, where the QMP
command would return. That may take very long, and guest IO will be
blocked.
Add sleep points like the later mirror iterations.
Signed-off-by: Fam Zheng
~(BDRV_SECTOR_SIZE - 1)
--
1.8.3.1
Reviewed-by: Jeff Cody jc...@redhat.com
-desc_offset = 0x200;
break;
default:
-ret = vmdk_open_desc_file(bs, flags, buf, errp);
+ret = vmdk_open_desc_file(bs, flags, buf, options, errp);
break;
}
if (ret) {
--
1.8.3.1
Reviewed-by: Jeff Cody jc...@redhat.com
;
}
}
--
1.8.3.1
Acked-by: Jeff Cody jc...@redhat.com
On Fri, Apr 03, 2015 at 01:49:01PM -0600, Eric Blake wrote:
On 04/02/2015 10:28 PM, Jeff Cody wrote:
Basically, once a commit crosses more than one file, all intermediate
files are useless and might as well be discarded.
That's if you do a job-complete operation. But if you do a job
On Thu, Apr 02, 2015 at 01:24:02PM +0200, Kevin Wolf wrote:
Am 02.04.2015 um 12:58 hat Michael Tokarev geschrieben:
01.04.2015 15:34, Kevin Wolf wrote:
[]
Overriding the backing file should work like this:
-drive file=...,backing.file.filename=/dev/fdset/2
Oh-ok, this
1101 - 1171 of 1171 matches
Mail list logo
