Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64

2021-06-08 Thread Thomas Huth
On 08/06/2021 17.35, Alex Bennée wrote: Thomas Huth writes: On 08/06/2021 16.27, Alex Bennée wrote: Richard Henderson writes: On 6/4/21 8:53 AM, Alex Bennée wrote: The assumption that the qemu-system-aarch64 image can run all 32 bit machines is about to be broken... Um, what? Really w

Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64

2021-06-08 Thread John Snow
On 6/8/21 11:01 AM, Thomas Huth wrote: On 08/06/2021 16.27, Alex Bennée wrote: Richard Henderson writes: On 6/4/21 8:53 AM, Alex Bennée wrote: The assumption that the qemu-system-aarch64 image can run all 32 bit machines is about to be broken... Um, what? Really what we want is to probe

Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64

2021-06-08 Thread Alex Bennée
Thomas Huth writes: > On 08/06/2021 16.27, Alex Bennée wrote: >> Richard Henderson writes: >> >>> On 6/4/21 8:53 AM, Alex Bennée wrote: The assumption that the qemu-system-aarch64 image can run all 32 bit machines is about to be broken... >>> >>> Um, what? >> Really what we want is

Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64

2021-06-08 Thread Thomas Huth
On 08/06/2021 16.27, Alex Bennée wrote: Richard Henderson writes: On 6/4/21 8:53 AM, Alex Bennée wrote: The assumption that the qemu-system-aarch64 image can run all 32 bit machines is about to be broken... Um, what? Really what we want is to probe the -M (machines) that a binary support

Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64

2021-06-08 Thread Richard Henderson
On 6/8/21 7:27 AM, Alex Bennée wrote: Richard Henderson writes: On 6/4/21 8:53 AM, Alex Bennée wrote: The assumption that the qemu-system-aarch64 image can run all 32 bit machines is about to be broken... Um, what? Really what we want is to probe the -M (machines) that a binary supports

Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64

2021-06-08 Thread Thomas Huth
On 08/06/2021 16.41, Alex Bennée wrote: Thomas Huth writes: On 08/06/2021 15.42, John Snow wrote: On 6/4/21 11:53 AM, Alex Bennée wrote: The assumption that the qemu-system-aarch64 image can run all 32 bit machines is about to be broken and besides it's not likely this is What's changing?

Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64

2021-06-08 Thread Thomas Huth
On 08/06/2021 16.27, Alex Bennée wrote: Richard Henderson writes: On 6/4/21 8:53 AM, Alex Bennée wrote: The assumption that the qemu-system-aarch64 image can run all 32 bit machines is about to be broken... Um, what? Really what we want is to probe the -M (machines) that a binary support

Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64

2021-06-08 Thread Alex Bennée
Thomas Huth writes: > On 08/06/2021 15.42, John Snow wrote: >> On 6/4/21 11:53 AM, Alex Bennée wrote: >>> The assumption that the qemu-system-aarch64 image can run all 32 bit >>> machines is about to be broken and besides it's not likely this is >> What's changing? I'm not deeply familiar with

Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64

2021-06-08 Thread Thomas Huth
On 08/06/2021 15.42, John Snow wrote: On 6/4/21 11:53 AM, Alex Bennée wrote: The assumption that the qemu-system-aarch64 image can run all 32 bit machines is about to be broken and besides it's not likely this is What's changing? I'm not deeply familiar with aarch64. Why is this assumption ab

Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64

2021-06-08 Thread Alex Bennée
Richard Henderson writes: > On 6/4/21 8:53 AM, Alex Bennée wrote: >> The assumption that the qemu-system-aarch64 image can run all 32 bit >> machines is about to be broken... > > Um, what? Really what we want is to probe the -M (machines) that a binary supports rather than just barfing the tes

Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64

2021-06-08 Thread John Snow
On 6/4/21 11:53 AM, Alex Bennée wrote: The assumption that the qemu-system-aarch64 image can run all 32 bit machines is about to be broken and besides it's not likely this is What's changing? I'm not deeply familiar with aarch64. Why is this assumption about to be broken? improving out cove

Re: [PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64

2021-06-05 Thread Richard Henderson
On 6/4/21 8:53 AM, Alex Bennée wrote: The assumption that the qemu-system-aarch64 image can run all 32 bit machines is about to be broken... Um, what? r~ and besides it's not likely this is improving out coverage by much. Test the "virt" machine for both arm and aarch64 as it can be used

[PATCH v16 96/99] tests/qtest: split the cdrom-test into arm/aarch64

2021-06-04 Thread Alex Bennée
The assumption that the qemu-system-aarch64 image can run all 32 bit machines is about to be broken and besides it's not likely this is improving out coverage by much. Test the "virt" machine for both arm and aarch64 as it can be used by either architecture. Signed-off-by: Alex Bennée --- tests/