Luiz Capitulino lcapitul...@redhat.com writes:
On Wed, 18 Nov 2009 16:16:11 +0100
Markus Armbruster arm...@redhat.com wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
[...]
+static const char *append_field(QString *outstr, const QError *qerror,
+
Am 18.11.2009 20:06, schrieb Stefan Weil:
Kevin Wolf schrieb:
Hi all,
as Steve suggests, I'm forwarding the list of issues he found to the
mailing list. I've already looked at a few points in the block code and
sent patches. If everyone picks up one point, we should get through the
list
This series is required to use the lsi53c895a emulation with an old
proprietary driver. All changes should move the emulation closer to the
spec and the real hardware.
Find the patches also at git://git.kiszka.org/qemu.git queues/scsi
Laszlo Ast (7):
SCSI: Fix Standard INQUIRY data
From: Laszlo Ast laszlo@siemens-enterprise.com
See SCRIPTS, 3.2.17 SELECT.
Signed-off-by: Laszlo Ast laszlo@siemens-enterprise.com
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
hw/lsi53c895a.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git
From: Laszlo Ast laszlo@siemens-enterprise.com
Signed-off-by: Laszlo Ast laszlo@siemens-enterprise.com
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
hw/lsi53c895a.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index
From: Laszlo Ast laszlo@siemens-enterprise.com
Signed-off-by: Laszlo Ast laszlo@siemens-enterprise.com
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
hw/lsi53c895a.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
From: Laszlo Ast laszlo@siemens-enterprise.com
The critical part of this change is how to deal with simultaneaous
generation of interrupts. The only (normal) case when this happens in
the emulation is near simultaneous reselection + selection. If selection
comes first, there is no problem,
From: Laszlo Ast laszlo@siemens-enterprise.com
See SCRIPTS Programming Guide, 3.2.17 SELECT.
Signed-off-by: Laszlo Ast laszlo@siemens-enterprise.com
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
hw/lsi53c895a.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff
Anthony Liguori aligu...@linux.vnet.ibm.com writes:
Markus Armbruster wrote:
1. QError feels overengineered, particularly for a first iteration of a
protocol.
We go to great lengths to build highly structured error objects.
There is only one sane reason for doing that: a
Paolo Bonzini pbonz...@redhat.com writes:
2. It falls short of the requirement that clients can reasonably
classify errors they don't know.
True. (Though adding a classification mechanism can be done later
once we have an idea of what errors are there at all).
Yes.
If we think there's
Hi,
I just managed to push a qemu-kvm process (git rev. b496fe3431) into an
endless loop in qcow2_alloc_cluster_offset, namely over
QLIST_FOREACH(old_alloc, s-cluster_allocs, next_in_flight):
(gdb) bt
#0 0x0048614b in qcow2_alloc_cluster_offset (bs=0xc4e1d0,
offset=7417184256,
On 11/19/2009 09:42 AM, Markus Armbruster wrote:
It's probably convenient to have qjson emitting QError, I'm unsure
if we should do that for all kinds of QObjects though.
For a general purpose system, I'd recommend to cover all types. But as
long as this has just one user (QEMU), it
Stefan Weil a écrit :
Stefan Weil schrieb:
Stefano Stabellini schrieb:
Hi all,
currently vga always resizes the screen when vga_hw_invalidate is called
while this is not required and all the other graphic emulators don't.
This patch fixes it, making vga invalidate behaviour consistent with
Trying to debug the cdrom issue, I see
Compiling whole program out/ccode32.o
src/util.c: In function ‘__end_thread’:
src/util.c:183: internal compiler error: in simplify_subreg, at
simplify-rtx.c:5055
(with F12's gcc (GCC) 4.4.2 20091027 (Red Hat 4.4.2-7))
The issue seems to be with the
I'm trying to install Interactive Unix 4 with qemu 0.10.6, but there is some
problems when accessing the IDE disk. Everything appears to hang when the
system try to format the fs and all I can see on gdb is some interrupts
being executed. The fdisk utility works correctly.
As I never had
On 11/19/2009 11:25 AM, Markus Armbruster wrote:
But I can't see that need in your particular example. The client asks
the server to create a snapshot. The operation fails. The client
already knows what the name of the snapshot is, doesn't it? No need to
get it from the error.
Yeah, I just
On Thu, Nov 19, 2009 at 03:10:20PM +0200, Avi Kivity wrote:
Trying to debug the cdrom issue, I see
Compiling whole program out/ccode32.o
src/util.c: In function ‘__end_thread’:
src/util.c:183: internal compiler error: in simplify_subreg, at
simplify-rtx.c:5055
(with F12's gcc (GCC)
As far as I can see, this series addresses the review comments regarding
the current QError implementation. I'm still concerned about QError
design, and my concerns are being discussed. I hope we can wrap that up
soon and move on.
On 11/19/2009 03:39 PM, Kevin O'Connor wrote:
On Thu, Nov 19, 2009 at 03:10:20PM +0200, Avi Kivity wrote:
Trying to debug the cdrom issue, I see
Compiling whole program out/ccode32.o
src/util.c: In function ‘__end_thread’:
src/util.c:183: internal compiler error: in simplify_subreg, at
This patch adds a 'SIZE' type property to those available to qdevs.
It is the analogue of the OPT_SIZE property for options.
Signed-off-by: Ian Molton ian.mol...@collabora.co.uk
---
hw/qdev-properties.c | 34 ++
hw/qdev.h|4
Paolo Bonzini pbonz...@redhat.com writes:
On 11/19/2009 11:25 AM, Markus Armbruster wrote:
But I can't see that need in your particular example. The client asks
the server to create a snapshot. The operation fails. The client
already knows what the name of the snapshot is, doesn't it? No
Hi Jan,
Am 19.11.2009 13:19, schrieb Jan Kiszka:
(gdb) print ((BDRVQcowState *)bs-opaque)-cluster_allocs.lh_first
$5 = (struct QCowL2Meta *) 0xcb3568
(gdb) print *((BDRVQcowState *)bs-opaque)-cluster_allocs.lh_first
$6 = {offset = 7417176064, n_start = 0, nb_available = 16, nb_clusters = 0,
Kevin Wolf wrote:
Hi Jan,
Am 19.11.2009 13:19, schrieb Jan Kiszka:
(gdb) print ((BDRVQcowState *)bs-opaque)-cluster_allocs.lh_first
$5 = (struct QCowL2Meta *) 0xcb3568
(gdb) print *((BDRVQcowState *)bs-opaque)-cluster_allocs.lh_first
$6 = {offset = 7417176064, n_start = 0, nb_available =
Avi and Anthony,
If you agree that I've addressed all outstanding issues, please consider this
patch for inclusion. Thanks.
Changes since V3:
- Increase stat field size to 64 bits
- Report all sizes in kb (not pages)
- Drop anon_pages stat
Changes since V2:
- Use a virtqueue for
Hi,
This is not stable yet, it has a few bugs and a number of things to
be done, but I'm sending it now so that it can get an initial review
while I'm working on it.
At the end of the series there are two simple Python scripts which are
able to talk to QEMU by using QMP.
Main issues are:
o
This flag will be set when Monitor enters control mode, in
which the output will be defined by the QEMU Monitor Protocol.
This also introduces a macro to check if the flag is set.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c |6 ++
monitor.h |1 +
2 files
This commit adds a flag called 'control' to the '-monitor'
command-line option. This flag enables control mode.
The syntax is:
qemu [...] -monitor control,device
Where device is a chardev (excluding 'vc', for obvious reasons).
For example:
$ qemu [...] -monitor
It's going to be used by QMP code as well.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 20 +---
1 files changed, 13 insertions(+), 7 deletions(-)
diff --git a/monitor.c b/monitor.c
index a98dc42..07bd21c 100644
--- a/monitor.c
+++ b/monitor.c
@@
NOTE: These errors where added quickly to satisfy immediate needs,
they need to be reviewed.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
qerror.c | 20
qerror.h | 15 +++
2 files changed, 35 insertions(+), 0 deletions(-)
diff --git a/qerror.c
This patch adds initial QMP support in QEMU. It's important
to notice that most QMP code will be part of the Monitor.
Input will be handled by monitor_control_read(). Currently it
reads the input and discards it, next patches add proper input
support.
The function monitor_json_emitter(), as its
In the new Monitor, output is always done by only two
functions: do_info() and monitor_call_handler().
To support QMP output, we modify those functions to test if we
are in control mode. If so, we call monitor_protocol_emitter()
to emit QMP output, otherwise we do regular output.
QMP has two
QMP input is handled by monitor_handle_qmp_command().
This function's job is to check if the input is correct and
if so call the appropriate handler. In other words, it does
for QMP what monitor_parse_command() does for the user
protocol.
This means that monitor_handle_qmp_command() also has to
Asynchronous events are generated with a call to
monitor_protocol_event().
This function builds the right data-type and emit the event
right away. The emitted data is always a JSON object and its
format is as follows:
{ event: json-string,
timestamp: { seconds: json-number, microseconds:
Debug, shutdown, reset, powerdown and stop are all basic events,
as they are very simple they can be added in the same commit.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
monitor.c | 15 +++
monitor.h |5 +
vl.c | 11 +--
3 files changed, 29
We still have handlers which will call monitor print functions
in several places.
If they do this when we are in control mode, we will be emitting
garbage to our clients.
To avoid this situation, this commit adds a way to disable
those functions. If any of them is called when in control mode,
we
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
QMP/README | 47 +++
1 files changed, 47 insertions(+), 0 deletions(-)
create mode 100644 QMP/README
diff --git a/QMP/README b/QMP/README
new file mode 100644
index 000..5ac1742
---
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
QMP/qmp-spec.txt | 193 ++
1 files changed, 193 insertions(+), 0 deletions(-)
create mode 100644 QMP/qmp-spec.txt
diff --git a/QMP/qmp-spec.txt b/QMP/qmp-spec.txt
new file mode 100644
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
QMP/qmp-events.txt | 26 ++
1 files changed, 26 insertions(+), 0 deletions(-)
create mode 100644 QMP/qmp-events.txt
diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
new file mode 100644
index
This is a very simple shell written in Python which works
on top of QMP.
Unfortunately it's a bit awkward right now, as the user has
to specify the arguments names, for example:
(QEMU) info item=version
0.11.50
(QEMU)
Also, if the output is not a string or integer, the user is
is going to get a
A Python script which uses qmp.py to print some simple VM info.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
QMP/vm-info | 32
1 files changed, 32 insertions(+), 0 deletions(-)
create mode 100755 QMP/vm-info
diff --git a/QMP/vm-info b/QMP/vm-info
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this patch for
inclusion. Thanks.
Changes since V2:
- Increase stat field size to 64 bits
- Report all sizes in kb (not pages)
- Drop anon_pages stat and fix endianness conversion
Changes since V1:
- Use a
On 11/19/2009 05:06 PM, Adam Litke wrote:
Avi and Anthony,
If you agree that I've addressed all outstanding issues, please consider this
patch for inclusion. Thanks.
I'd like to see this (and all other virtio-ABI-modifying patches) first
go into the virtio pci spec, then propagated to
On 11/19/2009 05:13 PM, Luiz Capitulino wrote:
Hi,
This is not stable yet, it has a few bugs and a number of things to
be done, but I'm sending it now so that it can get an initial review
while I'm working on it.
At the end of the series there are two simple Python scripts which are
able
On 11/19/2009 05:19 PM, Adam Litke wrote:
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this patch for
inclusion. Thanks.
+struct virtio_balloon_stat
+{
+ __le16 tag;
+ __le64 val;
+};
+
You're not doing endian conversion in the host?
--
error
On 11/17/2009 03:21 PM, Avi Kivity wrote:
qemu-kvm's switch to seabios uncovered a regression with cdrom
handling. Vista x64 no longer recognizes the cdrom, while pc-bios
still works. Installing works, but that uses int 13, not the native
driver. Haven't investigated further yet.
Command
Avi Kivity wrote:
On 11/17/2009 03:21 PM, Avi Kivity wrote:
qemu-kvm's switch to seabios uncovered a regression with cdrom
handling. Vista x64 no longer recognizes the cdrom, while pc-bios
still works. Installing works, but that uses int 13, not the native
driver. Haven't investigated
On Thu, 2009-11-19 at 17:19 +0200, Avi Kivity wrote:
On 11/19/2009 05:06 PM, Adam Litke wrote:
Avi and Anthony,
If you agree that I've addressed all outstanding issues, please consider
this
patch for inclusion. Thanks.
I'd like to see this (and all other virtio-ABI-modifying
On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote:
On 11/19/2009 05:19 PM, Adam Litke wrote:
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this patch for
inclusion. Thanks.
+struct virtio_balloon_stat
+{
+ __le16 tag;
+ __le64 val;
+};
+
On 11/19/2009 05:56 PM, Adam Litke wrote:
On Thu, 2009-11-19 at 17:19 +0200, Avi Kivity wrote:
On 11/19/2009 05:06 PM, Adam Litke wrote:
Avi and Anthony,
If you agree that I've addressed all outstanding issues, please consider this
patch for inclusion. Thanks.
I'd like to
On 11/19/2009 05:58 PM, Adam Litke wrote:
On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote:
On 11/19/2009 05:19 PM, Adam Litke wrote:
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this patch for
inclusion. Thanks.
+struct virtio_balloon_stat
+{
+
On Thu, 2009-11-19 at 18:13 +0200, Avi Kivity wrote:
On 11/19/2009 05:58 PM, Adam Litke wrote:
On Thu, 2009-11-19 at 17:22 +0200, Avi Kivity wrote:
On 11/19/2009 05:19 PM, Adam Litke wrote:
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this
On Thu, 19 Nov 2009 17:20:30 +0200
Avi Kivity a...@redhat.com wrote:
On 11/19/2009 05:13 PM, Luiz Capitulino wrote:
Hi,
This is not stable yet, it has a few bugs and a number of things to
be done, but I'm sending it now so that it can get an initial review
while I'm working on it.
On Thu, 19 Nov 2009 13:13:28 -0200
Luiz Capitulino lcapitul...@redhat.com wrote:
o Not using the stream parser to read the input
Just to clarify: this only means that a '\n' is required at the end of
input. This series is already capable on reading json input.
A code review run by Steve Grubb complained about code in e1000.c:
In hw/e1000.c at line 89, vlan is declared to be 4 bytes.
At line 382 is an attempt to do a memmove over it with a size of 12.
This was fixed by splitting the memmove in two calls and
adding a comment to the declaration of vlan
Make using mingw32 on windows does not preserve $@ in macros
when they are modified using this pattern:
target: macro += something
This behaviour results in an error when QEMU_CFLAGS containing
-MMD -MP -MT $@ is modified for compilation of source files
which use SDL: $@ will expand to nothing,
Make using mingw32 on windows fails when running grep =y$$.
The command is expanded to grep =y$ and the missing
results in an error.
I don't expect a file config-devices.mak with =y somewhere in
the middle of a line (they are always at the end of the line),
so simplifying the regular expression
Stefan Weil wrote:
Make using mingw32 on windows does not preserve $@ in macros
when they are modified using this pattern:
target: macro += something
This behaviour results in an error when QEMU_CFLAGS containing
-MMD -MP -MT $@ is modified for compilation of source files
which use SDL: $@ will
Stefan Weil wrote:
A code review run by Steve Grubb complained about code in e1000.c:
In hw/e1000.c at line 89, vlan is declared to be 4 bytes.
At line 382 is an attempt to do a memmove over it with a size of 12.
+/* Fields vlan and data must not be reordered or separated. */
Sebastian Herbszt schrieb:
v0.11.0-rc0-1677-gf165b53
$ ./configure --target-list=i386-softmmu
$ make
Makefile:427: no file name for `-include'
/bin/sh.exe: -c: line 1: unexpected EOF while looking for matching `'
/bin/sh.exe: -c: line 2: syntax error: unexpected end of file
make: ***
Stefan Weil wrote:
Sebastian Herbszt schrieb:
v0.11.0-rc0-1677-gf165b53
$ ./configure --target-list=i386-softmmu
$ make
Makefile:427: no file name for `-include'
/bin/sh.exe: -c: line 1: unexpected EOF while looking for matching `'
/bin/sh.exe: -c: line 2: syntax error: unexpected end of file
Sebastian Herbszt wrote:
Stefan Weil wrote:
Sebastian Herbszt schrieb:
v0.11.0-rc0-1677-gf165b53
$ ./configure --target-list=i386-softmmu
$ make
Makefile:427: no file name for `-include'
/bin/sh.exe: -c: line 1: unexpected EOF while looking for matching `'
/bin/sh.exe: -c: line 2: syntax
Sebastian Herbszt schrieb:
Stefan Weil wrote:
Sebastian Herbszt schrieb:
v0.11.0-rc0-1677-gf165b53
$ ./configure --target-list=i386-softmmu
$ make
Makefile:427: no file name for `-include'
/bin/sh.exe: -c: line 1: unexpected EOF while looking for matching `'
/bin/sh.exe: -c: line 2:
Handling of transmit commands is rather complex,
so about 80 lines of code were moved from function
action_command to the new function tx_command.
The two new values tx and cb_address in the
eepro100 status structure made this possible without
passing too many parameters.
In addition, the moved
i386-softmmu/qemu -M isapc -bios pc-bios/bios.bin
(qemu) info cpus
* CPU #0: pc=0x000f3852
(qemu) x/20i $pc
0x000f3852: mov0xfd408,%eax
0x000f3857: cmp%eax,%edx
0x000f3859: jne0xf3852
0x000f385b: mov%ecx,0x1
0x000f3861: mov%ebx,0x10004
0x000f3867: xor%eax,%eax
On Thu, 19 Nov 2009, Stefan Weil wrote:
Make using mingw32 on windows does not preserve $@ in macros
when they are modified using this pattern:
target: macro += something
This behaviour results in an error when QEMU_CFLAGS containing
-MMD -MP -MT $@ is modified for compilation of source
Hi.
I am experiencing problems with bridged networking to ARM guests. I have
experimented with various kernel versions, distributions and host
machines and I experience the problem in all cases.
When I copy files into the guest using SCP, after an undeterministic
number of megabytes have
On Fri, 20 Nov 2009 01:49:05 am Adam Litke wrote:
Rusty and Anthony,
If I've addressed all outstanding issues, please consider this patch for
inclusion. Thanks.
Changes since V2:
- Increase stat field size to 64 bits
- Report all sizes in kb (not pages)
Hi Adam,
Looks like we're
Adam Litke wrote:
The precision for most of these stats (except major and minor faults)
is 4kb (at least for Linux guests on the platforms I can think of).
Sparc and Alpha have 8kb pages (minimum).
The stats could be counted in 4kb pages, but what's the point in that?
-- Jamie
Stefan Weil wrote:
Make using mingw32 on windows does not preserve $@ in macros
when they are modified using this pattern:
target: macro += something
Is it not using GNU Make, or is it some ancient version?
(make --version shows the version, if it's GNU Make).
-- Jamie
malc schrieb:
On Thu, 19 Nov 2009, Stefan Weil wrote:
Make using mingw32 on windows does not preserve $@ in macros
when they are modified using this pattern:
target: macro += something
This behaviour results in an error when QEMU_CFLAGS containing
-MMD -MP -MT $@ is modified for
On (Wed) Nov 18 2009 [16:17:02], Markus Armbruster wrote:
Luiz Capitulino lcapitul...@redhat.com writes:
@@ -176,8 +177,7 @@ DeviceState *qdev_device_add(QemuOpts *opts)
/* find driver */
info = qdev_find_info(NULL, driver);
if (!info) {
-qemu_error(Device \%s\
Jamie Lokier schrieb:
Stefan Weil wrote:
Make using mingw32 on windows does not preserve $@ in macros
when they are modified using this pattern:
target: macro += something
Is it not using GNU Make, or is it some ancient version?
(make --version shows the version, if it's GNU
72 matches
Mail list logo
