viltio_blak_dma_restart_bh() was unsafe, it used req-next after having
(possible) put req in another list
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio-blk.c | 29 ++---
1 files changed, 14 insertions(+), 15 deletions(-)
diff --git a/hw/virtio-blk.c
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio-blk.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c
index 838ec32..0b04d0d 100644
--- a/hw/virtio-blk.c
+++ b/hw/virtio-blk.c
@@ -20,13 +20,14 @@
#endif
typedef struct
This driver send a struct directly in the wire, where the struct
contains:
- target_phis_addr_t (can be 32 or 64 bits depending of host)
- void * (on host)
- size_t.
It has no hope of working across 32/64 or big/little endian. This problem
exist in previous one.
Signed-off-by: Juan Quintela
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio.c | 10 --
hw/virtio.h |4
2 files changed, 0 insertions(+), 14 deletions(-)
diff --git a/hw/virtio.c b/hw/virtio.c
index 73dae7c..2c4ac0b 100644
--- a/hw/virtio.c
+++ b/hw/virtio.c
@@ -730,16 +730,6 @@ const
Glauber Costa wrote:
+{
+if (kvm_enabled()) {
Is this ever called or intended to be called when kvm is disabled?
+kvm_cpu_flush_state(env);
+}
I don't think so. But this is here for consistency with its synchronize
brother.
Ack. As soon as someone starts to use this
On Wed, Dec 02, 2009 at 01:04:16PM +0100, Jan Kiszka wrote:
Gleb Natapov wrote:
On Tue, Dec 01, 2009 at 10:51:26AM -0200, Glauber Costa wrote:
This is a repost of the -smp series. Note that it depends on
irqchip-in-kernel,
that is already in staging. Also, you'll have to enable the
Gleb Natapov wrote:
On Wed, Dec 02, 2009 at 01:04:16PM +0100, Jan Kiszka wrote:
Gleb Natapov wrote:
On Tue, Dec 01, 2009 at 10:51:26AM -0200, Glauber Costa wrote:
This is a repost of the -smp series. Note that it depends on
irqchip-in-kernel,
that is already in staging. Also, you'll have to
On Wed, Dec 02, 2009 at 01:10:22PM +0100, Jan Kiszka wrote:
Glauber Costa wrote:
+{
+if (kvm_enabled()) {
Is this ever called or intended to be called when kvm is disabled?
+kvm_cpu_flush_state(env);
+}
I don't think so. But this is here for consistency with its
Gleb Natapov wrote:
On Wed, Dec 02, 2009 at 01:25:39PM +0100, Jan Kiszka wrote:
Gleb Natapov wrote:
On Wed, Dec 02, 2009 at 01:04:16PM +0100, Jan Kiszka wrote:
Gleb Natapov wrote:
On Tue, Dec 01, 2009 at 10:51:26AM -0200, Glauber Costa wrote:
This is a repost of the -smp series. Note that it
Gleb Natapov wrote:
On Wed, Dec 02, 2009 at 01:10:22PM +0100, Jan Kiszka wrote:
Glauber Costa wrote:
+{
+if (kvm_enabled()) {
Is this ever called or intended to be called when kvm is disabled?
+kvm_cpu_flush_state(env);
+}
I don't think so. But this is here for consistency
On 12/02/2009 01:24 PM, Alexander Graf wrote:
If it leads to removing the subsystem then it's not much gain for the
project and the users :)
I don't know of any succesful project that has maintainers who don't
feel responsible for the code they're comming.
Well the point I was trying
On Wed, Dec 02, 2009 at 01:33:11PM +0100, Jan Kiszka wrote:
Gleb Natapov wrote:
On Wed, Dec 02, 2009 at 01:25:39PM +0100, Jan Kiszka wrote:
Gleb Natapov wrote:
On Wed, Dec 02, 2009 at 01:04:16PM +0100, Jan Kiszka wrote:
Gleb Natapov wrote:
On Tue, Dec 01, 2009 at 10:51:26AM -0200,
On 11/30/2009 09:02 PM, Michael S. Tsirkin wrote:
PCI memory should be disabled at reset, otherwise
we might claim transactions at address 0.
I/O should also be disabled, although for cirrus
it is harmless to enable it as we do not
have I/O bar.
Note: bios fix needed for this patch to work
was
On 11/30/2009 06:04 PM, Avi Kivity wrote:
Why hasn't qemu-kvm switched to seabios?
Regressions. AFAICT all have been fixed now, and the switch is imminent.
The switch is now complete.
--
error compiling committee.c: too many arguments to function
Am 02.12.2009 13:03, schrieb Scott Tsai:
On Wed, Dec 2, 2009 at 7:26 PM, Kevin Wolf kw...@redhat.com wrote:
v3 even. Anthony, I hope this doesn't confuse your scripts?
Kevin, I see use of fopen, fdopen, popen, eventfd in qemu without the
equivalent of CLOEXEC set.
Do you want to handle
On 11/30/2009 04:17 PM, Michael S. Tsirkin wrote:
On Thu, Oct 08, 2009 at 05:52:56PM +0200, Michael S. Tsirkin wrote:
VGA adapters need to claim memory and i/o
transactions even if they do not have any
i/o or memory bars. E.g. PCI spec, page 297,
gives an example of such a device:
On Tue, Dec 01, 2009 at 10:51:30AM -0200, Glauber Costa wrote:
This function is similar to qemu-kvm's on_vcpu mechanism. Totally synchronous,
and guarantees that a given function will be executed at the specified vcpu.
This patch also convert usage within the breakpoints system
On Wed, Dec 02, 2009 at 02:52:33PM +0200, Avi Kivity wrote:
On 11/30/2009 09:02 PM, Michael S. Tsirkin wrote:
PCI memory should be disabled at reset, otherwise
we might claim transactions at address 0.
I/O should also be disabled, although for cirrus
it is harmless to enable it as we do not
On Wed, Dec 02, 2009 at 11:27:53AM -0200, Marcelo Tosatti wrote:
On Tue, Dec 01, 2009 at 10:51:30AM -0200, Glauber Costa wrote:
This function is similar to qemu-kvm's on_vcpu mechanism. Totally
synchronous,
and guarantees that a given function will be executed at the specified vcpu.
On Wed, Dec 02, 2009 at 01:04:06PM +0100, Juan Quintela wrote:
VMstate send buffers in bytes ammonts, not bits or MSIX_ENTRY_SIZE
multiples
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/msix.c | 13 +
hw/pci.h |2 ++
2 files changed, 11 insertions(+), 4
On 12/02/2009 03:33 PM, Michael S. Tsirkin wrote:
This for qemu.git
Please set the To: header correctly to avoid confusion.
--
error compiling committee.c: too many arguments to function
On Wed, Dec 02, 2009 at 01:04:04PM +0100, Juan Quintela wrote:
virtio_common_init() creates a struct with the right size, DO_UPCAST
is the appropiate thing here
Signed-off-by: Juan Quintela quint...@redhat.com
BTW why not container_of? That one does not require
field to be at the beginning
Avi/Marcelo
Please include this in a branch in qemu-kvm, for future inclusion
in qemu.git
This is basically the same thing that was sitting in staging for weeks,
just with a build bug fix on non-x86 hosts.
Glauber Costa (9):
introduce VMSTATE_U64
Provide ioapic-kvm
provide
Slightly modified version of a patch already included in qemu-kvm:
This is a patch actually written by Juan, which, according to him,
he plans on posting to qemu.git. Problem is that linux defines
u64 in a way that is type-uncompatible with uint64_t.
I am including it here, because it is a
This patch provides the file ioapic-kvm.c, which implements a schim over
the kvm in-kernel IO APIC.
Signed-off-by: Glauber Costa glom...@redhat.com
---
Makefile.target |2 +
hw/ioapic-kvm.c | 89 +++
hw/pc.c |7 -
hw/pc.h
i8259 chip will use it, so provide it, and export it through pc.h
Signed-off-by: Glauber Costa glom...@redhat.com
---
hw/apic.c |5 +
hw/pc.h |1 +
2 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/hw/apic.c b/hw/apic.c
index 87e7dc0..482bb1e 100644
--- a/hw/apic.c
+++
This patch provides the file i8259-kvm.c, which implements a schim over
the kvm in-kernel PIC.
Signed-off-by: Glauber Costa glom...@redhat.com
---
Makefile.target |2 +-
hw/i8259-kvm.c| 112 +
hw/pc.c |8 +++-
hw/pc.h
It is actually not necessary to call a tpr function to save and load cr8,
as cr8 is part of the processor state, and thus, it is much easier
to just add it to CPUState.
As for apic base, wrap kvm usages, so we can call either the qemu device,
or the in kernel version.
Signed-off-by: Glauber
This patch provides the file apic-kvm.c, which implements a schim over
the kvm in-kernel APIC.
Signed-off-by: Glauber Costa glom...@redhat.com
---
Makefile.target |2 +-
hw/apic-kvm.c | 157 +
hw/pc.c |6 ++-
hw/pc.h
We'll use it from inside the in-kernel apic chip, so get it into a header
file.
Signed-off-by: Glauber Costa glom...@redhat.com
---
target-i386/cpu.h |4
target-i386/kvm.c |2 +-
2 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/target-i386/cpu.h b/target-i386/cpu.h
Now that we have all devices set up, this patch initializes the irqchip.
This is dependant on the io-thread, since we need someone to pull ourselves
out of the halted state.
I believe this should be the default when we are running over the io-thread.
Later on, I plan to post a patch that makes it
To follow correctly what our bios ACPI tables say, we have to be able to program
our irqchips with GSI routing mappings. This support is already in qemu-kvm
Signed-off-by: Glauber Costa glom...@redhat.com
---
kvm-all.c |6 ++-
kvm.h |3 +
target-i386/kvm.c | 118
On 11/27/09 12:08, Gerd Hoffmann wrote:
On 11/26/09 16:50, Hannes Reinecke wrote:
So indeed, this approach would only work if we signal some sense code
back to the host.
I, OTOH, don't have any qualms with returning HARDWARE_ERROR,
0x26/0x08(TOO MANY SEGMENT DESCRIPTORS) resp 0x26h/0x0B (INLINE
Avi/Marcelo
Please include this in a branch in qemu-kvm for future inclusion
in qemu.git. It is the same material people have already commented
on in the ML.
Glauber Costa (11):
Don't mess with halted state.
store thread-specific env information
update halted state on mp_state sync
Since we'll have multiple cpu threads, at least for kvm, we need a way to store
and retrieve the CPUState associated with the current execution thread.
For the I/O thread, this will be NULL.
I am using pthread functions for that, for portability, but we could as well
use __thread keyword.
When we have irqchip in kernel, halted state is kernel
business. So don't initialize it in our code.
Signed-off-by: Glauber Costa glom...@redhat.com
---
hw/apic-kvm.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/hw/apic-kvm.c b/hw/apic-kvm.c
index 089fa45..e5a0bfc
This function is similar to qemu-kvm's on_vcpu mechanism. Totally synchronous,
and guarantees that a given function will be executed at the specified vcpu.
This patch also convert usage within the breakpoints system
Signed-off-by: Glauber Costa glom...@redhat.com
---
cpu-all.h |3 ++
If we are using in-kernel irqchip, halted state belongs in the kernel.
So everytime we grab kernel's idea of mpstate, we also need to propagate
halted state to userspace.
Signed-off-by: Glauber Costa glom...@redhat.com
---
target-i386/kvm.c |5 +
1 files changed, 5 insertions(+), 0
This fix a bug with -smp in kvm. Since we have updated apic_base,
we also have to tell kernel about it. So instead of just updating
mp_state, update every regs.
It is mandatory that this happens synchronously, without waiting for
the next vcpu run. Otherwise, if we are migrating, or initializing
Before signalling a cpu, we have to set exit_request = 1, otherwise
it may go back to executing itself. So every cpu wakeup becomes
at least two statements. The qemu_cpu_kick already provides semantics
to that. So use it all over.
Signed-off-by: Glauber Costa glom...@redhat.com
---
vl.c |6
All reset functions are called from the same place, and this was a leftover
Signed-off-by: Glauber Costa glom...@redhat.com
---
kvm-all.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 596416a..1072d63 100644
--- a/kvm-all.c
+++ b/kvm-all.c
This have already been identified in qemu-kvm. We have to synchronously
tell the kernel about the APIC state. Otherwise, other cpus can see
bogus state for this lapic.
Signed-off-by: Glauber Costa glom...@redhat.com
---
hw/apic-kvm.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
The proposal in this patch is to add a system_reset caller that only
resets state related to the cpu. This will guarantee that does functions
are called from the cpu-threads, not the I/O thread.
In principle, it might seem close to the remote execution mechanism, but:
* It does not involve any
We don't support smp without irqchip in kernel, so only abort in
that situation
Signed-off-by: Glauber Costa glom...@redhat.com
---
kvm-all.c | 10 +-
kvm.h |2 ++
target-i386/kvm.c |7 +++
target-ppc/kvm.c |5 +
4 files changed, 19
It is much faster than pthread_{g,s}et_specific.
Signed-off-by: Glauber Costa glom...@redhat.com
---
configure | 17 +
vl.c | 16
2 files changed, 33 insertions(+), 0 deletions(-)
diff --git a/configure b/configure
index dca5a43..ce7bcc4 100755
---
On Wed, Dec 02, 2009 at 01:04:17PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/virtio.c b/hw/virtio.c
index fd617ff..2b36cad 100644
--- a/hw/virtio.c
+++
On Wed, Dec 02, 2009 at 11:41:19AM -0200, Glauber Costa wrote:
KVM vcpu threads should block SIGUSR1, set the in-kernel signal mask
with KVM_SET_SIGNAL_MASK ioctl, and eat the signal in
qemu_wait_io_event (qemu_flush_work should run after eating
the signal). Similarly to qemu-kvm's
This does not make a lot of sense separately:
you are changing routines that you yourself
then remove. And there is another helper not_msix
which you add in the next patch.
Maybe just roll this patch in
with the next one and be done with it.
On Wed, Dec 02, 2009 at 01:04:18PM +0100, Juan
On Wed, Dec 02, 2009 at 11:54:45AM -0200, Marcelo Tosatti wrote:
On Wed, Dec 02, 2009 at 11:41:19AM -0200, Glauber Costa wrote:
KVM vcpu threads should block SIGUSR1, set the in-kernel signal mask
with KVM_SET_SIGNAL_MASK ioctl, and eat the signal in
qemu_wait_io_event (qemu_flush_work
Kevin Wolf wrote:
Am 02.12.2009 12:24, schrieb Kevin Wolf:
We're leaking file descriptors to child processes. Set FD_CLOEXEC on file
descriptors that don't need to be passed to children to stop this misbehaviour.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
v2:
- The existence of
Our cpu keeps multiple seperate address spaces open at the same time
(similar to x86 with a bunch of cr0s), defined by address space control
elements in various control registers. Linux uses primary, secondary and
home space to address user space and kernel space. The third one is user
On Wed, Dec 02, 2009 at 01:04:10PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio-pci.c | 72 ++
1 files changed, 50 insertions(+), 22 deletions(-)
diff --git a/hw/virtio-pci.c
On Wed, Dec 02, 2009 at 01:04:13PM +0100, Juan Quintela wrote:
It was used only for PCI virtio devices, state that explicitely
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio-pci.c | 24 ++--
hw/virtio.c | 22 --
hw/virtio.h
On Wed, Dec 02, 2009 at 01:04:14PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio.c | 32 +++-
hw/virtio.h |2 ++
2 files changed, 21 insertions(+), 13 deletions(-)
diff --git a/hw/virtio.c b/hw/virtio.c
On Wed, Dec 02, 2009 at 01:04:25PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio-net.c | 21 ++---
1 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 97db0d0..cf13e94
On Wed, Dec 02, 2009 at 01:04:26PM +0100, Juan Quintela wrote:
This fixes endianess problems. Using ints and saving the state as bytes
break cross-endian migration.
Signed-off-by: Juan Quintela quint...@redhat.com
Good catch in itself, but relies on a broken patch before that.
---
Gerd Hoffmann wrote:
On 11/23/09 16:20, Anthony Liguori wrote:
Gerd Hoffmann wrote:
On 11/23/09 14:26, Paul Brook wrote:
I thinking more that this should be done by the character backend
itself. For
example, the graphical consoles should probably be putting this as
part of
the window title
On Wed, Dec 02, 2009 at 01:04:27PM +0100, Juan Quintela wrote:
And they were saved/loaded as unsigned already
I'm not sure how does on save/load a value as unsigned.
Could you please provide motivation for this
and similar changes?
Not that it matters very much, but int is slightly cleaner
than
No objection to this or similar change with vlans,
but I'd like to know why was this made a separate buffer
originally.
On Wed, Dec 02, 2009 at 01:04:29PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio-net.c |6 +-
1 files changed, 1
Markus Armbruster wrote:
The commit message is bogus. The patch is a minor fix of commit
e8ee28fb, and the message is a copy of that commit's message.
Thanks, I've updated the commit message appropriately.
Regards,
Anthony Liguori
On Wed, Dec 02, 2009 at 01:04:31PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio-net.c | 148
---
1 files changed, 64 insertions(+), 84 deletions(-)
diff --git a/hw/virtio-net.c
2009/12/1 Alexander Graf ag...@suse.de:
Hi,
Could someone with commit rights please stand up to feel responsible for
PPC?
Usually, when I send a patch to qemu-devel, I know who to address to
increase chances of it getting committed. For kvm/vnc/block I just CC
Anthony, for Audio I just CC
Arnd Bergmann wrote:
With the upcoming macvtap, we will want to open devices other than
/dev/net/tun but no longer need to call TUNSETIFF.
What are the names of these devices and how do you the character devices
get created in the first place?
This really isn't an arbitrary char device
Can you update this against staging (or master if you want 24 hours) to
take into account Mark's nic refactoring series? The changes looked
non-trivial to me.
Regards,
Anthony Liguori
* Jan Kiszka jan.kis...@siemens.com [2009-12-02 09:28]:
Hi,
I'm facing stalled x86-64 guests after live migration when using kvm
(share disk images). This does not happen with x86-32 guests or when
disabling kvm. Both qemu and qemu-kvm git heads are affected (recent
vmstate fixes applied).
I've got all of the patches I'm considering for 0.12 currently in
staging. I'm going to work through and test/commit these in a few
chunks over the next few days before freezing the tree.
If you have a pending patch that you think should be in 0.12, please
check to make sure it's there. If
On Wed, Dec 02, 2009 at 01:04:36PM +0100, Juan Quintela wrote:
viltio_blak_dma_restart_bh() was unsafe, it used req-next after having
(possible) put req in another list
Signed-off-by: Juan Quintela quint...@redhat.com
Sounds good, but why is this part of vmstate patchset?
---
On Wed, Dec 02, 2009 at 01:04:38PM +0100, Juan Quintela wrote:
This driver send a struct directly in the wire, where the struct
contains:
- target_phis_addr_t (can be 32 or 64 bits depending of host)
- void * (on host)
- size_t.
It has no hope of working across 32/64 or big/little endian.
Is -icount option supposed to work under qemu-system-sparc?
Tried a couple of values between 1 and 30 and get
qemu: fatal: Raised interrupt while not in I/O function
Ryan Harper wrote:
* Jan Kiszka jan.kis...@siemens.com [2009-12-02 09:28]:
Hi,
I'm facing stalled x86-64 guests after live migration when using kvm
(share disk images). This does not happen with x86-32 guests or when
disabling kvm. Both qemu and qemu-kvm git heads are affected (recent
* Jan Kiszka jan.kis...@siemens.com [2009-12-02 12:07]:
Ryan Harper wrote:
* Jan Kiszka jan.kis...@siemens.com [2009-12-02 09:28]:
Hi,
I'm facing stalled x86-64 guests after live migration when using kvm
(share disk images). This does not happen with x86-32 guests or when
disabling
Ryan Harper wrote:
* Jan Kiszka jan.kis...@siemens.com [2009-12-02 12:07]:
Ryan Harper wrote:
* Jan Kiszka jan.kis...@siemens.com [2009-12-02 09:28]:
Hi,
I'm facing stalled x86-64 guests after live migration when using kvm
(share disk images). This does not happen with x86-32 guests or when
Jan Kiszka jan.kis...@siemens.com wrote:
Hi,
I'm facing stalled x86-64 guests after live migration when using kvm
(share disk images). This does not happen with x86-32 guests or when
disabling kvm. Both qemu and qemu-kvm git heads are affected (recent
vmstate fixes applied). Running I/O load
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 01:04:04PM +0100, Juan Quintela wrote:
virtio_common_init() creates a struct with the right size, DO_UPCAST
is the appropiate thing here
Signed-off-by: Juan Quintela quint...@redhat.com
BTW why not container_of? That one
You probably can just roll not used anymore
lines in the parent patch. It does not help
splitting this part out IMO.
On Wed, Dec 02, 2009 at 01:04:39PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio.c | 10 --
hw/virtio.h |4
On Wed, Dec 02, 2009 at 07:19:17PM +0100, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 01:04:04PM +0100, Juan Quintela wrote:
virtio_common_init() creates a struct with the right size, DO_UPCAST
is the appropiate thing here
Signed-off-by: Juan
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 01:04:13PM +0100, Juan Quintela wrote:
diff --git a/hw/virtio.c b/hw/virtio.c
index c136005..b565bf9 100644
--- a/hw/virtio.c
+++ b/hw/virtio.c
@@ -643,8 +643,10 @@ void virtio_save(VirtIODevice *vdev, QEMUFile *f)
On Wed, Dec 02, 2009 at 01:04:19PM +0100, Juan Quintela wrote:
We need to do the virt queue msix and not msix version because we know
if there is msix at virtio level, not at queue element level
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/hw.h | 10 +
hw/virtio.c |
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 01:04:17PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/virtio.c b/hw/virtio.c
index
On Wed, Dec 02, 2009 at 07:24:12PM +0100, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 01:04:17PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio.c |8
1 files changed, 4 insertions(+),
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 01:04:25PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio-net.c | 21 ++---
1 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/hw/virtio-net.c
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 01:04:27PM +0100, Juan Quintela wrote:
And they were saved/loaded as unsigned already
I'm not sure how does on save/load a value as unsigned.
Could you please provide motivation for this
and similar changes?
Not that it
Artyom Tarasenko wrote:
2009/12/1 Alexander Graf ag...@suse.de:
Hi,
Could someone with commit rights please stand up to feel responsible for
PPC?
Usually, when I send a patch to qemu-devel, I know who to address to
increase chances of it getting committed. For kvm/vnc/block I just CC
On Wed, Dec 02, 2009 at 07:26:30PM +0100, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 01:04:25PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio-net.c | 21 ++---
1 files changed,
On Wed, Dec 02, 2009 at 07:30:18PM +0100, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 01:04:27PM +0100, Juan Quintela wrote:
And they were saved/loaded as unsigned already
I'm not sure how does on save/load a value as unsigned.
Could you please
* Jan Kiszka jan.kis...@siemens.com [2009-12-02 12:18]:
Ryan Harper wrote:
* Jan Kiszka jan.kis...@siemens.com [2009-12-02 12:07]:
Ryan Harper wrote:
* Jan Kiszka jan.kis...@siemens.com [2009-12-02 09:28]:
Hi,
I'm facing stalled x86-64 guests after live migration when using kvm
Michael S. Tsirkin m...@redhat.com wrote:
No objection to this or similar change with vlans,
but I'd like to know why was this made a separate buffer
originally.
Dunno, either, but I think that this has been always that way.
commit b6503ed9b8815ecfb82fe9faba28936365321248 was when it was
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 01:04:31PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio-net.c | 148
---
1 files changed, 64 insertions(+), 84 deletions(-)
Artyom Tarasenko wrote:
2009/12/1 Alexander Graf ag...@suse.de:
Hi,
Could someone with commit rights please stand up to feel responsible for
PPC?
Usually, when I send a patch to qemu-devel, I know who to address to
increase chances of it getting committed. For kvm/vnc/block I just CC
On Wed, Dec 02, 2009 at 01:04:31PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio-net.c | 148
---
1 files changed, 64 insertions(+), 84 deletions(-)
diff --git a/hw/virtio-net.c
On Wed, Dec 02, 2009 at 07:38:03PM +0100, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 01:04:31PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio-net.c | 148
On Wed, Dec 02, 2009 at 01:03:59PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
container_of please
---
hw/virtio-balloon.c | 11 +++
1 files changed, 3 insertions(+), 8 deletions(-)
diff --git a/hw/virtio-balloon.c b/hw/virtio-balloon.c
index
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 07:19:17PM +0100, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 01:04:04PM +0100, Juan Quintela wrote:
virtio_common_init() creates a struct with the right size, DO_UPCAST
is the
Ryan Harper wrote:
* Jan Kiszka jan.kis...@siemens.com [2009-12-02 12:18]:
Ryan Harper wrote:
* Jan Kiszka jan.kis...@siemens.com [2009-12-02 12:07]:
Ryan Harper wrote:
* Jan Kiszka jan.kis...@siemens.com [2009-12-02 09:28]:
Hi,
I'm facing stalled x86-64 guests after live migration when
On Wed, Dec 02, 2009 at 01:04:09PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
Let's just use binding for this.
---
hw/syborg_virtio.c |1 +
hw/virtio-pci.c|2 +-
hw/virtio.h|6 ++
3 files changed, 8 insertions(+), 1
On Wed, Dec 02, 2009 at 07:42:35PM +0100, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 07:19:17PM +0100, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 01:04:04PM +0100, Juan Quintela wrote:
2009/12/2 Jan Kiszka jan.kis...@siemens.com:
Artyom Tarasenko wrote:
2009/12/1 Alexander Graf ag...@suse.de:
Hi,
Could someone with commit rights please stand up to feel responsible for
PPC?
Usually, when I send a patch to qemu-devel, I know who to address to
increase chances of it
On Wed, 2009-12-02 at 19:33 +0100, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
No objection to this or similar change with vlans,
but I'd like to know why was this made a separate buffer
originally.
Dunno, either, but I think that this has been always that way.
2009/12/2 Anthony Liguori anth...@codemonkey.ws:
Artyom Tarasenko wrote:
2009/12/1 Alexander Graf ag...@suse.de:
Hi,
Could someone with commit rights please stand up to feel responsible for
PPC?
Usually, when I send a patch to qemu-devel, I know who to address to
increase chances of it
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 07:26:30PM +0100, Juan Quintela wrote:
Michael S. Tsirkin m...@redhat.com wrote:
On Wed, Dec 02, 2009 at 01:04:25PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/virtio-net.c |
101 - 200 of 236 matches
Mail list logo
