Re: [Qemu-devel] Re: [PATCH] Introduce a -libvirt-caps flag as a stop-gap

2010-07-27 Thread Avi Kivity
On 07/27/2010 07:38 PM, Anthony Liguori wrote: I'm going to revert the -help changes for 0.13 so that old versions of libvirt work but not for master. What is the goal here? Make qemu.git explicitly be unusable via libvirt? -- I have a truly marvellous patch that fixes the bug which this si

[Qemu-devel] [PATCH] vmstate: fix vmstate_subsection_load

2010-07-27 Thread TeLeMan
If the new version adds the new subsection for some vmstate, the old version will load the new version's vmstate unsuccessfully. So we have to ignore the unrecognized subsections. Signed-off-by: TeLeMan --- savevm.c | 11 +-- 1 files changed, 5 insertions(+), 6 deletions(-) diff --gi

Re: [Qemu-devel] [PATCH 02/34] pci: handle BAR mapping at PCI level

2010-07-27 Thread Isaku Yamahata
On Fri, Jul 23, 2010 at 08:15:44PM +, Blue Swirl wrote: > On Fri, Jul 23, 2010 at 10:40 AM, Isaku Yamahata > wrote: > > On Thu, Jul 22, 2010 at 09:54:46PM +, Blue Swirl wrote: > >> diff --git a/hw/pci.c b/hw/pci.c > >> index a98d6f3..49f03fb 100644 > >> --- a/hw/pci.c > >> +++ b/hw/pci.c

[Qemu-devel] PATCH: Adding options to generate SCSI based VMDK images

2010-07-27 Thread Aaron Mason
Hi all, I tried this once before using command-line parameters and it was knocked back. Someone made the mention of using options so I had a look and saw that it was really simple to do. The following is a patch from the latest Git snapshot. I have also attached it (in case it gets broken by Gm

[Qemu-devel] [Bug 586175] Re: Windows XP/2003 doesn't boot

2010-07-27 Thread Mathias Gug
** Changed in: qemu-kvm (Ubuntu) Importance: Undecided => Medium -- Windows XP/2003 doesn't boot https://bugs.launchpad.net/bugs/586175 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in QEMU: Incomplete Status in “qemu-kvm” p

[Qemu-devel] [Bug 586175] Re: Windows XP/2003 doesn't boot

2010-07-27 Thread flashydave
I am struggling with the same problem with a WIndows 2003 install under virt-manager/virsh The byte at 7e1c was already set to 3F. hexediting the byte at offset 7e1a to FF allowed the system to boot OK. -- Windows XP/2003 doesn't boot https://bugs.launchpad.net/bugs/586175 You received this bug n

Re: [Qemu-devel] [PATCH 07/12] linux-user: Load symbols from the interpreter.

2010-07-27 Thread malc
On Wed, 28 Jul 2010, malc wrote: > On Tue, 27 Jul 2010, Richard Henderson wrote: > > > On 07/27/2010 11:45 AM, malc wrote: > > >> +syms = realloc(syms, nsyms * sizeof(*syms)); > > > > > > Realloc can fail here. > > > > I don't believe it can. This (pre-existing) statement *reduces* > > the

Re: [Qemu-devel] [PATCH 07/12] linux-user: Load symbols from the interpreter.

2010-07-27 Thread malc
On Tue, 27 Jul 2010, Richard Henderson wrote: > On 07/27/2010 11:45 AM, malc wrote: > >> +syms = realloc(syms, nsyms * sizeof(*syms)); > > > > Realloc can fail here. > > I don't believe it can. This (pre-existing) statement *reduces* > the existing allocation of syms. I'd be surprised if a

[Qemu-devel] Re: sparc scsi/iommu/dma (was NMI handling)

2010-07-27 Thread Artyom Tarasenko
2010/7/27 Blue Swirl : > On Mon, Jul 26, 2010 at 10:23 PM, Artyom Tarasenko > wrote: >> 2010/7/26 Blue Swirl : >>> On Mon, Jul 26, 2010 at 4:53 PM, Artyom Tarasenko >>> wrote: 2010/6/21 Artyom Tarasenko : > 2010/5/25 Blue Swirl : About bugs, IIRC NetBSD 3.x crash could be relate

Re: [Qemu-devel] [PATCH 07/12] linux-user: Load symbols from the interpreter.

2010-07-27 Thread Richard Henderson
On 07/27/2010 11:45 AM, malc wrote: >> +syms = realloc(syms, nsyms * sizeof(*syms)); > > Realloc can fail here. I don't believe it can. This (pre-existing) statement *reduces* the existing allocation of syms. I'd be surprised if any malloc implementation fails on a size reduction. That sai

[Qemu-devel] Re: sparc scsi/iommu/dma (was NMI handling)

2010-07-27 Thread Blue Swirl
On Mon, Jul 26, 2010 at 10:23 PM, Artyom Tarasenko wrote: > 2010/7/26 Blue Swirl : >> On Mon, Jul 26, 2010 at 4:53 PM, Artyom Tarasenko >> wrote: >>> 2010/6/21 Artyom Tarasenko : 2010/5/25 Blue Swirl : >>> About bugs, IIRC NetBSD 3.x crash could be related to IOMMU. >> >> What do

Re: [Qemu-devel] [PATCH] ide_dma_cancel will result in partial DMA transfer (resend #4)

2010-07-27 Thread Andrea Arcangeli
Subject: avoid canceling ide dma From: Andrea Arcangeli The reason for not actually canceling the I/O is because with virtualization and lots of VM running, a guest fs may mistake a overload of the host, as an IDE timeout. So rather than canceling the I/O, it's safer to wait I/O completion and s

Re: [Qemu-devel] [PATCH] ide_dma_cancel will result in partial DMA transfer (resend #4)

2010-07-27 Thread malc
On Tue, 27 Jul 2010, Andrea Arcangeli wrote: > On Tue, Jul 27, 2010 at 01:24:12PM -0500, Anthony Liguori wrote: > > On 07/27/2010 01:15 PM, Andrea Arcangeli wrote: > > > On Tue, Jul 27, 2010 at 12:44:27PM -0500, Anthony Liguori wrote: > > > > > >> printf()s? > > >> > > > I see plenty of

Re: [Qemu-devel] [PATCH 07/12] linux-user: Load symbols from the interpreter.

2010-07-27 Thread malc
On Tue, 27 Jul 2010, Richard Henderson wrote: > First, adjust load_symbols to accept a load_bias parameter. At the same > time, read the entire section header table in one go, use pread instead > f lseek+read for the symbol and string tables, and properly free > allocated structures on error exit

[Qemu-devel] [PATCH 08/12] linux-user: Improve consistency checking in elf headers.

2010-07-27 Thread Richard Henderson
Validate more fields of the elf header. Extract those checks into two common functions to be used in both load_elf_interp and load_elf_binary. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 57 +- 1 files changed, 33 insertions(+),

Re: [Qemu-devel] [PATCH] ide_dma_cancel will result in partial DMA transfer (resend #4)

2010-07-27 Thread Anthony Liguori
On 07/27/2010 01:35 PM, Andrea Arcangeli wrote: On Tue, Jul 27, 2010 at 01:24:12PM -0500, Anthony Liguori wrote: On 07/27/2010 01:15 PM, Andrea Arcangeli wrote: On Tue, Jul 27, 2010 at 12:44:27PM -0500, Anthony Liguori wrote: printf()s? I see plenty of printf in

[Qemu-devel] [PATCH 12/12] linux-user: Re-use load_elf_image for the main binary.

2010-07-27 Thread Richard Henderson
This requires moving the PT_INTERP extraction and GUEST_BASE handling into load_elf_image. Key this off a non-null pointer argument to receive the interpreter name. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 380 ++ 1 files chang

[Qemu-devel] [PATCH 05/12] linux-user: Define ELF_DATA generically.

2010-07-27 Thread Richard Henderson
The only consideration on this value is the target endianness. The existing defines were incorrect for alpha and sh4eb. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 30 ++ 1 files changed, 6 insertions(+), 24 deletions(-) diff --git a/linux-user/elfl

Re: [Qemu-devel] [PATCH] ide_dma_cancel will result in partial DMA transfer (resend #4)

2010-07-27 Thread Andrea Arcangeli
On Tue, Jul 27, 2010 at 01:24:12PM -0500, Anthony Liguori wrote: > On 07/27/2010 01:15 PM, Andrea Arcangeli wrote: > > On Tue, Jul 27, 2010 at 12:44:27PM -0500, Anthony Liguori wrote: > > > >> printf()s? > >> > > I see plenty of printf in that file, do you want them only under > > #ifdef

[Qemu-devel] [PATCH 03/12] linux-user: Reindent elfload.c.

2010-07-27 Thread Richard Henderson
Signed-off-by: Richard Henderson --- linux-user/elfload.c | 1028 +- 1 files changed, 518 insertions(+), 510 deletions(-) diff --git a/linux-user/elfload.c b/linux-user/elfload.c index 2727222..6ea1e8d 100644 --- a/linux-user/elfload.c +++ b/linux-

[Qemu-devel] [PATCH 11/12] linux-user: Extract load_elf_image from load_elf_interp.

2010-07-27 Thread Richard Henderson
Moving toward a single copy of the elf binary loading code. Fill in the details of the loaded image into a struct image_info. Adjust create_elf_tables to read from such structures instead of from a collection of passed arguments. Don't return error values from load_elf_interp; always exit(-1) wit

[Qemu-devel] [PATCH 09/12] linux-user: Put the stack guard page at the top.

2010-07-27 Thread Richard Henderson
There are no supported stack-grows-up targets. We were putting the guard page at the highest address, i.e. the bottom of the stack. Use the maximum of host and guest page size for the guard size. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 31 +-- 1

[Qemu-devel] [PATCH 04/12] linux-user: Reduce lseek+reads while loading elf files.

2010-07-27 Thread Richard Henderson
Define BPRM_BUF_SIZE to 1k and read that amount initially. If the data we want from the binary is in this buffer, use it instead of reading from the file again. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 104 --- linux-user/linuxlo

Re: [Qemu-devel] [PATCH] Make default invocation of block drivers safer (v3)

2010-07-27 Thread Anthony Liguori
On 07/27/2010 12:43 PM, Anthony PERARD wrote: Anthony Liguori wrote: On 07/27/2010 12:01 PM, Anthony PERARD wrote: Anthony Liguori wrote: CVE-2008-2004 described a vulnerability in QEMU whereas a malicious user could trick the block probing code into accessing arbitrary files in a guest. To

Re: [Qemu-devel] [PATCH] ide_dma_cancel will result in partial DMA transfer (resend #4)

2010-07-27 Thread Anthony Liguori
On 07/27/2010 01:15 PM, Andrea Arcangeli wrote: On Tue, Jul 27, 2010 at 12:44:27PM -0500, Anthony Liguori wrote: printf()s? I see plenty of printf in that file, do you want them only under #ifdef DEBUG_IDE? Yes. Regards, Anthony Liguori

[Qemu-devel] [PATCH 06/12] linux-user: Clean up byte-swapping in elfload.c.

2010-07-27 Thread Richard Henderson
Remove ifdefs from code by defining empty inline functions when byte swapping isn't needed. Push loops over swapping arrays of structures into the swapping functions. Signed-off-by: Richard Henderson --- linux-user/elfload.c | 119 -- 1 files cha

[Qemu-devel] [PATCH 10/12] linux-user: Remove partial support for a.out interpreters.

2010-07-27 Thread Richard Henderson
At the bottom of the a.out support was the unimplemented load_aout_interp function. There were other portions of the support that didn't look right; when I went to look in the Linux kernel for clarification, I found that the support for such interpreters has been removed from binfmt_elf. There doe

[Qemu-devel] [PATCH 01/12] linux-user: Handle filesz < memsz for any PT_LOAD segment.

2010-07-27 Thread Richard Henderson
I caught padzero not properly initializing the .bss segment on a statically linked Alpha program. Rather than a minimal patch, replace the gross code with a single mmap+memset. Share more code between load_elf_interp and load_elf_binary. Legally, an ELF program need not have just a single .bss;

[Qemu-devel] [PATCH 02/12] Add more DT_* and AT_* constants to qemu's copy of elf.h.

2010-07-27 Thread Richard Henderson
Moving some PPC AT_* constants from elfload.c at the same time. Signed-off-by: Richard Henderson --- elf.h| 44 linux-user/elfload.c |9 - 2 files changed, 44 insertions(+), 9 deletions(-) diff --git a/elf.h b/elf.h inde

[Qemu-devel] [PATCH 07/12] linux-user: Load symbols from the interpreter.

2010-07-27 Thread Richard Henderson
First, adjust load_symbols to accept a load_bias parameter. At the same time, read the entire section header table in one go, use pread instead f lseek+read for the symbol and string tables, and properly free allocated structures on error exit paths. Second, adjust load_elf_interp to compute load

[Qemu-devel] [PATCH 00/12 v4] Clean up linux-user/elfload.c

2010-07-27 Thread Richard Henderson
A re-based and re-tested version of a patch series I posted back in April and May. These cleanups prepare elfload.c for loading the VDSO for x86_64. r~ Richard Henderson (12): linux-user: Handle filesz < memsz for any PT_LOAD segment. Add more DT_* and AT_* constants to qemu's copy of elf.

Re: [Qemu-devel] [PATCH] ide_dma_cancel will result in partial DMA transfer (resend #4)

2010-07-27 Thread Andrea Arcangeli
On Tue, Jul 27, 2010 at 12:44:27PM -0500, Anthony Liguori wrote: > printf()s? I see plenty of printf in that file, do you want them only under #ifdef DEBUG_IDE?

Re: [Qemu-devel] [PATCH] ide_dma_cancel will result in partial DMA transfer (resend #4)

2010-07-27 Thread malc
On Tue, 27 Jul 2010, Andrea Arcangeli wrote: > Subject: avoid canceling ide dma > > From: Andrea Arcangeli > > The reason for not actually canceling the I/O is because with > virtualization and lots of VM running, a guest fs may mistake a > overload of the host, as an IDE timeout. So rather tha

[Qemu-devel] Re: [PATCH] migration: Accept 'cont' only after successful incoming migration

2010-07-27 Thread Luiz Capitulino
On Tue, 27 Jul 2010 15:49:19 +0530 Amit Shah wrote: > When a 'cont' is issued on a VM that's just waiting for an incoming > migration, the VM reboots and boots into the guest, possibly corrupting > its storage since it could be shared with another VM running elsewhere. > > Ensure that a VM start

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Avi Kivity
On 07/27/2010 08:01 PM, Daniel P. Berrange wrote: It's annoying to us old hands, but it does give that nice integrated system feel that we're missing, and it works even if virt-manager is in the background (or if you don't use virt-manager at all). Given that there's a kerneloops pluging that

Re: [Qemu-devel] Re: [PATCH] Introduce a -libvirt-caps flag as a stop-gap

2010-07-27 Thread Chris Wright
* Anthony Liguori (anth...@codemonkey.ws) wrote: > Here are the possible things we can do: > > 1) merge -libvirt-caps as an intermediate solution, stop caring > about -help changes, when full caps are introduced, stop updating > -libvirt-caps > > 2) don't merge -libvirt-caps, stop caring about -h

Re: [Qemu-devel] [PATCH] Make default invocation of block drivers safer (v3)

2010-07-27 Thread Anthony PERARD
Anthony Liguori wrote: On 07/27/2010 12:01 PM, Anthony PERARD wrote: Anthony Liguori wrote: CVE-2008-2004 described a vulnerability in QEMU whereas a malicious user could trick the block probing code into accessing arbitrary files in a guest. To mitigate this, we added an explicit format para

Re: [Qemu-devel] [PATCH] ide_dma_cancel will result in partial DMA transfer (resend #4)

2010-07-27 Thread Anthony Liguori
On 07/27/2010 12:30 PM, Andrea Arcangeli wrote: Subject: avoid canceling ide dma From: Andrea Arcangeli The reason for not actually canceling the I/O is because with virtualization and lots of VM running, a guest fs may mistake a overload of the host, as an IDE timeout. So rather than canceling

[Qemu-devel] [PATCH] ide_dma_cancel will result in partial DMA transfer (resend #4)

2010-07-27 Thread Andrea Arcangeli
Subject: avoid canceling ide dma From: Andrea Arcangeli The reason for not actually canceling the I/O is because with virtualization and lots of VM running, a guest fs may mistake a overload of the host, as an IDE timeout. So rather than canceling the I/O, it's safer to wait I/O completion and s

Re: [Qemu-devel] Re: [PATCH] Introduce a -libvirt-caps flag as a stop-gap

2010-07-27 Thread Anthony Liguori
On 07/27/2010 12:00 PM, Daniel P. Berrange wrote: Yup. You'll need to decide up front if you want to probe for a feature when it's introduced and have something added to capabilities. This is simple though. A few weeks before 0.14 is released, go through the change log, and anything that looks

Re: [Qemu-devel] [PATCH] Make default invocation of block drivers safer (v3)

2010-07-27 Thread Anthony Liguori
On 07/27/2010 12:01 PM, Anthony PERARD wrote: Anthony Liguori wrote: CVE-2008-2004 described a vulnerability in QEMU whereas a malicious user could trick the block probing code into accessing arbitrary files in a guest. To mitigate this, we added an explicit format parameter to -drive which d

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Daniel P. Berrange
On Tue, Jul 27, 2010 at 07:42:34PM +0300, Avi Kivity wrote: > On 07/27/2010 07:36 PM, Chris Wright wrote: > > > >>If things work there's no reason for the user to go look at the > >>logs. An exclamation point invites clicking. > >> > >>Even better would be an ABRT plugin, so if something goes >

Re: [Qemu-devel] [PATCH] Make default invocation of block drivers safer (v3)

2010-07-27 Thread Anthony PERARD
Anthony Liguori wrote: CVE-2008-2004 described a vulnerability in QEMU whereas a malicious user could trick the block probing code into accessing arbitrary files in a guest. To mitigate this, we added an explicit format parameter to -drive which disabling block probing. Fast forward to today, a

Re: [Qemu-devel] Re: [PATCH] Introduce a -libvirt-caps flag as a stop-gap

2010-07-27 Thread Daniel P. Berrange
On Tue, Jul 27, 2010 at 11:38:04AM -0500, Anthony Liguori wrote: > On 07/27/2010 11:09 AM, Daniel P. Berrange wrote: > >On Tue, Jul 27, 2010 at 10:55:03AM -0500, Anthony Liguori wrote: > > > >>Today libvirt parses -help output to attempt to enumerate capabilities. > >>This > >>is very broken a

[Qemu-devel] [PATCH v8 5/5] RESEND: Inter-VM shared memory PCI device

2010-07-27 Thread Cam Macdonell
resend for bug fix related to removal of irqfd Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This patch applies to the qemu-kvm repository.

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Avi Kivity
On 07/27/2010 07:47 PM, Avi Kivity wrote: On 07/27/2010 07:42 PM, Daniel P. Berrange wrote: I read that to mean...propagate stderr from qemu to be right in front of the user. So that's output from virsh or in virt-manager. Trouble is, that's only useful (at best) when starting a guest. P

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Avi Kivity
On 07/27/2010 07:42 PM, Daniel P. Berrange wrote: I read that to mean...propagate stderr from qemu to be right in front of the user. So that's output from virsh or in virt-manager. Trouble is, that's only useful (at best) when starting a guest. Perhaps some virt-manager thing (an exclamatio

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Avi Kivity
On 07/27/2010 07:36 PM, Chris Wright wrote: If things work there's no reason for the user to go look at the logs. An exclamation point invites clicking. Even better would be an ABRT plugin, so if something goes (marginally) wrong, the siren pops up and you're invited to report the bug. Des

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Daniel P. Berrange
On Tue, Jul 27, 2010 at 09:29:13AM -0700, Chris Wright wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Tue, Jul 27, 2010 at 07:17:06PM +0300, Avi Kivity wrote: > > > On 07/27/2010 06:28 PM, Anthony Liguori wrote: > > > > > > > >If we add docs/deprecated-features.txt, schedule rem

Re: [Qemu-devel] Re: [PATCH] Introduce a -libvirt-caps flag as a stop-gap

2010-07-27 Thread Anthony Liguori
On 07/27/2010 11:09 AM, Daniel P. Berrange wrote: On Tue, Jul 27, 2010 at 10:55:03AM -0500, Anthony Liguori wrote: Today libvirt parses -help output to attempt to enumerate capabilities. This is very broken and has led to multiple failures. Since libvirt is an important management interfac

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Chris Wright
* Avi Kivity (a...@redhat.com) wrote: > On 07/27/2010 07:29 PM, Chris Wright wrote: > > > >>QEMU stderr+out is already recorded in /var/lib/libvirt/qemu/$GUESTNAME.log > >>along with the env variables and argv used to spawn it. Or did you mean > >>provide an API + virsh command /virt-manager UI fo

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Avi Kivity
On 07/27/2010 07:29 PM, Chris Wright wrote: QEMU stderr+out is already recorded in /var/lib/libvirt/qemu/$GUESTNAME.log along with the env variables and argv used to spawn it. Or did you mean provide an API + virsh command /virt-manager UI for accessing the logs ? I read that to mean...propag

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Chris Wright
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Tue, Jul 27, 2010 at 07:17:06PM +0300, Avi Kivity wrote: > > On 07/27/2010 06:28 PM, Anthony Liguori wrote: > > > > > >If we add docs/deprecated-features.txt, schedule removal for at least > > >1 year in the future, and put a warning in the c

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Daniel P. Berrange
On Tue, Jul 27, 2010 at 07:17:06PM +0300, Avi Kivity wrote: > On 07/27/2010 06:28 PM, Anthony Liguori wrote: > > > >If we add docs/deprecated-features.txt, schedule removal for at least > >1 year in the future, and put a warning in the code that prints > >whenever raw is probed, I think I could

[Qemu-devel] Re: [PATCH 4/7] move 'unsafe' to end of caching modes in help

2010-07-27 Thread Anthony Liguori
On 07/27/2010 11:10 AM, Kevin Wolf wrote: Am 26.07.2010 19:28, schrieb Anthony Liguori: Hi Kevin, There's an on-going discussion on this patch. Could you drop it from your pull request but leave it in your tree until the discussion is resolved? Right, so I guess waiting some hours w

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Avi Kivity
On 07/27/2010 06:28 PM, Anthony Liguori wrote: If we add docs/deprecated-features.txt, schedule removal for at least 1 year in the future, and put a warning in the code that prints whenever raw is probed, I think I could warm up to this. Since libvirt should be insulating users from this to

[Qemu-devel] Re: [PATCH 4/7] move 'unsafe' to end of caching modes in help

2010-07-27 Thread Kevin Wolf
Am 26.07.2010 19:28, schrieb Anthony Liguori: > Hi Kevin, > > There's an on-going discussion on this patch. Could you drop it from > your pull request but leave it in your tree until the discussion is > resolved? Right, so I guess waiting some hours was enough and you're going to pull it without

[Qemu-devel] Re: [PATCH] Introduce a -libvirt-caps flag as a stop-gap

2010-07-27 Thread Daniel P. Berrange
On Tue, Jul 27, 2010 at 10:55:03AM -0500, Anthony Liguori wrote: > Today libvirt parses -help output to attempt to enumerate capabilities. This > is very broken and has led to multiple failures. Since libvirt is an > important > management interface to QEMU, we need to do a better job giving the

[Qemu-devel] [PATCH] Introduce a -libvirt-caps flag as a stop-gap

2010-07-27 Thread Anthony Liguori
Today libvirt parses -help output to attempt to enumerate capabilities. This is very broken and has led to multiple failures. Since libvirt is an important management interface to QEMU, we need to do a better job giving them the ability to detect what a QEMU executable supports. Right now, we ke

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Daniel P. Berrange
On Tue, Jul 27, 2010 at 10:28:04AM -0500, Anthony Liguori wrote: > On 07/27/2010 10:22 AM, Markus Armbruster wrote: > >Kevin Wolf writes: > > > > > >>Am 27.07.2010 15:00, schrieb Anthony Liguori: > >> > >>>On 07/27/2010 02:19 AM, Markus Armbruster wrote: > >>> > Anthony Liguori

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Anthony Liguori
On 07/27/2010 10:22 AM, Markus Armbruster wrote: Kevin Wolf writes: Am 27.07.2010 15:00, schrieb Anthony Liguori: On 07/27/2010 02:19 AM, Markus Armbruster wrote: Anthony Liguori writes: - any additional input on probed_raw? Isn't it a fait acco

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Markus Armbruster
Kevin Wolf writes: > Am 27.07.2010 15:00, schrieb Anthony Liguori: >> On 07/27/2010 02:19 AM, Markus Armbruster wrote: >>> Anthony Liguori writes: >>> >>> - any additional input on probed_raw? >>> Isn't it a fait accompli? I stopped providing input when commit >>> 79368c81 a

[Qemu-devel] KVM call minutes for July 27

2010-07-27 Thread Chris Wright
0.13 - -rc0 tagged, propagating now - no more features, bug fix only - although a few things, like shared memory device, are still feasible qemu64 cpu model - currently model 2 - this cpu simply does not exist at all in the real world - model 13 or higher windows 32bit will enable MSI/-X support

[Qemu-devel] Re: Introduce a new 'connected' xendev op called when Connected.

2010-07-27 Thread Stefano Stabellini
Any comments? On Wed, 21 Jul 2010, Stefano Stabellini wrote: > From: John Haxby > > Introduce a new 'connected' xendev op called when Connected. > > Rename the existing xendev 'connect' op to 'initialised' and introduce > a new 'connected' op. This new op, if defined, is called when the > back

[Qemu-devel] Re: Move the xenfb pointer handler to the connected method

2010-07-27 Thread Stefano Stabellini
Any comments? On Wed, 21 Jul 2010, Stefano Stabellini wrote: > From: John Haxby > > Move the xenfb pointer handler to the connected method > > Ensure that we read "request-abs-pointer" after the frontend has written > it. This means that we will correctly set up an ansolute or relative > point

[Qemu-devel] [PATCH] monitor: make 'info snapshots' show only fully available snapshots

2010-07-27 Thread Miguel Di Ciurcio Filho
The output generated by 'info snapshots' shows only snapshots that exist on the block device that saves the VM state. This output can cause an user to erroneously try to load an snapshot that is not available on all block devices. $ qemu-img snapshot -l xxtest.qcow2 Snapshot list: IDTAG

Re: [Qemu-devel] [RFC PATCH 06/14] KVM-test: Add basic file transfer test

2010-07-27 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: > This test is the basic test of transfering file between host and guest. Try to > transfer a large file from host to guest, and transfer it back to host, then > compare the files by diff command. > The default file size is 4000M, scp timeout is 1

[Qemu-devel] Re: [RFC PATCH 05/14] KVM-test: Add a subtest jumbo

2010-07-27 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: > According to different nic model set different MTU for it. And ping from guest > to host, to see whether tested size can be received by host. > > Signed-off-by: Jason Wang > Signed-off-by: Amos Kong > --- > 0 files changed, 0 insertions(+),

[Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Cole Robinson
On 07/27/2010 09:30 AM, Anthony Liguori wrote: > On 07/27/2010 06:51 AM, Daniel P. Berrange wrote: >> On Mon, Jul 26, 2010 at 05:28:21PM -0500, Anthony Liguori wrote: >> >>> On 07/26/2010 04:28 PM, Chris Wright wrote: >>> Please send in any agenda items you are interested in covering

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-27 Thread Cole Robinson
On 07/27/2010 08:50 AM, Anthony Liguori wrote: > On 07/27/2010 07:30 AM, Cole Robinson wrote: >> On 07/27/2010 05:47 AM, Jes Sorensen wrote: >> >>> On 07/27/10 10:11, Markus Armbruster wrote: >>> Anthony Liguori writes: > On 07/26/2010 02:19 PM, Avi Kivity wrote: >>

[Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Anthony Liguori
On 07/27/2010 06:51 AM, Daniel P. Berrange wrote: On Mon, Jul 26, 2010 at 05:28:21PM -0500, Anthony Liguori wrote: On 07/26/2010 04:28 PM, Chris Wright wrote: Please send in any agenda items you are interested in covering. - 0.13 update I'll pre-empt the 0.13 question wit

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Kevin Wolf
Am 27.07.2010 15:00, schrieb Anthony Liguori: > On 07/27/2010 02:19 AM, Markus Armbruster wrote: >> Anthony Liguori writes: >> >> >>> - any additional input on probed_raw? >>> >> Isn't it a fait accompli? I stopped providing input when commit >> 79368c81 appeared. >> > > No. 79368

Re: [Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Jes Sorensen
On 07/27/10 02:13, Alex Williamson wrote: > On Mon, 2010-07-26 at 18:28 -0500, Anthony Liguori wrote: >> On 07/26/2010 05:28 PM, Anthony Liguori wrote: >>> On 07/26/2010 04:28 PM, Chris Wright wrote: Please send in any agenda items you are interested in covering. >>> >>> - 0.13 update >>> I'

[Qemu-devel] Re: [RFC PATCH 04/14] KVM-test: Add a new subtest ping

2010-07-27 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: > This test use ping to check the virtual nics, it contains two kinds of test: > 1. Packet loss ratio test, ping the guest with different size of packets. > 2. Stress test, flood ping guest then use ordinary ping to test the network. > > The inte

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-27 Thread Bruce Rogers
>>> On 7/27/2010 at 04:26 AM, "Daniel P. Berrange" >>> wrote: > On Wed, Jul 21, 2010 at 02:32:28PM -0600, Bruce Rogers wrote: >> Libvirt parses qemu help output to determine qemu features. In particular >> it probes for the following: "cache=writethrough|writeback|none". The >> addition of t

Re: [Qemu-devel] [RFC PATCH 03/14] KVM Test: Add a common ping module for network related tests

2010-07-27 Thread Lucas Meneghel Rodrigues
On Tue, 2010-07-20 at 09:35 +0800, Amos Kong wrote: > The kvm_net_utils.py is a just a place that wraps common network > related commands which is used to do the network-related tests. > Use -1 as the packet ratio for loss analysis. > Use quiet mode when doing the flood ping. > > Signed-off-by: Ja

[Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Anthony Liguori
On 07/27/2010 02:19 AM, Markus Armbruster wrote: Anthony Liguori writes: - any additional input on probed_raw? Isn't it a fait accompli? I stopped providing input when commit 79368c81 appeared. No. 79368c81 was to close the security hole (and I do consider it a security hol

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-27 Thread Anthony Liguori
On 07/27/2010 07:30 AM, Cole Robinson wrote: On 07/27/2010 05:47 AM, Jes Sorensen wrote: On 07/27/10 10:11, Markus Armbruster wrote: Anthony Liguori writes: On 07/26/2010 02:19 PM, Avi Kivity wrote: We should try to support all users, prioritized by the number of

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-27 Thread Cole Robinson
On 07/27/2010 05:47 AM, Jes Sorensen wrote: > On 07/27/10 10:11, Markus Armbruster wrote: >> Anthony Liguori writes: >>> On 07/26/2010 02:19 PM, Avi Kivity wrote: We should try to support all users, prioritized by the number of end users they represent. If this patch broke some other la

[Qemu-devel] [PATCH] block: Change bdrv_eject() not to drop the image

2010-07-27 Thread Markus Armbruster
bdrv_eject() gets called when a device model opens or closes the tray. If the block driver implements method bdrv_eject(), that method gets called. Drivers host_cdrom implements it, and it opens and closes the physical tray, and nothing else. When a device model opens, then closes the tray, medi

[Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Daniel P. Berrange
On Mon, Jul 26, 2010 at 05:28:21PM -0500, Anthony Liguori wrote: > On 07/26/2010 04:28 PM, Chris Wright wrote: > >Please send in any agenda items you are interested in covering. > > > > - 0.13 update > I'll pre-empt the 0.13 question with an answer. I'm just testing the > VNC changes and if

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-27 Thread Daniel P. Berrange
On Wed, Jul 21, 2010 at 02:32:28PM -0600, Bruce Rogers wrote: > Libvirt parses qemu help output to determine qemu features. In particular > it probes for the following: "cache=writethrough|writeback|none". The > addition of the unsafe cache mode was inserted within this string, as > opposed to b

[Qemu-devel] [PATCH] migration: Accept 'cont' only after successful incoming migration

2010-07-27 Thread Amit Shah
When a 'cont' is issued on a VM that's just waiting for an incoming migration, the VM reboots and boots into the guest, possibly corrupting its storage since it could be shared with another VM running elsewhere. Ensure that a VM started with '-incoming' is only run when an incoming migration succe

[Qemu-devel] [PING^2] [PATCH v2] rtc: Remove TARGET_I386 from qemu-config.c, enables driftfix

2010-07-27 Thread Paolo Bonzini
On 07/14/2010 03:32 PM, Amit Shah wrote: On (Wed) Jun 23 2010 [20:14:04], Amit Shah wrote: qemu-config.c doesn't contain any target-specific code, and the TARGET_I386 conditional code didn't get compiled as a result. Removing this enables the driftfix parameter for rtc. Signed-off-by: Amit Shah

[Qemu-devel] Re: [PATCH] migration: Issue 'cont' only on successful incoming migration

2010-07-27 Thread Daniel P. Berrange
On Mon, Jul 26, 2010 at 09:49:12PM +0200, Juan Quintela wrote: > Laine Stump wrote: > > On 07/26/2010 10:23 AM, Luiz Capitulino wrote: > >> On Sat, 24 Jul 2010 13:01:24 +0530 > >> Amit Shah wrote: > >> > >>> On (Fri) Jul 23 2010 [15:08:18], Luiz Capitulino wrote: > > diff --git a/monitor.c b

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-27 Thread Jes Sorensen
On 07/27/10 10:11, Markus Armbruster wrote: > Anthony Liguori writes: >> On 07/26/2010 02:19 PM, Avi Kivity wrote: >>> We should try to support all users, prioritized by the number of end >>> users they represent. If this patch broke some other large user >>> we'd be in a bind. But likely this i

[Qemu-devel] Re: [SeaBIOS] [PATCH 2/2] seabios: pciinit: fix overflow when bar allocation.

2010-07-27 Thread Isaku Yamahata
On Mon, Jul 26, 2010 at 09:45:42PM -0400, Kevin O'Connor wrote: > On Mon, Jul 26, 2010 at 02:02:46PM +0900, Isaku Yamahata wrote: > > When allocating bar, overflow can occur. > > So add overflow check and don't allocate bar if overflowed. > > Overflow check is ugly, but necessary. > > Another sugge

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-27 Thread Kevin Wolf
Am 26.07.2010 17:53, schrieb Anthony Liguori: > I'm a practical guy, and I don't see that it's a huge burden for libvirt > to detect downstreams and build a feature matrix based on versions. If > someone demonstrates that it's infeasible, I'll happily reconsider. As a practical guy you should s

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-27 Thread Markus Armbruster
Anthony Liguori writes: > On 07/26/2010 02:19 PM, Avi Kivity wrote: [...] >> Regardless, outside of Windows users qemu will mostly be consumed >> via distribution branches, with different levels of backport >> happiness. We should recognize that and work with it, not against >> it. > > And it's

Re: [Qemu-devel] [PATCH] move 'unsafe' to end of caching modes in help

2010-07-27 Thread Markus Armbruster
Anthony Liguori writes: > On 07/26/2010 02:19 PM, Avi Kivity wrote: >>> Is what we are supporting just what libvirt expects there to be or >>> what any tool out there expects there to be? >> >> We should try to support all users, prioritized by the number of end >> users they represent. If this

[Qemu-devel] Re: KVM call agenda for July 27

2010-07-27 Thread Markus Armbruster
Anthony Liguori writes: > - any additional input on probed_raw? Isn't it a fait accompli? I stopped providing input when commit 79368c81 appeared.