Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-07-31 Thread Aurelien Jarno
On Sat, Jul 31, 2010 at 08:23:55PM +, Blue Swirl wrote: > On Sat, Jul 31, 2010 at 4:23 PM, malc wrote: > > History has shown that this particular rule is unenforcable. > > > > Signed-off-by: malc > > --- > >  CODING_STYLE |   11 ++- > >  1 files changed, 6 insertions(+), 5 deletions(-

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-07-31 Thread malc
On Sat, 31 Jul 2010, Blue Swirl wrote: > On Sat, Jul 31, 2010 at 4:23 PM, malc wrote: > > History has shown that this particular rule is unenforcable. > > > > Signed-off-by: malc > > --- > >  CODING_STYLE |   11 ++- > >  1 files changed, 6 insertions(+), 5 deletions(-) > > Not again: >

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-07-31 Thread Blue Swirl
On Sat, Jul 31, 2010 at 4:23 PM, malc wrote: > History has shown that this particular rule is unenforcable. > > Signed-off-by: malc > --- >  CODING_STYLE |   11 ++- >  1 files changed, 6 insertions(+), 5 deletions(-) Not again: http://lists.nongnu.org/archive/html/qemu-devel/2009-12/msg0

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-07-31 Thread Aurelien Jarno
On Sat, Jul 31, 2010 at 06:47:29PM +0200, Aurelien Jarno wrote: > On Sat, Jul 31, 2010 at 08:23:34PM +0400, malc wrote: > > History has shown that this particular rule is unenforcable. > > > > Signed-off-by: malc > > --- > > CODING_STYLE | 11 ++- > > 1 files changed, 6 insertions(+),

Re: [Qemu-devel] [PATCH] Drop braces around single statement rule

2010-07-31 Thread Aurelien Jarno
On Sat, Jul 31, 2010 at 08:23:34PM +0400, malc wrote: > History has shown that this particular rule is unenforcable. > > Signed-off-by: malc > --- > CODING_STYLE | 11 ++- > 1 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/CODING_STYLE b/CODING_STYLE > index 92036f3..

[Qemu-devel] [PATCH] Drop braces around single statement rule

2010-07-31 Thread malc
History has shown that this particular rule is unenforcable. Signed-off-by: malc --- CODING_STYLE | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff --git a/CODING_STYLE b/CODING_STYLE index 92036f3..e0b5376 100644 --- a/CODING_STYLE +++ b/CODING_STYLE @@ -54,16 +54,17 @@

Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-31 Thread Aurelien Jarno
On Sat, Jul 31, 2010 at 05:21:34PM +0200, Jes Sorensen wrote: > On 07/31/10 17:13, Aurelien Jarno wrote: > > On Sat, Jul 31, 2010 at 04:40:05PM +0200, Jes Sorensen wrote: > >> If you want that, please do it in a separate patch for the entire file, > >> otherwise it will never become consistent. How

Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-31 Thread Jes Sorensen
On 07/31/10 17:13, Aurelien Jarno wrote: > On Sat, Jul 31, 2010 at 04:40:05PM +0200, Jes Sorensen wrote: >> If you want that, please do it in a separate patch for the entire file, >> otherwise it will never become consistent. However it doesn't change the >> issue either that putting braces around

Re: [Qemu-devel] [PATCH] [MIPS] Correctly identify multiple cpus in SMP systems

2010-07-31 Thread Aurelien Jarno
On Sat, Jul 31, 2010 at 12:29:03PM +0200, Hervé Poussineau wrote: > > Signed-off-by: Hervé Poussineau > --- > target-mips/op_helper.c |3 +-- > target-mips/translate.c |3 +-- > 2 files changed, 2 insertions(+), 4 deletions(-) Thanks, applied. > diff --git a/target-mips/op_helper.c b/

Re: [Qemu-devel] [PATCH] jazz led: Fix debug prints

2010-07-31 Thread Aurelien Jarno
On Sat, Jul 31, 2010 at 11:05:28AM +0200, Hervé Poussineau wrote: > Add a macro to easily enable/disable debug prints > Also fix wrong printf formatters > > Signed-off-by: Hervé Poussineau > --- > hw/jazz_led.c | 21 +++-- > 1 files changed, 15 insertions(+), 6 deletions(-) Th

Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-31 Thread Aurelien Jarno
On Sat, Jul 31, 2010 at 04:40:05PM +0200, Jes Sorensen wrote: > On 07/31/10 16:19, Aurelien Jarno wrote: > > On Sat, Jul 31, 2010 at 11:16:45AM +0200, Jes Sorensen wrote: > >> On 07/30/10 23:08, Aurelien Jarno wrote: > >>> Missing braces around the return 0 line. > >> > >> Half the QEMU code base

Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-31 Thread Jes Sorensen
On 07/31/10 16:19, Aurelien Jarno wrote: > On Sat, Jul 31, 2010 at 11:16:45AM +0200, Jes Sorensen wrote: >> On 07/30/10 23:08, Aurelien Jarno wrote: >>> Missing braces around the return 0 line. >> >> Half the QEMU code base doesn't have braces around single line if >> statements, including in hw/p

Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-31 Thread Aurelien Jarno
On Sat, Jul 31, 2010 at 11:16:45AM +0200, Jes Sorensen wrote: > On 07/30/10 23:08, Aurelien Jarno wrote: > > On Fri, Jul 23, 2010 at 05:56:38PM +0200, jes.soren...@redhat.com wrote: > >> From: Jes Sorensen > >> > >> pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is setup > >> at i

[Qemu-devel] [PATCH] [MIPS] Correctly identify multiple cpus in SMP systems

2010-07-31 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- target-mips/op_helper.c |3 +-- target-mips/translate.c |3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/target-mips/op_helper.c b/target-mips/op_helper.c index a619b72..50c65bd 100644 --- a/target-mips/op_helper.c +++ b/target-mi

Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-31 Thread Jes Sorensen
On 07/30/10 23:08, Aurelien Jarno wrote: > On Fri, Jul 23, 2010 at 05:56:38PM +0200, jes.soren...@redhat.com wrote: >> From: Jes Sorensen >> >> pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is setup >> at init time, it is not possible to load an option ROM for a hotplug >> device

[Qemu-devel] [PATCH] [MIPS] Remove unused constant

2010-07-31 Thread Hervé Poussineau
Remove unused constant MIPS_FCR0 Signed-off-by: Hervé Poussineau --- target-mips/translate_init.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/target-mips/translate_init.c b/target-mips/translate_init.c index 0d9899e..8d1ece7 100644 --- a/target-mips/translate_init

[Qemu-devel] [PATCH] jazz led: Fix debug prints

2010-07-31 Thread Hervé Poussineau
Add a macro to easily enable/disable debug prints Also fix wrong printf formatters Signed-off-by: Hervé Poussineau --- hw/jazz_led.c | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/hw/jazz_led.c b/hw/jazz_led.c index 18780e9..4cb680c 100644 --- a/hw/

[Qemu-devel] [Bug 595438] Re: KVM segmentation fault, using SCSI+writeback and linux 2.4 guest

2010-07-31 Thread Коренберг Марк
Yeah! bug is killed ! Thanks for work, I love OpenSource :) -- KVM segmentation fault, using SCSI+writeback and linux 2.4 guest https://bugs.launchpad.net/bugs/595438 You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. Status in Kernel Virt