[Qemu-devel] [PATCH 07/15] vnc: palette: and fill and color calls.

2010-08-11 Thread Corentin Chary
These two helpers are needed for zrle and zywrle. Signed-off-by: Corentin Chary corenti...@iksaif.net --- ui/vnc-palette.c | 33 + ui/vnc-palette.h |3 +++ 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/ui/vnc-palette.c b/ui/vnc-palette.c

[Qemu-devel] [PATCH 11/15] bitmap: add a generic bitmap and bitops library

2010-08-11 Thread Corentin Chary
Add most used bitmap and bitops functions into bitmap.c and bitops.c. Theses functions are mostly copied from Linux kernel source. Some of these functions are already redefined in the VNC server. Some of them could be used for some block stuff. The yet yo be submitted NUMA work also need bitmaps.

Re: [Qemu-devel] [PATCH] trace: Make trace record fields 64-bit

2010-08-11 Thread Prerna Saxena
On 08/09/2010 07:05 PM, Stefan Hajnoczi wrote: Explicitly use 64-bit fields in trace records so that timestamps and magic numbers work for 32-bit host builds. Signed-off-by: Stefan Hajnoczistefa...@linux.vnet.ibm.com --- simpletrace.c | 31 +-- simpletrace.h |

[Qemu-devel] [PATCH 09/15] vnc: fix uint8_t comparisons with negative values

2010-08-11 Thread Corentin Chary
Signed-off-by: Corentin Chary corenti...@iksaif.net --- ui/vnc-enc-tight.c |6 +++--- ui/vnc-enc-zrle.c |3 ++- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c index 5ca4342..9f83235 100644 --- a/ui/vnc-enc-tight.c +++

[Qemu-devel] [PATCH 14/15] vnc: tight: tweak adaptive tight settings

2010-08-11 Thread Corentin Chary
The force_jpeg threshold was too low. Signed-off-by: Corentin Chary corenti...@iksaif.net --- qemu-thread.c |1 + ui/vnc-enc-tight.c | 20 ++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/qemu-thread.c b/qemu-thread.c index fbc78fe..4094c51 100644

[Qemu-devel] [PATCH 10/15] vnc: fix lossy rect refreshing

2010-08-11 Thread Corentin Chary
The for loop in send_lossy_rect was totally wrong, and we can't call vnc_set_bits() because it does not really do what it should. Use vnc_set_bit() directly instead. Signed-off-by: Corentin Chary corenti...@iksaif.net --- ui/vnc.c | 12 1 files changed, 8 insertions(+), 4

[Qemu-devel] [PATCH 13/15] vnc: don't try to send bigger updates that client height

2010-08-11 Thread Corentin Chary
Respect client size if it doesn't not support desktop resizing. Signed-off-by: Corentin Chary corenti...@iksaif.net --- ui/vnc.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 0adab4a..dffb4aa 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@

[Qemu-devel] [PATCH 15/15] vnc: add a non-adaptive option

2010-08-11 Thread Corentin Chary
This option allow to disable adaptive behaviors in some encodings. Signed-off-by: Corentin Chary corenti...@iksaif.net --- qemu-options.hx|9 + ui/vnc-enc-tight.c |2 +- ui/vnc.c | 13 + ui/vnc.h |1 + 4 files changed, 20 insertions(+), 5

[Qemu-devel] [PATCH 12/15] vnc: use the new generic bitmap functions

2010-08-11 Thread Corentin Chary
Switch to bitmap.h and bitops.h instead of redefining our own bitmap helpers. Signed-off-by: Corentin Chary corenti...@iksaif.net --- ui/vnc.c | 91 ++--- ui/vnc.h |7 +++-- 2 files changed, 25 insertions(+), 73 deletions(-) diff

[Qemu-devel] [PATCH 2/2] ivshmem: Fix compilation without kvm

2010-08-11 Thread Stefan Weil
kvm_set_ioeventfd_mmio_long is only available with CONFIG_KVM. Cc: Anthony Liguori aligu...@us.ibm.com Cc: Cam Macdonell c...@cs.ualberta.ca Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/ivshmem.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 1/2] ivshmem: Fix compilation (wrong format specifier)

2010-08-11 Thread Stefan Weil
st_size is an off32_t or off64_t, so %ld does not always work. Cc: Anthony Liguori aligu...@us.ibm.com Cc: Cam Macdonell c...@cs.ualberta.ca Signed-off-by: Stefan Weil w...@mail.berlios.de --- hw/ivshmem.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/ivshmem.c

[Qemu-devel] [Tracing] More Trace events

2010-08-11 Thread Prerna Saxena
This patch adds few more trace events for tracking IO and also to trace balloon event flagged via the monitor. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- balloon.c|2 ++ ioport.c |7 +++ trace-events |8 3 files changed, 17 insertions(+), 0

[Qemu-devel] Running the user emulation

2010-08-11 Thread C K Kashyap
Hi, I've built qemu on my mac osx using this config - ./configure --prefix=/Users/ckk/local/ --target-list=i386-softmmu x86_64-softmmu --enable-linux-user Now, I have a simple a.out built on linux - how can I run it using qemu on my mac box? -- Regards, Kashyap

Re: [Qemu-devel] [PATCH v8 5/5] RESEND: Inter-VM shared memory PCI device

2010-08-11 Thread Stefan Weil
Am 27.07.2010 18:54, schrieb Cam Macdonell: resend for bug fix related to removal of irqfd Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also supports interrupts between guest by communicating over a unix domain socket. This

Re: [Qemu-devel] Running the user emulation

2010-08-11 Thread Stefan Weil
Am 11.08.2010 10:31, schrieb C K Kashyap: Hi, I've built qemu on my mac osx using this config - ./configure --prefix=/Users/ckk/local/ --target-list=i386-softmmu x86_64-softmmu --enable-linux-user Now, I have a simple a.out built on linux - how can I run it using qemu on my mac box? --

Re: [Qemu-devel] [PATCH] Add new user mode option -ignore-environment

2010-08-11 Thread Stefan Weil
Am 01.08.2010 13:48, schrieb Stefan Weil: Am 16.07.2010 15:09, schrieb Stefan Weil: Am 16.07.2010 09:04, schrieb Markus Armbruster: Stefan Weilw...@mail.berlios.de writes: An empty environment is sometimes useful in user mode. The new option provides it for linux-user and bsd-user

Re: [Qemu-devel] Running the user emulation

2010-08-11 Thread C K Kashyap
Let me see if I understand this right - qemu loads the a.out and begins to interpret the x86 instructions in the a.out and when a system call happens, it makes the call the host system is that right? On Wed, Aug 11, 2010 at 2:12 PM, Stefan Weil w...@mail.berlios.de wrote: Am 11.08.2010

Re: [Qemu-devel] Running the user emulation

2010-08-11 Thread Stefan Weil
Am 11.08.2010 11:06, schrieb C K Kashyap: Let me see if I understand this right - qemu loads the a.out and begins to interpret the x86 instructions in the a.out and when a system call happens, it makes the call the host system is that right? Right. That's the way how linux user mode

[Qemu-devel] Latest version in Git doesn't link - any ideas?

2010-08-11 Thread Nigel Horne
make distclean ./configure --enable-linux-aio --enable-io-thread --enable-kvm make ... LINK arm-softmmu/qemu-system-arm ivshmem.o: In function `ivshmem_mmio_map': ivshmem.c:(.text+0x80f): undefined reference to `kvm_set_ioeventfd_mmio_long' ivshmem.o: In function `ivshmem_read':

Re: [Qemu-devel] Running the user emulation

2010-08-11 Thread C K Kashyap
I was wondering if it would be easy to force build the user-emulation on mac - as in, lets say my a.out from linux is really trivial - even statically linked for that matter. All it does is, say, write hello world\n to the screen - I'd imaging that write system call would be similar on mac (as far

Re: [Qemu-devel] [PATCH] trace: Make trace record fields 64-bit

2010-08-11 Thread malc
On Wed, 11 Aug 2010, Prerna Saxena wrote: On 08/09/2010 07:05 PM, Stefan Hajnoczi wrote: Explicitly use 64-bit fields in trace records so that timestamps and magic numbers work for 32-bit host builds. Signed-off-by: Stefan Hajnoczistefa...@linux.vnet.ibm.com --- simpletrace.c |

Re: [Qemu-devel] Running the user emulation

2010-08-11 Thread Stefan Weil
Am 11.08.2010 11:33, schrieb C K Kashyap: I was wondering if it would be easy to force build the user-emulation on mac - as in, lets say my a.out from linux is really trivial - even statically linked for that matter. All it does is, say, write hello world\n to the screen - I'd imaging that

[Qemu-devel] Re: [Tracing] More Trace events

2010-08-11 Thread Stefan Hajnoczi
On Wed, Aug 11, 2010 at 01:55:02PM +0530, Prerna Saxena wrote: This patch adds few more trace events for tracking IO and also to trace balloon event flagged via the monitor. Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- Thanks for adding these trace events. Two minor

[Qemu-devel] Unmaintained QEMU builds

2010-08-11 Thread Stefan Weil
Hi, since several months, QEMU for Windows (and mingw32 cross builds) no longer builds without error. I suspect that the same is true for QEMU on Darwin (lots of errors like darwin-user/qemu.h:149: error: cast to pointer from integer of different size), but I'm not sure here because I have no

Fwd: [Qemu-devel] Unmaintained QEMU builds

2010-08-11 Thread Matthijs ter Woord
Stefan, Sorry for directly replying. Resending to list: At least QEMU for windows has some serious bugs, related to GDB handling, and serial handling.. On Wed, Aug 11, 2010 at 12:58 PM, Stefan Weil w...@mail.berlios.de wrote: Hi, since several months, QEMU for Windows (and mingw32 cross

[Qemu-devel] [PATCH v2] trace: Make trace record fields 64-bit

2010-08-11 Thread Prerna Saxena
Explicitly use 64-bit fields in trace records so that timestamps and magic numbers work for 32-bit host builds. Changelog (from initial patch posted by Stefan): 1) TraceEventID is now uint64_t to take care of same number of tracepoints on both 32 and 64 bit builds. 2) Cast arguments to

Re: [Qemu-devel] Running the user emulation

2010-08-11 Thread C K Kashyap
Thanks Stefan for the explanation ... It does not look like a pleasant thing to do though :) On Wed, Aug 11, 2010 at 3:33 PM, Stefan Weil w...@mail.berlios.de wrote: Am 11.08.2010 11:33, schrieb C K Kashyap: I was wondering if it would be easy to force build the user-emulation on mac - as

[Qemu-devel] [Tracing][PATCH 0/2] More Trace events

2010-08-11 Thread Prerna Saxena
Set of patches to add trace-events for tracking IO and balloon events flagged via the monitor. -- Prerna Saxena Linux Technology Centre, IBM Systems and Technology Lab, Bangalore, India

[Qemu-devel] [Tracing][PATCH 1/2] More Trace events

2010-08-11 Thread Prerna Saxena
[PATCH 1/2] Trace events for tracking port IO Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- ioport.c |7 +++ trace-events |4 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/ioport.c b/ioport.c index 53dd87a..ec3dc65 100644 --- a/ioport.c +++

Re: [Qemu-devel] [PATCH 14/15] vnc: tight: tweak adaptive tight settings

2010-08-11 Thread Chris Krumme
Hello Corentin, On 08/11/2010 12:49 AM, Corentin Chary wrote: The force_jpeg threshold was too low. Signed-off-by: Corentin Charycorenti...@iksaif.net --- qemu-thread.c |1 + ui/vnc-enc-tight.c | 20 ++-- 2 files changed, 11 insertions(+), 10 deletions(-) diff

Re: [Qemu-devel] [PATCH 14/15] vnc: tight: tweak adaptive tight settings

2010-08-11 Thread Corentin Chary
On Wed, Aug 11, 2010 at 3:06 PM, Chris Krumme chris.kru...@windriver.com wrote: Hello Corentin, On 08/11/2010 12:49 AM, Corentin Chary wrote: The force_jpeg threshold was too low. Signed-off-by: Corentin Charycorenti...@iksaif.net ---  qemu-thread.c      |    1 +  ui/vnc-enc-tight.c |  

[Qemu-devel] [PATCH] virtio-9p: Allow O_NOCTTY flag in open().

2010-08-11 Thread Sripathi Kodi
Currently virtio-9p server doesn't allow O_NOCTTY flag in open(). However, gcc passes this flag while opening files. As a result it is now impossible to compile any C code on the 9P mount! I don't see any reason for dis-allowing O_NOCTTY flag in QEMU 9P server. AFAIK QEMU starts off with a

Re: [Qemu-devel] [Tracing][PATCH 0/2] More Trace events

2010-08-11 Thread Stefan Hajnoczi
On Wed, Aug 11, 2010 at 12:43 PM, Prerna Saxena pre...@linux.vnet.ibm.com wrote: Set of patches to add trace-events for tracking IO and balloon events flagged via the monitor. http://repo.or.cz/w/qemu/stefanha.git/commitdiff/939e5dc31ec374036628986686e9d49e6cbbc33c

Re: [Qemu-devel] [PATCH v8 5/5] RESEND: Inter-VM shared memory PCI device

2010-08-11 Thread Cam Macdonell
On Wed, Aug 11, 2010 at 4:35 AM, Stefan Weil w...@mail.berlios.de wrote: Am 27.07.2010 18:54, schrieb Cam Macdonell: resend for bug fix related to removal of irqfd Support an inter-vm shared memory device that maps a shared-memory object as a PCI device in the guest. This patch also

Re: [Qemu-devel] [PATCH] elf: Calculate symbol size if needed

2010-08-11 Thread Blue Swirl
On Mon, Aug 9, 2010 at 2:43 PM, Stefan Weil w...@mail.berlios.de wrote: Symbols with a size of 0 are unusable for the disassembler. Example: While running an arm linux kernel, no symbolic names are used in qemu.log when the cpu is executing an assembler function. That is a problem of the

Re: [Qemu-devel] Unmaintained QEMU builds

2010-08-11 Thread Blue Swirl
On Wed, Aug 11, 2010 at 10:58 AM, Stefan Weil w...@mail.berlios.de wrote: Hi, since several months, QEMU for Windows (and mingw32 cross builds) no longer builds without error. Not true for mingw32, it was building fine here until the latest commit. I suspect that the same is true for QEMU

[Qemu-devel] [Bug 614958] Re: copy-paste between client and host

2010-08-11 Thread Steve White
Hi Paolo, Thanks for your acknowledgement! if a solution is on the way, I'm glad to hear it! I agree that it would be best to keep this report open until *after* the solution arrives and this particular feature has been tested and it has been released to the public. If this SPICE doesn't

Re: [Qemu-devel] [PATCH v8 5/5] RESEND: Inter-VM shared memory PCI device

2010-08-11 Thread Paolo Bonzini
On 08/11/2010 11:49 AM, Cam Macdonell wrote: The win32 problems (missing mmap, maybe more) remain. Could you please fix them? Could that be accomplished with excluding it on Windows on the makefiles? Yes, just use obj-$(CONFIG_POSIX). Paolo

[Qemu-devel] Re: [PATCH 2/2] ivshmem: Fix compilation without kvm

2010-08-11 Thread Paolo Bonzini
On 08/11/2010 03:38 AM, Stefan Weil wrote: kvm_set_ioeventfd_mmio_long is only available with CONFIG_KVM. We should just disable ivshmem for non-KVM diff --git a/Makefile.target b/Makefile.target index b791492..c8281e9 100644 --- a/Makefile.target +++ b/Makefile.target @@ -191,7 +191,7 @@

Re: [Qemu-devel] Re: [PATCH 2/2] ivshmem: Fix compilation without kvm

2010-08-11 Thread Blue Swirl
On Wed, Aug 11, 2010 at 5:05 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 08/11/2010 03:38 AM, Stefan Weil wrote: kvm_set_ioeventfd_mmio_long is only available with CONFIG_KVM. We should just disable ivshmem for non-KVM diff --git a/Makefile.target b/Makefile.target index

[Qemu-devel] Re: [PATCH 2/2] ivshmem: Fix compilation without kvm

2010-08-11 Thread Cam Macdonell
On Wed, Aug 11, 2010 at 1:05 PM, Paolo Bonzini pbonz...@redhat.com wrote: On 08/11/2010 03:38 AM, Stefan Weil wrote: kvm_set_ioeventfd_mmio_long is only available with CONFIG_KVM. We should just disable ivshmem for non-KVM diff --git a/Makefile.target b/Makefile.target index

Re: [Qemu-devel] [PATCH] elf: Calculate symbol size if needed

2010-08-11 Thread Stefan Weil
Am 11.08.2010 18:21, schrieb Blue Swirl: On Mon, Aug 9, 2010 at 2:43 PM, Stefan Weilw...@mail.berlios.de wrote: Symbols with a size of 0 are unusable for the disassembler. Example: While running an arm linux kernel, no symbolic names are used in qemu.log when the cpu is executing an

[Qemu-devel] Re: [PATCH 2/2] ivshmem: Fix compilation without kvm

2010-08-11 Thread Paolo Bonzini
On 08/11/2010 01:18 PM, Blue Swirl wrote: On Wed, Aug 11, 2010 at 5:05 PM, Paolo Bonzinipbonz...@redhat.com wrote: On 08/11/2010 03:38 AM, Stefan Weil wrote: kvm_set_ioeventfd_mmio_long is only available with CONFIG_KVM. We should just disable ivshmem for non-KVM diff --git

[Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems

2010-08-11 Thread Cam Macdonell
--- kvm-stub.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/kvm-stub.c b/kvm-stub.c index 3378bd3..d45f9fa 100644 --- a/kvm-stub.c +++ b/kvm-stub.c @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr, uint16_t val, bool assign) { return

[Qemu-devel] [PATCH 2/2] Disable build of ivshmem on non-KVM systems

2010-08-11 Thread Cam Macdonell
--- Makefile.target |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.target b/Makefile.target index b791492..c8281e9 100644 --- a/Makefile.target +++ b/Makefile.target @@ -191,7 +191,7 @@ obj-y += rtl8139.o obj-y += e1000.o # Inter-VM PCI shared memory -obj-y

Re: [Qemu-devel] Unmaintained QEMU builds

2010-08-11 Thread Stefan Weil
Am 11.08.2010 18:34, schrieb Blue Swirl: On Wed, Aug 11, 2010 at 10:58 AM, Stefan Weil w...@mail.berlios.de wrote: Hi, since several months, QEMU for Windows (and mingw32 cross builds) no longer builds without error. Not true for mingw32, it was building fine here until the latest commit.

Re: [Qemu-devel] [PATCH v8 5/5] RESEND: Inter-VM shared memory PCI device

2010-08-11 Thread Stefan Weil
Am 11.08.2010 19:07, schrieb Paolo Bonzini: On 08/11/2010 11:49 AM, Cam Macdonell wrote: The win32 problems (missing mmap, maybe more) remain. Could you please fix them? Could that be accomplished with excluding it on Windows on the makefiles? Yes, just use obj-$(CONFIG_POSIX). Paolo

Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems

2010-08-11 Thread Stefan Weil
Am 11.08.2010 20:16, schrieb Cam Macdonell: --- kvm-stub.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/kvm-stub.c b/kvm-stub.c index 3378bd3..d45f9fa 100644 --- a/kvm-stub.c +++ b/kvm-stub.c @@ -136,3 +136,8 @@ int kvm_set_ioeventfd_pio_word(int fd, uint16_t addr,

Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems

2010-08-11 Thread Cam Macdonell
On Wed, Aug 11, 2010 at 2:28 PM, Stefan Weil w...@mail.berlios.de wrote: Am 11.08.2010 20:16, schrieb Cam Macdonell: --- kvm-stub.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/kvm-stub.c b/kvm-stub.c index 3378bd3..d45f9fa 100644 --- a/kvm-stub.c +++

Re: [Qemu-devel] Running the user emulation

2010-08-11 Thread Natalia Portillo
You can check how NetBSD does that. NetBSD is able to run executables from other UNIXes and POSIX-compatible systems, including, Linux, IRIX, Darwin. They do that with a series of syscall conversions and library substitutions. That should be portable to use Mac OS X as host instead of NetBSD,

Re: [Qemu-devel] Unmaintained QEMU builds

2010-08-11 Thread Blue Swirl
On Wed, Aug 11, 2010 at 6:18 PM, Stefan Weil w...@mail.berlios.de wrote: Am 11.08.2010 18:34, schrieb Blue Swirl: On Wed, Aug 11, 2010 at 10:58 AM, Stefan Weil w...@mail.berlios.de wrote: Hi, since several months, QEMU for Windows (and mingw32 cross builds) no longer builds without error.

Re: [Qemu-devel] Unmaintained QEMU builds

2010-08-11 Thread Blue Swirl
On Wed, Aug 11, 2010 at 6:51 PM, Blue Swirl blauwir...@gmail.com wrote: On Wed, Aug 11, 2010 at 6:18 PM, Stefan Weil w...@mail.berlios.de wrote: Am 11.08.2010 18:34, schrieb Blue Swirl: On Wed, Aug 11, 2010 at 10:58 AM, Stefan Weil w...@mail.berlios.de wrote: Hi, since several months,

Re: [Qemu-devel] Unmaintained QEMU builds

2010-08-11 Thread Stefan Weil
Am 11.08.2010 21:19, schrieb Blue Swirl: On Wed, Aug 11, 2010 at 6:51 PM, Blue Swirlblauwir...@gmail.com wrote: On Wed, Aug 11, 2010 at 6:18 PM, Stefan Weilw...@mail.berlios.de wrote: Am 11.08.2010 18:34, schrieb Blue Swirl: On Wed, Aug 11, 2010 at 10:58 AM, Stefan

[Qemu-devel] [PATCH] make -qmp stdio usable

2010-08-11 Thread Paolo Bonzini
Currently -qmp stdio (or the equivalent -mon/-chardev combination) sets up the terminal attributes even though it does not go through readline to actually do I/O. As a result, echo is disabled and you cannot see anything you type. This patch fixes it by adding a cooked option to the stdio

Re: [Qemu-devel] [PATCH 1/2] Add kvm_set_ioeventfd_mmio_long definition for non-KVM systems

2010-08-11 Thread Paolo Bonzini
On 08/11/2010 02:32 PM, Cam Macdonell wrote: On Wed, Aug 11, 2010 at 2:28 PM, Stefan Weilw...@mail.berlios.de wrote: Am 11.08.2010 20:16, schrieb Cam Macdonell: --- kvm-stub.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/kvm-stub.c b/kvm-stub.c index

[Qemu-devel] Re: Unmaintained QEMU builds

2010-08-11 Thread Paolo Bonzini
On 08/11/2010 03:37 PM, Stefan Weil wrote: With these changes, build succeeds with SDL. For example, qemu-system-sparc.exe can boot from a Sparc32 CD under Wine. Yes, that's a possible solution. You could also take these patches which I sent to qemu-devel: