Re: [Qemu-devel] [PATCH 1/4] Introduce strtosz() library function to convert a string to a byte count.

2010-10-13 Thread Jes Sorensen
On 10/12/10 17:52, Markus Armbruster wrote: Still not entirely happy, but maybe we can commit it as is, and fix it up later. No worries, I think this is the most serious review I have ever received for any piece of code, but you're finding valid points so it's good. If all of QEMU had been

[Qemu-devel] Re: Where's gpxe-eepro100-80862449.rom ?

2010-10-13 Thread Markus Armbruster
Stefan Weil w...@mail.berlios.de writes: Am 12.10.2010 14:41, schrieb Markus Armbruster: Commit db667a12 added a reference to ROM file gpxe-eepro100-80862449.rom, but no such file. Intentional? Yes. See http://lists.nongnu.org/archive/html/qemu-devel/2010-05/msg00418.html Citation from my

[Qemu-devel] Re: [PATCH] Suppress warning: zero-length gnu_printf format string

2010-10-13 Thread Markus Armbruster
Blue Swirl blauwir...@gmail.com writes: On Mon, Oct 11, 2010 at 12:52 PM, Markus Armbruster arm...@redhat.com wrote: Warns about this line in check-qjson.c:    QObject *obj = qobject_from_json(); The obvious fix (add -Wno-format-zero-length to gcc_flags) doesn't work, because -Wall switches

Re: [Qemu-devel] [PATCH 04/39] fix sparse support (?)

2010-10-13 Thread Paolo Bonzini
On 10/12/2010 09:02 PM, Blue Swirl wrote: On Tue, Oct 12, 2010 at 1:00 PM, Paolo Bonzinipbonz...@redhat.com wrote: I didn't test with sparse, but the old code using += before a variable was set was wrong. Sparse support should probably be ripped out or redone, but this at least keeps some

[Qemu-devel] [PATCH v7 0/4] Introduce strtosz and make use of it

2010-10-13 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This patch introduces cutils.c: strtosz() and gets rid of the multiple custom hacks for parsing byte sizes. In addition it adds supports for specifying human style sizes such as 1.5G. Last it eliminates the horrible abuse of a float to store the byte

[Qemu-devel] [PATCH 3/4] Switch migrate_set_speed() to take an 'o' argument rather than a float.

2010-10-13 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Clarify default value of MB in migration speed argument in monitor, if no suffix is specified. This differ from previous default of bytes, but is consistent with the rest of the places where we accept a size argument. Signed-off-by: Jes Sorensen

[Qemu-devel] [PATCH 2/4] Add support for 'o' octet (bytes) format as monitor parameter.

2010-10-13 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com Octet format relies on strtosz which supports K/k, M/m, G/g, T/t suffixes and unit support for humans, like 1.3G Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- monitor.c | 29 + 1 files changed, 29 insertions(+),

Re: [Qemu-devel] [PATCH 13/39] properly detect compiler in tests/Makefile

2010-10-13 Thread Paolo Bonzini
On 10/12/2010 09:04 PM, Blue Swirl wrote: diff --git a/tests/Makefile b/tests/Makefile index ff7f787..a789e2d 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -64,11 +64,21 @@ linux-test: linux-test.c $(CC) $(CFLAGS) $(LDFLAGS) -o $@ $ -lm # speed test +ifeq ($(shell uname -m),

[Qemu-devel] [PATCH 4/4] Remove obsolete 'f' double parameter type

2010-10-13 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com 'f' double is no longer used, and we should be using floating point variables to store byte sizes. Remove it. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- monitor.c | 18 +- 1 files changed, 1 insertions(+), 17 deletions(-)

Re: [Qemu-devel] [PATCH 07/39] do not pass bogus $(SRC_PATH) include paths to cc during configure

2010-10-13 Thread Paolo Bonzini
On 10/12/2010 09:09 PM, Blue Swirl wrote: QEMU_CFLAGS=-Wstrict-prototypes -Wredundant-decls $QEMU_CFLAGS QEMU_CFLAGS=-D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE $QEMU_CFLAGS QEMU_CFLAGS=-D_FORTIFY_SOURCE=2 $QEMU_CFLAGS Aren't the above also CPP flags? Yes, the difference

[Qemu-devel] [PATCH 1/4] Introduce strtosz() library function to convert a string to a byte count.

2010-10-13 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com strtosz() returns -1 on error. It now supports human unit formats in eg. 1.0G, with better error handling. The following suffixes are supported: B/b = bytes K/k = KB M/m = MB G/g = GB T/t = TB This patch changes -numa and -m input to use strtosz().

Re: [Qemu-devel] [PATCH 36/39] add autoconfy --with-arch= option, compatible with --sparc-cpu

2010-10-13 Thread Paolo Bonzini
On 10/12/2010 09:47 PM, Blue Swirl wrote: +arm*|i386|x86_64|mips*|hppa*|s390|s390x) + test -n $with_arch QEMU_CFLAGS=-march=${with_arch} $QEMU_CFLAGS + ;; + +sparc|sparc64) + test $with_arch = v8plusa with_arch=v8plus Why? Nevermind, I didn't really

Re: [Qemu-devel] qemu-kvm build issue on RHEL5.1

2010-10-13 Thread Hidetoshi Seto
(Add CC to k...@vger) (2010/10/12 10:52), Hao, Xudong wrote: Hi, Currently qemu-kvm build fail on RHEL5 with gcc 4.1.2, build can pass on Fedora11 with gcc 4.4.1, can anybody look on RHEL5 system? Gcc: 4.1.2 system: RHEL5.1 qemu-kvm: 85566812a4f8cae721fea0224e05a7e75c08c5dd ...

Re: [Qemu-devel] [PATCH 1/4] Introduce strtosz() library function to convert a string to a byte count.

2010-10-13 Thread Markus Armbruster
Jes Sorensen jes.soren...@redhat.com writes: On 10/12/10 17:52, Markus Armbruster wrote: [...] +c = *endptr++; +if (isspace(c) || c == '\0') { +c = 0; +} else if (!isspace(*endptr) *endptr != 0) { +goto fail; +} I'm not happy with this check. If the

[Qemu-devel] [PATCH v2] Introduce 9p commandline arguments sanity checks

2010-10-13 Thread Harsh Prateek Bora
This patch checks the validity of 9p related commandline arguments and throws error if the arguments are not appropriate. Signed-off-by: Harsh Prateek Bora ha...@linux.vnet.ibm.com --- v2: - added check in get_fsdev_fsentry() and indenatation fixes fsdev/qemu-fsdev.c | 48

[Qemu-devel] Re: [PATCH v2 2/7] cutils: Add bytes_to_str() to format byte values

2010-10-13 Thread Avi Kivity
On 10/08/2010 05:48 PM, Stefan Hajnoczi wrote: From: Anthony Liguorialigu...@us.ibm.com This common function converts byte counts to human-readable strings with proper units. Signed-off-by: Anthony Liguorialigu...@us.ibm.com Signed-off-by: Stefan Hajnoczistefa...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH v8 0/4] Introduce strtosz and make use of it

2010-10-13 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com This patch introduces cutils.c: strtosz() and gets rid of the multiple custom hacks for parsing byte sizes. In addition it adds supports for specifying human style sizes such as 1.5G. Last it eliminates the horrible abuse of a float to store the byte

Re: [Qemu-devel] [PATCH v2 2/7] cutils: Add bytes_to_str() to format byte values

2010-10-13 Thread Kevin Wolf
Am 13.10.2010 11:15, schrieb Markus Armbruster: Stefan Hajnoczi stefa...@linux.vnet.ibm.com writes: From: Anthony Liguori aligu...@us.ibm.com This common function converts byte counts to human-readable strings with proper units. Signed-off-by: Anthony Liguori aligu...@us.ibm.com

Re: [Qemu-devel] [RFT] qemu 0.13.0-rc3

2010-10-13 Thread Amit Shah
On (Mon) Oct 11 2010 [17:15:30], Anthony Liguori wrote: After suffering from a prolonged maintainer softlockup, I'm attempting to get 0.13.0 release process back on track. Anthony, can you pick up the patches in the thread: http://www.mail-archive.com/qemu-devel@nongnu.org/msg41478.html

Re: [Qemu-devel] [PATCH v2 2/7] cutils: Add bytes_to_str() to format byte values

2010-10-13 Thread Stefan Hajnoczi
On Wed, Oct 13, 2010 at 11:28:42AM +0200, Kevin Wolf wrote: Am 13.10.2010 11:15, schrieb Markus Armbruster: Stefan Hajnoczi stefa...@linux.vnet.ibm.com writes: From: Anthony Liguori aligu...@us.ibm.com This common function converts byte counts to human-readable strings with proper

[Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-13 Thread Stefan Hajnoczi
On Tue, Oct 12, 2010 at 11:16:17AM -0500, Anthony Liguori wrote: On 10/12/2010 10:59 AM, Stefan Hajnoczi wrote: On Tue, Oct 12, 2010 at 05:39:48PM +0200, Kevin Wolf wrote: Am 12.10.2010 17:22, schrieb Anthony Liguori: On 10/12/2010 10:08 AM, Kevin Wolf wrote: Otherwise we might destroy

Re: [Qemu-devel] [PATCH 0/2] usb-ccid device (v2)

2010-10-13 Thread Alon Levy
- Anthony Liguori anth...@codemonkey.ws wrote: On 10/12/2010 12:09 PM, Alon Levy wrote: The smart card is not being migrated. It is running on the client machine, which is not being migrated/shutdown (same as vncviewer isn't migrated). Ok, let's look at this compared to

[Qemu-devel] [Bug 658610] Re: Check whether images have write permissions

2010-10-13 Thread Thierry Carrez
** Package changed: kvm (Ubuntu) = qemu-kvm (Ubuntu) ** Changed in: qemu-kvm (Ubuntu) Importance: Undecided = Wishlist ** Changed in: qemu-kvm (Ubuntu) Status: New = Confirmed -- Check whether images have write permissions https://bugs.launchpad.net/bugs/658610 You received this bug

[Qemu-devel] Re: qdev: Some ISA devices don't handle second instantiation gracefully (was: isa-applesmc doesn't handle second instantiation gracefully)

2010-10-13 Thread Richard W.M. Jones
On Tue, Oct 12, 2010 at 03:00:13PM +0200, Markus Armbruster wrote: Markus Armbruster arm...@redhat.com writes: When I try -device isa-applesmc -device isa-applesmc, I get WARNING: Using AppleSMC with invalid key qemu: hardware error: register_ioport_read: invalid opaque

Re: [Qemu-devel] [PATCH v7 0/4] Introduce strtosz and make use of it

2010-10-13 Thread Markus Armbruster
jes.soren...@redhat.com writes: From: Jes Sorensen jes.soren...@redhat.com This patch introduces cutils.c: strtosz() and gets rid of the multiple custom hacks for parsing byte sizes. In addition it adds supports for specifying human style sizes such as 1.5G. Last it eliminates the horrible

[Qemu-devel] [PATCH 1/4] Introduce strtosz() library function to convert a string to a byte count.

2010-10-13 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com strtosz() returns -1 on error. It now supports human unit formats in eg. 1.0G, with better error handling. The following suffixes are supported: B/b = bytes K/k = KB M/m = MB G/g = GB T/t = TB This patch changes -numa and -m input to use strtosz().

Re: [Qemu-devel] [PATCH 1/4] Introduce strtosz() library function to convert a string to a byte count.

2010-10-13 Thread Markus Armbruster
jes.soren...@redhat.com writes: From: Jes Sorensen jes.soren...@redhat.com strtosz() returns -1 on error. It now supports human unit formats in eg. 1.0G, with better error handling. The following suffixes are supported: B/b = bytes K/k = KB M/m = MB G/g = GB T/t = TB This patch

RE: [Qemu-devel] qemu-kvm build issue on RHEL5.1

2010-10-13 Thread Hao, Xudong
Hidetoshi Seto wrote: (Add CC to k...@vger) (2010/10/12 10:52), Hao, Xudong wrote: Hi, Currently qemu-kvm build fail on RHEL5 with gcc 4.1.2, build can pass on Fedora11 with gcc 4.4.1, can anybody look on RHEL5 system? Gcc: 4.1.2 system: RHEL5.1 qemu-kvm:

Re: [Qemu-devel] [PATCH] ceph/rbd block driver for qemu-kvm (v6)

2010-10-13 Thread Stefan Hajnoczi
On Wed, Oct 13, 2010 at 12:18 AM, Christian Brunner c...@muc.de wrote: +static int rbd_set_snapc(rados_pool_t pool, const char *snap, RbdHeader1 *header) +{ +    uint32_t snap_count = header-snap_count; +    rados_snap_t *snaps = NULL; +    rados_snap_t seq; +    uint32_t i; +    uint64_t

Re: [Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-13 Thread Kevin Wolf
Am 13.10.2010 14:13, schrieb Stefan Hajnoczi: On Tue, Oct 12, 2010 at 11:16:17AM -0500, Anthony Liguori wrote: On 10/12/2010 10:59 AM, Stefan Hajnoczi wrote: On Tue, Oct 12, 2010 at 05:39:48PM +0200, Kevin Wolf wrote: Am 12.10.2010 17:22, schrieb Anthony Liguori: On 10/12/2010 10:08 AM, Kevin

Re: [Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-13 Thread Anthony Liguori
On 10/13/2010 08:07 AM, Kevin Wolf wrote: Am 13.10.2010 14:13, schrieb Stefan Hajnoczi: We can avoid it when a backing image is not used. Your idea to check for zeroes in the backing image is neat too, it may well reduce the common case even for backing images. The additional

Re: [Qemu-devel] [PATCH 1/4] Introduce strtosz() library function to convert a string to a byte count.

2010-10-13 Thread Markus Armbruster
jes.soren...@redhat.com writes: From: Jes Sorensen jes.soren...@redhat.com strtosz() returns -1 on error. It now supports human unit formats in eg. 1.0G, with better error handling. The following suffixes are supported: B/b = bytes K/k = KB M/m = MB G/g = GB T/t = TB This patch

Re: [Qemu-devel] [PATCH] monitor: properly handle invalid fd/vhostfd from command line

2010-10-13 Thread Luiz Capitulino
On Tue, 12 Oct 2010 14:32:25 +0800 jason wang jasow...@redhat.com wrote: On 10/09/2010 01:40 AM, Luiz Capitulino wrote: On Tue, 28 Sep 2010 16:57:44 +0200 Michael S. Tsirkinm...@redhat.com wrote: On Tue, Sep 28, 2010 at 11:53:43AM -0300, Luiz Capitulino wrote: On Mon, 27

[Qemu-devel] Re: [PATCH v2 5/7] qed: Table, L2 cache, and cluster functions

2010-10-13 Thread Stefan Hajnoczi
On Tue, Oct 12, 2010 at 04:44:34PM +0200, Kevin Wolf wrote: Am 08.10.2010 17:48, schrieb Stefan Hajnoczi: diff --git a/block/qed-cluster.c b/block/qed-cluster.c new file mode 100644 index 000..af65e5a --- /dev/null +++ b/block/qed-cluster.c @@ -0,0 +1,145 @@ +/* + * QEMU

Re: [Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-13 Thread Avi Kivity
On 10/13/2010 03:24 PM, Anthony Liguori wrote: On 10/13/2010 08:07 AM, Kevin Wolf wrote: Am 13.10.2010 14:13, schrieb Stefan Hajnoczi: We can avoid it when a backing image is not used. Your idea to check for zeroes in the backing image is neat too, it may well reduce the common case even for

Re: [Qemu-devel] [PATCH] qemu-nbd: add statistics

2010-10-13 Thread Kevin Wolf
Hi Laurent, Am 05.10.2010 21:15, schrieb Laurent Vivier: During qemu-nbd run, I/O statistics can be now displayed using the option '-a N' where N is the number of seconds between each collect. The statistics diplayed are : I/O per second, kilobytes read per second, kilobytes written per

Re: [Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-13 Thread Anthony Liguori
That means we can maintain the physical size without introducing additional fsync()s in the allocation path. Since we're already writing out the header anyway, the write operation is basically free too. I don't see how it is free. It's an extra write. The good news is that it's

Re: [Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-13 Thread Avi Kivity
On 10/13/2010 04:11 PM, Anthony Liguori wrote: Why would you ever update the header, apart from relocating L1 for some reason? To update the L1/L2 tables clean bit. That's what prevents a check in the normal case where you have a clean shutdown. I see - so you wouldn't update it every

Re: [Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-13 Thread Stefan Hajnoczi
On Wed, Oct 13, 2010 at 03:50:00PM +0200, Avi Kivity wrote: On 10/13/2010 03:24 PM, Anthony Liguori wrote: On 10/13/2010 08:07 AM, Kevin Wolf wrote: Am 13.10.2010 14:13, schrieb Stefan Hajnoczi: We can avoid it when a backing image is not used. Your idea to check for zeroes in the backing

Re: [Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-13 Thread Avi Kivity
On 10/13/2010 04:07 PM, Stefan Hajnoczi wrote: On Wed, Oct 13, 2010 at 03:50:00PM +0200, Avi Kivity wrote: On 10/13/2010 03:24 PM, Anthony Liguori wrote: On 10/13/2010 08:07 AM, Kevin Wolf wrote: Am 13.10.2010 14:13, schrieb Stefan Hajnoczi: We can avoid it when a backing image is not

Re: [Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-13 Thread Anthony Liguori
On 10/13/2010 08:50 AM, Avi Kivity wrote: On 10/13/2010 03:24 PM, Anthony Liguori wrote: On 10/13/2010 08:07 AM, Kevin Wolf wrote: Am 13.10.2010 14:13, schrieb Stefan Hajnoczi: We can avoid it when a backing image is not used. Your idea to check for zeroes in the backing image is neat too,

Re: [Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-13 Thread Anthony Liguori
On 10/13/2010 09:07 AM, Stefan Hajnoczi wrote: That means we can maintain the physical size without introducing additional fsync()s in the allocation path. Since we're already writing out the header anyway, the write operation is basically free too. I don't see how it is free. It's

Re: [Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-13 Thread Anthony Liguori
On 10/13/2010 09:16 AM, Avi Kivity wrote: On 10/13/2010 04:11 PM, Anthony Liguori wrote: Why would you ever update the header, apart from relocating L1 for some reason? To update the L1/L2 tables clean bit. That's what prevents a check in the normal case where you have a clean shutdown.

Re: [Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-13 Thread Avi Kivity
On 10/13/2010 04:53 PM, Anthony Liguori wrote: On 10/13/2010 09:16 AM, Avi Kivity wrote: On 10/13/2010 04:11 PM, Anthony Liguori wrote: Why would you ever update the header, apart from relocating L1 for some reason? To update the L1/L2 tables clean bit. That's what prevents a check in

[Qemu-devel] v5 [PATCH 0/3] qemu: Threadlets: A generic task offloading framework

2010-10-13 Thread Arun R Bharadwaj
Hi, This is the v5 of the patch-series to have a generic asynchronous task offloading framework (called threadlets) within qemu. V4 can be found here: http://www.mail-archive.com/qemu-devel@nongnu.org/msg36157.html Change from v4: * The earlier code was hitting a null pointer dereference error

[Qemu-devel] [PATCH 1/3] Introduce threadlets

2010-10-13 Thread Arun R Bharadwaj
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This patch creates a generic asynchronous-task-offloading infrastructure named threadlets. The core idea has been borrowed from the threading framework that is being used by paio. The reason for creating this generic infrastructure is so

[Qemu-devel] [PATCH 2/3] Make paio subsystem use threadlets

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch makes the paio subsystem use the threadlet framework thereby decoupling asynchronous threading framework portion out of posix-aio-compat.c The patch has been tested with fstress. Signed-off-by: Gautham R Shenoy e...@in.ibm.com Signed-off-by:

[Qemu-devel] [PATCH 3/3] Add helper functions for virtio-9p to use threadlets

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com Add helper functions to enable virtio-9p make use of the threadlets infrastructure for offloading blocking tasks such as making posix calls on to the helper threads and handle the post_posix_operations() from the context of the iothread. This frees the vcpu

Re: [Qemu-devel] Re: [PATCH v2 6/7] qed: Read/write support

2010-10-13 Thread Anthony Liguori
On 10/13/2010 10:08 AM, Avi Kivity wrote: On 10/13/2010 04:53 PM, Anthony Liguori wrote: On 10/13/2010 09:16 AM, Avi Kivity wrote: On 10/13/2010 04:11 PM, Anthony Liguori wrote: Why would you ever update the header, apart from relocating L1 for some reason? To update the L1/L2 tables

Re: [Qemu-devel] [PATCH] [V2] Copy snapshots out of QCOW2 disk

2010-10-13 Thread Kevin Wolf
Am 22.09.2010 04:58, schrieb disheng...@gmail.com: From: edison edi...@cloud.com In order to backup snapshots, created from QCOW2 iamge, we want to copy snapshots out of QCOW2 disk to a seperate storage. The following patch adds a new option in qemu-img: qemu-img convert -f qcow2 -O qcow2

[Qemu-devel] [PATCH 6/6] This patch converts v9fs_walk() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_walk onto the helper threads belonging to the threadlets infrastructure. The handling of the v9fs_post_*walk* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [PATCH 2/6] This patch converts v9fs_wstat() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_wstat onto the helper threads belonging to the threadlets infrastructure.The handling of the v9fs_post_*wstat* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [PATCH 3/6] This patch converts v9fs_read() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_read onto the helper threads belonging to the threadlets infrastructure. The handling of the v9fs_post_*read* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [PATCH 4/6] This patch converts v9fs_write() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_write onto the helper threads belonging to the threadlets infrastructure. The handling of the v9fs_post_*write* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [PATCH 5/6] This patch converts v9fs_open() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_open onto the helper threads belonging to the threadlets infrastructure. The handling of the v9fs_post_*open* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [PATCH 0/6] First threading model.

2010-10-13 Thread Arun R Bharadwaj
Hi, The threadlets framework in qemu is being discussed here: http://www.mail-archive.com/qemu-devel@nongnu.org/msg36157.html This patchset implements the First threading model in Qemu using the above infrastructure. Following are the features of the first threading model: * The VCPU thread

[Qemu-devel] [PATCH 1/6] This patch converts v9fs_stat() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com Every call to v9fs_stat() is processed in the context of the vcpu thread before offloading the actual stat operation onto an async-thread. The post operation is handled in the context of the io-thread which in turn does the complete() operation for this

Re: [Qemu-devel] [PATCH 2/4] target-arm: Fix mixup in decoding of saturating add and sub

2010-10-13 Thread Peter Maydell
On 11 October 2010 09:18, Johan Bengtsson teofrast...@gmail.com wrote: The thumb2 decoder contained a mixup between the bit controlling doubling and the bit controlling if the operation was an add or a sub. Signed-off-by: Johan Bengtsson teofrast...@gmail.com I've confirmed against the ARM

Re: [Qemu-devel] [PATCH 1/4] target-arm: Add support for PKHxx in thumb2

2010-10-13 Thread Peter Maydell
On 11 October 2010 09:18, Johan Bengtsson teofrast...@gmail.com wrote: The PKHxx instructions were not recognized by the thumb2 decoder. The solution provided in this changeset is identical to the arm-mode implementation. Signed-off-by: Johan Bengtsson teofrast...@gmail.com I've checked

[Qemu-devel] [PATCH 0/3]: Threadlets: A generic task offloading framework

2010-10-13 Thread Arun R Bharadwaj
Hi, This is the v6 of the patch-series to have a generic asynchronous task offloading framework (called threadlets) within qemu. V5 can be found here: http://www.mail-archive.com/qemu-devel@nongnu.org/msg36678.html Change from v5: * The earlier code was hitting a null pointer dereference error

[Qemu-devel] [PATCH 1/3]: Introduce threadlets.

2010-10-13 Thread Arun R Bharadwaj
* Arun R Bharadwaj a...@linux.vnet.ibm.com [2010-10-13 22:14:39]: commit 1fb4801768722016cd6ec9bbf1271c69b37df2a2 Author: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Date: Tue Oct 12 14:06:10 2010 +0530 Introduce threadlets This patch creates a generic

[Qemu-devel] [PATCH 2/3]: Make paio subsystem use threadlets

2010-10-13 Thread Arun R Bharadwaj
* Arun R Bharadwaj a...@linux.vnet.ibm.com [2010-10-13 22:14:39]: Make paio subsystem use threadlets From: Gautham R Shenoy e...@in.ibm.com This patch makes the paio subsystem use the threadlet framework thereby decoupling asynchronous threading framework portion out of posix-aio-compat.c The

[Qemu-devel] [PATCH 3/3]: Add helper functions for virtio-9p to use threadlets

2010-10-13 Thread Arun R Bharadwaj
* Arun R Bharadwaj a...@linux.vnet.ibm.com [2010-10-13 22:14:39]: commit 1da2167c0c68bf24a841affa1bf6d2510cb675f2 Author: Gautham R Shenoy e...@in.ibm.com Date: Wed Oct 13 15:09:20 2010 +0530 Add helper functions for virtio-9p to use threadlets Add helper functions to enable

[Qemu-devel] [RFC PATCH 0/6] First Threading Model

2010-10-13 Thread Arun R Bharadwaj
Hi, This patchset implements first threading model by making use of the threadlets infrastructure being discussed here: http://www.mail-archive.com/qemu-devel@nongnu.org/msg36678.html Here are some of the performance results comparing between the original code and threading model code:

[Qemu-devel] [PATCH 1/6] This patch converts v9fs_stat() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com Every call to v9fs_stat() is processed in the context of the vcpu thread before offloading the actual stat operation onto an async-thread. The post operation is handled in the context of the io-thread which in turn does the complete() operation for this

[Qemu-devel] [PATCH 3/6] This patch converts v9fs_read() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_read onto the helper threads belonging to the threadlets infrastructure. The handling of the v9fs_post_*read* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [PATCH 6/6] This patch converts v9fs_walk() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_walk onto the helper threads belonging to the threadlets infrastructure. The handling of the v9fs_post_*walk* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [PATCH 5/6] This patch converts v9fs_open() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_open onto the helper threads belonging to the threadlets infrastructure. The handling of the v9fs_post_*open* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [PATCH 2/6] This patch converts v9fs_wstat() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_wstat onto the helper threads belonging to the threadlets infrastructure.The handling of the v9fs_post_*wstat* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [PATCH 4/6] This patch converts v9fs_write() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_write onto the helper threads belonging to the threadlets infrastructure. The handling of the v9fs_post_*write* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [Bug 660060] [NEW] virtio block read errors

2010-10-13 Thread Lionel Bouton
Public bug reported: Context : - Gentoo Linux distribution on host and guests. - qemu-kvm-0.12.5-r1 - 2.6.34-gentoo-r11 host kernel - 2.6.29-gentoo-r5 guest kernels - VM boots from and uses a single virtio block device. On the old kvm bugtracker there was a discussion about a bug with virtio

[Qemu-devel] [RFC PATCH 0/6] First threading model

2010-10-13 Thread Arun R Bharadwaj
This patchset implements first threading model by making use of the threadlets infrastructure being discussed here: http://www.mail-archive.com/qemu-devel@nongnu.org/msg36678.html Here are some of the performance results comparing between the original code and threading model code:

[Qemu-devel] [PATCH 1/6] This patch converts v9fs_stat() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com Every call to v9fs_stat() is processed in the context of the vcpu thread before offloading the actual stat operation onto an async-thread. The post operation is handled in the context of the io-thread which in turn does the complete() operation for this

[Qemu-devel] [PATCH 2/6] This patch converts v9fs_wstat() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_wstat onto the helper threads belonging to the threadlets infrastructure.The handling of the v9fs_post_*wstat* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [PATCH 4/6] This patch converts v9fs_write() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_write onto the helper threads belonging to the threadlets infrastructure. The handling of the v9fs_post_*write* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [PATCH 3/6] This patch converts v9fs_read() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_read onto the helper threads belonging to the threadlets infrastructure. The handling of the v9fs_post_*read* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [PATCH 5/6] This patch converts v9fs_open() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_open onto the helper threads belonging to the threadlets infrastructure. The handling of the v9fs_post_*open* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [PATCH 6/6] This patch converts v9fs_walk() to make use of the threadlets infrastructure.

2010-10-13 Thread Arun R Bharadwaj
From: Gautham R Shenoy e...@in.ibm.com This patch offloads all the blocking calls invoked for v9fs_walk onto the helper threads belonging to the threadlets infrastructure. The handling of the v9fs_post_*walk* calls is done from the io-thread context. Signed-off-by: Gautham R Shenoy

[Qemu-devel] [PATCH 1/2] Remove special handling of system include files (no longer needed)

2010-10-13 Thread Stefan Weil
The formerly used dyngen code did not work with system include files like stdio.h. Tests with Linux, OSX and Win32 show that this restriction is no longer needed. So we hopefully can remove that special piece of code. This results in cleaner code and allows better use of the new GCC_FMT_ATTR

[Qemu-devel] [PATCH 2/2] Replace remaining gcc format attributes by macro GCC_FMT_ATTR (format checking)

2010-10-13 Thread Stefan Weil
Replace the remaining format attribute printf by macro GCC_FMT_ATTR which uses gnu_printf (if supported). v2 * Removal of dyngen specific code is now done in a separate patch. * Handle attribute in new ui/spice-display.c, too. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Stefan Weil

Re: [Qemu-devel] [PATCH 13/39] properly detect compiler in tests/Makefile

2010-10-13 Thread Blue Swirl
On Wed, Oct 13, 2010 at 7:19 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 10/12/2010 09:04 PM, Blue Swirl wrote: diff --git a/tests/Makefile b/tests/Makefile index ff7f787..a789e2d 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -64,11 +64,21 @@ linux-test: linux-test.c        $(CC)

[Qemu-devel] Re: [PATCH] Suppress warning: zero-length gnu_printf format string

2010-10-13 Thread Blue Swirl
On Wed, Oct 13, 2010 at 7:19 AM, Markus Armbruster arm...@redhat.com wrote: Blue Swirl blauwir...@gmail.com writes: On Mon, Oct 11, 2010 at 12:52 PM, Markus Armbruster arm...@redhat.com wrote: Warns about this line in check-qjson.c:    QObject *obj = qobject_from_json(); The obvious fix

[Qemu-devel] Re: [PATCH] block: Use GCC_FMT_ATTR and fix a format error

2010-10-13 Thread Stefan Weil
Am 25.09.2010 10:01, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 9:23 PM, Stefan Weilw...@mail.berlios.de wrote: Am 23.09.2010 22:24, schrieb Blue Swirl: On Thu, Sep 23, 2010 at 7:11 PM, Stefan Weilw...@mail.berlios.de wrote: Am 23.09.2010 21:03, schrieb Stefan Weil:

[Qemu-devel] request information on qemu console functionality

2010-10-13 Thread Gabi Voiculescu
Hi. I am using a version of qemu from qemu-meego, git://gitorious.org/qemu-maemo/qemu.git, compiled under ubuntu 9.04. The questions I want to ask is however more general and I think apply to all version of qemu. Question 1 --- When qemu is built with SDL support, does it have a fully

Re: [Qemu-devel] Re: [PATCH] tcg: Fix compiler error (comparison of unsigned expression)

2010-10-13 Thread Stefan Weil
Am 08.10.2010 23:43, schrieb Stefan Weil: Am 08.10.2010 18:57, schrieb Hollis Blanchard: On Fri, Oct 8, 2010 at 1:32 AM, Stefan Weil w...@mail.berlios.de wrote: When qemu is configured with --enable-debug-tcg, gcc throws this warning (or error with -Werror): tcg/tcg.c:1030: error: comparison

Re: [Qemu-devel] qemu-kvm build issue on RHEL5.1

2010-10-13 Thread Blue Swirl
On Wed, Oct 13, 2010 at 8:00 AM, Hidetoshi Seto seto.hideto...@jp.fujitsu.com wrote: (Add CC to k...@vger) (2010/10/12 10:52), Hao, Xudong wrote: Hi, Currently qemu-kvm build fail on RHEL5 with gcc 4.1.2, build can pass on Fedora11 with gcc 4.4.1, can anybody look on RHEL5 system? Gcc:

Re: [Qemu-devel] request information on qemu console functionality

2010-10-13 Thread Blue Swirl
On Wed, Oct 13, 2010 at 7:07 PM, Gabi Voiculescu boy3d...@yahoo.com wrote: Hi. I am using a version of qemu from qemu-meego, git://gitorious.org/qemu-maemo/qemu.git, compiled under ubuntu 9.04. The questions I want to ask is however more general and I think apply to all version of qemu.

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-13 Thread H. Peter Anvin
On 10/12/2010 12:06 PM, Gleb Natapov wrote: This is true to some extent -- there is some standard content, and some further can be described via ACPI tables. However, my point was mostly that it is an existing model for nonvolatile storage which also works on hardware (and is vastly simpler

Re: [Qemu-devel] Re: [PATCH] tcg: Fix compiler error (comparison of unsigned expression)

2010-10-13 Thread Hollis Blanchard
On Wed, Oct 13, 2010 at 11:58 AM, Stefan Weil w...@mail.berlios.de wrote: Hollis, do you still see problems with my patch? Or can it be committed? I have no objection; I was just anticipating Blue's objection when I commented previously. It's just a style question really... -Hollis

[Qemu-devel] [PATCH] (master, stable-0.13) zaurus: workaround for io base address rounded down

2010-10-13 Thread Juergen Lock
The 2nd scoop's base address (0x08800040) now gets rounded down to start of page which causes its io read/write callbacks to be passed addresses 0x40 higher than the code expects: (as witnessed by Bad register offset messages and failure to attach the internal CF disk aka microdrive at least.)

Re: [Qemu-devel] request information on qemu console functionality

2010-10-13 Thread Stefan Weil
Am 13.10.2010 21:07, schrieb Gabi Voiculescu: Hi. I am using a version of qemu from qemu-meego, git://gitorious.org/qemu-maemo/qemu.git, compiled under ubuntu 9.04. The questions I want to ask is however more general and I think apply to all version of qemu. Question 1 --- When

Re: [Qemu-devel] [RFT] qemu 0.13.0-rc3

2010-10-13 Thread Juergen Lock
On Wed, Oct 13, 2010 at 05:28:37AM +0200, Juergen Lock wrote: On Tue, Oct 12, 2010 at 05:00:34PM -0500, Anthony Liguori wrote: On 10/12/2010 04:34 PM, Juergen Lock wrote: In article4cb38c82.1090...@linux.vnet.ibm.com you write: After suffering from a prolonged maintainer

Re: [Qemu-devel] Re: [PATCH] tcg: Fix compiler error (comparison of unsigned expression)

2010-10-13 Thread Blue Swirl
On Wed, Oct 13, 2010 at 7:22 PM, Hollis Blanchard hol...@penguinppc.org wrote: On Wed, Oct 13, 2010 at 11:58 AM, Stefan Weil w...@mail.berlios.de wrote: Hollis, do you still see problems with my patch? Or can it be committed? I have no objection; I was just anticipating Blue's objection when

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-13 Thread H. Peter Anvin
On 10/13/2010 12:17 PM, H. Peter Anvin wrote: The ACPI specification recognizes three interfaces as standard: PC/AT (64 bytes, even though 128 bytes is available on a lot of platforms), PIIX4 (256 bytes), and Dallas Semiconductor (256 bytes or more). The interface for the latter isn't well

Re: [Qemu-devel] [PATCH] (master, stable-0.13) zaurus: workaround for io base address rounded down

2010-10-13 Thread Blue Swirl
On Wed, Oct 13, 2010 at 7:12 PM, Juergen Lock qem...@jelal.kn-bremen.de wrote: The 2nd scoop's base address (0x08800040) now gets rounded down to start of page which causes its io read/write callbacks to be passed addresses 0x40 higher than the code expects:  (as witnessed by Bad register

Re: [SeaBIOS] [Qemu-devel] [RFC] Passing boot order from qemu to seabios

2010-10-13 Thread H. Peter Anvin
On 10/13/2010 01:00 PM, H. Peter Anvin wrote: On 10/13/2010 12:17 PM, H. Peter Anvin wrote: The ACPI specification recognizes three interfaces as standard: PC/AT (64 bytes, even though 128 bytes is available on a lot of platforms), PIIX4 (256 bytes), and Dallas Semiconductor (256 bytes or

Re: [Qemu-devel] [PATCH] (master, stable-0.13) zaurus: workaround for io base address rounded down

2010-10-13 Thread Juergen Lock
On Wed, Oct 13, 2010 at 07:45:19PM +, Blue Swirl wrote: On Wed, Oct 13, 2010 at 7:12 PM, Juergen Lock qem...@jelal.kn-bremen.de wrote: The 2nd scoop's base address (0x08800040) now gets rounded down to start of page which causes its io read/write callbacks to be passed addresses 0x40

[Qemu-devel] Problems with saving a vm in the qemu monitor

2010-10-13 Thread Keith Stevens
Hi all, I'm a teaching assistant for an operating systems class and we've been using an ancient version of qemu to do some of our lab assignments (v0.9.something). We've been relying on a qcow2 qemu image that we created a while back. Recently, I've been trying to get the labs working with the

[Qemu-devel] Hitting 29 NIC limit (was Re: 8 NIC limit - patch - places limit at 32)

2010-10-13 Thread Anjali Kulkarni
Hi, Using the legacy way of starting up NICs, I am hitting a limitation after 29 NICs ie no more than 29 are detected (that's because of the 32 PCI slot limit on a single bus- 3 are already taken up) I had initially increased the MAX_NICS to 48, just on my tree, to get to more, but ofcource that

[Qemu-devel] Hitting 29 NIC limit

2010-10-13 Thread Anjali Kulkarni
Hi, Using the legacy way of starting up NICs, I am hitting a limitation after 29 NICs ie no more than 29 are detected (that's because of the 32 PCI slot limit on a single bus- 3 are already taken up) I had initially increased the MAX_NICS to 48, just on my tree, to get to more, but ofcource

  1   2   >