[Qemu-devel] Re: [PATCH v5] virtio-9p: fix build on !CONFIG_UTIMENSAT

2010-11-24 Thread Jes Sorensen
On 11/24/10 03:38, Hidetoshi Seto wrote: This patch introduce a fallback mechanism for old systems that do not support utimensat(). This fix build failure with following warnings: hw/virtio-9p-local.c: In function 'local_utimensat': hw/virtio-9p-local.c:479: warning: implicit declaration of

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-11-24 Thread Avi Kivity
On 11/23/2010 06:49 PM, Anthony Liguori wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them to respond to these signals (which cannot be trapped), use SIGUSR1 to approximate the behavior of SIGSTOP/SIGCONT. The purpose of this is to implement CPU hard

[Qemu-devel] [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion

2010-11-24 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a handful of bugfixes for scsi-generic that where added into: commit a4194b3f79a85e111f000788ddec05d465748851 Author: Hannes Reinecke h...@suse.de Date: Mon Nov 22 15:39:33 2010 -0800 scsi: Use 'SCSIRequest' directly this

[Qemu-devel] [PATCH 1/5] block: Add top level BSG support

2010-11-24 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds top level BSG support to QEMU-KVM block and adds the BDS_* prefixed defines for SG_IO and BSG. It adds the BDS_SCSI_GENERIC and BDS_BSG assignments in block/raw-posix.c:hdev_open() using S_ISCHR() and major(st.st_rdev) in order to

[Qemu-devel] [PATCH 2/5] block: Add BSG qemu_open() in block/raw.c:raw_open()

2010-11-24 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a BSG specific qemu_open() call in block/raw.c:raw_open() that saves the opened file descriptor for BSG AIO into BlockDriverState-fd. It also adds the reverse close() call to block/raw.c:raw_close() Signed-off-by: Nicholas A.

[Qemu-devel] [PATCH 3/5] block: Add paio_submit_len() non sector sized AIO

2010-11-24 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch adds posix-aio-compat.c:paio_submit_len(), which is a identical to paio_submit() expect that in expected nb_len instead of nb_sectors (* 512) so that it can be used by BSG AIO for write()/read() of struct sg_io_v4. Signed-off-by: Nicholas

[Qemu-devel] [PATCH 0/5]: Add hw/scsi-bsg.c backend driver

2010-11-24 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Quick resend with proper subject Greetings QEMU SCSI / BLOCK folks, This series adds rebased support for the hw/scsi-bsg.c backstore for scsi-bus compatible HBA emulation in QEMU-KVM on Linux hosts supporting the BSG driver against current mainline

[Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion

2010-11-24 Thread Hannes Reinecke
On 11/24/2010 09:18 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a handful of bugfixes for scsi-generic that where added into: commit a4194b3f79a85e111f000788ddec05d465748851 Author: Hannes Reinecke h...@suse.de Date: Mon Nov 22

[Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion

2010-11-24 Thread Nicholas A. Bellinger
On Wed, 2010-11-24 at 09:57 +0100, Hannes Reinecke wrote: On 11/24/2010 09:18 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a handful of bugfixes for scsi-generic that where added into: commit a4194b3f79a85e111f000788ddec05d465748851

[Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion

2010-11-24 Thread Kevin Wolf
Am 24.11.2010 09:57, schrieb Hannes Reinecke: On 11/24/2010 09:18 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a handful of bugfixes for scsi-generic that where added into: commit a4194b3f79a85e111f000788ddec05d465748851 Author: Hannes

[Qemu-devel] [PATCH 0/5]

2010-11-24 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org Greetings QEMU SCSI / BLOCK folks, This series adds rebased support for the hw/scsi-bsg.c backstore for scsi-bus compatible HBA emulation in QEMU-KVM on Linux hosts supporting the BSG driver against current mainline qemu-kvm.git/master code. This

[Qemu-devel] Re: [PATCH 5/5] scsi-bsg: Add initial support for BSG based SCSIDeviceInfo

2010-11-24 Thread Paolo Bonzini
On 11/24/2010 09:40 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellingern...@linux-iscsi.org This patch adds initial support for using the Linux BSG interface with write/read vectored AIO as a QEMU backstore (SCSIDeviceInfo) with hw/scsi-bus.c compatible HBA emulation. So far it has

[Qemu-devel] Re: [PATCH 5/5] scsi-bsg: Add initial support for BSG based SCSIDeviceInfo

2010-11-24 Thread Nicholas A. Bellinger
On Wed, 2010-11-24 at 10:07 +0100, Paolo Bonzini wrote: On 11/24/2010 09:40 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellingern...@linux-iscsi.org This patch adds initial support for using the Linux BSG interface with write/read vectored AIO as a QEMU backstore (SCSIDeviceInfo)

[Qemu-devel] Re: [PATCH 0/5]: Add hw/scsi-bsg.c backend driver

2010-11-24 Thread Kevin Wolf
Am 24.11.2010 09:44, schrieb Nicholas A. Bellinger: From: Nicholas Bellinger n...@linux-iscsi.org Quick resend with proper subject Nicholas and Hannes, can both of you please make sure to use proper email threads for your patch series? On a list with some traffic, like qemu-devel, it's really

[Qemu-devel] Re: [PATCH] stop the iteration when too many pages is transferred

2010-11-24 Thread Michael S. Tsirkin
On Fri, Nov 19, 2010 at 08:23:55PM -0600, Anthony Liguori wrote: On 11/17/2010 08:32 PM, Wen Congyang wrote: When the total sent page size is larger than max_factor times of the size of guest OS's memory, stop the iteration. The default value of max_factor is 3. This is similar to

[Qemu-devel] Re: [PATCH 0/5]: Add hw/scsi-bsg.c backend driver

2010-11-24 Thread Boaz Harrosh
On 11/24/2010 10:44 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Quick resend with proper subject Greetings QEMU SCSI / BLOCK folks, This series adds rebased support for the hw/scsi-bsg.c backstore for scsi-bus compatible HBA emulation in QEMU-KVM on

Re: [Qemu-devel] [PATCH] Megasas HBA emulation and SCSI update v.2

2010-11-24 Thread Nicholas A. Bellinger
On Mon, 2010-11-22 at 11:34 +0100, Hannes Reinecke wrote: On 11/22/2010 11:15 AM, Hannes Reinecke wrote: The is the second version of the megasas patchset; changes are: v1 - v2: - Include suggestions (and acked-by) from Christoph Hellwig - Updated patch description as requested by Gerd

[Qemu-devel] Re: [PATCH 0/5]: Add hw/scsi-bsg.c backend driver

2010-11-24 Thread Nicholas A. Bellinger
On Wed, 2010-11-24 at 11:31 +0200, Boaz Harrosh wrote: On 11/24/2010 10:44 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org Quick resend with proper subject Greetings QEMU SCSI / BLOCK folks, This series adds rebased support for the hw/scsi-bsg.c

[Qemu-devel] Re: [PATCHv6 00/16] boot order specification

2010-11-24 Thread Gleb Natapov
On Tue, Nov 23, 2010 at 08:19:07PM -0500, Kevin O'Connor wrote: Hi Gleb, On Tue, Nov 23, 2010 at 05:31:41PM +0200, Gleb Natapov wrote: Anthony, Blue No comments on this patch series for almost a week. Can it be applied? My apologies - I haven't had time to review. On Wed, Nov 17,

[Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion

2010-11-24 Thread Hannes Reinecke
On 11/24/2010 10:04 AM, Kevin Wolf wrote: Am 24.11.2010 09:57, schrieb Hannes Reinecke: On 11/24/2010 09:18 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a handful of bugfixes for scsi-generic that where added into: commit

Re: [Qemu-devel] Re: KVM call agenda for Nov 23

2010-11-24 Thread Kevin Wolf
Am 23.11.2010 15:53, schrieb Stefan Hajnoczi: On Tue, Nov 23, 2010 at 2:37 PM, Kevin Wolf kw...@redhat.com wrote: Am 22.11.2010 14:55, schrieb Stefan Hajnoczi: On Mon, Nov 22, 2010 at 1:38 PM, Juan Quintela quint...@redhat.com wrote: Please send in any agenda items you are interested in

[Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion

2010-11-24 Thread Hannes Reinecke
On 11/24/2010 11:34 AM, Kevin Wolf wrote: Am 24.11.2010 11:16, schrieb Hannes Reinecke: The second one is actually a genuine error, and a rather old one to boot. It went in with this commit: commit 89c0f6438d16ebceccdcd096bbc0b5536146a443 Author: aurel32

[Qemu-devel] Re: [PATCH 09/10] Exit loop if we have been there too long

2010-11-24 Thread Michael S. Tsirkin
On Wed, Nov 24, 2010 at 12:03:06AM +0100, Juan Quintela wrote: From: Juan Quintela quint...@trasno.org cheking each 64 pages is a random magic number as good as any other. We don't want to test too many times, but on the other hand, qemu_get_clock_ns() is not so expensive either. Could

[Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion

2010-11-24 Thread Kevin Wolf
Am 24.11.2010 11:16, schrieb Hannes Reinecke: The second one is actually a genuine error, and a rather old one to boot. It went in with this commit: commit 89c0f6438d16ebceccdcd096bbc0b5536146a443 Author: aurel32 aure...@c046a42c-6fe2-441c-8c8c-71466251a162 Date: Fri Oct 17 08:08:56 2008

[Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant

2010-11-24 Thread Michael S. Tsirkin
On Wed, Nov 24, 2010 at 12:02:59AM +0100, Juan Quintela wrote: From: Juan Quintela quint...@trasno.org This time is each time that buffered_file ticks happen Signed-off-by: Juan Quintela quint...@trasno.org Signed-off-by: Juan Quintela quint...@redhat.com --- buffered_file.c |6

[Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant

2010-11-24 Thread Juan Quintela
Michael S. Tsirkin m...@redhat.com wrote: On Wed, Nov 24, 2010 at 12:02:59AM +0100, Juan Quintela wrote: From: Juan Quintela quint...@trasno.org diff --git a/buffered_file.h b/buffered_file.h index 98d358b..a728316 100644 --- a/buffered_file.h +++ b/buffered_file.h @@ -21,6 +21,8 @@

[Qemu-devel] Re: [PATCH 10/12] config: Add header file for device config options

2010-11-24 Thread Alexander Graf
On 24.11.2010, at 03:22, Juan Quintela wrote: Alexander Graf ag...@suse.de wrote: So far we have C preprocessor defines for target and host config options, but we're lacking any information on which devices are available. We do need that information at times though, for example in the

[Qemu-devel] Re: [PATCH v2 0/6] qdev reset refactoring and pci bus reset

2010-11-24 Thread Michael S. Tsirkin
On Wed, Nov 24, 2010 at 04:15:14PM +0900, Isaku Yamahata wrote: On Wed, Nov 24, 2010 at 07:27:58AM +0200, Michael S. Tsirkin wrote: Right. So let's add an inline helper to avoid code duplication here? pci: fix bus walk under secondary bus reset Take into account secondary bus reset

[Qemu-devel] Re: [PATCH] scsi-generic: bugfixes for 'SCSIRequest' conversion

2010-11-24 Thread Nicholas A. Bellinger
On Wed, 2010-11-24 at 11:16 +0100, Hannes Reinecke wrote: On 11/24/2010 10:04 AM, Kevin Wolf wrote: Am 24.11.2010 09:57, schrieb Hannes Reinecke: On 11/24/2010 09:18 AM, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch adds a handful of bugfixes for

[Qemu-devel] Re: [PATCH 09/10] Exit loop if we have been there too long

2010-11-24 Thread Juan Quintela
Michael S. Tsirkin m...@redhat.com wrote: On Wed, Nov 24, 2010 at 12:03:06AM +0100, Juan Quintela wrote: From: Juan Quintela quint...@trasno.org cheking each 64 pages is a random magic number as good as any other. We don't want to test too many times, but on the other hand,

Re: [Qemu-devel] [Patch] Small fix for qemu APIC for Mac OS X support

2010-11-24 Thread Alexander Graf
On 24.11.2010, at 03:40, adq wrote: On 23 November 2010 23:41, Alexander Graf ag...@suse.de wrote: On 23.11.2010, at 22:25, adq wrote: This patch ups the APIC version from 0x11 to 0x14. After that Mac OS X loads successfully (with appropriate kexts, applesmc ain't hooked up properly yet

[Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant

2010-11-24 Thread Michael S. Tsirkin
On Wed, Nov 24, 2010 at 11:52:25AM +0100, Juan Quintela wrote: Michael S. Tsirkin m...@redhat.com wrote: On Wed, Nov 24, 2010 at 12:02:59AM +0100, Juan Quintela wrote: From: Juan Quintela quint...@trasno.org diff --git a/buffered_file.h b/buffered_file.h index 98d358b..a728316 100644

[Qemu-devel] Re: [PATCH v2 0/6] qdev reset refactoring and pci bus reset

2010-11-24 Thread Isaku Yamahata
On Wed, Nov 24, 2010 at 12:59:43PM +0200, Michael S. Tsirkin wrote: @@ -1552,20 +1562,21 @@ PCIBus *pci_find_bus(PCIBus *bus, int bus_num) return bus; } +/* Consider all bus numbers in range for the host pci bridge. */ +if (bus-parent_dev +

[Qemu-devel] [PATCH v5 0/5] qed: Add QEMU Enhanced Disk format

2010-11-24 Thread Stefan Hajnoczi
For a changelog against v4, see below. QEMU Enhanced Disk format is a disk image format that forgoes features found in qcow2 in favor of better levels of performance and data integrity. Due to its simpler on-disk layout, it is possible to safely perform metadata updates more efficiently.

[Qemu-devel] [PATCH v5 1/5] docs: Add QED image format specification

2010-11-24 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- docs/specs/qed_spec.txt | 130 +++ 1 files changed, 130 insertions(+), 0 deletions(-) create mode 100644 docs/specs/qed_spec.txt diff --git a/docs/specs/qed_spec.txt

[Qemu-devel] [PATCH 01/15] scsi: Increase the number of possible devices

2010-11-24 Thread Hannes Reinecke
The SCSI parallel interface has a limit of 8 devices, but not the SCSI stack in general. So we should be removing the hard-coded limit and use MAX_SCSI_DEVS instead. And we only need to scan those devices which are allocated by the bus. Signed-off-by: Hannes Reinecke h...@suse.de Acked-by:

[Qemu-devel] [PATCH v5 5/5] qed: Consistency check support

2010-11-24 Thread Stefan Hajnoczi
This patch adds support for the qemu-img check command. It also introduces a dirty bit in the qed header to mark modified images as needing a check. This bit is cleared when the image file is closed cleanly. If an image file is opened and it has the dirty bit set, a consistency check will run

[Qemu-devel] [PATCH 03/15] scsi: INQUIRY VPD fixes

2010-11-24 Thread Hannes Reinecke
We should announce and support the block device characterics page only on block devices, not on CDROMs. And the VPD page 0x83 has an off-by-one error. Signed-off-by: Hannes Reinecke h...@suse.de Acked-by: Christoph Hellwig h...@lst.de --- hw/scsi-disk.c | 18 ++ 1 files

[Qemu-devel] [PATCH 00/15] Megasas HBA emulation and SCSI update v.3

2010-11-24 Thread Hannes Reinecke
The is the third version of the megasas patchset; changes are: v2 - v3: - Include review by Stefan Hajnoczi - Return SCSI error status on invalid data direction - Initialize sense code in scsi-generic.c v1 - v2: - Include suggestions (and acked-by) from Christoph Hellwig - Updated patch

[Qemu-devel] [PATCH 12/15] scsi: Implement 'get_sense' callback

2010-11-24 Thread Hannes Reinecke
The get_sense callback copies existing sense information into the provided buffer. This is required if sense information should be transferred together with the command response. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-disk.c|9 + hw/scsi-generic.c | 18

[Qemu-devel] [PATCH v5 2/5] qed: Add QEMU Enhanced Disk image format

2010-11-24 Thread Stefan Hajnoczi
This patch introduces the qed on-disk layout and implements image creation. Later patches add read/write and other functionality. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- Makefile.objs |1 + block/qed.c | 554 +

[Qemu-devel] [PATCH 04/15] scsi: Move sense handling into the driver

2010-11-24 Thread Hannes Reinecke
The current sense handling in scsi-bus is only used by the scsi-disk driver; the scsi-generic driver is using its own. So we should move the current sense handling into the scsi-disk driver. Signed-off-by: Hannes Reinecke h...@suse.de Acked-by: Christoph Hellwig h...@lst.de --- hw/scsi-bus.c |

[Qemu-devel] [PATCH 05/15] scsi-disk: Remove duplicate cdb parsing

2010-11-24 Thread Hannes Reinecke
We parse the CDB twice, which is completely unnecessary. Signed-off-by: Hannes Reinecke h...@suse.de Acked-by: Christoph Hellwig h...@lst.de --- hw/scsi-disk.c | 74 1 files changed, 21 insertions(+), 53 deletions(-) diff --git

[Qemu-devel] [PATCH v5 3/5] qed: Table, L2 cache, and cluster functions

2010-11-24 Thread Stefan Hajnoczi
This patch adds code to look up data cluster offsets in the image via the L1/L2 tables. The L2 tables are writethrough cached in memory for performance (each read/write requires a lookup so it is essential to cache the tables). With cluster lookup code in place it is possible to implement

[Qemu-devel] [PATCH 11/15] Remove 'bus' argument from SCSI command completion callbacks

2010-11-24 Thread Hannes Reinecke
The 'bus' argument is now pointless, as we already pass the request itself and the bus can be derived from it. Signed-off-by: Hannes Reinecke h...@suse.de Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/esp.c |5 ++--- hw/lsi53c895a.c |5 ++--- hw/scsi-bus.c

[Qemu-devel] [PATCH v5 4/5] qed: Read/write support

2010-11-24 Thread Stefan Hajnoczi
This patch implements the read/write state machine. Operations are fully asynchronous and multiple operations may be active at any time. Allocating writes lock tables to ensure metadata updates do not interfere with each other. If two allocating writes need to update the same L2 table they will

[Qemu-devel] [PATCH 09/15] scsi: Use 'SCSIRequest' directly

2010-11-24 Thread Hannes Reinecke
Currently the SCSIRequest structure is abstracted away and cannot accessed directly from the driver. This requires the handler to do a lookup on an abstract 'tag' which identifies the SCSIRequest structure. With this patch the SCSIRequest structure is exposed to the driver. This allows use to use

[Qemu-devel] [PATCH 07/15] lsi53c895a: Rename 'sense' to 'status'

2010-11-24 Thread Hannes Reinecke
The 'sense' field in the HBA status structure is misnamed, as it actually carries the SCSI status. Rename it. Signed-off-by: Hannes Reinecke h...@suse.de Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/lsi53c895a.c | 18 +- 1 files changed, 9 insertions(+), 9

[Qemu-devel] [PATCH 02/15] scsi: Return SAM status codes

2010-11-24 Thread Hannes Reinecke
Traditionally, the linux stack is using SCSI status codes which are shifted by one as compared to those defined in SAM. A SCSI emulation should naturally return the SAM defined codes, not the linux ones. So to avoid any confusion this patch modifies the existing definitions to match those found in

[Qemu-devel] [PATCH 15/15] Make SCSI HBA configurable

2010-11-24 Thread Hannes Reinecke
This patch introduces configuration variables CONFIG_SCSI_LSI CONFIG_SCSI_MEGASAS and renames the existing CONFIG_ESP to CONFIG_SCSI_ESP. With this the available SCSI HBAs can be configured for each target configuration instead of compiling it in for everyone. Signed-off-by: Hannes Reinecke

[Qemu-devel] [PATCH 08/15] scsi-disk: Allocate iovec dynamically

2010-11-24 Thread Hannes Reinecke
Rather than have the iovec part of the structure with a fixed size of '1' we should be allocating it dynamically. This will allow us to pass in SGLs directly. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-disk.c | 102 +--- 1 files

[Qemu-devel] [PATCH 10/15] scsi-disk: add data direction checking

2010-11-24 Thread Hannes Reinecke
scsi_req_parse() already provides for a data direction setting, so we should be using it to check for correct direction. And we should return the sense code 'INVALID FIELD IN CDB' in these cases. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-disk.c | 30 ++

[Qemu-devel] [PATCH 13/15] scsi: Implement alloc_req_iov callback

2010-11-24 Thread Hannes Reinecke
Add callback to create a request with a predefined iovec. This is required for drivers which can use the iovec of a command directly. Signed-off-by: Hannes Reinecke h...@suse.de --- hw/scsi-disk.c| 25 + hw/scsi-generic.c | 44

[Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant

2010-11-24 Thread Michael S. Tsirkin
On Wed, Nov 24, 2010 at 12:13:26PM +0100, Juan Quintela wrote: Michael S. Tsirkin m...@redhat.com wrote: On Wed, Nov 24, 2010 at 11:52:25AM +0100, Juan Quintela wrote: Michael S. Tsirkin m...@redhat.com wrote: On Wed, Nov 24, 2010 at 12:02:59AM +0100, Juan Quintela wrote: From: Juan

[Qemu-devel] Re: [PATCH 09/10] Exit loop if we have been there too long

2010-11-24 Thread Michael S. Tsirkin
On Wed, Nov 24, 2010 at 12:01:51PM +0100, Juan Quintela wrote: Michael S. Tsirkin m...@redhat.com wrote: On Wed, Nov 24, 2010 at 12:03:06AM +0100, Juan Quintela wrote: From: Juan Quintela quint...@trasno.org cheking each 64 pages is a random magic number as good as any other. We don't

[Qemu-devel] Re: [PATCH 02/10] Add buffered_file_internal constant

2010-11-24 Thread Juan Quintela
Michael S. Tsirkin m...@redhat.com wrote: On Wed, Nov 24, 2010 at 11:52:25AM +0100, Juan Quintela wrote: Michael S. Tsirkin m...@redhat.com wrote: On Wed, Nov 24, 2010 at 12:02:59AM +0100, Juan Quintela wrote: From: Juan Quintela quint...@trasno.org diff --git a/buffered_file.h

[Qemu-devel] [PATCH 06/15] scsi: Update sense code handling

2010-11-24 Thread Hannes Reinecke
The SCSI spec has a quite detailed list of sense codes available. It even mandates the use of specific ones for some failure cases. The current implementation just has one type of 'generic' error which is actually a violation of the spec in certain cases. This patch introduces various predefined

[Qemu-devel] Re: [PATCH 00/12] AHCI emulation support v4

2010-11-24 Thread Gerd Hoffmann
On 11/23/10 15:34, Alexander Graf wrote: This patch adds support for AHCI emulation. I have tested and verified it works in Linux, OpenBSD, Windows Vista and Windows 7. Also seabios ;) http://cgit.freedesktop.org/~kraxel/seabios/log/?h=ahci cheers, Gerd

[Qemu-devel] Re: [PATCH 00/12] AHCI emulation support v4

2010-11-24 Thread Alexander Graf
On 24.11.2010, at 12:44, Gerd Hoffmann wrote: On 11/23/10 15:34, Alexander Graf wrote: This patch adds support for AHCI emulation. I have tested and verified it works in Linux, OpenBSD, Windows Vista and Windows 7. Also seabios ;) http://cgit.freedesktop.org/~kraxel/seabios/log/?h=ahci

Re: [Qemu-devel] [PATCH] Fix commandline handling for ARM semihosted executables, on Linux and BSD hosts

2010-11-24 Thread Peter Maydell
On 23 November 2010 15:26, Schildbach, Wolfgang ws...@dolby.com wrote: When running an ARM semihosted executable on a linux machine, the command line is not delivered to the guest (see https://bugs.launchpad.net/qemu/+bug/673613). I've tested this, and it does work; however I don't think the

[Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-24 Thread Stefano Stabellini
Hi all, this patch can be applied to both qemu-xen and qemu and adds support for empty write barriers to xen_disk. Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com diff --git a/hw/xen_disk.c b/hw/xen_disk.c index 38b5fbf..94af001 100644 --- a/hw/xen_disk.c +++ b/hw/xen_disk.c

[Qemu-devel] Re: [PATCH 0/5]

2010-11-24 Thread Stefan Hajnoczi
On Wed, Nov 24, 2010 at 8:39 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: From: Nicholas Bellinger n...@linux-iscsi.org Greetings QEMU SCSI / BLOCK folks, This series adds rebased support for the hw/scsi-bsg.c backstore for scsi-bus compatible HBA emulation in QEMU-KVM on Linux

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-11-24 Thread Anthony Liguori
On 11/24/2010 02:18 AM, Avi Kivity wrote: On 11/23/2010 06:49 PM, Anthony Liguori wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them to respond to these signals (which cannot be trapped), use SIGUSR1 to approximate the behavior of SIGSTOP/SIGCONT. The

Re: [Qemu-devel] [Patch] Small fix for qemu APIC for Mac OS X support

2010-11-24 Thread adq
On 24 November 2010 11:00, Alexander Graf ag...@suse.de wrote: On 24.11.2010, at 03:40, adq wrote: On 23 November 2010 23:41, Alexander Graf ag...@suse.de wrote: On 23.11.2010, at 22:25, adq wrote: This patch ups the APIC version from 0x11 to 0x14. After that Mac OS X loads successfully

Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-24 Thread Gerd Hoffmann
On 11/24/10 14:08, Stefano Stabellini wrote: this patch can be applied to both qemu-xen and qemu and adds support for empty write barriers to xen_disk. Looks good. Acked-by: Gerd Hoffmann kra...@redhat.com cheers, Gerd

[Qemu-devel] Re: [PATCH] qemu-kvm: response to SIGUSR1 to start/stop a VCPU (v2)

2010-11-24 Thread Avi Kivity
On 11/24/2010 03:58 PM, Anthony Liguori wrote: On 11/24/2010 02:18 AM, Avi Kivity wrote: On 11/23/2010 06:49 PM, Anthony Liguori wrote: qemu-kvm vcpu threads don't response to SIGSTOP/SIGCONT. Instead of teaching them to respond to these signals (which cannot be trapped), use SIGUSR1 to

[Qemu-devel] Re: [PATCH comment tweaked] msix: allow byte and word reading from mmio

2010-11-24 Thread Bernhard Kohl
Am 17.11.2010 17:30, schrieb ext Michael S. Tsirkin: On Wed, Nov 17, 2010 at 05:12:12PM +0100, Bernhard Kohl wrote: I will fix the guest and inform you after testing. Then we can skip this patch. OK, that's best, Yes, the guest is fixed now. Only dword accesses to msix!

Re: [Qemu-devel] [PATCH v5 0/5] qed: Add QEMU Enhanced Disk format

2010-11-24 Thread Stefan Hajnoczi
On Wed, Nov 24, 2010 at 11:11 AM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: repo.or.cz is currently down but once it's back up the code will be available from git: http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/qed-v5 I have preserved distinct commits against v4 for

[Qemu-devel] Re: [PATCH 09/10] Exit loop if we have been there too long

2010-11-24 Thread Paolo Bonzini
On 11/24/2010 12:14 PM, Michael S. Tsirkin wrote: buffered_file timer runs each 100ms. And we try to measure channel bandwidth from there. If we are not able to run the timer, all the calculations are wrong, and then stalls happens. So the problem is the timer in the buffered file

[Qemu-devel] [PATCH 0/6] ARM: linux-user: save/restore fpu regs to signal context

2010-11-24 Thread Peter Maydell
This patchset fixes the ARM-specific parts of the linux-user signal handling code to save the VFP and iWMMXT registers to the signal context struct when invoking a signal handler, and restore them afterwards. (This omission was previously marked with a 'FIXME' comment, and meant that signal

[Qemu-devel] [PATCH 4/6] ARM: linux-user: Restore VFP state from ucontext on sigreturn

2010-11-24 Thread Peter Maydell
Restore the VFP registers from the ucontext on return from a signal handler in linux-user mode. This means that signal handlers cannot accidentally corrupt the interrupted code's VFP state, and allows them to deliberately modify the state via the ucontext structure. Signed-off-by: Peter Maydell

[Qemu-devel] [PATCH 2/6] ARM: Expose vfp_get_fpscr() and vfp_set_fpscr() to C code

2010-11-24 Thread Peter Maydell
Expose the vfp_get_fpscr() and vfp_set_fpscr() functions to C code as well as generated code, so we can use them to read and write the FPSCR when saving and restoring VFP registers across signal handlers in linux-user mode. Signed-off-by: Peter Maydell peter.mayd...@linaro.org ---

[Qemu-devel] [PATCH 3/6] ARM: linux-user: Expose VFP registers to signal handlers

2010-11-24 Thread Peter Maydell
For ARM linux-user mode signal handlers, fill in the ucontext with VFP register contents in the same way that the kernel does. We only do this for v2 format sigframe (2.6.12 and above); this is actually bug-for-bug compatible with the older kernels, which don't save and restore VFP registers

[Qemu-devel] [PATCH 1/6] ARM: linux-user: Correct size of padding in target_ucontext_v2

2010-11-24 Thread Peter Maydell
The padding in the target_ucontext_v2 is defined by the size of the target's sigset_t type, not the host's. (This bug only causes problems when we start using the uc_regspace[] array to expose VFP registers to userspace signal handlers.) Signed-off-by: Peter Maydell peter.mayd...@linaro.org ---

[Qemu-devel] [PATCH 6/6] ARM: linux-user: Restore iWMMXT state from ucontext on sigreturn

2010-11-24 Thread Peter Maydell
Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- linux-user/signal.c | 30 ++ 1 files changed, 30 insertions(+), 0 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 3d0233d..bd0dbc1 100644 --- a/linux-user/signal.c +++

[Qemu-devel] [PATCH 5/6] ARM: linux-user: Expose iWMMXT registers to signal handlers

2010-11-24 Thread Peter Maydell
Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- linux-user/signal.c | 37 + 1 files changed, 37 insertions(+), 0 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c index 5e8cbeb..3d0233d 100644 --- a/linux-user/signal.c +++

[Qemu-devel] [PATCH][qemu-iotests] filter IMGFMT correctly in 019

2010-11-24 Thread Stefan Hajnoczi
Test 019 can be run with qcow2 and qed image formats. Replace the specific image format value with IMGFMT so the golden output does not hardcode qcow2 or qed. This patch also includes a typo fix for occurrences. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- 019 |

[Qemu-devel] [PULL] virtio, e1000, pci aer, pci reset

2010-11-24 Thread Michael S. Tsirkin
Note: to avoid conflict in a merge I cherry-picked a patch by Stefan from master to my branch. git seems to resolve this without effort. The following changes since commit e927d48722fdcba50f82d653c5a1927752483054: pci: allow hotplug removal of cold-plugged devices (2010-11-16 14:55:23 +0200)

[Qemu-devel] [PATCHv2 6/6] migration: allow rate 4g

2010-11-24 Thread Michael S. Tsirkin
I'd like to disable bandwidth limit or make it very high, Use int64_t all over to make values = 4g work. Signed-off-by: Michael S. Tsirkin m...@redhat.com Tested-by: Jason Wang jasow...@redhat.com --- buffered_file.c |9 ++--- hw/hw.h |8 migration.c |6

[Qemu-devel] [PATCHv2 3/6] migration/savevm: no need to flush requests

2010-11-24 Thread Michael S. Tsirkin
There's no need to flush requests after vmstop as vmstop does it for us automatically now. Signed-off-by: Michael S. Tsirkin m...@redhat.com Tested-by: Jason Wang jasow...@redhat.com --- migration.c |2 -- savevm.c|4 2 files changed, 0 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] Re: [PATCH 09/10] Exit loop if we have been there too long

2010-11-24 Thread Michael S. Tsirkin
On Wed, Nov 24, 2010 at 04:16:04PM +0100, Paolo Bonzini wrote: On 11/24/2010 12:14 PM, Michael S. Tsirkin wrote: buffered_file timer runs each 100ms. And we try to measure channel bandwidth from there. If we are not able to run the timer, all the calculations are wrong, and then stalls

[Qemu-devel] [PATCHv2 4/6] virtio-net: stop/start bh on vm start/stop

2010-11-24 Thread Michael S. Tsirkin
Avoid sending out packets, and modifying device state, when VM is stopped. Add a bunch or assert statements to verify this does not happen. Signed-off-by: Michael S. Tsirkin m...@redhat.com Tested-by: Jason Wang jasow...@redhat.com --- hw/virtio-net.c | 36 ++--

[Qemu-devel] [PATCHv2 0/6] stable migration image on a stopped vm

2010-11-24 Thread Michael S. Tsirkin
I sent the exact same patches offline to some of the Cc'd, there's been no change but they have been tested by Jason now. I'll queue them up unless there are some comments. What these patches do is arrive at a state where migrate to exec with vm stopped produces a stable result. With these

[Qemu-devel] [PATCHv2 5/6] migration: stable ram block ordering

2010-11-24 Thread Michael S. Tsirkin
This makes ram block ordering under migration stable, ordered by offset. This is especially useful for migration to exec, for debugging. Signed-off-by: Michael S. Tsirkin m...@redhat.com Tested-by: Jason Wang jasow...@redhat.com --- arch_init.c | 35 +++

[Qemu-devel] [PATCHv2 2/6] cpus: flush all requests on each vm stop

2010-11-24 Thread Michael S. Tsirkin
Make sure disk is in consistent state. Signed-off-by: Michael S. Tsirkin m...@redhat.com Tested-by: Jason Wang jasow...@redhat.com --- cpus.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/cpus.c b/cpus.c index 91a0fb1..d421a96 100644 --- a/cpus.c +++ b/cpus.c @@

[Qemu-devel] [PATCHv2 1/6] virtio-net: don't dma while vm is stopped

2010-11-24 Thread Michael S. Tsirkin
DMA into memory while VM is stopped makes it hard to debug migration (consequitive saves result in different files). Fixing this completely is a large effort, this patch does this for virtio-net. Signed-off-by: Michael S. Tsirkin m...@redhat.com Tested-by: Jason Wang jasow...@redhat.com ---

Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-24 Thread Kevin Wolf
Am 24.11.2010 15:23, schrieb Gerd Hoffmann: On 11/24/10 14:08, Stefano Stabellini wrote: this patch can be applied to both qemu-xen and qemu and adds support for empty write barriers to xen_disk. Looks good. Acked-by: Gerd Hoffmann kra...@redhat.com Thanks, applied to the block branch.

[Qemu-devel] Re: [PATCH] ide: convert bmdma address ioport to ioport_register()

2010-11-24 Thread Kevin Wolf
Am 21.11.2010 17:29, schrieb Avi Kivity: cmd646, via compile tested, pci lightly boot tested. Signed-off-by: Avi Kivity a...@redhat.com Thanks, applied to the block branch. Kevin

[Qemu-devel] Re: [PATCH][qemu-iotests] filter IMGFMT correctly in 019

2010-11-24 Thread Christoph Hellwig
On Wed, Nov 24, 2010 at 03:38:46PM +, Stefan Hajnoczi wrote: Test 019 can be run with qcow2 and qed image formats. Replace the specific image format value with IMGFMT so the golden output does not hardcode qcow2 or qed. This patch also includes a typo fix for occurrences. Thanks,

Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-24 Thread Stefano Stabellini
On Wed, 24 Nov 2010, Kevin Wolf wrote: On 11/24/10 14:08, Stefano Stabellini wrote: this patch can be applied to both qemu-xen and qemu and adds support for empty write barriers to xen_disk. Looks good. Acked-by: Gerd Hoffmann kra...@redhat.com Thanks, applied to the block

Re: [Qemu-devel] Re: [PATCH 0/5]

2010-11-24 Thread Christoph Hellwig
On Wed, Nov 24, 2010 at 01:38:59PM +, Stefan Hajnoczi wrote: I don't know the Linux SCSI stack, so some basic questions for you :). With scsi-generic I can send SCSI commands to a device. How is bsg different? The bsg code looks cleaner than sg but they both boil down to issuing SCSI

Re: [Qemu-devel] [PATCH 1/5] block: Add top level BSG support

2010-11-24 Thread Christoph Hellwig
Nick, can we wait a bit with this series? With the threadlets currently pending for inclusion I can get my rewrite of the generic-generic to not abuse the qemu block layer out of the closet again, which should simplify a lot of the things you're touching here.

[Qemu-devel] [PATCH 2/3] vnc: support password expire

2010-11-24 Thread Gerd Hoffmann
This patch adds support for expiring passwords to vnc. It adds a new vnc_display_pw_expire() function which specifies the time when the password will expire. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.h |1 + qemu-common.h |3 +++ ui/vnc.c | 14 ++

[Qemu-devel] [PATCH 1/3] vnc: auth reject cleanup

2010-11-24 Thread Gerd Hoffmann
protocol_client_auth_vnc() has two places where the auth can fail, with identical code sending the reject message to the client. Move the common code to the end of the function and make both error paths jump there. No functional change. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---

[Qemu-devel] [PATCH 0/3] vnc/spice: add monitor commands to change+expire passwords.

2010-11-24 Thread Gerd Hoffmann
This patch series adds new monitor commands to set and expire the password: set-password $protocol $secret expire-password $protocol [ now | never | +secs | secs ] The time when the password expires can be specified either relative (+60 == password expires in 60 seconds from now) or absolute

Re: [Qemu-devel] [PATCH 1/1] iscsi: add iSCSI block device support

2010-11-24 Thread Christoph Hellwig
I don't really see the point of this. It's implemented as a protocol, and thus the bottom of the qemu protocol stack. So we might get SCSI commands in from the guest, decode them, just to re-encode them again and send them off to the network all inside qemu. Do you have any performance numbers

[Qemu-devel] [PATCH 3/3] vnc/spice: add set_passwd monitor command.

2010-11-24 Thread Gerd Hoffmann
This patch adds new set_password and expire_password monitor commands which allows to change and expire the password for spice and vnc connections. See the doc update patch chunk for details. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hmp-commands.hx | 54 +

Re: [Qemu-devel] [PATCH 02/15] scsi: Return SAM status codes

2010-11-24 Thread Christoph Hellwig
On Wed, Nov 24, 2010 at 12:15:57PM +0100, Hannes Reinecke wrote: Traditionally, the linux stack is using SCSI status codes which are shifted by one as compared to those defined in SAM. A SCSI emulation should naturally return the SAM defined codes, not the linux ones. So to avoid any

Re: [Qemu-devel] [PATCH 13/15] scsi: Implement alloc_req_iov callback

2010-11-24 Thread Christoph Hellwig
On Wed, Nov 24, 2010 at 12:16:08PM +0100, Hannes Reinecke wrote: Add callback to create a request with a predefined iovec. This is required for drivers which can use the iovec of a command directly. What happend to my comment that the iov and non-iov case should share code? Also what happened

Re: [Xen-devel] Re: [Qemu-devel] [PATCH] qemu and qemu-xen: support empty write barriers in xen_disk

2010-11-24 Thread Jeremy Fitzhardinge
On 11/24/2010 08:58 AM, Christoph Hellwig wrote: I had the discussion with Jeremy in Boston before, but let's repeat it here: - is there actually any pre-existing xen backend that does properly implement empty barries. Back then we couldn't find any. - if this is a new concept to Xen

  1   2   >